GNU bug report logs - #28921
[PROPOSED] Fix xdg timestamp error on 32-bit Emacs

Previous Next

Full log

View this message in rfc822 format

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: mvoteiza <at> udel.edu, 28921 <at> debbugs.gnu.org
Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs
Date: Sat, 21 Oct 2017 18:11:24 +0900

Paul Eggert <eggert <at> cs.ucla.edu> writes:

>  (defun xdg-thumb-mtime (filename)
> -  "Return modification time of FILENAME as integral seconds from the epoch."
> -  (floor (float-time (nth 5 (file-attributes filename)))))
> +  "Return modification time of FILENAME as an Emacs timestamp."
> +  (nth 5 (file-attributes filename)))
Maybe you could use here the new accesor `file-attribute-modification-time':

diff --git a/lisp/xdg.el b/lisp/xdg.el
index 4250faaeb4..9edc3d2629 100644
--- a/lisp/xdg.el
+++ b/lisp/xdg.el
@@ -94,8 +94,8 @@ xdg-thumb-name
   (concat (md5 (xdg-thumb-uri filename)) ".png"))
 
 (defun xdg-thumb-mtime (filename)
-  "Return modification time of FILENAME as integral seconds from the epoch."
-  (floor (float-time (nth 5 (file-attributes filename)))))
+  "Return modification time of FILENAME as an Emacs timestamp."
+  (file-attribute-modification-time (file-attributes filename)))
 
 
 ;; XDG User Directories

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.