From unknown Sat Jun 14 14:29:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 03:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 28921@debbugs.gnu.org, mvoteiza@udel.edu Cc: Paul Eggert X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, mvoteiza@udel.edu Received: via spool by submit@debbugs.gnu.org id=B.150855513222828 (code B ref -1); Sat, 21 Oct 2017 03:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Oct 2017 03:05:32 +0000 Received: from localhost ([127.0.0.1]:52950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5k6O-0005w8-1Z for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5k6M-0005vu-2Y for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5k6F-00050b-OD for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53746) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5k6F-00050T-IF for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5k6A-0005Lj-66 for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 23:05:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5k66-0004xc-RY for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 23:05:18 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59898) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5k66-0004uh-LT for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 23:05:14 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9C6E9160E83; Fri, 20 Oct 2017 20:05:05 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id RpxbhNOrXMmA; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E0A2A160E65; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id a4cKIMoNUyXd; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BF8F2160E3A; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) From: Paul Eggert Date: Fri, 20 Oct 2017 20:04:55 -0700 Message-Id: <20171021030455.16035-1-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp, not an integer. This avoids signaling an error on 32-bit Emacs, where timestamps typically do not fit into fixnums. --- lisp/xdg.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/xdg.el b/lisp/xdg.el index 76106f4258..6dcef74e4e 100644 --- a/lisp/xdg.el +++ b/lisp/xdg.el @@ -93,8 +93,8 @@ xdg-thumb-name (concat (md5 (xdg-thumb-uri filename)) ".png")) (defun xdg-thumb-mtime (filename) - "Return modification time of FILENAME as integral seconds from the epoch." - (floor (float-time (nth 5 (file-attributes filename))))) + "Return modification time of FILENAME as an Emacs timestamp." + (nth 5 (file-attributes filename))) ;; XDG User Directories -- 2.13.6 From unknown Sat Jun 14 14:29:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: mvoteiza@udel.edu, 28921@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 28921-submit@debbugs.gnu.org id=B28921.150857041215207 (code B ref 28921); Sat, 21 Oct 2017 07:21:02 +0000 Received: (at 28921) by debbugs.gnu.org; 21 Oct 2017 07:20:12 +0000 Received: from localhost ([127.0.0.1]:53002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5o4q-0003xD-6J for submit@debbugs.gnu.org; Sat, 21 Oct 2017 03:20:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5o4o-0003wy-S0 for 28921@debbugs.gnu.org; Sat, 21 Oct 2017 03:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5o4i-0001rk-Ri for 28921@debbugs.gnu.org; Sat, 21 Oct 2017 03:20:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5o4d-0001qU-16; Sat, 21 Oct 2017 03:19:59 -0400 Received: from [176.228.60.248] (port=3378 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e5o4c-000070-Iv; Sat, 21 Oct 2017 03:19:58 -0400 Date: Sat, 21 Oct 2017 10:19:52 +0300 Message-Id: <8360b9c6hz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <20171021030455.16035-1-eggert@cs.ucla.edu> (message from Paul Eggert on Fri, 20 Oct 2017 20:04:55 -0700) References: <20171021030455.16035-1-eggert@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Eggert > Date: Fri, 20 Oct 2017 20:04:55 -0700 > Cc: Paul Eggert > > * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp, > not an integer. This avoids signaling an error on 32-bit > Emacs, where timestamps typically do not fit into fixnums. Fine with me for the release branch. Thanks. From unknown Sat Jun 14 14:29:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: mvoteiza@udel.edu, 28921@debbugs.gnu.org Received: via spool by 28921-submit@debbugs.gnu.org id=B28921.150857710126403 (code B ref 28921); Sat, 21 Oct 2017 09:12:02 +0000 Received: (at 28921) by debbugs.gnu.org; 21 Oct 2017 09:11:41 +0000 Received: from localhost ([127.0.0.1]:53097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5poj-0006rn-MM for submit@debbugs.gnu.org; Sat, 21 Oct 2017 05:11:41 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:43604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5poh-0006rY-HL for 28921@debbugs.gnu.org; Sat, 21 Oct 2017 05:11:40 -0400 Received: by mail-pf0-f174.google.com with SMTP id a8so13759844pfc.0 for <28921@debbugs.gnu.org>; Sat, 21 Oct 2017 02:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZDZDGiQNCPBP71W9K0P4TkB6qeE/CwV0mf9aBIQzfJs=; b=lD20nCPzVn1LHYRuRZ1ufWWOOBMbBIIWI/pY2bNcLSzQNA2CGMFzCoUjeLO3ShJrla ERasBMWiMDS2A6PX11+aEZZ2ml9lMevzJFc0UpjroE13OQJGrbjbg++q56eIpq/pLY1m LpZVldmhVzIq+XDiTTz4Avnyir2YaKHiuJ1QECyDfAQTR0+wNTuxDbcEEK8fxie6wUCT yQzAtoLvZWa0xyMnb8bPLRsYkmMiN88elMNYhryuaQjmKypboNU2b7UnYKT10fXr+DEn 8qqH8H/6d6fTskYEmm2+PsT2ThUHjTSgHEdH2XXIvu60aeXlypD2adZZhrUpltz0mwY2 99qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZDZDGiQNCPBP71W9K0P4TkB6qeE/CwV0mf9aBIQzfJs=; b=g+g97H6hhRMTJJPnYlGw6cBCoUpz3Xvg6N93KFEG478ggz6tikHBestlu9vse+N6In mbxWw21kAUIMyFGvqzm24oX7C5DWqBNoOHZQLPg+xML8Ki1RCGtraEjXQlKxJ2jJN0/B E3hSAD8qddJI1NRdy039rm0VxnlGn0bCh1dGPy8o2I3Y6XfRkKVPXWFIRMvBvrdEFrpn T8abQkBtaL3zLF5GWVt/Jw5n2KoZEm5xA0eSZp+R3rcSTubNfFtKAoAbIc/7JeLZWBE5 zOaFwkNfan3ybrtrDesbjhfM3ZenXzgnpsYK2b3I5kB2wuOHJFPTUcFMlUEaGDThZjE7 qL6w== X-Gm-Message-State: AMCzsaUnjS+hNwNRRLq9Wfwc82QNwuCO9cuOa2QfdoHSjnHHsftgJd2x JKhjmAEa6cIHcbPIA89EUIM= X-Google-Smtp-Source: ABhQp+RmkOXAz8f0T9EwEZCffQmigwU5lJniv6myUa47sxj7fudSVU66TizyIa+CZt5J/cdcNOlZlg== X-Received: by 10.84.178.37 with SMTP id y34mr2537598plb.99.1508577093558; Sat, 21 Oct 2017 02:11:33 -0700 (PDT) Received: from calancha-pc (h212207.dynamic.ppp.asahi-net.or.jp. [61.114.212.207]) by smtp.gmail.com with ESMTPSA id z73sm3985273pgz.46.2017.10.21.02.11.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 02:11:32 -0700 (PDT) From: Tino Calancha References: <20171021030455.16035-1-eggert@cs.ucla.edu> Date: Sat, 21 Oct 2017 18:11:24 +0900 In-Reply-To: <20171021030455.16035-1-eggert@cs.ucla.edu> (Paul Eggert's message of "Fri, 20 Oct 2017 20:04:55 -0700") Message-ID: <874lqs6f2b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Paul Eggert writes: > (defun xdg-thumb-mtime (filename) > - "Return modification time of FILENAME as integral seconds from the epoch." > - (floor (float-time (nth 5 (file-attributes filename))))) > + "Return modification time of FILENAME as an Emacs timestamp." > + (nth 5 (file-attributes filename))) Maybe you could use here the new accesor `file-attribute-modification-time': diff --git a/lisp/xdg.el b/lisp/xdg.el index 4250faaeb4..9edc3d2629 100644 --- a/lisp/xdg.el +++ b/lisp/xdg.el @@ -94,8 +94,8 @@ xdg-thumb-name (concat (md5 (xdg-thumb-uri filename)) ".png")) (defun xdg-thumb-mtime (filename) - "Return modification time of FILENAME as integral seconds from the epoch." - (floor (float-time (nth 5 (file-attributes filename))))) + "Return modification time of FILENAME as an Emacs timestamp." + (file-attribute-modification-time (file-attributes filename))) ;; XDG User Directories From unknown Sat Jun 14 14:29:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 28921@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1508596008650 (code B ref -1); Sat, 21 Oct 2017 14:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Oct 2017 14:26:48 +0000 Received: from localhost ([127.0.0.1]:54439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ujf-0000AQ-Om for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ujd-0000AC-Ce for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5ujX-0007mg-6O for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5ujX-0007mX-2l for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5ujW-0005Fx-3F for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5ujS-0007lH-Uv for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:26:38 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:44793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5ujS-0007ke-ND for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:26:34 -0400 Received: by mail-qk0-x236.google.com with SMTP id r64so17428475qkc.1 for ; Sat, 21 Oct 2017 07:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IfethB1WHr5ULwG/6skTc7WL8Nuvaur2EK0/AYiS0A8=; b=bSq8XQoME8q8P9uy2Qal70X9gJVLWYrJ1kiiFHJ+OIVZPNTx1oV97GmUgHhfhThVKb FtJtFcoQhOUbKj3safUV1Dka4rDMhfyrSWo/kXsZUP96b1rqPLUFReXzaLGtBHlHS/sM i3cdHQYFO3c2aHTeyvUAqSZq8xX5nuiBIkzP0ALV+5x8A9auDjf3/jfOv7Ct+AHudvi4 UUNWK70Ti4wxdVLwLTGh0sz4WylxzOfxPmTfLby9xuo8wXhagZZxwwgmQVVTkTul4Jwq v1QAe3jzbs+JJ8hgTh8nFaWsXozXJKRJXSSXehMzn1tcxWOcZzyhGn2YLYfySdJ+nkyg rslw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IfethB1WHr5ULwG/6skTc7WL8Nuvaur2EK0/AYiS0A8=; b=Wbt2HDco5Gc1eHAHDGxoPMx3KCUEIXwDhZFe6g3RzM7+rQQB0OGexQT35kt9rikgyK CSTEFScH2v6qRAcHBUcD/PVSPtaNoH/Oy5N+gbUjxE0DeOnK9YW0MwC/GFpUTPe7rZ4/ Bx7nlfJPCZV0sAzOPw7Rb0L9LvhLEGww4SKzJvWj/dft2RLRm5nw9iEQCw0itL4Xqkl+ uucAMYCNGkNeIWqfUjStgd8Nhy37Em6SdPlvzj58taiZ+8sJFPZhbQjQ1C77SpazMyk3 JjN8ikQ6afzEhl3W1PlfqpZCR3jt4TP5R19rjLIFbG9AAqiBcb32PO2U9r435kOzw3YQ SfPA== X-Gm-Message-State: AMCzsaUB0/QAa2CKOez4Qmf2C2JqPVBmnJ0GQQoOJV1BA/K4Q4l8iXoI pKcvAD1rf5KvfwYsMPcKZGoisA== X-Google-Smtp-Source: ABhQp+Tr+QF+5nmFoIP/d7GGnn1ePfky+ZIW1pYW2Wbv1SlWR9nvkpyDxy45Fg9w/IqaKeCf5Nsn9A== X-Received: by 10.55.175.132 with SMTP id y126mr12056960qke.45.1508595992227; Sat, 21 Oct 2017 07:26:32 -0700 (PDT) Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id n24sm2208207qta.94.2017.10.21.07.26.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 07:26:31 -0700 (PDT) Date: Sat, 21 Oct 2017 10:26:30 -0400 From: Mark Oteiza Message-ID: <20171021142630.4asr6z7qjfdxonzh@logos.localdomain> References: <20171021030455.16035-1-eggert@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171021030455.16035-1-eggert@cs.ucla.edu> User-Agent: NeoMutt/20171013 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) On 20/10/17 at 08:04pm, Paul Eggert wrote: > * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp, > not an integer. This avoids signaling an error on 32-bit > Emacs, where timestamps typically do not fit into fixnums. I had the following sitting in my tree, but I don't feel strongly either way. diff --git a/lisp/xdg.el b/lisp/xdg.el index 76106f4258..f57ed5e683 100644 --- a/lisp/xdg.el +++ b/lisp/xdg.el @@ -93,8 +93,8 @@ xdg-thumb-name (concat (md5 (xdg-thumb-uri filename)) ".png")) (defun xdg-thumb-mtime (filename) - "Return modification time of FILENAME as integral seconds from the epoch." - (floor (float-time (nth 5 (file-attributes filename))))) + "Return modification time of FILENAME as seconds from the epoch." + (ffloor (float-time (nth 5 (file-attributes filename))))) ;; XDG User Directories From unknown Sat Jun 14 14:29:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#28921: closed (Re: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs) Message-ID: References: <8572af36-ccd1-ff61-b5dc-9d69569c3b9c@cs.ucla.edu> <20171021030455.16035-1-eggert@cs.ucla.edu> X-Gnu-PR-Message: they-closed 28921 X-Gnu-PR-Package: emacs Reply-To: 28921@debbugs.gnu.org Date: Sun, 22 Oct 2017 07:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1508658122-12231-1" This is a multi-part message in MIME format... ------------=_1508658122-12231-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28921@debbugs.gnu.org. --=20 28921: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28921 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1508658122-12231-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28921-done) by debbugs.gnu.org; 22 Oct 2017 07:41:19 +0000 Received: from localhost ([127.0.0.1]:54882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Asp-0003AL-FL for submit@debbugs.gnu.org; Sun, 22 Oct 2017 03:41:19 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Asn-0003A7-PA for 28921-done@debbugs.gnu.org; Sun, 22 Oct 2017 03:41:18 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7783A160068; Sun, 22 Oct 2017 00:41:10 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QBuNWBUJXZoW; Sun, 22 Oct 2017 00:41:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BD4B4160E33; Sun, 22 Oct 2017 00:41:09 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0ED_wvQ0BtA0; Sun, 22 Oct 2017 00:41:09 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 60427160068; Sun, 22 Oct 2017 00:41:09 -0700 (PDT) Subject: Re: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs To: Tino Calancha References: <20171021030455.16035-1-eggert@cs.ucla.edu> <874lqs6f2b.fsf@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <8572af36-ccd1-ff61-b5dc-9d69569c3b9c@cs.ucla.edu> Date: Sun, 22 Oct 2017 00:41:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <874lqs6f2b.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28921-done Cc: mvoteiza@udel.edu, 28921-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tino Calancha wrote: > Maybe you could use here the new accesor `file-attribute-modification-t= ime': Thanks, good idea, I installed it that way into emacs-26. I prefer this t= o=20 float-time because float-time loses information on platforms like GNU/Lin= ux=20 where typical file timestamps these days have about 61 bits of precision,= which=20 is more than the 53 bits that Emacs floats have. ------------=_1508658122-12231-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Oct 2017 03:05:32 +0000 Received: from localhost ([127.0.0.1]:52950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5k6O-0005w8-1Z for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5k6M-0005vu-2Y for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5k6F-00050b-OD for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53746) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5k6F-00050T-IF for submit@debbugs.gnu.org; Fri, 20 Oct 2017 23:05:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5k6A-0005Lj-66 for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 23:05:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5k66-0004xc-RY for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 23:05:18 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59898) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5k66-0004uh-LT for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 23:05:14 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9C6E9160E83; Fri, 20 Oct 2017 20:05:05 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id RpxbhNOrXMmA; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E0A2A160E65; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id a4cKIMoNUyXd; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BF8F2160E3A; Fri, 20 Oct 2017 20:05:04 -0700 (PDT) From: Paul Eggert To: bug-gnu-emacs@gnu.org, mvoteiza@udel.edu Subject: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Date: Fri, 20 Oct 2017 20:04:55 -0700 Message-Id: <20171021030455.16035-1-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp, not an integer. This avoids signaling an error on 32-bit Emacs, where timestamps typically do not fit into fixnums. --- lisp/xdg.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/xdg.el b/lisp/xdg.el index 76106f4258..6dcef74e4e 100644 --- a/lisp/xdg.el +++ b/lisp/xdg.el @@ -93,8 +93,8 @@ xdg-thumb-name (concat (md5 (xdg-thumb-uri filename)) ".png")) (defun xdg-thumb-mtime (filename) - "Return modification time of FILENAME as integral seconds from the epoch." - (floor (float-time (nth 5 (file-attributes filename))))) + "Return modification time of FILENAME as an Emacs timestamp." + (nth 5 (file-attributes filename))) ;; XDG User Directories -- 2.13.6 ------------=_1508658122-12231-1--