Subject: Re: [bug#28917] gst-transcoder + python-pycanberra + gavl (pitivi dependencies)

From: Kei Kebreau <[email-masked]>
Date: Fri, 27 Oct 2017 08:28:01 -0400

ng0 <[email-masked]> writes:

> Kei Kebreau transcribed 3.2K bytes:
>> ng0 <[email-masked]> writes:
>> 
>> > ng0 transcribed 1.4K bytes:
>> >> ng0 transcribed 10K bytes:
>> >> > This adds gst-transcoder, python-pycanberra and gavl
>> >> > required for pitivi.
>> >> 
>> >> Yarg. I've sent the wrong python-pycanberra. Correction incoming.
>> >
>> > Correction appended.
>> >
>> > -- 
>> > ng0
>> > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
>> > GnuPG: https://dist.ng0.infotropique.org/dist/keys/
>> > https://www.infotropique.org https://ng0.infotropique.org
>> >
>> >
>> >
>> > From b97a66068be69bc53d654d6204cdb1df5c889dd6 Mon Sep 17 00:00:00 2001
>> > From: ng0 <[email-masked]>
>> > Date: Fri, 20 Oct 2017 18:32:12 +0000
>> > Subject: [PATCH 3/3] gnu: Add gavl.
>> >
>> > * gnu/packages/video.scm (gavl): New variable.
>> > ---
>> >  gnu/packages/video.scm | 34 ++++++++++++++++++++++++++++++++++
>> >  1 file changed, 34 insertions(+)
>> >
>> > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> > index baebe6404..7294c5bf2 100644
>> > --- a/gnu/packages/video.scm
>> > +++ b/gnu/packages/video.scm
>> > @@ -69,6 +69,7 @@
>> >    #:use-module (gnu packages databases)
>> >    #:use-module (gnu packages dejagnu)
>> >    #:use-module (gnu packages docbook)
>> > +  #:use-module (gnu packages documentation)
>> >    #:use-module (gnu packages elf)
>> >    #:use-module (gnu packages file)
>> >    #:use-module (gnu packages flex)
>> > @@ -2499,3 +2500,36 @@ tools for styling them, including a built-in real-time video preview.")
>> >      (synopsis "GStreamer Transcoding API")
>> >      (description "GStreamer Transcoding API")
>> >      (license license:lgpl2.1)))
>> > +
>> > +(define-public gavl
>> > +  (package
>> > +    (name "gavl")
>> > +    (version "1.4.0")
>> > +    (source
>> > +     (origin
>> > +       (method url-fetch)
>> > +       (uri (string-append "mirror://sourceforge/gmerlin/"
>> > +                           name "/" version "/"
>> > +                           name "-" version ".tar.gz"))
>> > +       (file-name (string-append name "-" version ".tar.gz"))
>> > +       (sha256
>> > +        (base32
>> > +         "1kikkn971a14zzm7svi7190ldc14fjai0xyhpbcmp48s750sraji"))))
>> > +    (build-system gnu-build-system)
>> > +    (native-inputs
>> > +     `(("pkg-config" ,pkg-config)
>> > +       ("doxygen" ,doxygen)))
>> > +    (home-page "http://gmerlin.sourceforge.net")
>> > +    (synopsis "low level library for multimedia API building")

I also missed this the first time: the synopsis must start with an
upper-case letter or digit. I fixed it before pushing the patch.

>> > +    (description
>> > +     "Gavl is short for Gmerlin Audio Video Library.  It is a low level
>> > +library, upon which multimedia APIs can be built.  Gavl handles all the
>> > +details of audio and video formats like colorspaces, samplerates,
>> 
>> "samplerates" should be two words.
>> 
>> > +multichannel configurations etc.  It provides standardized definitions for
>>                               ^
>>                a comma after "configurations" would be nice.
>> > +those formats as well as container structures for carrying audio samples or
>> > +video images inside an application.
>> > +
>> > +In addition, it handles the sometimes ugly task to convert between all
>> 
>> Instead of "ugly task to convert..." perhaps we can say "ugly task of
>> converting..."
>> 
>> > +these formats and provides some elementary operations (copying, scaling,
>> > +alpha blending etc).")
>> > +    (license license:gpl3)))
>> 
>> I suppose the changes to gavl's description could be forwarded upstream,
>> seeing as this is the same description as the one
>> gmerlin.sourceforge.net uses.
>
> Maybe… Besides having the correct text it requires writing
> the email etc. If I don't forget it, I'll get to it eventually
> at some point… this year.
>
>> Everything else LGTM. Thanks for working on this!
>> 
> Thanks for the review.
>
> Updated patches appended.

Excellent, and thank you. These have been pushed to master.