GNU bug report logs - #28904
modes changed outside Customize

Previous Next

Full log

Message #8 received at 28904 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: charles <at> aurox.ch
Cc: 28904 <at> debbugs.gnu.org
Subject: Re: bug#28904: modes changed outside Customize
Date: Mon, 24 Aug 2020 20:04:06 -0300

[Message part 1 (text/plain, inline)]

charles <at> aurox.ch (Charles A. Roelli) writes:

>>From emacs -q (26.0.90):
>
> M-x column-number-mode
> C-x z > Repeat it to turn it back off.
> M-x load-theme RET tango RET > Any theme will do.
>
> Notice that column numbers are turned on again in the mode line.  They
> should not be on.

I can reproduce this with latest master.

This was introduced in commit fccf278488785f482c7c50ac0713aa8f60dafbe9.
The issue is that we are pushing the new value to the user theme only if
it is not the saved-value or the standard-value.  So if the user ever goes
back
to one of those two values (in the recipe, by turning `column-number-mode'
off),
then we never store that value in the user theme.

And because we have the wrong value stored, loading a theme steps over
the user preference.

So I think the fix would be to keep the user theme in sync with the
actual value, at any time.

[Message part 2 (text/html, inline)]

[0001-Keep-the-user-theme-in-sync-when-marking-a-variable-.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.