From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 17 16:40:40 2017 Received: (at submit) by debbugs.gnu.org; 17 Oct 2017 20:40:40 +0000 Received: from localhost ([127.0.0.1]:46685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4YfI-0001jM-48 for submit@debbugs.gnu.org; Tue, 17 Oct 2017 16:40:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4YfE-0001j6-2q for submit@debbugs.gnu.org; Tue, 17 Oct 2017 16:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4Yf7-0004N2-Aq for submit@debbugs.gnu.org; Tue, 17 Oct 2017 16:40:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e4Yf7-0004Mp-1S for submit@debbugs.gnu.org; Tue, 17 Oct 2017 16:40:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4Yf5-00010Y-Tj for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 16:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4Yf0-0004Jf-LY for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 16:40:27 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:51531) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4Yf0-0004IW-Eo for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 16:40:22 -0400 Received: by mail-wm0-x236.google.com with SMTP id f4so6327688wme.0 for ; Tue, 17 Oct 2017 13:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:subject:from:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=tWizWA+WcRMzjrzlDHtKpHLQn78ySE79DB5QDHbT+Yk=; b=IEJ+jcT+WjTLmDfPXXQbtMtRwr8BjzB4qYZmr4C3d9fqXHKif85KRmFiCAIx3aUfbg DGCf5zgyuBTA222/vf5VmSho6DAU2mpiY/XHm0delxVyosy2WjXNJP6GpVIhp+spPZjX 9uCz8qIe4b1ZXXCgxElYuPllG4O1MM0umNOyeCbTWk9iyFEViCQs+Uswxg9rKyzyQqD3 PpSRuoL9mlivIkkBGUSEDlJvtsm3bT8sM4dF29QSpaF/PqSsDYNfBMedjmvxL+8RKWq7 RJrmeWvrWacsGIK6TJHGy2Qf8SFDKWLp31tHtHJMnmlG9YznVbSdc67SZguOmM75v4Qx mLJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:from:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=tWizWA+WcRMzjrzlDHtKpHLQn78ySE79DB5QDHbT+Yk=; b=JcOo1qk29v7Em+I1Jrbjj6hwhaAOViYJOq/iwVuMVQxo5I1ZXc2Q1HqnyAR8qgu5qI i22886pXI/H/9iYEREXAogKDCAmHpO67wdwEbvAlkl3X97x3Kb782jTfGMY9dapwbH3U DmoCZDqU5jusIvuNYM+umA9EuMCQnWzp5ljF8t/KNMao0hjB4fd96kdpoPFHASJMeH55 dNS2hkAiNb78rr5jv0Yqf7WN8SvzTufWYbESVaBUJ6moXtnuPvD1IE6C25Z8hotlD2gD LxuxFyp2vscQXnPn4uFhH55Iu7Z4wgnJ1EFK3Ff7Mm6cNzFLmcQaZuduCMm8hwQ1fT6t LmTg== X-Gm-Message-State: AMCzsaWVkChOSGTOk/iiWetBjTowzRQQ6SgVLTbOmDqH0aXBVT1gAnUQ NLS4HJbtBgowGX1Jpv/9Wv3u6g== X-Google-Smtp-Source: ABhQp+SzAFfR/Qdh5YxKkpJEsRDlYKHCzFZjT5DuT09N73Nsvut11rs+2Ko6deISy8I2yvTJTKgC1g== X-Received: by 10.28.6.14 with SMTP id 14mr4196014wmg.37.1508272819747; Tue, 17 Oct 2017 13:40:19 -0700 (PDT) Received: from [192.168.0.3] (82-69-64-228.dsl.in-addr.zen.co.uk. [82.69.64.228]) by smtp.gmail.com with ESMTPSA id e196sm23678051wmf.9.2017.10.17.13.40.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Oct 2017 13:40:18 -0700 (PDT) To: bug-gnu-emacs@gnu.org Subject: 26.0.90; Narrowed line numbers shown with display-line-numbers-widen From: Andy Moreton Message-ID: Date: Tue, 17 Oct 2017 21:40:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) From emacs -Q: 1) Open a lisp file    (setq display-line-numbers-widen t)    M-x display-line-numbers-mode 2) Move point inside a function    M-x narrow-to-defun 3) M-x widen After (2) the window shows line numbers relative to the start of the buffer, as expected. After (3), the window shows line numbers starting from 1 for the narrowed region. After the next mouse or keyboard input, the line numbers are displayed normally. Thus it seems that when display-line-numbers-widen is non-nil the line numbers are not recomputed after widen until then next input. In GNU Emacs 26.0.90 (build 9, x86_64-w64-mingw32)  of 2017-10-17 built on QUIETUS Repository revision: 2e1b3522b8562f94a98fed07aeddb6b5ba0dbc6c From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 12:22:59 2017 Received: (at 28879) by debbugs.gnu.org; 18 Oct 2017 16:22:59 +0000 Received: from localhost ([127.0.0.1]:48505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4r7T-0007VW-LA for submit@debbugs.gnu.org; Wed, 18 Oct 2017 12:22:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4r7S-0007VH-RO for 28879@debbugs.gnu.org; Wed, 18 Oct 2017 12:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4r7K-0008Hx-Gv for 28879@debbugs.gnu.org; Wed, 18 Oct 2017 12:22:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4r7K-0008Hr-7G; Wed, 18 Oct 2017 12:22:50 -0400 Received: from [176.228.60.248] (port=3746 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e4r7J-0007U6-3P; Wed, 18 Oct 2017 12:22:50 -0400 Date: Wed, 18 Oct 2017 19:22:33 +0300 Message-Id: <83k1zse88m.fsf@gnu.org> From: Eli Zaretskii To: Andy Moreton In-reply-to: (message from Andy Moreton on Tue, 17 Oct 2017 21:40:16 +0100) Subject: Re: bug#28879: 26.0.90; Narrowed line numbers shown with display-line-numbers-widen References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28879 Cc: 28879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Andy Moreton > Date: Tue, 17 Oct 2017 21:40:16 +0100 > > From emacs -Q: > 1) Open a lisp file >    (setq display-line-numbers-widen t) >    M-x display-line-numbers-mode > 2) Move point inside a function >    M-x narrow-to-defun > 3) M-x widen > > After (2) the window shows line numbers relative to the start of > the buffer, as expected. > > After (3), the window shows line numbers starting from 1 for the > narrowed region. After the next mouse or keyboard input, the line > numbers are displayed normally. Right. And if your Emacs is built with --enable-checking (which is something I advise for the first couple of pretest of a new release), you might be able to trigger an assertion violation by repeating the above recipe several times. > Thus it seems that when display-line-numbers-widen is non-nil the line > numbers are not recomputed after widen until then next input. Actually, the numbers have been recomputed, as you see them change on display. They just were recomputed incorrectly: the logic related to widening failed to catch the first redisplay cycle after 'widen', which is special. (In general, line numbers are computed as part of displaying a window, so whenever you see redisplay, you know the line numbers were recomputed, at least for some lines.) Should be fixed now. Thanks for reporting this. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 13:40:03 2017 Received: (at submit) by debbugs.gnu.org; 18 Oct 2017 17:40:03 +0000 Received: from localhost ([127.0.0.1]:48548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4sK1-00019M-SY for submit@debbugs.gnu.org; Wed, 18 Oct 2017 13:40:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4sK0-00019A-Vq for submit@debbugs.gnu.org; Wed, 18 Oct 2017 13:40:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4sJu-000140-SL for submit@debbugs.gnu.org; Wed, 18 Oct 2017 13:39:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56351) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e4sJu-00013q-Ox for submit@debbugs.gnu.org; Wed, 18 Oct 2017 13:39:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4sJt-0005FR-C3 for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 13:39:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4sJp-00011h-E7 for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 13:39:53 -0400 Received: from [195.159.176.226] (port=48746 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4sJp-000113-6e for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 13:39:49 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e4sJM-0002Hz-Ep for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 19:39:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#28879: 26.0.90; Narrowed line numbers shown with display-line-numbers-widen Date: Wed, 18 Oct 2017 18:39:12 +0100 Lines: 31 Message-ID: References: <83k1zse88m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) Cancel-Lock: sha1:7GxHcSwXdbxpntiJwp3hxwoFkHk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) On Wed 18 Oct 2017, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Tue, 17 Oct 2017 21:40:16 +0100 >> >> From emacs -Q: >> 1) Open a lisp file >>    (setq display-line-numbers-widen t) >>    M-x display-line-numbers-mode >> 2) Move point inside a function >>    M-x narrow-to-defun >> 3) M-x widen >> >> After (2) the window shows line numbers relative to the start of >> the buffer, as expected. >> >> After (3), the window shows line numbers starting from 1 for the >> narrowed region. After the next mouse or keyboard input, the line >> numbers are displayed normally. > > Right. And if your Emacs is built with --enable-checking (which is > something I advise for the first couple of pretest of a new release), > you might be able to trigger an assertion violation by repeating the > above recipe several times. Good point - mine was built without it. > Should be fixed now. Thanks for reporting this. Confirmed fixed. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 13:58:30 2017 Received: (at 28879-done) by debbugs.gnu.org; 18 Oct 2017 17:58:30 +0000 Received: from localhost ([127.0.0.1]:48576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4sbu-0001eD-0I for submit@debbugs.gnu.org; Wed, 18 Oct 2017 13:58:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4sbs-0001dv-I6 for 28879-done@debbugs.gnu.org; Wed, 18 Oct 2017 13:58:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4sbi-0007Y2-HG for 28879-done@debbugs.gnu.org; Wed, 18 Oct 2017 13:58:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4sbi-0007Xk-Dr; Wed, 18 Oct 2017 13:58:18 -0400 Received: from [176.228.60.248] (port=3992 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e4sbg-0007ob-FT; Wed, 18 Oct 2017 13:58:18 -0400 Date: Wed, 18 Oct 2017 20:57:56 +0300 Message-Id: <83efq0e3tn.fsf@gnu.org> From: Eli Zaretskii To: Andy Moreton In-reply-to: (message from Andy Moreton on Wed, 18 Oct 2017 18:39:12 +0100) Subject: Re: bug#28879: 26.0.90; Narrowed line numbers shown with display-line-numbers-widen References: <83k1zse88m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28879-done Cc: 28879-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Andy Moreton > Date: Wed, 18 Oct 2017 18:39:12 +0100 > > > Should be fixed now. Thanks for reporting this. > > Confirmed fixed. Thanks, closing. From unknown Sun Aug 10 16:51:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Nov 2017 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator