From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 16 00:09:16 2017 Received: (at submit) by debbugs.gnu.org; 16 Oct 2017 04:09:16 +0000 Received: from localhost ([127.0.0.1]:42276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3wiK-0002Xo-DN for submit@debbugs.gnu.org; Mon, 16 Oct 2017 00:09:16 -0400 Received: from mail.ericabrahamsen.net ([50.56.99.223]:51723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3wiJ-0002Xh-LR for submit@debbugs.gnu.org; Mon, 16 Oct 2017 00:09:15 -0400 Received: from localhost (71-212-71-66.tukw.qwest.net [71.212.71.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D33DABF820 for ; Mon, 16 Oct 2017 04:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1508126955; bh=R560q/QY+NnoRR0nTeqeD6iwfcSVRUtrQvBKulixSBk=; h=From:To:Subject:Date:From; b=bRI+fj9GXscPjSgzTJUAb9NXoi5yDRGvf/UXM2tdrxt+xWYE6yh9STGL6lsggTtCU uippnqX838prF8EHN0R9OVVBx2EoD51pXpfOhfAMp803amIn3dwR/dZFy6JLWGjaiJ xfaXwvJgwSUwR6moLu1BnuMJlz+sQM/hYpB8nsck= From: Eric Abrahamsen To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: Replace gnus-last-element with car->last X-Debbugs-Version: 5.13 X-Debbugs-Package: emacs,gnus Date: Sun, 15 Oct 2017 21:07:42 -0700 Message-ID: <87efq3ka5t.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain (car (last LIST)) does just what (gnus-last-element LIST) does, and is considerably more efficient. I think this is fairly uncontroversial, but will let it hang out a bit first in case anyone sees something I don't. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Remove-gnus-last-element.patch >From 63251a3248569df0fde85f52e3ce1f605e0c3b3a Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Tue, 9 May 2017 18:48:00 +0800 Subject: [PATCH] Remove gnus-last-element * lisp/gnus/gnus-range.el: Now better expressed as (car (last LIST)). * lisp/gnus/gnus-cache.el (gnus-cache-generate-active): * lisp/gnus/gnus-sum.el (gnus-select-newsgroup, gnus-summary-insert-articles): Replace calls. --- lisp/gnus/gnus-cache.el | 2 +- lisp/gnus/gnus-range.el | 6 ------ lisp/gnus/gnus-sum.el | 4 ++-- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/lisp/gnus/gnus-cache.el b/lisp/gnus/gnus-cache.el index 12c8903d02..801728d2f2 100644 --- a/lisp/gnus/gnus-cache.el +++ b/lisp/gnus/gnus-cache.el @@ -735,7 +735,7 @@ gnus-cache-generate-active ;; `gnus-cache-unified-group-names' needless. (gnus-sethash (or (cdr (assoc group gnus-cache-unified-group-names)) group) - (cons (car nums) (gnus-last-element nums)) + (cons (car nums) (car (last nums))) gnus-cache-active-hashtb)) ;; Go through all the other files. (dolist (file alphs) diff --git a/lisp/gnus/gnus-range.el b/lisp/gnus/gnus-range.el index b30b2e9099..3c84f9d69a 100644 --- a/lisp/gnus/gnus-range.el +++ b/lisp/gnus/gnus-range.el @@ -33,12 +33,6 @@ gnus-range-normalize If RANGE is a single range, return (RANGE). Otherwise, return RANGE." (if (listp (cdr-safe range)) range (list range))) -(defun gnus-last-element (list) - "Return last element of LIST." - (while (cdr list) - (setq list (cdr list))) - (car list)) - (defun gnus-copy-sequence (list) "Do a complete, total copy of a list." (let (out) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 48571096cc..22160e4142 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -5737,7 +5737,7 @@ gnus-select-newsgroup (mail-header-number (car gnus-newsgroup-headers)) gnus-newsgroup-end (mail-header-number - (gnus-last-element gnus-newsgroup-headers)))) + (car (last gnus-newsgroup-headers))))) ;; GROUP is successfully selected. (or gnus-newsgroup-headers t))))) @@ -12915,7 +12915,7 @@ gnus-summary-insert-articles (mail-header-number (car gnus-newsgroup-headers)) gnus-newsgroup-end (mail-header-number - (gnus-last-element gnus-newsgroup-headers)))) + (car (last gnus-newsgroup-headers))))) (when gnus-use-scoring (gnus-possibly-score-headers)))) -- 2.14.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 06:44:33 2017 Received: (at control) by debbugs.gnu.org; 19 Oct 2017 10:44:33 +0000 Received: from localhost ([127.0.0.1]:49187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e58JV-0007Qp-K2 for submit@debbugs.gnu.org; Thu, 19 Oct 2017 06:44:33 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:56774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e58JT-0007QV-UH; Thu, 19 Oct 2017 06:44:32 -0400 Received: by mail-io0-f173.google.com with SMTP id m81so9321404ioi.13; Thu, 19 Oct 2017 03:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hF++O6bRjv+O3m+8ONVfPgqGzGU/RmzV4EoUZOGB6BA=; b=JzMAIVkPt7p3J+rUA/9FhYTY+prwSPwdQDO1aVIu3VRkIgo3CFFOA/ODfvlZAo/RiA z39HzmpOiCs+s/kHaMLW9impJXzsHRH4hIr1mQEVdG0L4duUm7JS1h7pNlyKVOQfflvU 4qIufjjnf2dXzRKQzhYAneQ4PAruABvXeT0KxdxBFbnDL9U8X/ND66vKNS7L8FmBLu4B H86YGOvQz5FsunU42uwhnq9aivF75sO28nl1JcIm2QQB+97ATswDwEeBu92w/Wc8aV5k fKJVhgBA9upWG2icaPPkJ3MgdDXkZ93oubbNpbeD7aOgCLnqIxCCvQQIziEUnssA9sWk MyMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=hF++O6bRjv+O3m+8ONVfPgqGzGU/RmzV4EoUZOGB6BA=; b=Gga9uPUqDl1i9M2Oir5YGyD8Djzldsi1vrSAAjyXjfL1jh+d8boo4qw1d6XYLxZIvm 1REMRh3Cm9RdM4ear52a4va7/RUM9KAbmkIn12xPal+aZhHhMJQ5Bu2vnxe9pV5PhKM5 GUcMjLk6p9RVoTE1AjUYeXVr45uOgYGW9rREiPKCaaQOHomNUnv74nuYI9iO0pXtABY4 ScX24jQUBTVeimkkX8HNFXcc/rMHUPobOnxmCvGK9iXfaftDgIf+0zJUheb8Bfv6TNg/ qH6WB3+mFCWVwwSC1LfLLaY/mr5OJtM2cczQ19YcnYiXMmxcglynIPBCEXXCjyCrt0BF ng7w== X-Gm-Message-State: AMCzsaXHcSSCl0VBUYbfowHpRkgfyEV8LjytHs65Ts0ys2Xsf36n3bXr FKO/QYFu49uTvEcWZiWRO47zFw== X-Google-Smtp-Source: ABhQp+S50tdqRVjW+7N5oqR6Q4HjMu+m6GytmCqJEJEwPvU4KRJHQREWEZvDdKT8hAEyg4T/BrD5Gg== X-Received: by 10.107.42.10 with SMTP id q10mr1363500ioq.196.1508409865972; Thu, 19 Oct 2017 03:44:25 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id f12sm2815286itc.1.2017.10.19.03.44.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2017 03:44:24 -0700 (PDT) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#28867: Acknowledgement (Replace gnus-copy-sequence with copy-tree) References: <87k1zvxc5z.fsf@ericabrahamsen.net> <878tgbxbyf.fsf@ericabrahamsen.net> Date: Thu, 19 Oct 2017 06:44:23 -0400 In-Reply-To: <878tgbxbyf.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 16 Oct 2017 10:02:48 -0700") Message-ID: <87k1zrfmd4.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control Cc: 28867@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 28867 + patch tags 28856 + patch quit Both patches look fine, the only possibly problem I can see is if some other packge relies on the gnus functions you are removing. Probably not an issue, since they're so trivially replaced by builtins anyway. Eric Abrahamsen writes: > tags 28867 patch You have to send this to control@debbugs.gnu.org (which I've Bcc'd on this email). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 12:28:32 2017 Received: (at control) by debbugs.gnu.org; 28 Nov 2017 17:28:32 +0000 Received: from localhost ([127.0.0.1]:34957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjgO-0004D9-Hm for submit@debbugs.gnu.org; Tue, 28 Nov 2017 12:28:32 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:53237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjgN-0004D2-Mv for control@debbugs.gnu.org; Tue, 28 Nov 2017 12:28:31 -0500 Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B6408C0329 for ; Tue, 28 Nov 2017 17:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1511890110; bh=UrRHf26NyFIT3imOBhbUQCgO3geJ00+EKdYm0QifYKU=; h=From:To:Subject:Date:From; b=kx94HP3xyrVGXOrO/lghiNs+0J48uPmvlRY9u+sawFbxaHrROxQSfCAStNBEtimFZ EglFD4fsVq0fI0cSMebjKLA6GzLdf9ucjzBTcUWAH4u5VZviImGeZ1IW7soYapA1L6 uwqXQDySnh9sC/UJuVycDofgCcPd+1oPTpJxwCFc= From: Eric Abrahamsen To: control@debbugs.gnu.org Subject: Close 28856 and 28867 Date: Tue, 28 Nov 2017 09:06:44 -0800 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Message-ID: <87a7z6gvnm.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 28856 close 28867 tags 29489 patch thanks From unknown Sun Jun 22 00:56:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Dec 2017 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator