GNU bug report logs - #28853
Some virt-manager improvements

Previous Next

Package: guix-patches;

Reported by: Andy Patterson <ajpatter <at> uwaterloo.ca>

Date: Sun, 15 Oct 2017 19:56:02 UTC

Severity: normal

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log


Message #62 received at 28853 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andy Patterson <ajpatter <at> uwaterloo.ca>
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 28853 <at> debbugs.gnu.org
Subject: Re: [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and
 glib modules support.
Date: Wed, 25 Oct 2017 22:18:01 -0700
Hello,

Andy Patterson <ajpatter <at> uwaterloo.ca> skribis:

> On Mon, 16 Oct 2017 21:25:18 +0800
> iyzsong <at> member.fsf.org (宋文武) wrote:
>
>> Andy Patterson <ajpatter <at> uwaterloo.ca> writes:
>> 
>> > virt-manager: Enable gtk schemas and glib modules support.  
>> 
>> How about: Wrap with GSettings schema and GIO modules search paths.
>> 
>> Otherwise, this patch series look good to me, thanks!
>
> Sounds good, updated patch appened:
>
> --
> Andy
>
> From f504ccc9e961e7657261a478e278c142b9006e6b Mon Sep 17 00:00:00 2001
> From: Andy Patterson <ajpatter <at> uwaterloo.ca>
> Date: Sun, 15 Oct 2017 11:47:16 -0400
> Subject: [PATCH] gnu: virt-manager: Wrap with GSettings schema and GIO modules
>  search paths.
>
> Fixes a crash when opening the file chooser dialog.
>
> * gnu/packages/virtualization.scm (virt-manager)[arguments]
> <#:imported-modules>: Add (guix build glib-or-gtk-build-system).
> <#:modules>: Import (guix build glib-or-gtk-build-system) as glib-or-gtk:.
> <#:arguments>: Add 'glib-or-gtk-compile-schemas and 'glib-or-gtk-wrap.

Since we haven’t heard from 宋文武, I went ahead and committed it.

Thanks!

Ludo’.




This bug report was last modified 7 years and 211 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.