GNU bug report logs - #28853
Some virt-manager improvements

Previous Next

Full log

Message #44 received at 28853 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andy Patterson <ajpatter <at> uwaterloo.ca>
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 28853 <at> debbugs.gnu.org
Subject: Re: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection
 support.
Date: Thu, 19 Oct 2017 11:52:02 +0200

[Message part 1 (text/plain, inline)]

Hello,

Andy Patterson <ajpatter <at> uwaterloo.ca> skribis:

> On Mon, 16 Oct 2017 21:15:39 +0800
> iyzsong <at> member.fsf.org (宋文武) wrote:
>
>> Andy Patterson <ajpatter <at> uwaterloo.ca> writes:
>> 
>> > * gnu/packages/virtualization.scm
>> > (qemu)[arguments]<#:configure-flags>: New argument.
>> > [inputs]: Add usbredir.
>> > (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even
>> > when they are set by qemu.
>> > [inputs]: Remove usbredir.  
>> 
>> Doesn't the 'configure' script auto-detect usb redirection support
>> when usbredir is available?
>
> To me, the advantage of specifying the enabled features is that the
> build will require the dependencies to be available for that feature
> even if they change. So, if more dependencies are required for the
> feature in future versions, the build will immediately inform us, rather
> than somewhat silently dropping support. Thoughts?

That makes sense to me.

I took the liberty to make the change below, to avoid a rebuild of
‘qemu-minimal’, and applied it.

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 4a711ee7f..49dee07f5 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -192,10 +192,8 @@ server and embedded PowerPC, and S390 guests.")
     (arguments
      (substitute-keyword-arguments (package-arguments qemu)
        ((#:configure-flags _ '(list))
-        `(list
-          ,(string-append
-            "--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu"
-            ",arm-softmmu,aarch64-softmmu")))))
+        ;; Restrict to the targets supported by Guix.
+        ''("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu"))))
 
     ;; Remove dependencies on optional libraries, notably GUI libraries.
     (inputs (fold alist-delete (package-inputs qemu)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.