GNU bug report logs - #28853
Some virt-manager improvements

Previous Next

Full log

Message #32 received at 28853 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Andy Patterson <ajpatter <at> uwaterloo.ca>
Cc: 28853 <at> debbugs.gnu.org
Subject: Re: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection
 support.
Date: Mon, 16 Oct 2017 21:15:39 +0800

Andy Patterson <ajpatter <at> uwaterloo.ca> writes:

> * gnu/packages/virtualization.scm (qemu)[arguments]<#:configure-flags>: New
> argument.
> [inputs]: Add usbredir.
> (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even when they are
> set by qemu.
> [inputs]: Remove usbredir.

Doesn't the 'configure' script auto-detect usb redirection support when
usbredir is available?

> ---
>  gnu/packages/virtualization.scm | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index 5cdf6d09b..24ffc2f28 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -4,6 +4,7 @@
>  ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2016 Ricardo Wurmus <rekado <at> elephly.net>
>  ;;; Copyright © 2017 Alex Vong <alexvong1995 <at> gmail.com>
> +;;; Copyright © 2017 Andy Patterson <ajpatter <at> uwaterloo.ca>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -85,7 +86,7 @@
>       '(;; Running tests in parallel can occasionally lead to failures, like:
>         ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
>         #:parallel-tests? #f
> -
> +       #:configure-flags '("--enable-usb-redir")

In that case, this and ...

>         #:phases
>         (modify-phases %standard-phases
>           (replace 'configure
> @@ -152,6 +153,7 @@
>         ("pixman" ,pixman)
>         ("sdl" ,sdl)
>         ("spice" ,spice)
> +       ("usbredir" ,usbredir)
>         ("util-linux" ,util-linux)
>         ;; ("vde2" ,vde2)
>         ("virglrenderer" ,virglrenderer)
> @@ -188,14 +190,17 @@ server and embedded PowerPC, and S390 guests.")
>      (name "qemu-minimal")
>      (synopsis "Machine emulator and virtualizer (without GUI)")
>      (arguments
> -     `(#:configure-flags
> -       ;; Restrict to the targets supported by Guix.
> -       '("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu")
> -       ,@(package-arguments qemu)))
> +     (substitute-keyword-arguments (package-arguments qemu)
> +       ((#:configure-flags _ '(list))
> +        `(list
> +          ,(string-append
> +            "--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu"
> +            ",arm-softmmu,aarch64-softmmu")))))
>  
... can be removed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.