GNU bug report logs - #28844
26.0.90; display-line-numbers-mode should call window-configuration-change-hook

Previous Next

Full log

View this message in rfc822 format

From: Paul Rankin <hello <at> paulwrankin.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28844 <at> debbugs.gnu.org, agrambot <at> gmail.com
Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook
Date: Tue, 17 Oct 2017 17:13:46 +1000

On Tue, 17 Oct 2017, at 03:44 PM, Eli Zaretskii wrote:
> First, let's be clear about something: it's not "my" mode.  I'll never use it, except
> for testing and fixing bugs.  I implemented this feature because line numbers are
> very popular among Emacs users, and existing solutions, like linum-mode, slow
> down Emacs, sometimes to a crawl.  The excitement expressed by users on Reddit
> when the feature landed, which surprised me, is a clear evidence that the results
> are very satisfactory, as far as users are
> concerned.  So this feature is here to
> stay, and Lisp packages need to adapt (bundled packages already did, AFAIK).
> 
> Next, I *know* that I'm misunderstanding something, but repeating what you
> already said, twice, won't help me understand it.  Please provide more
> details about your application's needs regarding the window layout.

https://github.com/rnkn/olivetti

Here’s the minor mode. Go nuts.

> Given the little that you said until now, would checking the value returned by
> line-number-display-width in a post-command-hook solve your problem?
> If not, please tell why not, and let's take it from there.

No it wouldn’t. I don’t need to run code after every command. Until now, the following hooks have been perfect:

window-configuration-change-hook
window-size-change-functions
after-setting-font-hook
text-scale-mode-hook

n.b. window-size-change-functions only added recently due to 26.x changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.