GNU bug report logs - #28841
[PATCH] New java packages

Previous Next

Package: guix-patches;

Reported by: Julien Lepiller <julien <at> lepiller.eu>

Date: Sat, 14 Oct 2017 22:02:02 UTC

Owned by: Ricardo Wurmus <rekado <at> elephly.net>

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

Full log

Message #83 received at 28841 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: julien <at> lepiller.eu
Cc: 28841 <at> debbugs.gnu.org
Subject: Re: [bug#28841] [PATCH 02/24] gnu: Add java-tomcat.
Date: Wed, 18 Oct 2017 22:42:23 +0200

Hi again,

> * gnu/packages/java.scm (java-tomcat): New variable.
> ---

[…]

> +    (inputs
> +     `(("java-eclipse-jdt-core" ,java-eclipse-jdt-core)))

Actually … I’m *very* surprised that this is the only input here.  I
remember trying to package this early on, but failing because there were
so many unpackaged dependencies.

Are you sure this is the only required input here?  Do the sources come
with bundled jars?

> +         (add-after 'unpack 'properties
> +           (lambda _
> +             (mkdir "downloads")
> +             (substitute* "build.xml"
> +               (("download-compile,") "")
> +               (("depends=\"validate\"") "depends=\"build-prepare\"")
> +               ((",download-validate") ""))
> +             (with-output-to-file "build.properties"
> +               (lambda _
> +                 (display
> +                   (string-append "base.path=" (getcwd)
> "/downloads\n"))))))

Forgot to say this in my previous comment: please end this phase with “#t”.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net
This bug report was last modified 7 years and 215 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.