Subject: [bug#28841] [PATCH 01/24] gnu: Add java-hdrhistogram.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 18 Oct 2017 22:40:07 +0200

Hi Julien,

> From: Julien Lepiller <[email-masked]>
>
> * gnu/packages/java.scm (java-hdrhistogram): New variable.
[…]
> +         (add-before 'configure 'set-version
> +           (lambda _
> +             (let* ((version-java "src/main/java/org/HdrHistogram/Version.java")
> +                    (template (string-append version-java ".template")))
> +               (copy-file template version-java)
> +               (substitute* version-java
> +                 (("\\$VERSION\\$") ,version)
> +                 (("\\$BUILD_TIME\\$") "0"))))))))

Please end the phase with #t.

> +    (native-inputs
> +     `(("junit" ,java-junit)
> +       ("hamcrest" ,java-hamcrest-core)))
> +    (home-page "https://hdrhistogram.github.io/HdrHistogram")
> +    (synopsis "High Dynamic Range Histogram")

Please use lower case here.

> +    (description "Histogram that supports recording and analyzing sampled data
> +value counts across a configurable integer value range with configurable value
> +precision within the range.  Value precision is expressed as the number of
> +significant digits in the value recording, and provides control over value
> +quantization behavior across the value range and the subsequent value resolution
> +at any given level.")

The first fragment is not a full sentence.  Could you please change it?

> +    (license license:bsd-2)))

The website says:

--8<---------------cut here---------------start------------->8---
HdrHistogram was originally authored by Gil Tene (@giltene)
(Java) and placed in the public domain, as explained at
http://creativecommons.org/publicdomain/zero/1.0
--8<---------------cut here---------------end--------------->8---

Does this not apply to this version?

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net