GNU bug report logs - #28832
[PATCH 0/3] gnu: Add emacs-json-mode.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28832 <at> debbugs.gnu.org, 28832-done <at> debbugs.gnu.org, Alex Kost <alezost <at> gmail.com>
Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat.
Date: Mon, 15 Jan 2018 14:33:22 +0100

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
> [...]
>
>>>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001
>>>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>>>> Date: Tue, 12 Dec 2017 01:41:08 +0300
>>>> Subject: [PATCH] gnu: Add emacs-json-reformat.
>>>>
>>>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file.
>>>> * gnu/local.mk (dist_patch_DATA): Add this.
>>>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable.
>>>
>>> [...]
>>>
>>>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch
>>>> new file mode 100644
>>>> index 000000000..23a239582
>>>> --- /dev/null
>>>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch
>>>> @@ -0,0 +1,28 @@
>>>> +Copyright © 2017 Oleg Pykhalov <go.wigust <at> gmail.com>
>>>> +
>>>> +This patch fixes tests for Emacs 25.
>>>
>>> Please mention <https://github.com/gongo/json-reformat/issues/33> here.
>>>
>>> OK with these changes!
>>
>> We went on discussing other things and forgot about the patch.  :-)
>> Could you commit it with these changes, Oleg?
>
> I thought we suspend this until automation of "-L" flags.

No no, the “OK with these changes” above really means you can go ahead.
:-)

The “-L” discussion is about an improvement we should make, but it
should not block this patch.

> Seems like a similar discussion[1] gets stuck too.
> Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a

Yeah, though I don’t think you should wait for Alex or anyone else to
make a decision: if you have an idea on how to improve this, based on
these discussions, then you’re probably in a good position to do it and
everyone will be happy.  ;-)

> Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1

Great, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.