Subject: Re: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat.

From: [email-masked] (Ludovic Courtès)
Date: Fri, 20 Oct 2017 14:34:39 +0200

Hello,

Oleg Pykhalov <[email-masked]> skribis:

> * gnu/packages/emacs.scm (emacs-json-reformat): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'install 'check
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (zero? (system* "emacs" "--batch" "-L" "."
> +                             "-L" (string-append
> +                                   (assoc-ref inputs "emacs-undercover")
> +                                   "/share/emacs/site-lisp/guix.d/undercover-"
> +                                   ,(package-version emacs-undercover))
> +                             "-L" (string-append
> +                                   (assoc-ref inputs "emacs-dash")
> +                                   "/share/emacs/site-lisp/guix.d/dash-"
> +                                   ,(package-version emacs-dash))
> +                             "-L" (string-append
> +                                   (assoc-ref inputs "emacs-shut-up")
> +                                   "/share/emacs/site-lisp/guix.d/shut-up-"
> +                                   ,(package-version emacs-shut-up))
> +                             "-l" "test/test-helper.el"
> +                             "-l" "test/json-reformat-test.el"
> +                             "-f" "ert-run-tests-batch-and-exit"))
> +             ;; Fails
> +             ;; json-reformat-test:json-reformat-region-occur-error
> +             ;; json-reformat-test:string-to-string
> +             #t)))))

Did you have a chance to investigate the test failures?  It’s not
confidence-inspiring ;-), so it would be good to at least have a link to
an upstream bug report.

Besides, I wonder: shouldn’t ‘emacs-build-system’ define the
‘EMACSLOADPATH’ env. var. so we don’t have to carry all these -L flags?
Is there any downside?

Thanks,
Ludo’.