From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 0/3] gnu: Add emacs-json-mode. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2017 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28832@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150797472825352 (code B ref -1); Sat, 14 Oct 2017 09:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Oct 2017 09:52:08 +0000 Received: from localhost ([127.0.0.1]:38846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3J72-0006ap-0W for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3J70-0006aN-JL for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3J6u-00064D-IX for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e3J6u-000649-FK for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3J6t-0005oc-DC for guix-patches@gnu.org; Sat, 14 Oct 2017 05:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3J6q-00063M-Cu for guix-patches@gnu.org; Sat, 14 Oct 2017 05:51:59 -0400 Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:54009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3J6q-00062v-5B for guix-patches@gnu.org; Sat, 14 Oct 2017 05:51:56 -0400 Received: by mail-lf0-x22c.google.com with SMTP id l23so12045267lfk.10 for ; Sat, 14 Oct 2017 02:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version:content-disposition :content-description; bh=9kdt2EHW7kkPEAEtegbEcreD5Et8aB+P9ofmVSZGG4o=; b=oFY8kB7oqOWNhOYWSTP9uwtpr2b+64BOFZQ9fkCLzlg7hQyL0kbcpOiM2OHYXkSvfk 4YJ8SFYmqWCGKyO/5dOaCMIXLFspgnrpAOJsiqCaEvqZ8LpRxyXhoOe1EjhfS3+wLqdS hQV1qsp3GdZsacEJjYsZcaLW/CVQV0Jr644RXFVGQaayCEvNfUQuJjp0DLHuSz7a/kCD mYYuv2VMvkEUxpOgchiG2Vz3YvFWna1ZMqPa+id4b8kI5wHCx2w0FdPye33ffftQxoOB gWhF/1IfrnL4qNeoqD9dAbBNj8tk/puV2w8bt9qzNB3LPijy9Oi5G2t1R7i0Y5z97Lih s5Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-disposition:content-description; bh=9kdt2EHW7kkPEAEtegbEcreD5Et8aB+P9ofmVSZGG4o=; b=KHAZq7geTfcTtkSkK9WQhQdRnrebgR+6uZ9zw0wtX8TVtUJrjm+cQ6sa19XH6VqO/A +wcYBy6jOG+UvsmNyg4YesX+pSNX1Gbw+m/tjf50xgO/fPZvdLUBnwHywjXopVEec3OR UMjam0qvEYtlWCy7IzWloAIugnNN3Xno0WE+W6dOKCVdPcyGi5DVOsC2Da7/aFHkUpV0 fwr8PjcOYGWgfNebsTvVrLYxofA82n4iD1mjytxsWzAGDFK9M2QDyEUfHu9AnMPZiSEp u1dAyTGlWiIywvEUC2C48SY8270jlfspvxZ1JXwwk/kN+yjK/XtjG7UWIF0r4mR3Og/O 4BgQ== X-Gm-Message-State: AMCzsaVPanrpRVeONJ12daIkChz9FcT1SZsbAZUkf2sAX4DmV4wpG8RF s2frpx6lMlYTfa8tyGtt4yZLng== X-Google-Smtp-Source: ABhQp+SSZF8xldokoJpTFNiD9CzDPibREZ04Pdj/HpyGuqZiR4b/pH4fgawWnU/0Mdu1BQCcp1GJAA== X-Received: by 10.46.82.14 with SMTP id g14mr1628011ljb.118.1507974714405; Sat, 14 Oct 2017 02:51:54 -0700 (PDT) Received: from magnolia ([178.71.225.184]) by smtp.gmail.com with ESMTPSA id t10sm704002lja.92.2017.10.14.02.51.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 02:51:53 -0700 (PDT) From: Oleg Pykhalov Date: Sat, 14 Oct 2017 12:51:52 +0300 Message-ID: <87lgke3vlz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/x-patch Content-Disposition: inline; filename=0000-cover-letter.patch Content-Description: [PATCH 0/3] gnu: Add emacs-json-mode. X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) >From b3b7b79f85e3b2aca6322e9c994b0fe0a666825d Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sat, 14 Oct 2017 12:50:21 +0300 Subject: [PATCH 0/3] gnu: Add emacs-json-mode. 2 tests fails in emacs-json-reformat. Oleg Pykhalov (3): gnu: Add emacs-json-reformat. gnu: Add emacs-json-snatcher. gnu: Add emacs-json-mode. gnu/packages/emacs.scm | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) -- 2.14.2 From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. References: <87lgke3vlz.fsf@gmail.com> In-Reply-To: <87lgke3vlz.fsf@gmail.com> Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2017 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28832@debbugs.gnu.org Cc: Oleg Pykhalov Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.150797697629122 (code B ref 28832); Sat, 14 Oct 2017 10:30:02 +0000 Received: (at 28832) by debbugs.gnu.org; 14 Oct 2017 10:29:36 +0000 Received: from localhost ([127.0.0.1]:38869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3JhH-0007Zd-V4 for submit@debbugs.gnu.org; Sat, 14 Oct 2017 06:29:36 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:47853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3JhE-0007ZA-Dd for 28832@debbugs.gnu.org; Sat, 14 Oct 2017 06:29:32 -0400 Received: by mail-lf0-f54.google.com with SMTP id k40so12107847lfi.4 for <28832@debbugs.gnu.org>; Sat, 14 Oct 2017 03:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zkvfaxkF9ScXu1N6PFvtTmrIommfS3+sKmE1EFu5C9s=; b=a7y7SwjgrlGWAgsmCgsGM9eaxrf2mxhPJposMTnfgpsl8sz0DAfghbwyg2aBg7VJAA NpSOzzB8MP+mN8Pi9fgNKvcWha/yC8pH2nfNx4h79ZhP64W0M3n5WKi0I5BUmujjhajH PC4OPA2zWybpWCEaUXm8DK1iCgleO19Bc2nHQ4wS/FSVOYmmVrDh72gVUAFrYmzOkiOr aAt6FtXWqKkOaHbJa0YRp/wiIpvEP3Q/t0/Ge3BuKOBZcd7js8oX31IL2u07D6C/40cZ w7SeVW6nExgU5I3PnjUjJ56FTcpzKTig+HWZeu2ORFmZQQF2+wqOP6LvhdQvYPdd4Hih ogww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zkvfaxkF9ScXu1N6PFvtTmrIommfS3+sKmE1EFu5C9s=; b=df40pA+Dz8X8DTtOR3watM2F/Ls3yjEMxMS9CFfA8ZYgBw8omPDnZWP0IwIJ4MUi7M K0AsxukI/xTIOoooGOffkCwNxyY+9XaDuyhoXCjPpsAYGyGxcVmzRFIVTvIIg7TpQ6ml 5UAFRBbFfNjgp9s5Ciqt2es2lfyk6BHA7AUBrEBZ8f+rfmXr7NDZX5Xn4tLvx89rNKNZ hArKNSoRRlfWxoLMUEUd+Q+zxi1hqJMRoir9mJ475evl6L5fFazhTAjhjd/k2LwUWWGf CAota16sXUwkaDE9v4fYb+D/4Sg0CVLR7wjPbkap39l7yId4b8pVf/LNZ86SeSbdTzNs 048A== X-Gm-Message-State: AMCzsaV8rnkourEpRRR+7dRAgy6fuy3y5njCOe4fYjUlaSowFA09KltN gEE41ew0fmWx78aKKKF82SBYhw== X-Google-Smtp-Source: ABhQp+SYryGkBlvAQV8ov/u/N6epR/Fjy20kgq9LjwEW9WS3JC1Pp3hHGgP9e5qAID2zzvwHtuHdnA== X-Received: by 10.46.71.82 with SMTP id u79mr1699805lja.52.1507976965972; Sat, 14 Oct 2017 03:29:25 -0700 (PDT) Received: from localhost.localdomain ([178.71.225.184]) by smtp.gmail.com with ESMTPSA id u69sm567412lfk.68.2017.10.14.03.29.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2017 03:29:25 -0700 (PDT) From: Oleg Pykhalov Date: Sat, 14 Oct 2017 13:29:13 +0300 Message-Id: <20171014102915.11778-1-go.wigust@gmail.com> X-Mailer: git-send-email 2.14.2 X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * gnu/packages/emacs.scm (emacs-json-reformat): New variable. --- gnu/packages/emacs.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 66f0a2ebe..8d94341ab 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -5569,6 +5569,55 @@ pair of minor modes which suppress all mouse events by intercepting them and running a customisable handler command (@code{ignore} by default). ") (license license:gpl3+))) +(define-public emacs-json-reformat + (package + (name "emacs-json-reformat") + (version "0.0.6") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/gongo/json-reformat/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "11fbq4scrgr7m0iwnzcrn2g7xvqwm2gf82sa7zy1l0nil7265p28")))) + (build-system emacs-build-system) + (propagated-inputs `(("emacs-undercover" ,emacs-undercover))) + (inputs + `(("emacs-dash" ,emacs-dash) ; for tests + ("emacs-shut-up" ,emacs-shut-up))) ; for tests + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'install 'check + (lambda* (#:key inputs #:allow-other-keys) + (zero? (system* "emacs" "--batch" "-L" "." + "-L" (string-append + (assoc-ref inputs "emacs-undercover") + "/share/emacs/site-lisp/guix.d/undercover-" + ,(package-version emacs-undercover)) + "-L" (string-append + (assoc-ref inputs "emacs-dash") + "/share/emacs/site-lisp/guix.d/dash-" + ,(package-version emacs-dash)) + "-L" (string-append + (assoc-ref inputs "emacs-shut-up") + "/share/emacs/site-lisp/guix.d/shut-up-" + ,(package-version emacs-shut-up)) + "-l" "test/test-helper.el" + "-l" "test/json-reformat-test.el" + "-f" "ert-run-tests-batch-and-exit")) + ;; Fails + ;; json-reformat-test:json-reformat-region-occur-error + ;; json-reformat-test:string-to-string + #t))))) + (home-page "https://github.com/gongo/json-reformat") + (synopsis "Reformatting tool for JSON") + (description "@code{json-reformat} provides a reformatting tool for +@url{http://json.org/, JSON}.") + (license license:gpl3+))) + (define-public emacs-restclient (let ((commit "07a3888bb36d0e29608142ebe743b4362b800f40") (revision "1")) ;Guix package revision, -- 2.14.2 From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 2/3] gnu: Add emacs-json-snatcher. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2017 10:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28832@debbugs.gnu.org Cc: Oleg Pykhalov Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.150797697629128 (code B ref 28832); Sat, 14 Oct 2017 10:30:03 +0000 Received: (at 28832) by debbugs.gnu.org; 14 Oct 2017 10:29:36 +0000 Received: from localhost ([127.0.0.1]:38871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3JhI-0007Zf-7U for submit@debbugs.gnu.org; Sat, 14 Oct 2017 06:29:36 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:47016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3JhF-0007ZC-0u for 28832@debbugs.gnu.org; Sat, 14 Oct 2017 06:29:33 -0400 Received: by mail-lf0-f66.google.com with SMTP id g70so12108615lfl.3 for <28832@debbugs.gnu.org>; Sat, 14 Oct 2017 03:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xNjv1dr4U1DVEmBK0nLsKrrNmy+HEBNbacf/k3qDRGQ=; b=HAMyDtlppNBXMVUszumfOdSibZX/Cb82Uf+ZOwBzhkXMkpqlVX2y0nsTCM8AZbI/Gx EiZRyTablvADgPNE0Ch6PHsn4OzE57vWu0UnSir+N69dVYIkiKkbYyGNRzeyLTh5+cjC ZZZt+gLGW2yqu//oZw9a/KbkxqyVjzTerE4g64wkhnGXRXfhdKojsZQtwMLZ8f1LxxnZ o3tbRErFJUf5I9V6qEjMDupJ3DPKvHYVM2AmC4Gs5gBMp4n1CHDb25uPAYL0MtFZgyuK SuK2dRVDkKzkODVXe4ACLajt/8j/ziIE2VvlQGPeJLlAoI3mLYoJ29mDBdnP3vjU4DCD z84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xNjv1dr4U1DVEmBK0nLsKrrNmy+HEBNbacf/k3qDRGQ=; b=AqYkhH9wYhOlVZQ1fwpXkqfQfPkEr9Qc+fzgRJiuxA96t/0O9o4Yk2eb3WWSHa47p4 FeFecBNieautRBy9COALt+L2pA0sHNJyk12fEPDZ5GGH7DsGVtvcHmJu3yDoSALagZEI kuSDMeUrq8YZ6z6xijQHCVQruR7XthWsqXzKgv+F1ASzYmHd/SSgRjuOEHFXCbwAdk4q +GRY8E3PFfkptwU8twofcoUBg64cLmQ4eal/f7cT3TJn6x0NQTemmi2PUCtPlP9xNcpa Sndv89p9tqrAaWSbhzDGn+LAhw6b+N3FqvA2OmdCHTl+2unMv9UP7MJFyR0OirpYdbGq S7DA== X-Gm-Message-State: AMCzsaWAuphJdsKKHLS+Kd0dnXslqVQv84wdh4gIHDeX+pwA48dnhM/5 9SQLpc/JQ3dgpFGOZsMYTdG1Vg== X-Google-Smtp-Source: ABhQp+SePoUGDbuH8XaywLg6JxtXMUVnvAa8eCIdGhQ7KacexZxM2VAGEcZ7IX3hPANR2KGsFW196g== X-Received: by 10.46.16.10 with SMTP id j10mr1633463lje.13.1507976966952; Sat, 14 Oct 2017 03:29:26 -0700 (PDT) Received: from localhost.localdomain ([178.71.225.184]) by smtp.gmail.com with ESMTPSA id u69sm567412lfk.68.2017.10.14.03.29.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2017 03:29:26 -0700 (PDT) From: Oleg Pykhalov Date: Sat, 14 Oct 2017 13:29:14 +0300 Message-Id: <20171014102915.11778-2-go.wigust@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171014102915.11778-1-go.wigust@gmail.com> References: <20171014102915.11778-1-go.wigust@gmail.com> X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * gnu/packages/emacs.scm (emacs-json-snatcher): New variable. --- gnu/packages/emacs.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 8d94341ab..9bf7acf0b 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -5618,6 +5618,26 @@ running a customisable handler command (@code{ignore} by default). ") @url{http://json.org/, JSON}.") (license license:gpl3+))) +(define-public emacs-json-snatcher + (package + (name "emacs-json-snatcher") + (version "1.0.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/Sterlingg/json-snatcher/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1nfiwsifpdiz0lbrqa77nl0crnfrv5h85ans9b0g5rggnmyshcfb")))) + (build-system emacs-build-system) + (home-page "https://github.com/sterlingg/json-snatcher") + (synopsis "Grabs the path to JSON values in a JSON file") + (description "@code{emacs-json-snatcher} grabs the path to JSON values in +a @url{http://json.org/, JSON} file.") + (license license:gpl3+))) + (define-public emacs-restclient (let ((commit "07a3888bb36d0e29608142ebe743b4362b800f40") (revision "1")) ;Guix package revision, -- 2.14.2 From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 3/3] gnu: Add emacs-json-mode. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2017 10:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28832@debbugs.gnu.org Cc: Oleg Pykhalov Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.150797697929142 (code B ref 28832); Sat, 14 Oct 2017 10:30:03 +0000 Received: (at 28832) by debbugs.gnu.org; 14 Oct 2017 10:29:39 +0000 Received: from localhost ([127.0.0.1]:38873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3JhL-0007Zy-GX for submit@debbugs.gnu.org; Sat, 14 Oct 2017 06:29:39 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:50021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3JhG-0007ZE-2p for 28832@debbugs.gnu.org; Sat, 14 Oct 2017 06:29:35 -0400 Received: by mail-lf0-f66.google.com with SMTP id w21so4468542lfc.6 for <28832@debbugs.gnu.org>; Sat, 14 Oct 2017 03:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8shD4q43/ooGVreqaZMC3qglQRuXoiJq6WdsWaDCvTc=; b=oGa/P6Xso6+hwTGOji2Rajxnl9XA7uDFeWT17aAmk2orzHG1D4RFNj+OTPzN3WQeRZ hD3WE3whn2JsikUX5ZRnSDT0i/NukBdn4i3wKv6hhG5wk3QEDI6uUPGTujfoGY8M7ZWi dP3Xxfa+WJiKCR1gU1rStoxveBv+MwBAXZND7ffZIHJrY0X9IW587B2TeK9FeiCykTce DrImKrCuZhVpzGUBqYi4j+6xAUoFbMoPiaTyC8u2fsnINuvNxAfmyg5r1PUyIZZgRlmf JfAAqKp6rXdn0th5r91Sp/wmebTMOuTPE7BZftf+CbwXiDsnyzOHVlnronPEyC0YVSl4 j6SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8shD4q43/ooGVreqaZMC3qglQRuXoiJq6WdsWaDCvTc=; b=OuhBguauepRM31tLRYd3auWOm3uFTZ6TNLZ3e6MpC0b3W6SVub5ZzVrujtqYo5BM6Y L2ysEKT1UreEHxn9CziJpgYKWGvzn6Y4lHoobUWI+24/th69B1nq52CRqw2sMVgvU1N2 BnHm9wyvun42qJAnrQqeRzLz8x5h0eVptEHQ83eoxmr+8ShNFVRvvuWf+SklXlFOq3sU SD+eYLvoo4LdeMXRmXfy4MzxoZgxfOuHS42NdzbWXRF6KsHXX8dh5G0i/EkK8RD9R86G beUM1wig5LMukbKSwr6Pnjb8I56O+SGkWryPqBEOLdSEBsvq5e/sV0QeXOG33JK4taaK hqkw== X-Gm-Message-State: AMCzsaWKarh+Ssb6ZDa8YIzu/Sci+HZW9BZKCWCOXL8hR1cOWEb/VE6X 6DuvkrFYiKtT7ZIDFzfGCNSuqw== X-Google-Smtp-Source: ABhQp+T4qdd4JEH1k+oanhujxdNCSlecvSomq1QYpa47dDdq3GSgVw4W0+VU1XAGnMADayTY3irHTw== X-Received: by 10.46.89.10 with SMTP id n10mr1779649ljb.149.1507976968109; Sat, 14 Oct 2017 03:29:28 -0700 (PDT) Received: from localhost.localdomain ([178.71.225.184]) by smtp.gmail.com with ESMTPSA id u69sm567412lfk.68.2017.10.14.03.29.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2017 03:29:27 -0700 (PDT) From: Oleg Pykhalov Date: Sat, 14 Oct 2017 13:29:15 +0300 Message-Id: <20171014102915.11778-3-go.wigust@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171014102915.11778-1-go.wigust@gmail.com> References: <20171014102915.11778-1-go.wigust@gmail.com> X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * gnu/packages/emacs.scm (emacs-json-mode): New variable. --- gnu/packages/emacs.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 9bf7acf0b..78a950900 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -5638,6 +5638,29 @@ running a customisable handler command (@code{ignore} by default). ") a @url{http://json.org/, JSON} file.") (license license:gpl3+))) +(define-public emacs-json-mode + (package + (name "emacs-json-mode") + (version "1.7.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/joshwnj/json-mode/archive/" + "v" version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "06h45p4cn767pk9sqi2zb1c65wy5gyyijqxzpglp80zwxhvajdz5")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-json-reformat" ,emacs-json-reformat) + ("emacs-json-snatcher" ,emacs-json-snatcher))) + (home-page "https://github.com/joshwnj/json-mode") + (synopsis "Major mode for editing JSON files") + (description "@code{json-mode} extends the builtin js-mode syntax +highlighting.") + (license license:gpl3+))) + (define-public emacs-restclient (let ((commit "07a3888bb36d0e29608142ebe743b4362b800f40") (revision "1")) ;Guix package revision, -- 2.14.2 From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2017 12:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15085028829308 (code B ref 28832); Fri, 20 Oct 2017 12:35:01 +0000 Received: (at 28832) by debbugs.gnu.org; 20 Oct 2017 12:34:42 +0000 Received: from localhost ([127.0.0.1]:51237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5WVe-0002Q3-Hg for submit@debbugs.gnu.org; Fri, 20 Oct 2017 08:34:42 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:40988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5WVd-0002Pw-Ds for 28832@debbugs.gnu.org; Fri, 20 Oct 2017 08:34:41 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1572AEE93; Fri, 20 Oct 2017 14:34:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cqsURyZ5ynmV; Fri, 20 Oct 2017 14:34:41 +0200 (CEST) Received: from ribbon (unknown [193.50.110.53]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6577E46E7; Fri, 20 Oct 2017 14:34:41 +0200 (CEST) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> Date: Fri, 20 Oct 2017 14:34:39 +0200 In-Reply-To: <20171014102915.11778-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sat, 14 Oct 2017 13:29:13 +0300") Message-ID: <87y3o6uheo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, Oleg Pykhalov skribis: > * gnu/packages/emacs.scm (emacs-json-reformat): New variable. [...] > + (modify-phases %standard-phases > + (add-before 'install 'check > + (lambda* (#:key inputs #:allow-other-keys) > + (zero? (system* "emacs" "--batch" "-L" "." > + "-L" (string-append > + (assoc-ref inputs "emacs-undercover") > + "/share/emacs/site-lisp/guix.d/underc= over-" > + ,(package-version emacs-undercover)) > + "-L" (string-append > + (assoc-ref inputs "emacs-dash") > + "/share/emacs/site-lisp/guix.d/dash-" > + ,(package-version emacs-dash)) > + "-L" (string-append > + (assoc-ref inputs "emacs-shut-up") > + "/share/emacs/site-lisp/guix.d/shut-u= p-" > + ,(package-version emacs-shut-up)) > + "-l" "test/test-helper.el" > + "-l" "test/json-reformat-test.el" > + "-f" "ert-run-tests-batch-and-exit")) > + ;; Fails > + ;; json-reformat-test:json-reformat-region-occur-error > + ;; json-reformat-test:string-to-string > + #t))))) Did you have a chance to investigate the test failures? It=E2=80=99s not confidence-inspiring ;-), so it would be good to at least have a link to an upstream bug report. Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80=99 d= efine the =E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to carry= all these -L flags? Is there any downside? Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 2/3] gnu: Add emacs-json-snatcher. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2017 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15085032669971 (code B ref 28832); Fri, 20 Oct 2017 12:42:01 +0000 Received: (at 28832) by debbugs.gnu.org; 20 Oct 2017 12:41:06 +0000 Received: from localhost ([127.0.0.1]:51246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5Wbo-0002aj-LH for submit@debbugs.gnu.org; Fri, 20 Oct 2017 08:41:06 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:41018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5Wbm-0002aE-DA for 28832@debbugs.gnu.org; Fri, 20 Oct 2017 08:41:02 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 0F56AF3D2; Fri, 20 Oct 2017 14:41:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v6F3dHZYX9rk; Fri, 20 Oct 2017 14:41:02 +0200 (CEST) Received: from ribbon (unknown [193.50.110.53]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 52BD746E7; Fri, 20 Oct 2017 14:41:02 +0200 (CEST) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171014102915.11778-1-go.wigust@gmail.com> <20171014102915.11778-2-go.wigust@gmail.com> Date: Fri, 20 Oct 2017 14:41:00 +0200 In-Reply-To: <20171014102915.11778-2-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sat, 14 Oct 2017 13:29:14 +0300") Message-ID: <87tvyuuh43.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Oleg Pykhalov skribis: > * gnu/packages/emacs.scm (emacs-json-snatcher): New variable. Applied, thanks! From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Dec 2017 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15121237871709 (code B ref 28832); Fri, 01 Dec 2017 10:24:02 +0000 Received: (at 28832) by debbugs.gnu.org; 1 Dec 2017 10:23:07 +0000 Received: from localhost ([127.0.0.1]:39079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKiTL-0000RV-6Q for submit@debbugs.gnu.org; Fri, 01 Dec 2017 05:23:07 -0500 Received: from [141.255.128.1] (port=33752 helo=hera.aquilenet.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKiTK-0000RO-0J for 28832@debbugs.gnu.org; Fri, 01 Dec 2017 05:23:06 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 43CAF10080; Fri, 1 Dec 2017 11:23:08 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sv7Mb3CPiVTZ; Fri, 1 Dec 2017 11:23:07 +0100 (CET) Received: from ribbon (unknown [193.50.110.211]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D08EF10048; Fri, 1 Dec 2017 11:23:06 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> Date: Fri, 01 Dec 2017 11:23:03 +0100 In-Reply-To: <87y3o6uheo.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 20 Oct 2017 14:34:39 +0200") Message-ID: <87d13yiw6w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Oleg, Ping! :-) ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) skribis: [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Oleg, Ping! :-) ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) skribis: [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Hi Oleg, Ping! :-) ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Oleg Pykhalov skribis: > >> * gnu/packages/emacs.scm (emacs-json-reformat): New variable. > > [...] > >> + (modify-phases %standard-phases >> + (add-before 'install 'check >> + (lambda* (#:key inputs #:allow-other-keys) >> + (zero? (system* "emacs" "--batch" "-L" "." >> + "-L" (string-append >> + (assoc-ref inputs "emacs-undercover") >> + "/share/emacs/site-lisp/guix.d/under= cover-" >> + ,(package-version emacs-undercover)) >> + "-L" (string-append >> + (assoc-ref inputs "emacs-dash") >> + "/share/emacs/site-lisp/guix.d/dash-" >> + ,(package-version emacs-dash)) >> + "-L" (string-append >> + (assoc-ref inputs "emacs-shut-up") >> + "/share/emacs/site-lisp/guix.d/shut-= up-" >> + ,(package-version emacs-shut-up)) >> + "-l" "test/test-helper.el" >> + "-l" "test/json-reformat-test.el" >> + "-f" "ert-run-tests-batch-and-exit")) >> + ;; Fails >> + ;; json-reformat-test:json-reformat-region-occur-error >> + ;; json-reformat-test:string-to-string >> + #t))))) > > Did you have a chance to investigate the test failures? It=E2=80=99s not > confidence-inspiring ;-), so it would be good to at least have a link to > an upstream bug report. > > Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80=99= define the > =E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to car= ry all these -L flags? > Is there any downside? > > Thanks, > Ludo=E2=80=99. From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Dec 2017 23:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15130339814909 (code B ref 28832); Mon, 11 Dec 2017 23:13:02 +0000 Received: (at 28832) by debbugs.gnu.org; 11 Dec 2017 23:13:01 +0000 Received: from localhost ([127.0.0.1]:57407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOXFo-0001H0-B9 for submit@debbugs.gnu.org; Mon, 11 Dec 2017 18:13:01 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:37451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOXFk-0001Gl-DW for 28832@debbugs.gnu.org; Mon, 11 Dec 2017 18:12:55 -0500 Received: by mail-lf0-f50.google.com with SMTP id a12so21094877lfe.4 for <28832@debbugs.gnu.org>; Mon, 11 Dec 2017 15:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bB/XXJG4af9PE5Z6hpRVThFHVg9Aayv79vPKL3C8L9Y=; b=c7H7gOgrCyW5tT8Dk8LANGVdFxOg30KCMWbONvhmStyHGKevKt6y+Vayfvm3/DuDmJ bglIvSaIHQh7RHnfhVGe5V6933HimnJJQy5xJkFR0Q7/nDrWYGSuhQc2TEkyOFJx1YuR Nz59NAmE56mPMs4t4rQow/WPdfTWbEpGTuWqXTbtbNvCrRy5pvnQwC5W7RbiV1F0gybC n0GT9dn8Faxn8sXNehV5W1TNxqxFof5yn8BbFJAXydknuzmW3PWVl+8sjw/llZ7zXwMH +o4Uo85VaqEjOKfPQmiYHErR10/iBYep28KwkfeOccG4EphTh/KtTzSBv0SGw2sHAxVM np+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bB/XXJG4af9PE5Z6hpRVThFHVg9Aayv79vPKL3C8L9Y=; b=d6aqe2fRO+QQMrEdJ04f+P9WaBsR69UGsDCOpRe+vFxmpNS6QANqSoD5hrXALzSw/K Iuz3CAu0Eqy3KvhA1hGl62CXmznlSNRVd5pHZp6u06CPFJgJaMrSNkRYDWUWsiEti0ai SmOEDG/pKoMOQwL+Ol9cYY7Smf5+g4fb/melcpk0X58oB1Y4Y9rFq9WTLu3HOXNe03uw x5nQkhax2oYP+bF39uWKvm4ovvXRfoL5gB9uRT/ZwEILLv12WsDJZ6qLP7+RvRthQ1FN bhGDpiHUZY5GS701mgAYiQUk6ei0vb8mJ1lsjt+9g/7F4agB9OVEmRAU4S4rVgyFlBa+ bjzQ== X-Gm-Message-State: AKGB3mJ1AO427QxDL/qePawlr6DOW/LwLnlAi298B7cEv59c09gFFSxU RnJsSt1fkK+Z6aFhgA1aDgodBg== X-Google-Smtp-Source: ACJfBosnc6rAGQBF9Mx5AzX/PQqOEC7cN6j7Nw9JN/jehluZAWuqu+zHKNpOehPhw2SxCQN/gzv2SQ== X-Received: by 10.46.41.26 with SMTP id u26mr944753lje.164.1513033966012; Mon, 11 Dec 2017 15:12:46 -0800 (PST) Received: from magnolia (95-55-116-102.dynamic.avangarddsl.ru. [95.55.116.102]) by smtp.gmail.com with ESMTPSA id i23sm2926869lfh.18.2017.12.11.15.12.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 15:12:43 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> Date: Tue, 12 Dec 2017 02:12:36 +0300 In-Reply-To: <87d13yiw6w.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 01 Dec 2017 11:23:03 +0100") Message-ID: <87609cluzf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Apologies for late reply and thank you for review. ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> + (modify-phases %standard-phases >>> + (add-before 'install 'check >>> + (lambda* (#:key inputs #:allow-other-keys) >>> + (zero? (system* "emacs" "--batch" "-L" "." >>> + "-L" (string-append >>> + (assoc-ref inputs "emacs-undercover= ") >>> + "/share/emacs/site-lisp/guix.d/unde= rcover-" >>> + ,(package-version emacs-undercover)) >>> + "-L" (string-append >>> + (assoc-ref inputs "emacs-dash") >>> + "/share/emacs/site-lisp/guix.d/dash= -" >>> + ,(package-version emacs-dash)) >>> + "-L" (string-append >>> + (assoc-ref inputs "emacs-shut-up") >>> + "/share/emacs/site-lisp/guix.d/shut= -up-" >>> + ,(package-version emacs-shut-up)) >>> + "-l" "test/test-helper.el" >>> + "-l" "test/json-reformat-test.el" >>> + "-f" "ert-run-tests-batch-and-exit")) >>> + ;; Fails >>> + ;; json-reformat-test:json-reformat-region-occur-error >>> + ;; json-reformat-test:string-to-string >>> + #t))))) >> >> Did you have a chance to investigate the test failures? It=E2=80=99s not >> confidence-inspiring ;-), so it would be good to at least have a link to >> an upstream bug report. Yes I looked at those tests. Here is a little review of them. json-reformat-test:string-to-string basically just calls a reimplemented in Emacs 25 json-encode-string function. json-reformat-test:json-reformat-region-occur-error emulates error and produce a message. This message is differ from Emacs 24 in symbol '`'. So, I think those test fails are harmless. I attach the new patch with fixing those failing tests. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-emacs-json-reformat.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] gnu: Add emacs-json-reformat. From=20d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Tue, 12 Dec 2017 01:41:08 +0300 Subject: [PATCH] gnu: Add emacs-json-reformat. * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Add this. * gnu/packages/emacs.scm (emacs-json-reformat): New variable. =2D-- gnu/local.mk | 1 + gnu/packages/emacs.scm | 47 ++++++++++++++++++= ++++ .../patches/emacs-json-reformat-fix-tests.patch | 28 +++++++++++++ 3 files changed, 76 insertions(+) create mode 100644 gnu/packages/patches/emacs-json-reformat-fix-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index 46829756b..ec5ba06d3 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -613,6 +613,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/einstein-build.patch \ %D%/packages/patches/emacs-exec-path.patch \ %D%/packages/patches/emacs-fix-scheme-indent-function.patch \ + %D%/packages/patches/emacs-json-reformat-fix-tests.patch \ %D%/packages/patches/emacs-highlight-stages-add-gexp.patch \ %D%/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch \ %D%/packages/patches/emacs-source-date-epoch.patch \ diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index fd0305629..1aa139c92 100644 =2D-- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -5914,6 +5914,53 @@ pair of minor modes which suppress all mouse events = by intercepting them and running a customisable handler command (@code{ignore} by default). ") (license license:gpl3+))) =20 +(define-public emacs-json-reformat + (package + (name "emacs-json-reformat") + (version "0.0.6") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/gongo/json-reformat/archive= /" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "11fbq4scrgr7m0iwnzcrn2g7xvqwm2gf82sa7zy1l0nil7265p28")) + (patches (search-patches "emacs-json-reformat-fix-tests.patch")))) + (build-system emacs-build-system) + (propagated-inputs `(("emacs-undercover" ,emacs-undercover))) + (inputs + `(("emacs-dash" ,emacs-dash) ; for tests + ("emacs-shut-up" ,emacs-shut-up))) ; for tests + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'install 'check + (lambda* (#:key inputs #:allow-other-keys) + (zero? (system* "emacs" "--batch" "-L" "." + "-L" (string-append + (assoc-ref inputs "emacs-undercover") + "/share/emacs/site-lisp/guix.d/undercov= er-" + ,(package-version emacs-undercover)) + "-L" (string-append + (assoc-ref inputs "emacs-dash") + "/share/emacs/site-lisp/guix.d/dash-" + ,(package-version emacs-dash)) + "-L" (string-append + (assoc-ref inputs "emacs-shut-up") + "/share/emacs/site-lisp/guix.d/shut-up-" + ,(package-version emacs-shut-up)) + "-l" "test/test-helper.el" + "-l" "test/json-reformat-test.el" + "-f" "ert-run-tests-batch-and-exit")) + #t))))) + (home-page "https://github.com/gongo/json-reformat") + (synopsis "Reformatting tool for JSON") + (description "@code{json-reformat} provides a reformatting tool for +@url{http://json.org/, JSON}.") + (license license:gpl3+))) + (define-public emacs-json-snatcher (package (name "emacs-json-snatcher") diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b/gnu= /packages/patches/emacs-json-reformat-fix-tests.patch new file mode 100644 index 000000000..23a239582 =2D-- /dev/null +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch @@ -0,0 +1,28 @@ +Copyright =C2=A9 2017 Oleg Pykhalov + +This patch fixes tests for Emacs 25. + +diff --git a/test/json-reformat-test.el b/test/json-reformat-test.el +index 7de3be1..b4a4dde 100644 +--- a/test/json-reformat-test.el ++++ b/test/json-reformat-test.el +@@ -58,7 +58,7 @@ + (ert-deftest json-reformat-test:string-to-string () + (should (string=3D "\"foobar\"" (json-reformat:string-to-string "foobar= "))) + (should (string=3D "\"fo\\\"o\\nbar\"" (json-reformat:string-to-string = "fo\"o\nbar"))) +- (should (string=3D "\"\\u2661\"" (json-reformat:string-to-string "\u266= 1"))) ++ (should (string=3D "\"=E2=99=A1\"" (json-reformat:string-to-string "\u2= 661"))) +=20 + (should (string=3D "\"^(amq\\\\.gen.*|amq\\\\.default)$\"" (json-reform= at:string-to-string "^(amq\\.gen.*|amq\\.default)$"))) + ) +@@ -148,6 +148,6 @@ bar\"" (json-reformat:string-to-string "fo\"o\nbar"))) + [{ foo : \"bar\" }, { \"foo\" : \"baz\" }]") ;; At 3 (line) + (json-reformat-region (point-min) (point-max))) + (should (string=3D +- "JSON parse error [Reason] Bad string format: \"doesn't st= art with '\\\"'!\" [Position] In buffer, line 3 (char 6)" ++ "JSON parse error [Reason] Bad string format: \"doesn't st= art with \`\\\"'!\" [Position] In buffer, line 3 (char 6)" + message-string)) + ))) +--=20 +2.15.1 + =2D-=20 2.15.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The upstream is quite: https://github.com/gongo/json-reformat/issues/33 >> Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80= =99 define the >> =E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to ca= rry all these -L flags? >> Is there any downside? As I see from the documentation=C2=B9 EMACSLOADPATH is a list of directories with *.el files in it. If we will use it, then it will be almost the same carring bunch of directories in package recipes, will it? =C2=B9 https://www.gnu.org/software/emacs/manual/html_node/emacs/General-Va= riables.html Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlovEOQACgkQckbhHGm3 lWkSaw/8DZBbfCS2StoHGs1x9i+dPOTqmvksLBcll+qLWb/aLYNbbBkZknPrSypA sYJEVX9tLxDUuqX6xKBab1MRnjSB2itaC18nJKGUm5j/7XlPckE3Dkm1L5QDxaYA WC0fwWuSEFgId2Hsh2FJNBupsdc5Zi2wy7MtBeVWuFSfRvRhbsvvaefA3jCSgimA nJm36MbVvzphdaiZp3VN7d3dbajUmu47v0YPMxiGU7GpWLHCt8YTcRKh7HgyqEva ABrgTWgC/0GsvZc+WeVIelJwu8dUoKhKaPG+gYUO0MRTZpNlTNgpoMwuE3Bb8u+v vaQV3sEGasVk1ciZMjrCCB8K+24vAQIu712BvYBFTjMNtnl2/wt0PeU+5rgRwPEg ocJ1C1S4ADZllajU0uBAsjKfqPaec3BpkjAGpR/lgt7xGJJuSaPaGt3I/KXqHOpJ M68xkMKR0MYJxgBbgPHwYmlBSE0k3VcQG/nmacbaS6jLKlIC/mJb8vJuGa3z3X7Z t2FZge2ivIMIwcEB+PSrHjm1ButDucKgw9jNBU/YVG11X/gnWxNGPH+12oW8Rf8B owqwx0b1fIxV+gAL5csRB8pOk+Qq0mwTDIQk1jHo27PCP4LYBb73w6pEc9caDOMS 7qGTxbWT/7GdE4Gj9kh5mVTYkqXPXM5b4o3W3EWGCEnoCE/lbEs= =3Cg/ -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Dec 2017 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org, Alex Kost Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151307023626342 (code B ref 28832); Tue, 12 Dec 2017 09:18:02 +0000 Received: (at 28832) by debbugs.gnu.org; 12 Dec 2017 09:17:16 +0000 Received: from localhost ([127.0.0.1]:57678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOgge-0006qo-GO for submit@debbugs.gnu.org; Tue, 12 Dec 2017 04:17:16 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:42225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOggY-0006qZ-8R for 28832@debbugs.gnu.org; Tue, 12 Dec 2017 04:17:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 021A6F5CC; Tue, 12 Dec 2017 10:17:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a04hTd11x3ix; Tue, 12 Dec 2017 10:17:11 +0100 (CET) Received: from ribbon (unknown [193.50.110.104]) by hera.aquilenet.fr (Postfix) with ESMTPSA id B1EB08EEC; Tue, 12 Dec 2017 10:17:11 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Frimaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 12 Dec 2017 10:17:08 +0100 In-Reply-To: <87609cluzf.fsf@gmail.com> (Oleg Pykhalov's message of "Tue, 12 Dec 2017 02:12:36 +0300") Message-ID: <87zi6os3u3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Oleg, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> Did you have a chance to investigate the test failures? It=E2=80=99s n= ot >>> confidence-inspiring ;-), so it would be good to at least have a link to >>> an upstream bug report. > > Yes I looked at those tests. Here is a little review of them. > > json-reformat-test:string-to-string basically just calls > a reimplemented in Emacs 25 json-encode-string function. > > json-reformat-test:json-reformat-region-occur-error emulates error and > produce a message. This message is differ from Emacs 24 in symbol '`'. > > So, I think those test fails are harmless. I attach the new patch with > fixing those failing tests. Indeed. > From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Tue, 12 Dec 2017 01:41:08 +0300 > Subject: [PATCH] gnu: Add emacs-json-reformat. > > * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add this. > * gnu/packages/emacs.scm (emacs-json-reformat): New variable. [...] > diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b/g= nu/packages/patches/emacs-json-reformat-fix-tests.patch > new file mode 100644 > index 000000000..23a239582 > --- /dev/null > +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch > @@ -0,0 +1,28 @@ > +Copyright =C2=A9 2017 Oleg Pykhalov > + > +This patch fixes tests for Emacs 25. Please mention here. OK with these changes! > >> Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80= =99 define the > >> =E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to = carry all these -L flags? > >> Is there any downside? >=20 > As I see from the documentation=C2=B9 EMACSLOADPATH is a list of director= ies > with *.el files in it. If we will use it, then it will be almost the > same carring bunch of directories in package recipes, will it? If =E2=80=98emacs-build-system=E2=80=99 sets =E2=80=98EMACSLOADPATH=E2=80= =99 automatically, then individual package definitions won=E2=80=99t need those -L flags. Dunno if there are good reasons not to do so. Maybe Alex has an opinion? Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Dec 2017 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Oleg Pykhalov , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151309943720706 (code B ref 28832); Tue, 12 Dec 2017 17:24:02 +0000 Received: (at 28832) by debbugs.gnu.org; 12 Dec 2017 17:23:57 +0000 Received: from localhost ([127.0.0.1]:58819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOoHd-0005Nt-BU for submit@debbugs.gnu.org; Tue, 12 Dec 2017 12:23:57 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:33231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOoHb-0005Nh-En for 28832@debbugs.gnu.org; Tue, 12 Dec 2017 12:23:55 -0500 Received: by mail-lf0-f46.google.com with SMTP id 74so24080518lfs.0 for <28832@debbugs.gnu.org>; Tue, 12 Dec 2017 09:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=OQS8XRgWTk3tHw7l9dI58ViPr24GsxBDMVyL04G/WiE=; b=JjboPBMbSUlIi0FBRaFli5QXHtophZVh0ZstExdVXWtMI9lzQ6x3AI9UkvZhcv9nZ3 gFBvOuV5YJj3D+JwiYl2kz+X98uYg+qGIwANL+nRN4sED8tU8lmgqcLrUvCQh+UW/ngI yhT7D3u6sfL0GBAIfuhOsrF0jkCp/Z/sD7hUr1Xv9BGzXdRyWxE6RjUinwxVbnIQ4Eny GjLvUENGcNYRsavQgC7Hd+kLULJnUTjRQsng5xHxMfaFMjXW2FC2abCDBlYTc9dvtLzI xL4NlwQP9Tc+mMCDvnpD99T77nTKYoG3xprCVLbWQIs2ZeIFbyUFbsS6QX1afA1451Wx ndeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OQS8XRgWTk3tHw7l9dI58ViPr24GsxBDMVyL04G/WiE=; b=Rv7RCwIz1/EGc+SIOVGB2rHBqPbfrGSlkbeaJbTn/JextWjMl6FVkC5AOfMdwhKFQH 9JyTT6fSb3efd8US+0m70u5aIvi1522vqaUtzQDOlFTtFYTA8NLYRVqDCBjH+lpU0ZH1 dPsNor025njit3xkPRphawmOi+ja4KjMgUIwvYarP6WmSTgJ9ku4Ohb27W7ATe0gwLL9 SSK560BgN4ayWI+hfPoaALEkLGmBsk1wk3gWHlCuuBAPL765oPC2SckIoj3TOtPqbPEo EkO4AKZ+58BGF1Ap4aK6D3Hb14oVXGkSIzYqoGsqRGojVgWqbwar2twucKm2hmnhr1mj 2v+A== X-Gm-Message-State: AKGB3mK8jfndvCx9mcMOvf1QBGZXtO780FQYkystdD2r+ym2ldwY2gtV znnd50wXqUDwEiZPgUiq6UIczQ== X-Google-Smtp-Source: ACJfBosGbO4OMgKGxZFpOYcax1s26vx4wAWIpnZlZd2F+zxiHZUcsxggevlIC2srsL4FFcApSwGQ3Q== X-Received: by 10.25.89.69 with SMTP id n66mr2209452lfb.96.1513099429423; Tue, 12 Dec 2017 09:23:49 -0800 (PST) Received: from leviafan ([217.107.194.133]) by smtp.gmail.com with ESMTPSA id i18sm3298599ljb.45.2017.12.12.09.23.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2017 09:23:48 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> Date: Tue, 12 Dec 2017 20:23:49 +0300 In-Reply-To: <87zi6os3u3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 12 Dec 2017 10:17:08 +0100") Message-ID: <87fu8famhm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ludovic Court=C3=A8s (2017-12-12 10:17 +0100) wrote: > Oleg Pykhalov skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80= =99 define the >>> =E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to c= arry all these -L flags? >>> Is there any downside? >> >> As I see from the documentation=C2=B9 EMACSLOADPATH is a list of directo= ries >> with *.el files in it. If we will use it, then it will be almost the >> same carring bunch of directories in package recipes, will it? > > If =E2=80=98emacs-build-system=E2=80=99 sets =E2=80=98EMACSLOADPATH=E2=80= =99 automatically, then > individual package definitions won=E2=80=99t need those -L flags. Dunno = if > there are good reasons not to do so. Maybe Alex has an opinion? I would rather ask Federico who wrote =E2=80=98emacs-build-system=E2=80=99 = :) Yeah, maybe =E2=80=98emacs-build-system=E2=80=99 could benefit from using E= MACSLOADPATH, I don't know, someone should probably give it a try ;-) BTW, Oleg, did you try to use 'ert-runner' instead of running emacs for tests manually? Perhaps, it will work; look at commit 8505d34829b99744a36d72dd583768f1e49210a6 for example. --=20 Alex From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Dec 2017 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151314094432686 (code B ref 28832); Wed, 13 Dec 2017 04:56:01 +0000 Received: (at 28832) by debbugs.gnu.org; 13 Dec 2017 04:55:44 +0000 Received: from localhost ([127.0.0.1]:59278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOz56-0008V7-4e for submit@debbugs.gnu.org; Tue, 12 Dec 2017 23:55:44 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:32999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOz53-0008Ur-VB for 28832@debbugs.gnu.org; Tue, 12 Dec 2017 23:55:42 -0500 Received: by mail-lf0-f68.google.com with SMTP id 74so1194171lfs.0 for <28832@debbugs.gnu.org>; Tue, 12 Dec 2017 20:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cApvbbAeIJRoPuRY5Pc8gej7xH603PG8KyLXXtaxUC4=; b=DdRabavdic5l6dhZerdEXnk51jdGopXoB0J+sanfBDRCQESd/UX6WcqkWPd+/xqFTW kJKYATJTVPGwwReiij5wthc84W+qcr/dI6Hlwhr+pa8d01/zVm7t45aoKLsNS5l1mobv E0tReXVq7rbJBvpLXzE+taHmLDziLrOD5eZDaTcFrpK26SDqTDyjr/B6rfGqM+DRtyK/ 8r6p7A4RUfV+5Q/srpcJl9n6VZBc0OxgsLfPbTSFmiQLmZc7FvBy6SZdw4NVIR+zB8nc F8Xk/O8mw5dzjVlTHin01xfSGNaAVMV9h4cwfQG4bmtuegHqTST+rqFvto4y7LwBHYHP DAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cApvbbAeIJRoPuRY5Pc8gej7xH603PG8KyLXXtaxUC4=; b=Sa0BEvtXM0+0s8aB8+Ki/RPZCJXgegDKniLFQl0hxhuGNI4Zbxj9Vijt7VE7qNRlKj aJYM6OcvmTxchlaUvLHBS4Ny/mOArjz7hCHYVDE5vWT6AG/vUpvDr2y0NAtY1r6hAcgW qdIcr+ysvNtSWtynCY0rR5pdG94LCZnELUt8vvUTZ6eWeZrY18RHsYd7R0hZ7XrI0xuc tfBqaiqM//OaeaqJKgR5w+IwOwdcIecmvkV2+tMyAN4SsI0ItDivECq8kLu5QO6KNNWi bRNCJ22+NtzQMkd6Ez7aoOyLYaqwUUoVPNbdJgnZ+R1aJV7inSE6PR0NdZLPSS9yy5+e b/qQ== X-Gm-Message-State: AKGB3mKDL/t786S+BvjiJiKmL/Ra9WQ26Ng7+RvdppJ7sPxhLQGcflR7 /zPAVsk9BzoAagLGqU82mvpwCQ== X-Google-Smtp-Source: ACJfBovmYVuU3jdTzO/AcdtMBsx7va+PwFE1b1KTkxeFQ97BMNa/fUVze3TDDQ7R5GxiAMwfGTnrQA== X-Received: by 10.25.67.86 with SMTP id m22mr581451lfj.69.1513140935740; Tue, 12 Dec 2017 20:55:35 -0800 (PST) Received: from magnolia (ppp91-122-81-8.pppoe.avangarddsl.ru. [91.122.81.8]) by smtp.gmail.com with ESMTPSA id e10sm144767lfb.0.2017.12.12.20.55.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2017 20:55:34 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> Date: Wed, 13 Dec 2017 07:55:22 +0300 In-Reply-To: <87fu8famhm.fsf@gmail.com> (Alex Kost's message of "Tue, 12 Dec 2017 20:23:49 +0300") Message-ID: <87r2rzi5vp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Alex and Ludovic, Alex Kost writes: [...] >> If =E2=80=98emacs-build-system=E2=80=99 sets =E2=80=98EMACSLOADPATH=E2= =80=99 automatically, then >> individual package definitions won=E2=80=99t need those -L flags. Dunno= if >> there are good reasons not to do so. Maybe Alex has an opinion? > > I would rather ask Federico who wrote =E2=80=98emacs-build-system=E2=80= =99 :) Do you mean Federico Beffa ? He is quite in Guix git repository for 9 months as I see. Is it a good idea to CC him? > Yeah, maybe =E2=80=98emacs-build-system=E2=80=99 could benefit from using= EMACSLOADPATH, > I don't know, someone should probably give it a try ;-) I succeeded to implement this, but the patch needs some more love. The biggest issue is how to get an Emacs version in setup-environment. You could test it on emacs-git-messenger or emacs-json-reformat. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: EMACSLOADPATH diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm index bd0d2e026..269038744 100644 --- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -183,6 +183,10 @@ store in '.el' files." "Check if NAME correspond to the name of an Emacs package." (string-prefix? "emacs-" name)) +(define (string-drop-emacs x) + "Drops `emacs-' from a string." + (string-drop x 6)) + (define (emacs-inputs inputs) "Retrieve the list of Emacs packages from INPUTS." (filter (match-lambda @@ -222,6 +226,38 @@ second hyphen. This corresponds to 'name-version' as used in ELPA packages." strip-store-file-name) store-dir)) +;; Copied from haskell-build-system.scm +(define (package-name-version store-dir) + "Given a store directory STORE-DIR return 'name-version' of the package." + (let* ((base (basename store-dir))) + (string-drop base (+ 1 (string-index base #\-))))) + +(define* (setup-environment #:key inputs outputs #:allow-other-keys) + "Export the variable EMACSLOADPATH, which are based on INPUTS and OUTPUTS, +respectively." + (let ((out (assoc-ref outputs "out"))) + ;; EMACSLOADPATH is where Emacs looks for the source code of the build's + ;; dependencies. + (set-path-environment-variable + "EMACSLOADPATH" + ;; XXX Matching "." hints that we could do + ;; something simpler here... + (list ".") + (cons (let ((store-item (cdr (assoc "emacs" (emacs-inputs inputs))))) + ;; TODO: Get a version from inputs + (string-append store-item "/share/emacs/25.3/lisp")) + (map + (lambda (foobar) + (let ((store-item (cdr foobar))) + (string-append store-item + %install-suffix "/" + (string-drop-emacs + (package-name-version store-item))))) + (alist-delete "emacs" + (alist-delete "source" + (emacs-inputs inputs)))))) + #t)) + (define %standard-phases (modify-phases gnu:%standard-phases (replace 'unpack unpack) @@ -229,6 +265,7 @@ second hyphen. This corresponds to 'name-version' as used in ELPA packages." (delete 'check) (delete 'install) (replace 'build build) + (add-before 'build 'setup-environment setup-environment) (add-before 'build 'install install) (add-after 'install 'make-autoloads make-autoloads) (add-after 'make-autoloads 'patch-el-files patch-el-files) --=-=-= Content-Type: text/plain > BTW, Oleg, did you try to use 'ert-runner' instead of running emacs for > tests manually? Perhaps, it will work; look at commit > 8505d34829b99744a36d72dd583768f1e49210a6 for example. Nope, but I will. Thank you for notice this! Thanks, Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlowsroACgkQckbhHGm3 lWkavRAAgBL33pB4bdv+sWGKvHB7coEznQ7CnjrXzB6bkJ9xePWfnfeiOIkr2Sbf 3RtsKLB7PmNpdZe/J5ps98iNSURXOjZvswhwL13bJP53EZr9+/cBTBXZwRZfuGjv q8lv1U93MSKh5l3loGtcVri6M3s7ACnrebv74kvNwN3c/pXHU5WpKh/qhd8ni5XO WDLKaJq2iz2nlvvnwJCJlmJ1w8bv+12MITtL1K4oViRm6+UL7t+5ccKuR0J7d/6b yE73LodudKE9+JrtKaMyfjMD+hGvQyOL5FmcoAT1nJEHzy4I+Wx/dLmmvPf/BTpa g1TelDLOOWsnszgM8eutkDUiDBlQ/1IADAbuk7ypon22pqFURVKVUXoCrhLlTtvq E/XPpmlRRdw9UaEui4Htv5TCYp0L5sGgLtBulN31Di9FH/xQi6gRO0wunR3Aamat 1g+O17Gwg7bTrc5lIvbW17WzQ/HWsd6MyIqSotfwpF69CEAQdWAXRVgKICuZdw4X YVyYsVzcuv0ny/ebY0v/0ZTnZ8V4gJQr8dtRsv4QSnnpx18wjz1HFLfKomlyBzjP wQfGPsuIuJpxn3ZRYyUg5jJJEZWkhqwE5GSYWZDN7kkhtzaMptPjLCAqePxzOjwt RaPv8h+YZvSpSXW6hIO7aysaIF26IGwAoSPaGwCLhXALcaWVp8U= =zHnc -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Dec 2017 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151333060412087 (code B ref 28832); Fri, 15 Dec 2017 09:37:01 +0000 Received: (at 28832) by debbugs.gnu.org; 15 Dec 2017 09:36:44 +0000 Received: from localhost ([127.0.0.1]:34620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePmQ8-00038t-DL for submit@debbugs.gnu.org; Fri, 15 Dec 2017 04:36:44 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:41841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePmQ6-00038f-Us for 28832@debbugs.gnu.org; Fri, 15 Dec 2017 04:36:43 -0500 Received: by mail-lf0-f41.google.com with SMTP id f18so9740224lfg.8 for <28832@debbugs.gnu.org>; Fri, 15 Dec 2017 01:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LRsESz2t9c+f/AL5I7o3x6UAVP5AMC5PydRo/4k9sOY=; b=ZSkzeaalzwCYRXYSZDcfxWU1KPcz83hxwGZXBX27gXrrnjPZ2GbLSDXfI57SQjXxz5 jfMLrvnIv8pVaixcDVbyWkkeLQ7QgraB7x99XaSxNj9cQmi0KTO1466Zyhc1H/awrDZa U1ZWCfEBH3IucWUwl6YQmvBXlrZEdQtAET0cRevWMqWcAIt766sz82/0TJZPzPP0LA0z U8ys7PPkbbYvpRXr60f5lEVEiwiX84Ew+kD4Z1PG+9YkZnVCDhHQO7lu2L2dbN4YDrG8 mi3SzWvUpo30kiudpXwYeUtISyoxAAljZxdAk2FQ/+aRSGTbAdQiV53aMLp+F3HXlOvE /xQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LRsESz2t9c+f/AL5I7o3x6UAVP5AMC5PydRo/4k9sOY=; b=TPCTKgaqRIPgroOj0F4Z8KYHsP8RSQdFB5YKwEE/PnqUV7bxtFAaK3Stlblnvjv97U ap8FbFVIrsNCZe780tacEHDID8z5rUFOOywpUYfmZy9SgFSWNMBYqqp3ndzWMfhamTcf OqjWL6OI/seYOktHdIbCMGg3i/hI8qrZ2t/uyVydx6vtUPJqTo+efZB9hXew+CZMGF2f Nc2EWWc7yxLXeFmJ4fPTqPKjeV2Ec25zN2h2/lk05CwVkDyJxGxG1tdxjkRcHAPES0Sv GnhgoSbDVOI/rafR6xPiFVqyuwQfMOB+9GBMc8WqyXk1oI3jbB+NmH9IduLYefiskBGG QDRg== X-Gm-Message-State: AKGB3mLcfe3TU4+yXlVcd131yLYx/v/jaJN+S4DnZND3DFS+Hr7ap3OB EbJ6I4SrY8QRZvAXa2Vw6LF87A== X-Google-Smtp-Source: ACJfBos1GrSqAT1iJWlI7q5Igl2YiyCrb1J5NmRvr7C9lo7E4Vl1nVaf5bdZHVGKNDc2fnmcnfkQKg== X-Received: by 10.46.9.69 with SMTP id 66mr5752585ljj.134.1513330596586; Fri, 15 Dec 2017 01:36:36 -0800 (PST) Received: from magnolia (pppoe.178-66-210-21.dynamic.avangarddsl.ru. [178.66.210.21]) by smtp.gmail.com with ESMTPSA id b75sm1274312lfe.47.2017.12.15.01.36.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Dec 2017 01:36:35 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> Date: Fri, 15 Dec 2017 12:36:28 +0300 In-Reply-To: <87fu8famhm.fsf@gmail.com> (Alex Kost's message of "Tue, 12 Dec 2017 20:23:49 +0300") Message-ID: <877etofi3n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-emacs-build-system-Add-EMACSLOADPATH.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] emacs-build-system: Add EMACSLOADPATH. From=20adda59022a61dfcf2add1d9f01d02df4be90a0f1 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Wed, 13 Dec 2017 08:10:21 +0300 Subject: [PATCH] emacs-build-system: Add EMACSLOADPATH. * guix/build/emacs-build-system.scm: Add EMACSLOADPATH. =2D-- guix/build/emacs-build-system.scm | 47 +++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 47 insertions(+) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index bd0d2e026..06479bf6b 100644 =2D-- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2015 Federico Beffa ;;; Copyright =C2=A9 2016 David Thompson ;;; Copyright =C2=A9 2016 Alex Kost +;;; Copyright =C2=A9 2017 Oleg Pykhalov ;;; ;;; This file is part of GNU Guix. ;;; @@ -183,6 +184,10 @@ store in '.el' files." "Check if NAME correspond to the name of an Emacs package." (string-prefix? "emacs-" name)) =20 +(define (string-drop-emacs value) + "Drops `emacs-' from a string." + (string-drop value 6)) + (define (emacs-inputs inputs) "Retrieve the list of Emacs packages from INPUTS." (filter (match-lambda @@ -222,6 +227,47 @@ second hyphen. This corresponds to 'name-version' as = used in ELPA packages." strip-store-file-name) store-dir)) =20 +(define (store-directory->package-name store-dir) + "Extract package name from STORE-DIR." + (let-values (((name _) ((compose package-name->name+version + strip-store-file-name) + store-dir))) + name)) + +(define (store-directory->package-version store-dir) + "Extract package version from STORE-DIR." + (let-values (((_ version) ((compose package-name->name+version + strip-store-file-name) + store-dir))) + version)) + +(define* (setup-environment #:key inputs #:allow-other-keys) + "Export the variable EMACSLOADPATH, which are based on INPUTS respective= ly." + (let* ((filtered-inputs (emacs-inputs inputs)) + (emacs-input-dir (cdr (assoc "emacs" filtered-inputs))) + (inputs-dirs (cdr filtered-inputs))) + ;; EMACSLOADPATH is where Emacs looks for the source code of the build= 's + ;; dependencies. + (setenv "EMACSLOADPATH" + (string-append emacs-input-dir "/share/emacs/" + (store-directory->package-version emacs-input-d= ir) + "/lisp")) + (for-each + (lambda (input) + (let ((store-item (cdr input))) + (setenv "EMACSLOADPATH" + (string-append + (or (getenv "EMACSLOADPATH") "") + ":" store-item %install-suffix "/" + ((compose string-drop-emacs store-directory->package-nam= e) + store-item))))) + ((compose (lambda (inputs) (alist-delete "emacs" inputs)) + (lambda (inputs) (alist-delete "source" inputs))) + (delete-duplicates inputs-dirs))) + (format #t "environment variable EMACSLOADPATH set to `~a'~%" + (getenv "EMACSLOADPATH")) + #t)) + (define %standard-phases (modify-phases gnu:%standard-phases (replace 'unpack unpack) @@ -229,6 +275,7 @@ second hyphen. This corresponds to 'name-version' as u= sed in ELPA packages." (delete 'check) (delete 'install) (replace 'build build) + (add-before 'build 'setup-environment setup-environment) (add-before 'build 'install install) (add-after 'install 'make-autoloads make-autoloads) (add-after 'make-autoloads 'patch-el-files patch-el-files) =2D-=20 2.15.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlozl5wACgkQckbhHGm3 lWloIQ//X4kbK+twWgLdXeak2kskM0WpxxGLu4dwl0TRGJ+Sn2UH67FAVvVXGV/4 qR+m4xg74FAo2Ksrk11GiwuDJEoHDhMHE/VK6YhBzflFc8vpll1jpslRC68uGgcC vuUdF8a0z7RSSOeq2rkmoO+3+BHZoVcL5m09mHad1aMbc+Sk01XAFnbc2Qt6r/j2 X9jmnFiHZNg3EYaMBUJw1IjbvXShy4kqH5Zzq4oV5AIPwUlsIbBrt0NEJxRfnG9X i4ysKVSV7AzR9EVcRhzxoZ/2EYYTZneOEO145jIJhlPjJIG8eZ46OTqsZjaf+3Lg UrwbkOjm7GECXLprBSBTuqNqv2BP0Hm7/+NXs/olXeRWTijEnMZ3462eoHfkX7rY YwYHXnNxAKKrFp34MLkaVqXkdDzOF7P4WdrKYlHPCMI+XL5XAp3vlEpmnFHwIeB+ 9TT6MLsKEjqfEY3/dSnanb0V7sEeH/rt4CvXT/Wqz+jzDmUYX+KKLgqVeDkZZ1MI B24LUDJ/DM/Fuk3CQmVxlTS+WpK9boosvlekaIMfLRR9hzYuVsY72H6Vc0KGfEUI KiV2xANKPj8yeIlGfo1hziDHoGqk9rsdGwfcAr/8Oqv+x/4xyGvcrqUuSSuozIhT uuGDVKaPFs66aSjhjaAj+LCzvQtreS7aM3VUhmvhgBO0bxAJrHg= =gHQw -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Dec 2017 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Alex Kost , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151334653318901 (code B ref 28832); Fri, 15 Dec 2017 14:03:01 +0000 Received: (at 28832) by debbugs.gnu.org; 15 Dec 2017 14:02:13 +0000 Received: from localhost ([127.0.0.1]:34840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePqZ2-0004un-Ja for submit@debbugs.gnu.org; Fri, 15 Dec 2017 09:02:12 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:55311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePqZ1-0004uf-EI for 28832@debbugs.gnu.org; Fri, 15 Dec 2017 09:02:11 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C66E1F7FB; Fri, 15 Dec 2017 15:02:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id csLbTsEi6wVX; Fri, 15 Dec 2017 15:02:11 +0100 (CET) Received: from ribbon (unknown [193.50.110.249]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6DF3FC673; Fri, 15 Dec 2017 15:02:11 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Frimaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Dec 2017 15:02:07 +0100 In-Reply-To: <877etofi3n.fsf@gmail.com> (Oleg Pykhalov's message of "Fri, 15 Dec 2017 12:36:28 +0300") Message-ID: <87vah8hyxs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Oleg, I think it would have been better to open a separate issue for this. Here are some superficial comments. I hope someone more knowledgeable about Emacs can comment. Oleg Pykhalov skribis: > From adda59022a61dfcf2add1d9f01d02df4be90a0f1 Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Wed, 13 Dec 2017 08:10:21 +0300 > Subject: [PATCH] emacs-build-system: Add EMACSLOADPATH. > > * guix/build/emacs-build-system.scm: Add EMACSLOADPATH. Please see =E2=80=98C-x v l=E2=80=99 in that file for the syntax of commit = logs. :-) > +(define (store-directory->package-name store-dir) > + "Extract package name from STORE-DIR." > + (let-values (((name _) ((compose package-name->name+version > + strip-store-file-name) > + store-dir))) > + name)) It=E2=80=99s enough to write it like this: (define store-directory->package-name (compose package-name->name+version strip-store-file-name)) Guile does automatic =E2=80=9Cmultiple-value truncation=E2=80=9D, which mea= ns that the second value that the procedure returns can be ignored by the caller. > +(define (store-directory->package-version store-dir) > + "Extract package version from STORE-DIR." > + (let-values (((_ version) ((compose package-name->name+version > + strip-store-file-name) > + store-dir))) > + version)) Likewise. > +(define* (setup-environment #:key inputs #:allow-other-keys) > + "Export the variable EMACSLOADPATH, which are based on INPUTS respecti= vely." > + (let* ((filtered-inputs (emacs-inputs inputs)) > + (emacs-input-dir (cdr (assoc "emacs" filtered-inputs))) > + (inputs-dirs (cdr filtered-inputs))) Nitpick: Please see the guidelines mentioned in on how to choose identifiers. I=E2=80=99d write: (let* ((inputs (emacs-inputs inputs)) (emacs (assoc-ref inputs "emacs"))) =E2=80=A6) =E2=80=98inputs-dirs=E2=80=99 is unneeded AIUI (see below). > + ;; EMACSLOADPATH is where Emacs looks for the source code of the bui= ld's > + ;; dependencies. > + (setenv "EMACSLOADPATH" > + (string-append emacs-input-dir "/share/emacs/" > + (store-directory->package-version emacs-input= -dir) > + "/lisp")) > + (for-each > + (lambda (input) > + (let ((store-item (cdr input))) Rather: (for-each (match-lambda ((name . input) =E2=80=A6)) =E2=80=A6) > + (setenv "EMACSLOADPATH" > + (string-append > + (or (getenv "EMACSLOADPATH") "") > + ":" store-item %install-suffix "/" > + ((compose string-drop-emacs store-directory->package-n= ame) > + store-item))))) Rather: (string-drop-emacs (store-directory->package-name item)) IMO =E2=80=98compose=E2=80=99 makes things less readable in this case. > + ((compose (lambda (inputs) (alist-delete "emacs" inputs)) > + (lambda (inputs) (alist-delete "source" inputs))) > + (delete-duplicates inputs-dirs))) Rather: (fold alist-delete inputs '("emacs" "source")) Did you try rebuilding Emacs packages, and to simplify those that explicitly pass -L flags? Thanks a lot for working on it! Ludo=E2=80=99. From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Dec 2017 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15133701164746 (code B ref 28832); Fri, 15 Dec 2017 20:36:01 +0000 Received: (at 28832) by debbugs.gnu.org; 15 Dec 2017 20:35:16 +0000 Received: from localhost ([127.0.0.1]:36140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePwhP-0001EU-So for submit@debbugs.gnu.org; Fri, 15 Dec 2017 15:35:16 -0500 Received: from mail-lf0-f49.google.com ([209.85.215.49]:33158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePwhM-0001EF-5d for 28832@debbugs.gnu.org; Fri, 15 Dec 2017 15:35:12 -0500 Received: by mail-lf0-f49.google.com with SMTP id g80so7309953lfg.0 for <28832@debbugs.gnu.org>; Fri, 15 Dec 2017 12:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Xo9DGBRT/l7pQEWDF8kFGeYGEeKY/xEt39oxATI9mLs=; b=ELOtr3NolJcecQyspBjBUKIK2fxaIR2NtqFztvWQj11ou5I9gsDTByZ8YenLNmnVv9 xu7mQRzK9NCOqSTPPhOZezDR/p5eiBhkPFY64nGx3vnwB+tUOoT8BgIUSVOC5kaJ3HhG rE4e0w2xMfLtGfzLC9Pns9s2SfgddG2KXfDYqjGk9+uTM4DthVXexEp7JcNrZprNwPGW EjHRDaF0kVi1DsqVZReeSEOO44oPWMJBwDlGlecq6bXOtAW3CE71i0pcCamXvqURIDCF w74om9qbv67r07gWl5SsNWCuSqF7dGQqaxrKPzCKmsPXx+sIgMsAP2LU4CjqYt9d02q0 h9hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Xo9DGBRT/l7pQEWDF8kFGeYGEeKY/xEt39oxATI9mLs=; b=LtYBlAt56NEyZDwjUssimFC7hzt3FtEnyWu7EM52FbgHpmF4dpcLvvZZBMOxq16tK4 1FdBnEn1qe6AZdgpTG37pDL16BxpVMo2mX+wGZz7nMg2U65KtcVDKQVf5JPErXxooMRn VUhC5xNOQEZauMPvePaCzCjX3WG2ZjbsZUUdO59zQlc1u0rDTkaXDaKTAOzT4kXqQZFy Oxhl09Tmt8sOCnUpECxl0Bbt1TWJX2ilCf/HBVYKTReBMwKsfPnrf4s57mcYux53Jtfo w6HW4UMlp1Mv0eITBtNuEvPgnI5aNylEDH/vXw94R3vmsD2HTKI3QFnye6xGhcgxVza2 5j+A== X-Gm-Message-State: AKGB3mIXQjVUDAG8VJMnP6Znwh47rynRk6Pzd+Lpvj9136EM42wmVEty LQ2hkzHNaf+///bOoYqsVTqFQQ== X-Google-Smtp-Source: ACJfBou6YESkC5KLnAM0WhDNyS8yzkds/8caFUetrP5OhZAMqezdjuTwu5IjlObapOMeCWJLQPC63Q== X-Received: by 10.25.59.77 with SMTP id i74mr6921020lfa.46.1513370105911; Fri, 15 Dec 2017 12:35:05 -0800 (PST) Received: from leviafan ([217.107.194.133]) by smtp.gmail.com with ESMTPSA id z68sm1384998lje.26.2017.12.15.12.34.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Dec 2017 12:35:00 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <87r2rzi5vp.fsf@gmail.com> Date: Fri, 15 Dec 2017 23:35:01 +0300 In-Reply-To: <87r2rzi5vp.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 13 Dec 2017 07:55:22 +0300") Message-ID: <87wp1nloga.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Oleg Pykhalov (2017-12-13 07:55 +0300) wrote: > Hello Alex and Ludovic, > > Alex Kost writes: > > [...] > >>> If =E2=80=98emacs-build-system=E2=80=99 sets =E2=80=98EMACSLOADPATH=E2= =80=99 automatically, then >>> individual package definitions won=E2=80=99t need those -L flags. Dunn= o if >>> there are good reasons not to do so. Maybe Alex has an opinion? >> >> I would rather ask Federico who wrote =E2=80=98emacs-build-system=E2=80= =99 :) > > Do you mean Federico Beffa ? He is quite in > Guix git repository for 9 months as I see. Is it a good idea to CC him? Yeah, I meant this Federico. I'm not sure if it is a good idea..., probably..., I don't know :-) --=20 Alex From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Dec 2017 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15133701274771 (code B ref 28832); Fri, 15 Dec 2017 20:36:02 +0000 Received: (at 28832) by debbugs.gnu.org; 15 Dec 2017 20:35:27 +0000 Received: from localhost ([127.0.0.1]:36143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePwhY-0001Ep-3e for submit@debbugs.gnu.org; Fri, 15 Dec 2017 15:35:26 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:40847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePwhW-0001Ec-3F for 28832@debbugs.gnu.org; Fri, 15 Dec 2017 15:35:22 -0500 Received: by mail-lf0-f48.google.com with SMTP id g74so1837125lfk.7 for <28832@debbugs.gnu.org>; Fri, 15 Dec 2017 12:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SRLOeaaYTTbT4XChnKOek2Cz2F03hWdZkAlGSl/IT0c=; b=rEVwSVoJDs7m6PQ4On4Z9kQyhil8jQ9eWY7LB1IoZX6KlMnZ7B85TR579xy1/124TA 7BPqoC5Ak1d8wOMCstBE/0TxXe4wF4DJ68dVEnr7DLZfvX8YmiWcmjrkFfNitE0qHgXE O/gPvM9PnSfoL79GTa9ozbie0tNangaevDtTd+bZbVCKSGD+C/3pAjO2hpvtiZcZR5r5 TpPxabCu76ZP7oDeBMcyzElUGstLfw5mU9VCOCBOA6Y08wzgIC2MoOXPAeWnQUVVaU/4 d6kuKCVj6GJA7+V6EQDLG6SuK2TGOSKjkFrNxesyeNsD7R+OEwayH+qgdRO1GAW47dH/ eMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SRLOeaaYTTbT4XChnKOek2Cz2F03hWdZkAlGSl/IT0c=; b=e1zt/v7E5D2FlTC7l/kj0Eha2AuIueuxBbWUErzwRmkj49fOUYO47hkNWWuuRRK2ws obzo5kD9O5TuwolYLadlXv+fFMwLAyqqYV18O7s3iRMPqZevVPNhdF77Oq/IXBTDlvv6 MuxTU47uHVo5ZZFXfHLyv9G12MVB2QydLWGugHoBhEG0ZVIyUkK13fWLPDQqQf6FsxWH SGTo9ng9vixZzXbZVyA8NTvmjBg44LL89JNM/2x01gzeCyJcsd0k3e98s2MwmMMj5Y8E IywXbRgeT7XA91JP5+oCV5B89pmQylLAkm6h8NmpVbDgsmUoKA8Hk04+PfPrP8fIGk81 givw== X-Gm-Message-State: AKGB3mIy5uFKwyo20xJadMo93uPGx53Idnqm4VsAH8fSxzVhjthsHRRk XUIkzw7g/9lxEEAmO95p+RaL3g== X-Google-Smtp-Source: ACJfBouWVCTThaWVnOmVCivS2g636sLKc+Frcjj/H43hXHSvNC1cF948Dd7jnR6tPZEYLUzVHxQDGQ== X-Received: by 10.25.145.93 with SMTP id y29mr6651653lfj.135.1513370116192; Fri, 15 Dec 2017 12:35:16 -0800 (PST) Received: from leviafan ([217.107.194.133]) by smtp.gmail.com with ESMTPSA id n9sm1393300ljb.1.2017.12.15.12.35.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Dec 2017 12:35:14 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> Date: Fri, 15 Dec 2017 23:35:17 +0300 In-Reply-To: <877etofi3n.fsf@gmail.com> (Oleg Pykhalov's message of "Fri, 15 Dec 2017 12:36:28 +0300") Message-ID: <87vah7lofu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, I have only one addition to the Ludovic's comments. Oleg Pykhalov (2017-12-15 12:36 +0300) wrote: [...] > +(define* (setup-environment #:key inputs #:allow-other-keys) > + "Export the variable EMACSLOADPATH, which are based on INPUTS respectively." > + (let* ((filtered-inputs (emacs-inputs inputs)) > + (emacs-input-dir (cdr (assoc "emacs" filtered-inputs))) > + (inputs-dirs (cdr filtered-inputs))) > + ;; EMACSLOADPATH is where Emacs looks for the source code of the build's > + ;; dependencies. > + (setenv "EMACSLOADPATH" > + (string-append emacs-input-dir "/share/emacs/" > + (store-directory->package-version emacs-input-dir) > + "/lisp")) > + (for-each > + (lambda (input) > + (let ((store-item (cdr input))) > + (setenv "EMACSLOADPATH" > + (string-append > + (or (getenv "EMACSLOADPATH") "") > + ":" store-item %install-suffix "/" > + ((compose string-drop-emacs store-directory->package-name) > + store-item))))) > + ((compose (lambda (inputs) (alist-delete "emacs" inputs)) > + (lambda (inputs) (alist-delete "source" inputs))) "emacs" and "source" may not be the only inputs that should be deleted. For example, 'emacs-exwm-x' package also has "xhost" and "dbus" inputs. And your 'string-drop-emacs' will fail on these names, right? Since there is 'emacs-package?' function in this module, perhaps it would be better to use it instead (to add only emacs packages to EMACSLOADPATH), WDYT? P.S. Actually, I didn't test your patch, so maybe I just didn't understand the code properly :-) -- Alex From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. In-Reply-To: <87lgke3vlz.fsf@gmail.com> Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Dec 2017 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Alex Kost , bug-guix@gnu.org, 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151368053312387 (code B ref 28832); Tue, 19 Dec 2017 10:49:01 +0000 Received: (at 28832) by debbugs.gnu.org; 19 Dec 2017 10:48:53 +0000 Received: from localhost ([127.0.0.1]:41281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRFS9-0003Dj-Cr for submit@debbugs.gnu.org; Tue, 19 Dec 2017 05:48:53 -0500 Received: from mail-wr0-f177.google.com ([209.85.128.177]:34433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRFS7-0003DR-KB for 28832@debbugs.gnu.org; Tue, 19 Dec 2017 05:48:52 -0500 Received: by mail-wr0-f177.google.com with SMTP id y21so18711630wrc.1 for <28832@debbugs.gnu.org>; Tue, 19 Dec 2017 02:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=p31FKREf1tlDj/b216DEsKTcwOP3BFyoAGwAX/TA4gg=; b=icuVcH0cuo97toVQbYI0ngTyXv0MEEWhPfjReGRLcjaXSCe/QELi/fqJ4cvvhzw9La PIip0fli2XcqvWhlkqcKchglm6yWRxu/NglQt8xeJG1rlAy7loY0eP0moEIvpJE+3DW1 PCEw+xm3F8SsBJxBRkd94AUb8LrIBPMJAdQn1588OODBDFs6BSCQYNT2Ytq38UXOEFQS wsQRo2jRkL2HbxCDjgDwV4iMd62osXQ8Dq88aKPkZ3xtfNSlAAGqJJ4hD88VALLZkc3q WlTt8figX0f5ARP6eKEHGH4C9xNWCLLnMa83M9MM2U+EnYwXXWNUe6dG4VBp+BpeERKI krdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=p31FKREf1tlDj/b216DEsKTcwOP3BFyoAGwAX/TA4gg=; b=D9LDcR0p48WdyUiTJ4idtYmaqQMsju+r9Cni6gSweIjnXQH4N6vzTwvBRBu3QGvTm1 U1BfH1GtdFvnGDAUX3sBOAdTl3b2e28SyJiRC5II2C71C33iQ3Y1zUncKgxYwVZn0vf+ nO4Avg1stOOY57xlEWBjgfIqiPOWhBE2D0Va01rIwvqgIIdTgo8FDPu9yi7kKmyfS7Hh OGqDR2XjoKArq5OzUJEMn6ie84LOTgx18M3y9em7ZPQBb0Jg7fSmYNxW9E36BRNzNEt5 QSlNwdKRkavTw7XWpiaI2S0CDUJZl1yeb7/h3ZQ6OmmVUvNKXIjTj+49YmWCaces8BY9 c5Dg== X-Gm-Message-State: AKGB3mIAgjbgEOE1/TvYqLYkKON2VxxWboTw5YsMeRewzRpIe70AV3+Z lGvwljGLMUCWhW52CUYPAlo= X-Google-Smtp-Source: ACJfBotg4GneYuRJzDocrKwylKXoTLJvwwCMAAvTmHDdKqAwblqOYa/HLHEGS579SYtjlJ36x/T3UA== X-Received: by 10.46.127.9 with SMTP id a9mr2055468ljd.44.1513680525698; Tue, 19 Dec 2017 02:48:45 -0800 (PST) Received: from magnolia (ip92-101-245-247.onego.ru. [92.101.245.247]) by smtp.gmail.com with ESMTPSA id e10sm3246870lfb.0.2017.12.19.02.48.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Dec 2017 02:48:44 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> Date: Tue, 19 Dec 2017 13:46:56 +0300 Message-ID: <87lghzyoyn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Thank you for refactoring notes! ludo@gnu.org (Ludovic Court=C3=A8s) writes: > I think it would have been better to open a separate issue for this. > Here are some superficial comments. I hope someone more knowledgeable > about Emacs can comment. OK, I CC bug-guix@gnu.org in this message. Previos discussion: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28832#17 > Oleg Pykhalov skribis: [...] > Please see =E2=80=98C-x v l=E2=80=99 in that file for the syntax of commi= t logs. :-) Oh, nice tip. Thanks! [...] > Did you try rebuilding Emacs packages, and to simplify those that > explicitly pass -L flags? I tried it on emacs-json-reformat which wants many -L flags and succeeded build a manifest with following packages and patch: emacs-aggressive-indent emacs-company emacs-company-quickhelp emacs-debbugs emacs-elfeed emacs-erc-hl-nicks emacs-default-encrypt emacs-god-mode emacs-ggtags emacs-git-gutter emacs-gitpatch emacs-guix emacs-helm emacs-helm-make emacs-helm-projectile emacs-highlight-stages emacs-ivy emacs-markdown-mode emacs-multiple-cursors emacs-nix-mode emacs-org emacs-projectile emacs-rainbow-delimiters emacs-rainbow-mode emacs-slime emacs-smartparens emacs-transmission emacs-transpose-frame emacs-use-package emacs-w3m emacs-which-key emacs-yasnippet emacs-yasnippet-snippets flycheck geiser magit --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-emacs-build-system-Handle-EMACSLOADPATH-environment-.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] emacs-build-system: Add EMACSLOADPATH. From=20c66f03c09517571a03fdf97b86bc571a71e969bf Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Wed, 13 Dec 2017 08:10:21 +0300 Subject: [PATCH] emacs-build-system: Handle EMACSLOADPATH environment variable. Define the 'EMACSLOADPATH' environment variable to carry all inputs in test= s. * guix/build/emacs-build-system.scm (setup-environment): New procedure. (%standard-phases): Use the new setup-environment procedure. =2D-- guix/build/emacs-build-system.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index bd0d2e026..9897abf9e 100644 =2D-- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2015 Federico Beffa ;;; Copyright =C2=A9 2016 David Thompson ;;; Copyright =C2=A9 2016 Alex Kost +;;; Copyright =C2=A9 2017 Oleg Pykhalov ;;; ;;; This file is part of GNU Guix. ;;; @@ -222,6 +223,37 @@ second hyphen. This corresponds to 'name-version' as = used in ELPA packages." strip-store-file-name) store-dir)) =20 +(define* (setup-environment #:key inputs #:allow-other-keys) + "Export the variable EMACSLOADPATH, which are based on INPUTS respective= ly." + (define (name+version input) + (package-name->name+version (strip-store-file-name input))) + (match (assoc "emacs" inputs) + ((name . input) + (setenv "EMACSLOADPATH" + (string-join (list input "share" name + ((compose (lambda (_ version) version) + name+version) + input) + "lisp") + "/")))) + (for-each (match-lambda + ((name . input) + (setenv "EMACSLOADPATH" + (string-append + (or (getenv "EMACSLOADPATH") "") + ":" input %install-suffix "/" + ((compose (lambda (name version) + (string-append + (string-drop name + (string-length "emacs-")) + "-" version)) + name+version) + input))))) + (fold alist-delete (emacs-inputs inputs) '("emacs" "source"))) + (format #t "environment variable EMACSLOADPATH set to `~a'~%" + (getenv "EMACSLOADPATH")) + #t) + (define %standard-phases (modify-phases gnu:%standard-phases (replace 'unpack unpack) @@ -229,6 +261,7 @@ second hyphen. This corresponds to 'name-version' as u= sed in ELPA packages." (delete 'check) (delete 'install) (replace 'build build) + (add-before 'build 'setup-environment setup-environment) (add-before 'build 'install install) (add-after 'install 'make-autoloads make-autoloads) (add-after 'make-autoloads 'patch-el-files patch-el-files) =2D-=20 2.15.1 --=-=-= Content-Type: text/plain Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo47iAACgkQckbhHGm3 lWlk7hAAqCLXXev9SVyFvT3exIBwpczBqjzfJRYXeM/bWnQ+FYL5AlaXZzlMs/Jo gG4PXcnVX8UBmcCQH5X84EkRLGtLosy4SLKVhU6q/cqI1t4YEHfVaeVNiNqK0E1c Oc6o24TxFj7Roau/PXQ5eVMSsIe5gxstX5Q7nZVSf/tUzzSITyRAcUpE799egnak xS4RAWD49ZDxQiaTljBv61jBgra+rmDebnEm5XPFG6NoxAiw0k+lRfNs2jENhpQJ j01dxkivSTk2XCHknBwzeEh7wSCO8kGiQz8rD14RTAGOkDNH4NIHiDrPAvB5PoCx 1r2SlIlhUV4PpSfed1zR9TUIrxGBTk94TMOMvR64I3V5J7/AcQrD7sv5OgAmDMlh pvEJKnqp9Bt/e68iP8Tv/QoniZSdjyPBl2UB5Ty4Vl87ChpbNi3X2JxB9mc5Un52 zCDH54Ycu4OWif2V0I6jS4nXezmz3vWNm9mT6WusoVmjPW76Nh50FPYT5+P6PcV+ /IGsND2lO5SXx6Syau3iCOV885iXw2c/UhaWmZlSdrBD0i2s95MGQbA7gs9usU4w O7RxR/z7qdpEeZ5qnG3pEOmqAmDYgJnkosa9NyS8vhBKDlu59WM36JHray2SYnlF ij8y0vPC6I0XWUH5qF1+DOWFNLU/XYiwqltgy8mHumo9wGfUBeU= =uzE+ -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Dec 2017 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: 28832@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151368166314091 (code B ref 28832); Tue, 19 Dec 2017 11:08:02 +0000 Received: (at 28832) by debbugs.gnu.org; 19 Dec 2017 11:07:43 +0000 Received: from localhost ([127.0.0.1]:41291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRFkN-0003fD-Jn for submit@debbugs.gnu.org; Tue, 19 Dec 2017 06:07:43 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:46714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRFkJ-0003ex-Vq for 28832@debbugs.gnu.org; Tue, 19 Dec 2017 06:07:40 -0500 Received: by mail-wm0-f51.google.com with SMTP id r78so2791721wme.5 for <28832@debbugs.gnu.org>; Tue, 19 Dec 2017 03:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qVBExDqe0OQEs2IGK3JN98nGT9jA87zYqDmKk4ZQacI=; b=FXga5JcRDaGJKYChLUV+tIi8sS++G/vDSYC0B/ArAF/5/tB8BUQS8w/pAOBWccsSkw 5qcR7DvAcrbxeG7d6xDXmOzftl2+V+Vk+QutV44dAMIFOPfjHAxPnYzUuQe34T0hyJJU 3aMIUEb/DPOa15jmkAvgohxsaf2Pi3pWKUnF49KylQM+XWVNxNy1XtFmPUjNSbk0dNMf lbMMQCwsAIw55VbxOh/T0glcMNw39P6cG5xmWIc34nf001RjZsb7K8YuBPVL88SL0trJ PTqezjM3L1deKG8/VdYETRjuBGMLnU9GL2Dmr9upAY71mZ89ZyB0NCnTqhKEM6h3qEWh bHgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qVBExDqe0OQEs2IGK3JN98nGT9jA87zYqDmKk4ZQacI=; b=Yu1qvUWY4tejHfP0SN4Ew+AVjt9MwTyRAYyzTgNOTiL38YthYSvOVSYXy9+I+CkDSL 9V0NvDvNBLXbCwbgtK3Mv4/MVQWhSAD6Vuz0p6fUjNmj3IIMSlJOTsGrFolZ1spu6KBL N7qzyfJF+eCiIDQ8kVgVURRvqF8ATcR28dLtfNgqK55MUdwJWFFZRJtuEJD3LEX56yij HT6UsBlpEXAQ5WaEMjuT10bcOMQsKWlk99rlLT6CwAZ+Z/vWVD8z1ljwfqXOAN8OJWcV D44ITii9cWpSa13wM4KFxikyBjlYHWZTg6kD40TtH9Mp1jjIUmKPIHnhQmvWPOi9VCT2 cJgw== X-Gm-Message-State: AKGB3mLDxgZh8elOvFco+VH+RHdck/yQbB4I/vjCgE1UWSnf9U2ln4ib mjZ+HCdLZvnIlXXAn65DUbU= X-Google-Smtp-Source: ACJfBotnW9J+pDCoHOn+9lmhTxr3+L2fFsovCqUFmY5DhkbNkom9owqFQjzw5sYRMbcSx5rbeGgaqQ== X-Received: by 10.25.233.25 with SMTP id g25mr1863056lfh.101.1513681654198; Tue, 19 Dec 2017 03:07:34 -0800 (PST) Received: from magnolia (ip92-101-245-247.onego.ru. [92.101.245.247]) by smtp.gmail.com with ESMTPSA id h142sm3258765lfh.37.2017.12.19.03.07.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Dec 2017 03:07:33 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah7lofu.fsf@gmail.com> Date: Tue, 19 Dec 2017 14:07:05 +0300 In-Reply-To: <87vah7lofu.fsf@gmail.com> (Alex Kost's message of "Fri, 15 Dec 2017 23:35:17 +0300") Message-ID: <87ind3yo12.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Alex, Alex Kost writes: [...] > "emacs" and "source" may not be the only inputs that should be deleted. > For example, 'emacs-exwm-x' package also has "xhost" and "dbus" inputs. > And your 'string-drop-emacs' will fail on these names, right? > > Since there is 'emacs-package?' function in this module, perhaps it > would be better to use it instead (to add only emacs packages to > EMACSLOADPATH), WDYT? Yes, this is why I used 'emacs-inputs'. It evaluates 'emacs-package?' as I see. So we peek only "/gnu/store/=E2=80=A6-emacs-" packages. [...] Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo48tkACgkQckbhHGm3 lWkGJBAAm9E1l4zV81CEwhn4KjwJlUSrLlv3PG2cDMxDjIOxwJHdHGZCsLmgDKw0 F7Ye9XKLrWcQBZ3B5JAsm+XvOKvMc1tGFGOe1jd0eQyQj2R2LAC5SGJ8xwfEbrE1 /kXp8AG3vCXG8LdroTuqiRy5o3rBAyJZ9rjyhgxnZlt+FzvNZK0Sdi/2PvC54W7b 32ZvzYBFAxJIH97POFEw/rGLB4g4sFKumdFzPAjet9WmYvpzlWUPPaJdyCdYvXgC KJZqPOjGpzfH3nsvTkwqvoeIBdpAPz+WIqVmGrFzfVuShe8V3vSHaclAnH6/6YzF /cqrTAbUpoxos8etwtYK8VAK91Kmfd6gx7OvaVOKX5HBlnXc6q0RrFOWjy7rozdp DSiYJa4cunZumJYwmTqpSXkhaKq7fZcVzI40S4LzvArIgxX5nLTIsR9cc16wHJNM 28nD2J0MRpRQzKJ9DPjU36uTYul2N/PDM/7985NSc23vhK01vycica+U7BBz4q8z Tcyr+uhmC+xoEtkf0GicmsNPIRWO2TJERlzWXoyhFkgRi7Dtg4NL8+I92X9zZp2x Ogs4ZUKok61SHZgKI2YVkVEjUGr2qHFnMax4WcUmnhKtEikvh+3LGCJDwwQR6Emb 1UVKWz8fwG3XVfOivajftGA4mCri84qosOT73a4/nZS4Vq5USRo= =QX7P -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Dec 2017 20:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151371705526798 (code B ref 28832); Tue, 19 Dec 2017 20:58:01 +0000 Received: (at 28832) by debbugs.gnu.org; 19 Dec 2017 20:57:35 +0000 Received: from localhost ([127.0.0.1]:42718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eROxC-0006yA-Q8 for submit@debbugs.gnu.org; Tue, 19 Dec 2017 15:57:34 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:44508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eROxB-0006xy-Gt for 28832@debbugs.gnu.org; Tue, 19 Dec 2017 15:57:33 -0500 Received: by mail-lf0-f43.google.com with SMTP id x204so21642191lfa.11 for <28832@debbugs.gnu.org>; Tue, 19 Dec 2017 12:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TZUENIPPG61p0UYMZJzRDNSdy57bfJu7WYWqhVWVKCs=; b=ZiWvv15DhhGC0a4kg802jVOuHNU1/wN1WhrrFTYq37jOV+lW9QyvY4zhKLcRyxmLMM DrllpabpoTx63iOwJB50yL8xwl+O7C5Fe7rqo0GW/vlwXjgNEfeibRqn7208A8zl6HFw eYVpCzvpOHgt7jgT6pYlsmWLQ8GvxXAQqRKRGHZeRrV/OJmGbSOPspBC7ZVAfH5LmcHg qK9IsGmx/6GfXKaB6inIVtxTAwunpfdG21K/jCK22LQdflPyqO5AaNNA2ING0XjC4UMN S2DCkvpvbOx2Rndw11q2PAxwrE605qfvfI1VUqyCY/OAcVgwOMfPBxeTq/75eQotsqtv HfYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TZUENIPPG61p0UYMZJzRDNSdy57bfJu7WYWqhVWVKCs=; b=a3ILmw/fm9IYmbPmOEVnSbZjY9xid/6moPzkYBjiCPkA0y7N2frTe3coufUtGw6Umw yXXvmf/leezj9EKMOT8MrnmjZeAhJ94HGTWplO4H67XHFi5VpNyug2Yu2gHKpvNbqKZE /PUjrMJJq/gCwKWN6IvDJ8DpYxGnixOFmZJuWbQnGEMZGfGm2/Khwo/1U+7gGtgxNuQC cmuK9DRCa2lEnA1TG+eiSwv4Nb8XNP0avxaWgW1CZUtnDDiEl9hkwOQ5aGasclfuLva1 w51U2nSSzodlCbMOyItw2zAcKrV8SlGt3RMkKQUMdbWK8nkWQZUBvVCvL3oxTwukA8Nu o2Wg== X-Gm-Message-State: AKGB3mLWPV+vwAuUtE6RoERsQUGSEWhE/4YcyuN0msfQ5s4dFj7r9eKA 08H9j60GykEZAoVI1x0e5eUuIA== X-Google-Smtp-Source: ACJfBotJAvsVcG8KAY1UYmMxwOR/tr2f5BmY5WkLf1qYTaOm5ia1k7fheALYTK0sqxw8N7Zr5pArdw== X-Received: by 10.46.116.1 with SMTP id p1mr3044459ljc.103.1513717047158; Tue, 19 Dec 2017 12:57:27 -0800 (PST) Received: from leviafan ([217.107.194.134]) by smtp.gmail.com with ESMTPSA id b15sm3474454lfb.41.2017.12.19.12.57.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Dec 2017 12:57:26 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> Date: Tue, 19 Dec 2017 23:57:33 +0300 In-Reply-To: <87lghzyoyn.fsf@gmail.com> (Oleg Pykhalov's message of "Tue, 19 Dec 2017 13:46:56 +0300") Message-ID: <878tdy1lmq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Oleg Pykhalov (2017-12-19 13:46 +0300) wrote: [...] > + (for-each (match-lambda > + ((name . input) > + (setenv "EMACSLOADPATH" > + (string-append > + (or (getenv "EMACSLOADPATH") "") > + ":" input %install-suffix "/" > + ((compose (lambda (name version) > + (string-append > + (string-drop name > + (string-length "emacs-")) I would move this code into its own 'string-drop-emacs' function (as you did in the previous patch) and I would make it more robust: there is a problem with this code: (string-drop "geiser" 6) does not return what you mean, and (string-drop "dash" 6) errors! I think we shouldn't rely on the assumption that all emacs inputs have "emacs-" prefix, so I think this procedure should check whether the input name begins with "emacs-" before trying to remove this substring. > + "-" version)) > + name+version) > + input))))) > + (fold alist-delete (emacs-inputs inputs) '("emacs" "source"))) Since you already take only emacs inputs, is it really needed to remove "emacs" and "source"? I mean emacs inputs do not contain "emacs" and "source" anyway, right? -- Alex From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Dec 2017 03:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151374046228976 (code B ref 28832); Wed, 20 Dec 2017 03:28:01 +0000 Received: (at 28832) by debbugs.gnu.org; 20 Dec 2017 03:27:42 +0000 Received: from localhost ([127.0.0.1]:42863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRV2k-0007XI-Dr for submit@debbugs.gnu.org; Tue, 19 Dec 2017 22:27:42 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:37686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRV2j-0007X3-AQ for 28832@debbugs.gnu.org; Tue, 19 Dec 2017 22:27:41 -0500 Received: by mail-lf0-f48.google.com with SMTP id a12so22427176lfe.4 for <28832@debbugs.gnu.org>; Tue, 19 Dec 2017 19:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SIZ1lENjd1Ll6AxX4EvNphc5OOaYc8f7xFyO3CXThcg=; b=P/k7eN7SFLRpfEqjJBJylwXHSmjBpq5i0LiTyEeFat9n6dXOQJnV7CHk66fWBKHeUn Y3C/jNq/Ym3XHNUeMOnOLxT568B3VJElpNJHP8DnZibU0vrRdBa3pNBwq8WSb9zXH44t ABro4zxHvING2cAlNWIa1Cvknh3y+VuXRAOpXLnpcp0AgJUD3woydEW05joyn1tZRpDo XXEX1bwv+1Yv7eA8V1Cl1+mumq8fuNQ5AA4XY2EY0+vZEDQPiQCLee29qKTrXbYcKEfs 7tJ1/UDCfcUvAqYxRPQt0xYUvsaqvlNbFzmNXmtxzmQfB7rK6bwamzO6Kihu7xDKLg6y c8Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SIZ1lENjd1Ll6AxX4EvNphc5OOaYc8f7xFyO3CXThcg=; b=mqPWafQAb6EWEuQxsWJ342IElVP5q0IcVVSf1SWqvrGXB0xgHsXmLk1kozryavE3Vv 9ZB8TlOEPeb85cJc/hktUh+wyowrOQvclTfdwN9oPwP3Q+TYQ3AhBp/aASin0EX2WUML ZDBx64A83xh7hVv5w2Xby4o+pidCgDXBQfrid034R9rYDurpfWiwBqNxuqNAtWq+RRSk xtaizCRViuFONYUkwHV3lX3DOEk/tnmGXxNIDDpBwOTlVDYeYz4/lUCICdx0XjaDFbS8 Q5j0u+qs4UtZ3b027RXhsLSCCJQvggUxeQJmmG56ZmtS3Ncibk517+y4frl3rxuhonp5 QvRg== X-Gm-Message-State: AKGB3mLE543sTA0yOfX7pcoInCq+kdR/WqxeULKIyjvv94lJX3i3goBW TJtdOaERfBU39mN28uOpu1UP860I X-Google-Smtp-Source: ACJfBovO2rB1KjkyiL3q+CiKfQ1WmlI1npi5B5cML1yVE9N8f8kZnrsn328HUqhuwfWF4TiMcrOM0w== X-Received: by 10.46.116.9 with SMTP id p9mr3451667ljc.28.1513740455071; Tue, 19 Dec 2017 19:27:35 -0800 (PST) Received: from magnolia ([178.71.224.245]) by smtp.gmail.com with ESMTPSA id m26sm3314529ljb.61.2017.12.19.19.27.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Dec 2017 19:27:33 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> <878tdy1lmq.fsf@gmail.com> Date: Wed, 20 Dec 2017 06:26:54 +0300 In-Reply-To: <878tdy1lmq.fsf@gmail.com> (Alex Kost's message of "Tue, 19 Dec 2017 23:57:33 +0300") Message-ID: <87o9muxeo1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Kost writes: > and I would make it more robust: there is a > problem with this code: (string-drop "geiser" 6) does not return what > you mean Yes, because "geiser" differs from most of Emacs packages: ls /gnu/store/7rl2k8ismmyq9ic6ha6vzv38a3hrrni2-emacs-dash-2.13.0/share/= emacs/site-lisp/guix.d/dash-2.13.0/ dash-autoloads.el dash.el dash.elc dash-functional.el dash-function= al.elc ls /gnu/store/7lh77fmapmjjv3kj2q69dy58kjniw9am-geiser-0.9/share/emacs/s= ite-lisp/ geiser-autodoc.el geiser-chibi.elc =E2=80=A6 Maybe we just need to fix "geiser"? > , and (string-drop "dash" 6) errors! Do you really mean emacs-dash or dash? For me both succeeded. As I see emacs-dash is OK, except "emacs-minimal" in EMACSLOADPATH. Here is a log-file with DEBUG-INPUTS: --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=vggdk813p8c82h7bjgwm5ghrl6r42a-emacs-dash-2.13.0.drv.bz2 Content-Transfer-Encoding: base64 Content-Description: emacs-dash build log-file QlpoOTFBWSZTWZiCLtoAG2FfgEAQcP//+b/n3uT////wYBIM74N1969S1nfG8nn2A1aqm27fJ6ni hS6YioUEhUUXppOtddBwAJJJoU/UCeE09RlTaJppoeoaGnqPU02kaPRih6Q4CN/+qqTIMEMCYmjT TAIyDBGRpkMNNCAQnpNTaUGgGgAAAA0Bp6gEp6SlT8pP1GU9EPU0GmRoDQNAAAA0AIpIBDCNBMEy YTJJlPUaaGjQaNAAEURACAAmRDSntSNpihoGmmRoNNGnqYiRBN2wPHbyLPs1u4b5Bqme9w8afbuk fg73cJ8LnNNvdhShNoYmghiiq0fotDIucDE1qx5rQdTF1OEcVeWOECrQLEMUMqQkXH2OaSUiAvR3 JOU1cn95TkL7Gjd1b4SayJXBox/W1qvkd2ZYYUPJjDpZmpAmhhv0kHrByFI7qOCgO0EQ94IhSgkQ JECRAkQhCiLfvFMM4Dlqy0RPvxp8uWZrYAENBT5BiG0U9h6WojFdVB/KABMbwLDqPqYSSqg6xTPX +ZqwCkh4hfTiHvwx17u1A2AiGAp14B8IHGBL/shPhApwC48gjAEkAGo97Z7T2sNm19Ow7f52k41o qq99tyMNFZdPXLK7Tpdpokf15AEwJmEWWWV3LzSW4/690xmTpczwd141z584vYU50wlMjMxMrKuK wkoetspMBHC6DICFwhE+08WdBSUW53gUTVX0nE6PBJOh9DQGuIoVVFVSqQHPWCNJVmRgVWNYVzyt lLaFnZEO5J0sSZ/VfE8gj9wfvxNxQkqCIC+q3bSR/c3bJo370zLaGJI/mw1B+dhTa9ybiYKSC4nJ QMiChr1Aa0Li+6IpWbUQVh2YlkSxDF0GQXD7Uk81vbixjR2HxzxbCdP333Zaq1rhtxN2S2FCUviJ bqfWfCc5meb6NwNY1no2nBKKIYgggLkM60XxuvpDCBNpIrmLCIiIVR00hMwRRhW4wSszGFemseVt Yk2TKrMqCmKD1acs5KeiU+l5pS/aECkB92lmDEE88OHdKKUpIpBAszPrkYCFgVLIlPpSRfBgbmgJ ZZSiSpIREPsLrKMyEWlj1Bq20z13kO5ICIqrfrKnJvdozPVUqKxhHzwEOQgnLZfomTps64AAAAAA AAAAAAAAAAAAAAAAA5OaBAgjieJicCD/xXVeYZVyiNV9KxpSNVPDusgOtA1m3RKO74xR2ycYS7BZ UgdUtVwwwFFWhEUGwhEFKWhRVFkhwVVbhzTWZm03m4obzUKWFLLLrrN/pvTBEw4SSzEW8AuqsJST jjq0muqNWow5g6PzBB4JdQYLjWCeIrgzp809BSZG2qm3Rhnz6LrLLLMjKC6BIYBkQRCBSUwfgfYk 1ZFxEjVLmwWp5fkzP6ebQ4EVJ6qVxoR7UTnvRyopx5iIDhMvjRZlzT21Yaa4YYYZhpZCkQJOhNKD IkCpEwpEAegIhCTsMx+KVr9g5lKRH0Mz0Ww7Pde78c9rV9iHJO72NN/aNcpBoBROIqQkCHavTTp2 06du3XDDDCgZxDGZrn9p4FKRHNJmIuS4uXvC2WVAmdbiVvQssozMjMybDQ0TJ8Wr7xwf1r+lPkB1 S5PauY7dQkQoERD0nVt1693Tp04YYYYZicbJCZ2Mz6EzLMxERyXJpTE7DSmp6gUpL0dqdhzJ7AXp asnFnaE6poei38nPpcX2ZJtGFgQhh68OmW7fz3ZddMMMMM16WRER4J6mlLkmb2UqmUqpSkQqISiK k7vZOqbjK6jB2jrdyyoGLxQYoockmERokrqjHFGMYQhDBIBHQMMczLOkBqSNI8Sxm1uxC07vB0tj inZaR3J0c6CVD0c6LChJlc/JGu7juv3XQhCF8USZDdKaZMdGKlhzLJwSp5sniBM6k3pzbx9UOAlC cgHGVjVzjkFZGSSiWNUY3qYQhBzDWcia0TFiaxgMiRwNzkKmB9k6jqAhCSEnQkNyohpvsDo6tE+W qzVqz6NVlllkrYCMbkpfYmeDWyO6aJJmkFQPU8W1JTo9DFfUyB04j4j60lOYUFIuhKlFluN1Mb1u S2NsIQYyxTC5xs6aRDX0s5glpc6wOrxW0dzY73IPoupKUuTaB8w3Bw8a8M4i4QkVSGm4Wly2y5CS 2y7tYZznZQ1H26TUwzI4IO/Z46m8t+yY3gavDdCcgbxox+q9TMB7j3cAwfmHAaY5+CoxYbLZUqQh PLLcIUk/LrC8pmo1yA3bNQGAwEAeFBG2+yWJsNuVxvvqOJ2nxEkHiHRpL3hiMT68IWR/X39Xcugd WZtvCw8n9PKAcaZCF14l8Ey1gdi2FKDqA3aQG7F1IgGRfI7UgI0KD+x+1fvXcKX25GAEHBdCaIlA +17v9wK8AaOIZhr/FPrsCYyeeiGoMoMJxQBUnOKkQTlyvBdabQPmFhaKQOdoKZp2AYWEQ87ARDgh y1xGkFIKoHKCMtsRhcQFxRvqCkkQzlbVS/gP4LicSHY6vVjgYP8E/J1O1pG4T7/uNpoXZSprHCf8 V5yK1GyQ/2Rnb3omhL+Nr7P3mQLiB2tsk7Z7JELJIf6pc4JtbQMng4Aa/Xyobx2D+Qp87pzyJPXQ liklDaKUD1T1SmikOiE0KRaGwm1nGgjcbGXgfrTgIXp2ZgzRmPlKwUxkHGA5PMwFNrCNuNiSCAJ0 q6MTFN3EmURKomITqye6TGYfyaWh/wDUnJD2dj2H5vRlgGlYAhDYsQREQLATHt7B+Pm4vuTwOhAB yFPEonbMzXkkRT8UJBPxh4sHICL3s+HLOlEIeicB8TPFzClTimpPZ0gaKQxfgqal+E809b74PpNR PNEiLYo6xI430AvBSEssm3eSs1SUkwswmwwJKBdNkikEgHkXk4CLcAghQVkTGcYiYAAAYACtm95p Zn5SY1RqKS1moH0kgiGOIpNlstTQUuV0FNJqchQzNUt7QyLHE8KonFGwaAvCP7zdTQrSdAKzPSFs JYSi2BTQxgR8RoigIpy5sQo0I5SRD2oKxmoawIYGCCQUiVhBQceHY9E1vdpC5OS2YDns7XrILQ3b FJhCYQ4876XMrbQO6ZbbuFNaYil/IdHxTauTmFWgpIaBTyHAQOn1IdU6IeKcxtA5ZD1ZlPRgsTzb Q9lRLh1aOYIPTehaZoDRkUpV7nJah1p1KW7Q5TKnLdHrKGUkkkkKkkQEBDCwBEBAIdBwX3ricl+E 9GoPcCwJAvYFPmw8G5JxKD6XBpYGxkwknI2LO05U0vzA0GDg9UMXuVlha1KfJtPdORWvNmAtNCUC mwCG4NiSDYTJO6WeqdnW3wlb3ALoSGNq1qEqUSTs8cpQXEKPn5iFt7YhAR7KwRLCOPba5+wK4ClA zImWz7AhtWxqKoAJaXWQjm0vB1ieRMUgzMcH1A/YGZWqA0GINY1OnAcu5WA3vh926d6JzLea1Aya FvaV2Odw+iGhdHUIH2SxfhaSgtAhyN6clMvnSPuNaULwbL8GhLXy9V1NbUeEzIZh2W4xFfws00gi FGSJDJhkN4FNbR4h04d4AmhBV9+ScrTktD3RAFsrBBEJMGejMEVgIcQuGpTe9DiBl6hLnXYVhGRn b4BrgnDFyLVVA9WS53zZYWwmikE9pCFRycz74k5FMiRMl7zQwHU/DSoF1yeS9EkDc4+Cx+Dc4UQx wlnE0JlcR9E5tzsSFZzJwdTyuHuNxxAuNjrIeTe0hMZgkEFGmtPJK4j6h2Abi7d3yrXhSkRbNYrh JMJuWoZpiCKCCIkYBAHXivl4udejSoWSWwNdqXNtbZUMQ0kCICopAQ+NhQUs9coBaEBAnVOrzObg ppcid6BjnySBJy2jflDz8pxuDUlj70x6x5prLqSE7xKQlG4EGBJFDAnZdDDvz2jneOMKfiEhkTxI XczdCRIAnme6y11FQ6JL9TAbekRCOEBRUy/Ctl4lgRgQTjkFtgINQtyoHCA7lpqPwnKhhN71A7Wd dvh4cyl4RSBhq2FLCYJImb20G5Jh0DvzNLTaaM0XQOIIh5kdx+oQNRMYZ7PGoM+Wqqqqqqqqqqqq qrK4qYLg8pUEhvJ4D3es+fVc936kvkPUkY1sFpIqTMnx4Xe8fRKULmzQOJUnzTohz8AUPNPoPNCg +LyPMdjreaU2HPtIpwSLIIeZcW0ofF3LkTczORNrsW91mH0b7Yfd6M3Nx4G9kAs6MJCsKhZ3NYGu qCIciykOW0JJ2J3tkTJG84PB8QMuDxZ4vcDAMy0NgnZ2bYwyQzAlLU1yYiu8LjB0QwQuQl63uhBM WigwzDW7m45kPK82BFVLO7kVqySQCaEJcVATjJlCCxm2cKUiCso5JgnBKtqZJXt1d/D4vgwOo0gp G0U04giHiwDMULvNRAey733DM1xEEEAgSEguAnFfLSoNBtyyLuQGNSq0pdAJWujMMTYCigXmOpyk VY4NIqFD6BS8txBB2lg5iNkxond5pqfR26oyv0WFodNmKNvgrAgjQqCYIBMAMQqB9sUkHFt0FlCC 2DWXw3Wjwo8aClSxMBXAvBkMYCW8jxLzy6ClTB4lwZmwLHENZNFDVaZWCmltyQkEhQbubfipg1fW Ygg3gVMoWjqhMjYagQaCnACAiwQnunkrJilTYG4Mj6+xU27rI4ky95OJlvo7s926Bllo7t7Y8oL3 elK+XWQB6uxPzJyer7JwStdwbgMNoH1TOjM5mZ8v1TFClZAeGvscGxNJ5SE2nhsNvLla7ErbErXU NY8g0jD6vhkbJ1mQx5DQ2vlKzkhlStOb4ywx4fhmByb04IeXe3dk7ITtb1QtDFzpI7JRIsWxcx9i +g5mnBqcXohg48zKhgPy2p4ydQ2IQbNabjmnV9k2vuv2G9OqFw8vfo3uD4b3cNQ+Oi3ewHJa03pm X0TJlhJ0wLHF7Gxm8NyZUyodxqdrazvCSRBGoehqe4GBpSTxTK//F3JFOFCQmIIu2g== --=-=-= Content-Type: text/plain > I think we shouldn't rely on the assumption that all emacs inputs have > "emacs-" prefix Then, how to determine that a package is Emacs package? > , so I think > this procedure should check whether the input name begins with "emacs-" > before trying to remove this substring. >> + "-" version)) >> + name+version) >> + input))))) >> + (fold alist-delete (emacs-inputs inputs) '("emacs" "source"))) > > Since you already take only emacs inputs, is it really needed to remove > "emacs" and "source"? I mean emacs inputs do not contain "emacs" and > "source" anyway, right? emacs inputs contain "emacs-minimal" and "source". So we actually need to remove "emacs-minimal" instead "emacs". (emacs-inputs '(("emacs" . "/gnu/store/g1ldcr600kmdf2n1gsphk04hm30jr4bn-emacs-25.3") ("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7mvgy-emacs-minimal-25.3") ("emacs-dash" . "/gnu/store/dn7mygbi0pm985lz6qc64fsaz9f8zmfi-emacs-dash-2.13.0") ("emacs-shut-up" . "/gnu/store/k0zddbwfwpdgj1ih2ypl50n09dfxhq1f-emacs-shut-up-0.3.2") ("emacs-undercover" . "/gnu/store/ypcyxb3wpqlnf962k8ygp5csr6cmi6w3-emacs-undercover-0.6.0") ("source" . "/gnu/store/gyxjrmhk4xqd8r78blxb92f9xc1z92fr-emacs-pos-tip-0.4.6.tar.gz"))) (("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7mvgy-emacs-minimal-25.3") ("emacs-dash" . "/gnu/store/dn7mygbi0pm985lz6qc64fsaz9f8zmfi-emacs-dash-2.13.0") ("emacs-shut-up" . "/gnu/store/k0zddbwfwpdgj1ih2ypl50n09dfxhq1f-emacs-shut-up-0.3.2") ("emacs-undercover" . "/gnu/store/ypcyxb3wpqlnf962k8ygp5csr6cmi6w3-emacs-undercover-0.6.0") ("source" . "/gnu/store/gyxjrmhk4xqd8r78blxb92f9xc1z92fr-emacs-pos-tip-0.4.6.tar.gz")) Thanks, Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo52H4ACgkQckbhHGm3 lWn5exAAzPKsSjsTpr6GAUSH772uDY5QzaDJjqe5BKap66JkFswNy4rVFT1ZN+iS mqvC05/nWe4QVRud3gb4fptssIV49iUT/Edsd7SEKW3gvf+1fumA9/iJDwIE2x5t a4fkP8bMpbVSelWoPEvVH1GNJoeRwq0Tb8jbG1lVeg1SzIdCT6AiJ9mVc3Zv8w1a 2jBMLLUqA27yXQsob6JuKVOn/98UHTQPZb5VzL9FRQ6CDGshR58XQCWzzvU2PMFc z/OBHTzDgV2xY+JWhZhrFsfU7doMOa+cEwpgUeFtqZ6eV5My+zGLCXfqfrpfEdv8 bowA+bZUDVALSeis2jZApkb7YRAOq1EqpZpkS9JU6EnuVj3PUno4sJGaXzqzyZa2 /4TsHqTO82P2m4vv1IYSB/zmvk96PdrKyFFQKQusNLKDhZpmDHAyFziojxRfuOmi A2hZZ8l1H9on//wk7Va6XKAKWBDX8Pji9adiSOKtoM1a891LoCGwh5eM3zRhG38v /u2S32L35UjC5MbtLZrERuJrmL2Rvf696PbLcm1oAcz9QR3pKQNRfF9x/5LuNQww 81djRF+EqHMEVgpUCu0dy2f/oimGL1PSiMS5zsDVzgzD9pmqn9uH/Xou/NKpgT4L df40asgV8BeuJl03cvdLlNmYyhISkp2iXGK/uraTNw/30C3L0nA= =KB90 -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Dec 2017 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151380783216716 (code B ref 28832); Wed, 20 Dec 2017 22:11:02 +0000 Received: (at 28832) by debbugs.gnu.org; 20 Dec 2017 22:10:32 +0000 Received: from localhost ([127.0.0.1]:44902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRmZK-0004LV-CD for submit@debbugs.gnu.org; Wed, 20 Dec 2017 17:10:31 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:36108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRmZI-0004LH-Ra for 28832@debbugs.gnu.org; Wed, 20 Dec 2017 17:10:29 -0500 Received: by mail-lf0-f51.google.com with SMTP id c19so5842600lfg.3 for <28832@debbugs.gnu.org>; Wed, 20 Dec 2017 14:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=LESCmOrW9vzmD+7EJdH2cNpCAc8uvJR0aSrKnZlTMmU=; b=LnZs3Gmgn0kpGhJW9l+kOoWwbKvmasBY60Ounsw7EWHdICAZXX1sNj0ae4idIctzQC BGa4WxAXMcvpb+m5132+7HV9kUh4U9BqwVSNbBV7g2iDlqxsqRh37BIuA+imwVUtEoRl c6XSOWGgJoMgU0nZJpIQ8PNs1YCinT7s/KPhbOtQ6tS+NznK9wZzYBPTlaBkHsvsfjjT J7txnYXdmIlu43Kgd3jSOPiEvNrNu9n8XtkzUmEP95do96Y/QseBxVU3a6O8v3zusdYB GkAODCc/GWXPp+JbGLMKBeauyPl40MgQIqHqhq2rcTB/3wm7sbAOfaGdV7ty2wVu6WRU qaRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LESCmOrW9vzmD+7EJdH2cNpCAc8uvJR0aSrKnZlTMmU=; b=bGHYO5a9lguY2wgBBqWIP4QWAqH/kMhSpZXhBqeQVnj+Dp82GTLYouJ2xt0zFITl8H awtiRxHB81H2J9d1HCLu/5yzHe/SFB0UNVeEBKDv+vxz+ehgM6WBWQIZVvk88FTJ/kcN /u2Ha+dFkhTjaMQdslL+vPi552zzU3Vu/NIvJEu+xX/S9aKK2WFYLVMeedq7tNaq0imn jLnOE12FUjk+ZB43ROM8CX3P/fvYMZ1jTsohbHJ0zjXR8WnGKpCz4ZLyiDViIs21VEZz /7ou6dXe4AH0nPCFd2yc4lApowGWcuKcojOViplE5rirfR9zsw2xfknDb0toNL2lnsZZ 0KSA== X-Gm-Message-State: AKGB3mIyO/qhJML20UzBVRmZxOA779hta3Wra0RGDNOCf0nKNISvI5ne g1J0Jvd1fbuueL4ETEOBjsQRrA== X-Google-Smtp-Source: ACJfBou0zYDnl/86TjHMzYeOvOZM0lWweszpRJ2u4pboXSm5MecBv6NT3SaN6gpQ/B1rJ6eU1chBug== X-Received: by 10.25.153.65 with SMTP id b62mr2267656lfe.109.1513807822675; Wed, 20 Dec 2017 14:10:22 -0800 (PST) Received: from leviafan ([217.107.194.138]) by smtp.gmail.com with ESMTPSA id 28sm278514lfy.96.2017.12.20.14.10.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 14:10:21 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> <878tdy1lmq.fsf@gmail.com> <87o9muxeo1.fsf@gmail.com> Date: Thu, 21 Dec 2017 01:10:30 +0300 In-Reply-To: <87o9muxeo1.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 20 Dec 2017 06:26:54 +0300") Message-ID: <87y3lxuk2x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Oleg Pykhalov (2017-12-20 06:26 +0300) wrote: > Alex Kost writes: > >> and I would make it more robust: there is a >> problem with this code: (string-drop "geiser" 6) does not return what >> you mean > > Yes, because "geiser" differs from most of Emacs packages: > > ls > /gnu/store/7rl2k8ismmyq9ic6ha6vzv38a3hrrni2-emacs-dash-2.13.0/share/emacs= /site-lisp/guix.d/dash-2.13.0/ > dash-autoloads.el dash.el dash.elc dash-functional.el dash-functi= onal.elc > > ls /gnu/store/7lh77fmapmjjv3kj2q69dy58kjniw9am-geiser-0.9/share/emacs= /site-lisp/ > geiser-autodoc.el geiser-chibi.elc =E2=80=A6 > > Maybe we just need to fix "geiser"? Sorry, I don't understand what you mean. What is wrong with geiser and why/how should it be fixed? Also do other non-"emacs-" packages (magit, emms) have the same problem? >> , and (string-drop "dash" 6) errors! > > Do you really mean emacs-dash or dash? For me both succeeded. I meant just "dash" name. > As I see emacs-dash is OK, except "emacs-minimal" in EMACSLOADPATH. > Here is a log-file with DEBUG-INPUTS: No-no, I didn't mean that the build process of 'emacs-dash' would fail, I meant that your code uses 'string-drop' and it may fail: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (string-drop "dash" 6) ERROR: In procedure string-drop: Value out of range 0 to 4: 6 Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. scheme@(guile-user) [1]>=20 --8<---------------cut here---------------end--------------->8--- All I wanted to say is that emacs inputs do not necessarily have "emacs-" prefix. For example, 'emacs-direnv' and 'emacs-ag' packages have "dash" input, but not "emacs-dash". But now I see that it's not a problem: I mistakenly thought that the names are taken from the input names, but now I see they are extracted from the store file names, so my above concern is not relevant :-) >> I think we shouldn't rely on the assumption that all emacs inputs have >> "emacs-" prefix > > Then, how to determine that a package is Emacs package? I don't know :-) 'emacs-inputs' is probably the best way. >> , so I think >> this procedure should check whether the input name begins with "emacs-" >> before trying to remove this substring. >>> + "-" version)) >>> + name+version) >>> + input))))) >>> + (fold alist-delete (emacs-inputs inputs) '("emacs" "source= "))) >> >> Since you already take only emacs inputs, is it really needed to remove >> "emacs" and "source"? I mean emacs inputs do not contain "emacs" and >> "source" anyway, right? > > emacs inputs contain "emacs-minimal" and "source". > So we actually need to remove "emacs-minimal" instead "emacs". or maybe both? since some packages uses 'emacs' instead of 'emacs-minimal' (emacs-auctex, emacs-exwm, etc.). --=20 Alex From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. In-Reply-To: <87lgke3vlz.fsf@gmail.com> Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Dec 2017 05:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.1513834536383 (code B ref 28832); Thu, 21 Dec 2017 05:36:01 +0000 Received: (at 28832) by debbugs.gnu.org; 21 Dec 2017 05:35:36 +0000 Received: from localhost ([127.0.0.1]:45096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRtW4-000066-Jm for submit@debbugs.gnu.org; Thu, 21 Dec 2017 00:35:36 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:37394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRtW2-00005i-GQ for 28832@debbugs.gnu.org; Thu, 21 Dec 2017 00:35:34 -0500 Received: by mail-lf0-f65.google.com with SMTP id a12so26521045lfe.4 for <28832@debbugs.gnu.org>; Wed, 20 Dec 2017 21:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=2r8zfhRC6aUq4A3VgvuHeBXc28pugBs+aoW6lW8mQrc=; b=r6n+BJQeSge8Zj0hGyDiz/e+/NCX/6m9677cZ2jHnsnStiE87ppa4UMrbOrSDC668R /0P24/DsToScu7bXvBg7CzCKfLaiK2qcjDnbvH7iH9jTqfgRO+KlROs90l9+j+rr1+SC cUQkw8O3ClH/ciiGg4i/oe91AggCIEdszKBhnFtbZ+kM9pgeroBm+Atz7NrT19dzqzKT fII1R+TSDRpOnXxCxcgCs7t6ja9TB8f/bHggAfhvlDmY7org/HKJyUwmURAX4dPwZYhF JRcIPOxcXGItQYwTc9MRyQg1PoM9jr6qpzS25E+PgRKDfWXQdz6rQ7MZk54nrvo4TP92 28YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=2r8zfhRC6aUq4A3VgvuHeBXc28pugBs+aoW6lW8mQrc=; b=cQ0BDr+OFlQS9F48sTAbgHpg8OGxycCrQjXgjEHv/Ydb0M0i/+b8sAvoIfLlMTSt53 h2NkeZRLvQlysRPDwOcUiVidycycnZLMYxPXRXpgpPB0Tu6tl/hKnlBGJ7zz0zVzgnHW 0REwevwB+ZCjOcgqp+7mZgL9HfastBgTeZnv3PjQRPT0GLSv6Wzgi+8x7d5U50kSi9kS cpupTgi15Tc5zrCMngWwFl9KXj7UIhxUxsENjNeM46cN9VYLqcopOC6OzAAu3nYu79Mc 5nIF+OlRT9eMtcWgx+prU+992WVHzDtPZ0FYMgR0W2+YTJ4I3tD/b4rDpVl508o0S/E0 kBGQ== X-Gm-Message-State: AKGB3mIpw935xfOUPLjFzEC/GJbBpiEsPKpYqRhQIDZKUDW8MbeAvmfr W7qPC6Oq6NWjLOUWVWStRoJk2h5d X-Google-Smtp-Source: ACJfBosk7Nj1ePaTfZ2vLEkCztNOkxaotBeCnpMRLWH3Ev2IM3TS5zcIPLeqJ8+wXFDVj17vRq8t1w== X-Received: by 10.46.29.67 with SMTP id d64mr5705446ljd.139.1513834528161; Wed, 20 Dec 2017 21:35:28 -0800 (PST) Received: from magnolia (ppp80-88-51-1.spb.avans-nw.ru. [80.88.51.1]) by smtp.gmail.com with ESMTPSA id 2sm3789252lju.17.2017.12.20.21.35.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 21:35:26 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> <878tdy1lmq.fsf@gmail.com> <87o9muxeo1.fsf@gmail.com> <87y3lxuk2x.fsf@gmail.com> Date: Thu, 21 Dec 2017 07:48:27 +0300 Message-ID: <874lokvg84.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Alex, Alex Kost writes: > Oleg Pykhalov (2017-12-20 06:26 +0300) wrote: >> Yes, because "geiser" differs from most of Emacs packages: >> >> ls >> /gnu/store/7rl2k8ismmyq9ic6ha6vzv38a3hrrni2-emacs-dash-2.13.0/share/emac= s/site-lisp/guix.d/dash-2.13.0/ >> dash-autoloads.el dash.el dash.elc dash-functional.el dash-funct= ional.elc >> >> ls /gnu/store/7lh77fmapmjjv3kj2q69dy58kjniw9am-geiser-0.9/share/emac= s/site-lisp/ >> geiser-autodoc.el geiser-chibi.elc =E2=80=A6 >> >> Maybe we just need to fix "geiser"? > > Sorry, I don't understand what you mean. What is wrong with geiser and > why/how should it be fixed? Elisp files of Geiser are in different place than others Emacs packages. There is no 'guix.d/geiser-0.9/'. (for-each (match-lambda =E2=80=A6) =E2=80=A6) in 'setup-environment' will f= ailed. Either we need to handle this case specific for Geiser or just change where it need to store Elisp files in 'geiser' package recipe. > Also do other non-"emacs-" packages (magit, emms) have the same problem? Hm, /gnu/store/k9zrrzpdw0mld0lqyackba3kwbw41ipr-emacs-emms-4.3/share/emacs/= site-lisp/ /gnu/store/zihybmvkccjb310fsxc2sad5j0w5vdi1-magit-2.11.0/share/emacs/st= ie-lisp/ it seems that it will be easier to handle a case without 'guix.d/PACKAGE-VERSION/'. But I don't see a way to determine is magit an Emacs package, because there is no "emacs-" prefix in "/gnu/store/=E2=80=A6-magit-2.11.0". 'emacs-inputs' will not help. See below. >>> I think we shouldn't rely on the assumption that all emacs inputs have >>> "emacs-" prefix >> >> Then, how to determine that a package is Emacs package? > > I don't know :-) 'emacs-inputs' is probably the best way. No :-), it only relies on "emacs-" prefix in store. emacs-inputs -> emacs-package? -> (string-prefix? "emacs-" name) >> emacs inputs contain "emacs-minimal" and "source". >> So we actually need to remove "emacs-minimal" instead "emacs". > > or maybe both? since some packages uses 'emacs' instead of > 'emacs-minimal' (emacs-auctex, emacs-exwm, etc.). Not both, because 'emacs-inputs' removes all inputs without "emacs-" prefix, so 'emacs' too. (emacs-inputs '(("emacs" . "/gnu/store/g1ldcr600kmdf2n1gsphk04hm30jr4bn-ema= cs-25.3") ("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7= mvgy-emacs-minimal-25.3"))) $3 =3D (("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7mvgy-ema= cs-minimal-25.3")) Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo7PRsACgkQckbhHGm3 lWnwCA/+NZmVuc7RV+eqxRIHd/ldaAsSUmLHtocl0g1WqyJjmnfElnW2hVOXkaXl aerz5iVlsd2r4U3zEwvS9JSuxCS3ZvavZ22PCIvRuKaoGYDslYtSxM2hrdpxFnIr 5EZ56RaqPhvdhr/FPx2fTcLW6BNGnN1KfLYz9O2dsbWbnFvSaZ2JcADJteKnD8IY YTREVcPxqsZztbP8kU2B09kWz4gQi5wBjxZvtuIB9vlhOCthr68N/PxL8JtIc1uz wSKj1jAy1B1oc2NrXs/frkh1S3ZCfwDXvY7/kNFvcOcXi6IzsV3wRHr/0jsPujp/ s4FFPMLnP5ww5i7u6e9IYbddnbpeRWXAZNy/zWlJiHFnTk+EwIBSGPp3x9GflNY3 5SKTnFPWBb8eH/cjPvYuRWMxYY0kt9cQExtWHsgw9Mx7sEntcz/ZanGtfqFcCv8/ EQAciN9zjJ/+6647rf/oi4QE4rgXw9Hg/CqK5JHMtfNPr4pd4KYMatNBGhiKH/A3 +p/40hzpSNwlILSbVnHWB9hQ/WJ0XqesXB/QBi9ZVG+YtLeu0IrnxS124T0n7jEo 9N9zfmcK4eiN6t/epqsMc+NP7oY7NF8YwvuntTJpJJBmGZ51gxwEtM1zvHUMY32B /Ulv4i2PlEoOXNwbWpOmX1zWt8yDmjfvBV3K1rxLAV8wlBWepkA= =R4dm -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Dec 2017 20:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151397403729021 (code B ref 28832); Fri, 22 Dec 2017 20:21:01 +0000 Received: (at 28832) by debbugs.gnu.org; 22 Dec 2017 20:20:37 +0000 Received: from localhost ([127.0.0.1]:48357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSTo5-0007Y0-HJ for submit@debbugs.gnu.org; Fri, 22 Dec 2017 15:20:37 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:39100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSTo4-0007Xo-2y for 28832@debbugs.gnu.org; Fri, 22 Dec 2017 15:20:36 -0500 Received: by mail-lf0-f66.google.com with SMTP id m20so19568719lfi.6 for <28832@debbugs.gnu.org>; Fri, 22 Dec 2017 12:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=yNMud+hGMEoUHdRNRHVJUpV5vxl61GsFsRsxPCmsK2Y=; b=auF7RZl0oSqVo5yTDznEXcFFleKiWQXgUBTgPPKEthTo5aenYKNL0ysIXC8vxOcE32 M1Ll3NsmC45qJxXejM6MY6bcqpcNrbBtzVdHgmirnj+Kcr+m6ctFeNMi7HKD1u36ajaw 7rZEeBK9RShtZXaC6PWtp7W1ciiAD76iMwbOKbVG+0efp8eF7MMyu97RjjoGpgCADDII lWsueWFpoS5LJkNAZrTI0Lg4LosncugUwt55/p4rJX3hFTuyB25uRsDC/Y5GzoFu0bWk HyJZGpz+i+l09zLJISQG+gEBcz5coPsSBfloLlSDgY3ksyhzwyX1+w2x6hMoLjDkEgSr ouQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yNMud+hGMEoUHdRNRHVJUpV5vxl61GsFsRsxPCmsK2Y=; b=HPcUKPIdZ6EMsTNQSvjk8t2LgRcy3pZXwerUCGBreoSmKSzr37q3H/UiIp2rb0Mr/L o+PIZUB3d3VYfjW441yhYLh85NmxHxAOin6vkL0L+4/E+9xnHPaDZTpuBCGIVQulLxJw bcBgJot2eLQ2TrfDLPfX1vlXl/VpyQBEgZ4Agm4QlDHLSF0JHhNfck2dh0UG8csxCDrz ++eJIsJxJckEukwkGDnS2hXoVPjyw/INVFfSdHtkdZFOY0wX1iz+CF/y4kIasKr/KPYe d5+0myhCQUFZCNmTZv6WxZ9RKLjfyOoG5u1R8AqZLjfADVdoN77pBXMyVnfumTJnrrND H+Qw== X-Gm-Message-State: AKGB3mJh03P1MIoRI4Emf9+xAT4DNP7srL/QhWlo5fpzILVBbk1M502f /phDo/gimslYWR5mjDb4hLM= X-Google-Smtp-Source: ACJfBos2u4pci+8NNk6lsrkxXCuamwdEJHBAiKYKesS4xk9UP60B7SCOUkCcYuikruHLXxUkAxGHsw== X-Received: by 10.46.93.13 with SMTP id r13mr10330900ljb.102.1513974029846; Fri, 22 Dec 2017 12:20:29 -0800 (PST) Received: from leviafan ([217.107.194.138]) by smtp.gmail.com with ESMTPSA id n189sm4918587lfb.32.2017.12.22.12.20.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Dec 2017 12:20:28 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> <878tdy1lmq.fsf@gmail.com> <87o9muxeo1.fsf@gmail.com> <87y3lxuk2x.fsf@gmail.com> <874lokvg84.fsf@gmail.com> Date: Fri, 22 Dec 2017 23:20:40 +0300 In-Reply-To: <874lokvg84.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 21 Dec 2017 07:48:27 +0300") Message-ID: <87vagyldk7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Oleg Pykhalov (2017-12-21 07:48 +0300) wrote: > Hello Alex, > > Alex Kost writes: > >> Oleg Pykhalov (2017-12-20 06:26 +0300) wrote: [...] >>> Maybe we just need to fix "geiser"? >> >> Sorry, I don't understand what you mean. What is wrong with geiser and >> why/how should it be fixed? > > Elisp files of Geiser are in different place than others Emacs > packages. There is no 'guix.d/geiser-0.9/'. Oh, now I see what you mean. > (for-each (match-lambda =E2=80=A6) =E2=80=A6) in 'setup-environment' will= failed. > > Either we need to handle this case specific for Geiser or just > change where it need to store Elisp files in 'geiser' package recipe. It is not a specific Geiser case: installing *.el files in "share/emacs/site-lisp/" is a common practice. Actually, it is the default place where automake wants to install elisp files (using AM_PATH_LISPDIR macro), so whenever a package uses gnu-build-system, most likely it will install elisp files to the site-lisp directory. For example, the following packages do this: bbdb, gettext, emms, magit, emacs-wget, emacs-w3m, emacs-mmm-mode,... >> Also do other non-"emacs-" packages (magit, emms) have the same problem? > > Hm, > > /gnu/store/k9zrrzpdw0mld0lqyackba3kwbw41ipr-emacs-emms-4.3/share/emac= s/site-lisp/ > /gnu/store/zihybmvkccjb310fsxc2sad5j0w5vdi1-magit-2.11.0/share/emacs/= stie-lisp/ > > it seems that it will be easier to handle a case without > 'guix.d/PACKAGE-VERSION/'. I also think so, for example, 'emacs-inputs-el-directories' procedure simply adds "/share/emacs/site-lisp" along with the "guix.d/..." directory. [...] >>>> I think we shouldn't rely on the assumption that all emacs inputs have >>>> "emacs-" prefix >>> >>> Then, how to determine that a package is Emacs package? >> >> I don't know :-) 'emacs-inputs' is probably the best way. > > No :-), it only relies on "emacs-" prefix in store. > emacs-inputs -> emacs-package? -> (string-prefix? "emacs-" name) Yeah, I understand this. I meant this is the best way we have at our disposal. I also don't know how to determine emacs packages without "emacs-" prefix (well, maybe by looking for *.el files inside the package store dir, not sure if it's suitable though). >>> emacs inputs contain "emacs-minimal" and "source". >>> So we actually need to remove "emacs-minimal" instead "emacs". >> >> or maybe both? since some packages uses 'emacs' instead of >> 'emacs-minimal' (emacs-auctex, emacs-exwm, etc.). > > Not both, because 'emacs-inputs' removes all inputs without "emacs-" > prefix, so 'emacs' too. Oh right, sorry. So to clarify the current situation, we have 2 problems: 1. 'emacs-package?' defines emacs package simply by checking "emacs-" prefix, so it doesn't find such packages as magit or geiser. This problem does not relate directly to your patch; rather it is the problem of the current 'emacs-build-system': if some emacs package depends on 'magit' or 'geiser' (currently there are no such packages), emacs-build-system will not compile *.el files (because it will not find 'magit'/'geiser' needed for compilation). 2. Your patch handles only "/share/emacs/site-lisp/guix.d//" but not "/share/emacs/site-lisp/". --=20 Alex From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Jan 2018 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org, Alex Kost Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151570719817084 (code B ref 28832); Thu, 11 Jan 2018 21:47:02 +0000 Received: (at 28832) by debbugs.gnu.org; 11 Jan 2018 21:46:38 +0000 Received: from localhost ([127.0.0.1]:52570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZkgI-0004RB-6N for submit@debbugs.gnu.org; Thu, 11 Jan 2018 16:46:38 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:35540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZkgD-0004N9-O4 for 28832@debbugs.gnu.org; Thu, 11 Jan 2018 16:46:36 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 18ABD10959; Thu, 11 Jan 2018 22:46:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2dIXVbksrW4t; Thu, 11 Jan 2018 22:46:31 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id ED687101B9; Thu, 11 Jan 2018 22:46:29 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> Date: Thu, 11 Jan 2018 22:46:29 +0100 In-Reply-To: <87zi6os3u3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 12 Dec 2017 10:17:08 +0100") Message-ID: <87po6gm5l6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Oleg, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Oleg Pykhalov skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 >> From: Oleg Pykhalov >> Date: Tue, 12 Dec 2017 01:41:08 +0300 >> Subject: [PATCH] gnu: Add emacs-json-reformat. >> >> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add this. >> * gnu/packages/emacs.scm (emacs-json-reformat): New variable. > > [...] > >> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b/= gnu/packages/patches/emacs-json-reformat-fix-tests.patch >> new file mode 100644 >> index 000000000..23a239582 >> --- /dev/null >> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >> @@ -0,0 +1,28 @@ >> +Copyright =C2=A9 2017 Oleg Pykhalov >> + >> +This patch fixes tests for Emacs 25. > > Please mention here. > > OK with these changes! We went on discussing other things and forgot about the patch. :-) Could you commit it with these changes, Oleg? Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Jan 2018 12:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 28832@debbugs.gnu.org, 28832-done@debbugs.gnu.org, Alex Kost Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15160176803179 (code B ref 28832); Mon, 15 Jan 2018 12:02:02 +0000 Received: (at 28832) by debbugs.gnu.org; 15 Jan 2018 12:01:20 +0000 Received: from localhost ([127.0.0.1]:56715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb3S4-0000p8-1I for submit@debbugs.gnu.org; Mon, 15 Jan 2018 07:01:20 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:45372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb3Rx-0000ok-7n; Mon, 15 Jan 2018 07:01:15 -0500 Received: by mail-lf0-f67.google.com with SMTP id y71so13035978lfd.12; Mon, 15 Jan 2018 04:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Oj6vR0bBiKVnLaJinqiheC49ImaE+PLUyarZ1XhM7bY=; b=mWe9aPmCNt8Egp/Yg0IqlRpGFElOCfk9SYKILwVdDsRYdhw4VFs5aOra8H+KEUWruc YZplDcAGbRdgq0pGZpLcZZ69s09ZP8WmjB5OGJMo/ei2zk5m7A6YSi3soO+kkFzmwgYL 7Pe4Q5DPbycrhJby3YVuAOlETj4Jv2fVe9Cno1YYrGeLPkPh8dhfuoxqkAL/2KLrP9c7 Ks8+TwKW0E3NVEB5+39UW7M9jhxiuloagZx0kfK7bv6LWPjAo9HrkZGeaOO5yaQP8yY0 uDdo0zIc9F2xlFV2rH2Npebd/JYVf0483isD8hgewGeRVqZyrXdx63f69quna+tZSbM0 Y3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Oj6vR0bBiKVnLaJinqiheC49ImaE+PLUyarZ1XhM7bY=; b=OsoUfPN3l4y0S76R/HesoSWOyANFQO8YpQyCPCNQHwpAniO+nS65JbPzjp7uJECprF 4OLTwxEuGMLmrz1jrzzIeCUuSTA4cULgp52O4vw5cRDpUFg+JBiC70FqIYGbVRuoog28 vszwnQ09Tq3uiy7FaMJ+mTLm7KuvahymSSpMzCzvKqbMPNVyqezkYCNJdLaVxwgvNjJa jH1QVYTg9uH05cpux1ssIWSR9dkAXa8ihopYeO04RvA229nnp9/TgWXYTVw57Vlr7Ntv 86oZoo+el6JsdcbP5ycR9IVOi8qiX1MzlN3yfsKwFU+Q+Cuv311mA5cmal1Kq3DHDFrK ugNw== X-Gm-Message-State: AKwxytedSN4uKpNW34c9tfAwq4CCt4IlbVh6m1sUMSO2gRG5VhyxumTl 3vkXhaJctYUyqslJh/hu6Bc= X-Google-Smtp-Source: ACJfBosZBMEkG6pZ8KU2ZwRt7JlwFe8i8S9BEOWojnA0PvM6qNoAqwSLwmhVe9DTb3QRjBOxepOvyQ== X-Received: by 10.25.216.90 with SMTP id p87mr18418713lfg.11.1516017667158; Mon, 15 Jan 2018 04:01:07 -0800 (PST) Received: from magnolia (95-55-115-16.dynamic.avangarddsl.ru. [95.55.115.16]) by smtp.gmail.com with ESMTPSA id u1sm2815674lff.6.2018.01.15.04.01.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jan 2018 04:01:05 -0800 (PST) From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87po6gm5l6.fsf@gnu.org> Date: Mon, 15 Jan 2018 15:01:01 +0300 In-Reply-To: <87po6gm5l6.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 11 Jan 2018 22:46:29 +0100") Message-ID: <87tvvntjpe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 >>> From: Oleg Pykhalov >>> Date: Tue, 12 Dec 2017 01:41:08 +0300 >>> Subject: [PATCH] gnu: Add emacs-json-reformat. >>> >>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add this. >>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable. >> >> [...] >> >>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b= /gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>> new file mode 100644 >>> index 000000000..23a239582 >>> --- /dev/null >>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>> @@ -0,0 +1,28 @@ >>> +Copyright =C2=A9 2017 Oleg Pykhalov >>> + >>> +This patch fixes tests for Emacs 25. >> >> Please mention here. >> >> OK with these changes! > > We went on discussing other things and forgot about the patch. :-) > Could you commit it with these changes, Oleg? I thought we suspend this until automation of "-L" flags. Seems like a similar discussion[1] gets stuck too. Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1 I'll close current bug report. Footnotes:=20 [1] https://lists.nongnu.org/archive/html/guix-patches/2017-12/msg00640.ht= ml Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlpcl/0ACgkQckbhHGm3 lWkQoQ/+OCLEiUf9Lj4Mu8gUlcDmBk1AP0lc55Q48AmcjxkL3swALauylyxrU6/b sOYGs5unptxGhFbRpqFnjdavgzvd9Fl6YV+DgekbRldVW5SvYVk2pfTGidWfNBeW 9Qq53UO7HoHB4ETpKwBWFwZXctyJc/tfoi+vPyqdd0t2vSHXnaUNPDYMO0dnKaU/ efH+5gJFN1HhaHrp6iT2AYBXKDK6rQZeYQaup93E27uKSuIaEu1OzasAF3rDiw5e 7Wsm2rGrH/MSZEoCUo4kZnrqhQXebPmvziMfBsdg8iI8SigkwOx+FLCEQWyoXozb dVjmI1WMITqRWbTDmq9e5Wk+L4Y1qiRd7pfnVx5+WHXfrEpoQtZy7laLqXIhdNts dYjM3BPn4IIplE2Ful6pIkFNV/IQrX62hfRyCXzbClg6UMDxndH4TbsTGDKkkpLF vh6Vx6vZ5SSzmVexixFdM1ziBpjSfvYOnbub+Y8nuACzC3MMcRBMl5YEXBv4MRdl bXKzHPIEpBq7S81YXp1PQ0Jqn+kHWe9n2ff6YF/FlHo4ShDI8ZFXKb3UMV+Yl3II +p6560MJixYhfY5bSwWDBj/vs9WCxvaNrjwuo+TeHYewM2BuuvBe/TeOBUwf1sgG ds20YrPrQYTv//n7URa6obV4Ur6R7KCa547ls3Z2GU6Cv73vvYI= =/4CZ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 17:13:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Oleg Pykhalov Subject: bug#28832: closed (Re: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat.) Message-ID: References: <87tvvntjpe.fsf@gmail.com> <87lgke3vlz.fsf@gmail.com> X-Gnu-PR-Message: they-closed 28832 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28832@debbugs.gnu.org Date: Mon, 15 Jan 2018 12:02:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1516017723-3239-1" This is a multi-part message in MIME format... ------------=_1516017723-3239-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28832: [PATCH 0/3] gnu: Add emacs-json-mode. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28832@debbugs.gnu.org. --=20 28832: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28832 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1516017723-3239-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28832-done) by debbugs.gnu.org; 15 Jan 2018 12:01:20 +0000 Received: from localhost ([127.0.0.1]:56713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb3S1-0000p5-MK for submit@debbugs.gnu.org; Mon, 15 Jan 2018 07:01:19 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:45372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb3Rx-0000ok-7n; Mon, 15 Jan 2018 07:01:15 -0500 Received: by mail-lf0-f67.google.com with SMTP id y71so13035978lfd.12; Mon, 15 Jan 2018 04:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Oj6vR0bBiKVnLaJinqiheC49ImaE+PLUyarZ1XhM7bY=; b=mWe9aPmCNt8Egp/Yg0IqlRpGFElOCfk9SYKILwVdDsRYdhw4VFs5aOra8H+KEUWruc YZplDcAGbRdgq0pGZpLcZZ69s09ZP8WmjB5OGJMo/ei2zk5m7A6YSi3soO+kkFzmwgYL 7Pe4Q5DPbycrhJby3YVuAOlETj4Jv2fVe9Cno1YYrGeLPkPh8dhfuoxqkAL/2KLrP9c7 Ks8+TwKW0E3NVEB5+39UW7M9jhxiuloagZx0kfK7bv6LWPjAo9HrkZGeaOO5yaQP8yY0 uDdo0zIc9F2xlFV2rH2Npebd/JYVf0483isD8hgewGeRVqZyrXdx63f69quna+tZSbM0 Y3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Oj6vR0bBiKVnLaJinqiheC49ImaE+PLUyarZ1XhM7bY=; b=OsoUfPN3l4y0S76R/HesoSWOyANFQO8YpQyCPCNQHwpAniO+nS65JbPzjp7uJECprF 4OLTwxEuGMLmrz1jrzzIeCUuSTA4cULgp52O4vw5cRDpUFg+JBiC70FqIYGbVRuoog28 vszwnQ09Tq3uiy7FaMJ+mTLm7KuvahymSSpMzCzvKqbMPNVyqezkYCNJdLaVxwgvNjJa jH1QVYTg9uH05cpux1ssIWSR9dkAXa8ihopYeO04RvA229nnp9/TgWXYTVw57Vlr7Ntv 86oZoo+el6JsdcbP5ycR9IVOi8qiX1MzlN3yfsKwFU+Q+Cuv311mA5cmal1Kq3DHDFrK ugNw== X-Gm-Message-State: AKwxytedSN4uKpNW34c9tfAwq4CCt4IlbVh6m1sUMSO2gRG5VhyxumTl 3vkXhaJctYUyqslJh/hu6Bc= X-Google-Smtp-Source: ACJfBosZBMEkG6pZ8KU2ZwRt7JlwFe8i8S9BEOWojnA0PvM6qNoAqwSLwmhVe9DTb3QRjBOxepOvyQ== X-Received: by 10.25.216.90 with SMTP id p87mr18418713lfg.11.1516017667158; Mon, 15 Jan 2018 04:01:07 -0800 (PST) Received: from magnolia (95-55-115-16.dynamic.avangarddsl.ru. [95.55.115.16]) by smtp.gmail.com with ESMTPSA id u1sm2815674lff.6.2018.01.15.04.01.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jan 2018 04:01:05 -0800 (PST) From: Oleg Pykhalov To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87po6gm5l6.fsf@gnu.org> Date: Mon, 15 Jan 2018 15:01:01 +0300 In-Reply-To: <87po6gm5l6.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 11 Jan 2018 22:46:29 +0100") Message-ID: <87tvvntjpe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28832-done Cc: 28832@debbugs.gnu.org, 28832-done@debbugs.gnu.org, Alex Kost X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 >>> From: Oleg Pykhalov >>> Date: Tue, 12 Dec 2017 01:41:08 +0300 >>> Subject: [PATCH] gnu: Add emacs-json-reformat. >>> >>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add this. >>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable. >> >> [...] >> >>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b= /gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>> new file mode 100644 >>> index 000000000..23a239582 >>> --- /dev/null >>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>> @@ -0,0 +1,28 @@ >>> +Copyright =C2=A9 2017 Oleg Pykhalov >>> + >>> +This patch fixes tests for Emacs 25. >> >> Please mention here. >> >> OK with these changes! > > We went on discussing other things and forgot about the patch. :-) > Could you commit it with these changes, Oleg? I thought we suspend this until automation of "-L" flags. Seems like a similar discussion[1] gets stuck too. Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1 I'll close current bug report. Footnotes:=20 [1] https://lists.nongnu.org/archive/html/guix-patches/2017-12/msg00640.ht= ml Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlpcl/0ACgkQckbhHGm3 lWkQoQ/+OCLEiUf9Lj4Mu8gUlcDmBk1AP0lc55Q48AmcjxkL3swALauylyxrU6/b sOYGs5unptxGhFbRpqFnjdavgzvd9Fl6YV+DgekbRldVW5SvYVk2pfTGidWfNBeW 9Qq53UO7HoHB4ETpKwBWFwZXctyJc/tfoi+vPyqdd0t2vSHXnaUNPDYMO0dnKaU/ efH+5gJFN1HhaHrp6iT2AYBXKDK6rQZeYQaup93E27uKSuIaEu1OzasAF3rDiw5e 7Wsm2rGrH/MSZEoCUo4kZnrqhQXebPmvziMfBsdg8iI8SigkwOx+FLCEQWyoXozb dVjmI1WMITqRWbTDmq9e5Wk+L4Y1qiRd7pfnVx5+WHXfrEpoQtZy7laLqXIhdNts dYjM3BPn4IIplE2Ful6pIkFNV/IQrX62hfRyCXzbClg6UMDxndH4TbsTGDKkkpLF vh6Vx6vZ5SSzmVexixFdM1ziBpjSfvYOnbub+Y8nuACzC3MMcRBMl5YEXBv4MRdl bXKzHPIEpBq7S81YXp1PQ0Jqn+kHWe9n2ff6YF/FlHo4ShDI8ZFXKb3UMV+Yl3II +p6560MJixYhfY5bSwWDBj/vs9WCxvaNrjwuo+TeHYewM2BuuvBe/TeOBUwf1sgG ds20YrPrQYTv//n7URa6obV4Ur6R7KCa547ls3Z2GU6Cv73vvYI= =/4CZ -----END PGP SIGNATURE----- --=-=-=-- ------------=_1516017723-3239-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Oct 2017 09:52:08 +0000 Received: from localhost ([127.0.0.1]:38846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3J72-0006ap-0W for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3J70-0006aN-JL for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3J6u-00064D-IX for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e3J6u-000649-FK for submit@debbugs.gnu.org; Sat, 14 Oct 2017 05:52:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3J6t-0005oc-DC for guix-patches@gnu.org; Sat, 14 Oct 2017 05:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3J6q-00063M-Cu for guix-patches@gnu.org; Sat, 14 Oct 2017 05:51:59 -0400 Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:54009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3J6q-00062v-5B for guix-patches@gnu.org; Sat, 14 Oct 2017 05:51:56 -0400 Received: by mail-lf0-x22c.google.com with SMTP id l23so12045267lfk.10 for ; Sat, 14 Oct 2017 02:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version:content-disposition :content-description; bh=9kdt2EHW7kkPEAEtegbEcreD5Et8aB+P9ofmVSZGG4o=; b=oFY8kB7oqOWNhOYWSTP9uwtpr2b+64BOFZQ9fkCLzlg7hQyL0kbcpOiM2OHYXkSvfk 4YJ8SFYmqWCGKyO/5dOaCMIXLFspgnrpAOJsiqCaEvqZ8LpRxyXhoOe1EjhfS3+wLqdS hQV1qsp3GdZsacEJjYsZcaLW/CVQV0Jr644RXFVGQaayCEvNfUQuJjp0DLHuSz7a/kCD mYYuv2VMvkEUxpOgchiG2Vz3YvFWna1ZMqPa+id4b8kI5wHCx2w0FdPye33ffftQxoOB gWhF/1IfrnL4qNeoqD9dAbBNj8tk/puV2w8bt9qzNB3LPijy9Oi5G2t1R7i0Y5z97Lih s5Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-disposition:content-description; bh=9kdt2EHW7kkPEAEtegbEcreD5Et8aB+P9ofmVSZGG4o=; b=KHAZq7geTfcTtkSkK9WQhQdRnrebgR+6uZ9zw0wtX8TVtUJrjm+cQ6sa19XH6VqO/A +wcYBy6jOG+UvsmNyg4YesX+pSNX1Gbw+m/tjf50xgO/fPZvdLUBnwHywjXopVEec3OR UMjam0qvEYtlWCy7IzWloAIugnNN3Xno0WE+W6dOKCVdPcyGi5DVOsC2Da7/aFHkUpV0 fwr8PjcOYGWgfNebsTvVrLYxofA82n4iD1mjytxsWzAGDFK9M2QDyEUfHu9AnMPZiSEp u1dAyTGlWiIywvEUC2C48SY8270jlfspvxZ1JXwwk/kN+yjK/XtjG7UWIF0r4mR3Og/O 4BgQ== X-Gm-Message-State: AMCzsaVPanrpRVeONJ12daIkChz9FcT1SZsbAZUkf2sAX4DmV4wpG8RF s2frpx6lMlYTfa8tyGtt4yZLng== X-Google-Smtp-Source: ABhQp+SSZF8xldokoJpTFNiD9CzDPibREZ04Pdj/HpyGuqZiR4b/pH4fgawWnU/0Mdu1BQCcp1GJAA== X-Received: by 10.46.82.14 with SMTP id g14mr1628011ljb.118.1507974714405; Sat, 14 Oct 2017 02:51:54 -0700 (PDT) Received: from magnolia ([178.71.225.184]) by smtp.gmail.com with ESMTPSA id t10sm704002lja.92.2017.10.14.02.51.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 02:51:53 -0700 (PDT) From: Oleg Pykhalov To: guix-patches@gnu.org Subject: [PATCH 0/3] gnu: Add emacs-json-mode. Date: Sat, 14 Oct 2017 12:51:52 +0300 Message-ID: <87lgke3vlz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/x-patch Content-Disposition: inline; filename=0000-cover-letter.patch Content-Description: [PATCH 0/3] gnu: Add emacs-json-mode. X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) >From b3b7b79f85e3b2aca6322e9c994b0fe0a666825d Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sat, 14 Oct 2017 12:50:21 +0300 Subject: [PATCH 0/3] gnu: Add emacs-json-mode. 2 tests fails in emacs-json-reformat. Oleg Pykhalov (3): gnu: Add emacs-json-reformat. gnu: Add emacs-json-snatcher. gnu: Add emacs-json-mode. gnu/packages/emacs.scm | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) -- 2.14.2 ------------=_1516017723-3239-1-- From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Jan 2018 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org, 28832-done@debbugs.gnu.org, Alex Kost Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.151602321218720 (code B ref 28832); Mon, 15 Jan 2018 13:34:01 +0000 Received: (at 28832) by debbugs.gnu.org; 15 Jan 2018 13:33:32 +0000 Received: from localhost ([127.0.0.1]:56786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb4tH-0004rn-QV for submit@debbugs.gnu.org; Mon, 15 Jan 2018 08:33:32 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:39676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb4tC-0004rV-8x; Mon, 15 Jan 2018 08:33:29 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E884F109A2; Mon, 15 Jan 2018 14:33:24 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QslcSkcXtc70; Mon, 15 Jan 2018 14:33:23 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 673A61092B; Mon, 15 Jan 2018 14:33:23 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87po6gm5l6.fsf@gnu.org> <87tvvntjpe.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 =?UTF-8?Q?Niv=C3=B4se?= an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 15 Jan 2018 14:33:22 +0100 In-Reply-To: <87tvvntjpe.fsf@gmail.com> (Oleg Pykhalov's message of "Mon, 15 Jan 2018 15:01:01 +0300") Message-ID: <877esjgsbh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Oleg, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > > [...] > >>>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 >>>> From: Oleg Pykhalov >>>> Date: Tue, 12 Dec 2017 01:41:08 +0300 >>>> Subject: [PATCH] gnu: Add emacs-json-reformat. >>>> >>>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. >>>> * gnu/local.mk (dist_patch_DATA): Add this. >>>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable. >>> >>> [...] >>> >>>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch = b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>>> new file mode 100644 >>>> index 000000000..23a239582 >>>> --- /dev/null >>>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>>> @@ -0,0 +1,28 @@ >>>> +Copyright =C2=A9 2017 Oleg Pykhalov >>>> + >>>> +This patch fixes tests for Emacs 25. >>> >>> Please mention here. >>> >>> OK with these changes! >> >> We went on discussing other things and forgot about the patch. :-) >> Could you commit it with these changes, Oleg? > > I thought we suspend this until automation of "-L" flags. No no, the =E2=80=9COK with these changes=E2=80=9D above really means you c= an go ahead. :-) The =E2=80=9C-L=E2=80=9D discussion is about an improvement we should make,= but it should not block this patch. > Seems like a similar discussion[1] gets stuck too. > Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a Yeah, though I don=E2=80=99t think you should wait for Alex or anyone else = to make a decision: if you have an idea on how to improve this, based on these discussions, then you=E2=80=99re probably in a good position to do it= and everyone will be happy. ;-) > Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1 Great, thank you! Ludo=E2=80=99. From unknown Sun Jun 22 17:13:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Jan 2018 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Oleg Pykhalov , 28832@debbugs.gnu.org Received: via spool by 28832-submit@debbugs.gnu.org id=B28832.15161239533691 (code B ref 28832); Tue, 16 Jan 2018 17:33:02 +0000 Received: (at 28832) by debbugs.gnu.org; 16 Jan 2018 17:32:33 +0000 Received: from localhost ([127.0.0.1]:59006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebV69-0000xT-4q for submit@debbugs.gnu.org; Tue, 16 Jan 2018 12:32:33 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:44694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebV67-0000xC-M0 for 28832@debbugs.gnu.org; Tue, 16 Jan 2018 12:32:32 -0500 Received: by mail-lf0-f68.google.com with SMTP id w23so18394228lfd.11 for <28832@debbugs.gnu.org>; Tue, 16 Jan 2018 09:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WyTWogYi7cf6shROapUQwxv6DHQFJaWbZZdnKTmWk/c=; b=rFMg4ReiCbG4dW9ItLIwdjdHG60o07Whq2YphXHuiznFWl34t1IgYpoIG1iGg2fq4D tj1NcbuymUubZqppu7SlPM+b9sdlLHS1FTsAbaDQG44uK6i+uKTivcSlt1ehB1QiBB3S xJD/oGaRNoqcxptE3eyFV53oqry4w71xH/vuUtw6woXqLBuFkBvXfin7+MxXArgp5mcC 0OGRZV4XtCrs8zTMuKxTvNe+a9GNXTyRLgbffuVIefeqH8LsdzMS+VMSoj2JJbIZ9J4e Y7Rr2r1L/1z8xNJOrKWFmKOJkNBcg71XM3FLJcfs+0nNDWZ8tjv7hYKqSsXj1Z2ttzyX ffyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WyTWogYi7cf6shROapUQwxv6DHQFJaWbZZdnKTmWk/c=; b=tSvFCV/rIqkPJtsBIoZE9LVDsW9Vnk3SO9q2kAom9dtn7yojd8zGMsuZVnD+2ETCzt gBHLm8EWPq6xAa7fTa5BH4isOvbNSvKtd4mLLqlCQCio4WFTCJOiH+XyhHS258+nwy3n wnDRpnOGxFy1nrnZrGvKk3w2aj7prInorBHlbKPm30791ZhT2bId38DvM7ppaZZG5CfY vbZkl9n396MY2sIs7t/nR79TczVVY2DYqGEqo3CsxZ0gdRx1Rc9LEvpN/7nqr+XFpgBs HikScnZ2APOjfTN0wAhJHpzabhm4fFRXrJcz6QiTFpPkDxDZteXH+e+MyYIkOl4o5k/r xqkw== X-Gm-Message-State: AKwxytfIut37LMfVomsZ8WfmLVdsHYR6YEa8nAN1E19jMXkeFJ80qN0A kEQSZqjctv8bqMYkw67fqBoNRw== X-Google-Smtp-Source: ACJfBovMX61rAmYWVMIbcX533gqKYZzfz9D07ZDZWNLPyADnU12YYTSjMxWSSoogOsevhV7Wg72XwA== X-Received: by 10.25.223.83 with SMTP id q19mr5774570lfj.45.1516123945607; Tue, 16 Jan 2018 09:32:25 -0800 (PST) Received: from leviafan ([217.107.194.26]) by smtp.gmail.com with ESMTPSA id k77sm449734lfe.48.2018.01.16.09.32.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 09:32:24 -0800 (PST) From: Alex Kost References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87po6gm5l6.fsf@gnu.org> <87tvvntjpe.fsf@gmail.com> <877esjgsbh.fsf@gnu.org> Date: Tue, 16 Jan 2018 20:32:25 +0300 In-Reply-To: <877esjgsbh.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 15 Jan 2018 14:33:22 +0100") Message-ID: <87shb5ogk6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ludovic Court=C3=A8s (2018-01-15 14:33 +0100) wrote: > Oleg Pykhalov skribis: [...] >> I thought we suspend this until automation of "-L" flags. > > No no, the =E2=80=9COK with these changes=E2=80=9D above really means you= can go ahead. > :-) > > The =E2=80=9C-L=E2=80=9D discussion is about an improvement we should mak= e, but it > should not block this patch. > >> Seems like a similar discussion[1] gets stuck too. >> Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a > > Yeah, though I don=E2=80=99t think you should wait for Alex or anyone els= e to > make a decision: if you have an idea on how to improve this, based on > these discussions, then you=E2=80=99re probably in a good position to do = it and > everyone will be happy. ;-) I didn't think someone waits for me. My last message was: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28832#71 and I wasn't going to write anything else until a reply. To make it clear: I don't mind any decision you make, I participated in this discussion just because I was CC-ed. Please, go on with whatever seems appropriate to you. --=20 Alex