GNU bug report logs - #28824
26.0.90; display of pbm images broken?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28824: closed (26.0.90; display of pbm images broken?)
Date: Mon, 16 Oct 2017 08:31:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 16 Oct 2017 01:30:07 -0700
with message-id <6c4a985c-b0a1-93a4-8c3b-36f7c2f5721c <at> cs.ucla.edu>
and subject line Re: bug#28824: 26.0.90; display of pbm images broken?
has caused the debbugs.gnu.org bug report #28824,
regarding 26.0.90; display of pbm images broken?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28824: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28824
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Roland Winkler" <winkler <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; display of pbm images broken?
Date: Fri, 13 Oct 2017 21:10:50 -0500

start emacs -Q
evaluate (arg FILE-OR-DATA of create-image should point to a pbm image)

(defun foo ()
  (interactive)
  (insert-image (create-image "~/foo.pbm")))

M-x foo

This displays the image with emacs 25, but not with emacs 26.0.90:
there is just a small bounding box (smaller than the image) where
the image should be displayed.  It is my understanding that pbm
images do not depend on external libraries.  (Anyway, I built emacs
25 on the same machine without problems.)


In GNU Emacs 26.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2017-10-13 built on regnitz
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:	Ubuntu 16.04.3 LTS

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LCMS2

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: 
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  display-time-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, Andy Moreton <andrewjmoreton <at> gmail.com>
Cc: 28824-done <at> debbugs.gnu.org, Roland Winkler <winkler <at> gnu.org>
Subject: Re: bug#28824: 26.0.90; display of pbm images broken?
Date: Mon, 16 Oct 2017 01:30:07 -0700

[Message part 4 (text/plain, inline)]

Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton <at> gmail.com>
>> Date: Sun, 15 Oct 2017 18:42:27 +0100
>>
>> Eli can decide if reverting the previous "unsigned char" -> "char"
>> changes is a better fix.
> 
> Looks like going back to unsigned should be cleaner, but I'd like to
> hear what Paul thinks.

Andy's fixes look good to me. Going back to unsigned would result in several 
pointer casts that are more dangerous than converting to unsigned. They can be 
further improved by encapsulating this stuff into a function, and I installed 
the attached (the second one is Andy's other fix, which I installed in his name).

I looked for related bugs in image.c (i.e., caused by my earlier patch) and did 
not find any.

[0001-Fix-regression-in-display-of-PPM-images.patch (text/x-patch, attachment)]

[0002-Don-t-reject-PBM-header-whitespace-unnecessarily.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.