From unknown Fri Jun 20 07:19:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28817 <28817@debbugs.gnu.org> To: bug#28817 <28817@debbugs.gnu.org> Subject: Status: incorrect NEWS entry about vc-state faces Reply-To: bug#28817 <28817@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:19:32 +0000 retitle 28817 incorrect NEWS entry about vc-state faces reassign 28817 emacs submitter 28817 charles@aurox.ch (Charles A. Roelli) severity 28817 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 13 14:29:33 2017 Received: (at submit) by debbugs.gnu.org; 13 Oct 2017 18:29:33 +0000 Received: from localhost ([127.0.0.1]:38374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34i9-0000hS-Oe for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34i5-0000h9-1n for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e34hv-0003ge-Tr for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e34hv-0003gZ-Qj for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e34hr-0007XZ-OY for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:29:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e34hm-0003VC-Qw for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:29:11 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:59166) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e34hm-0003TU-Hm for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:29:06 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 6DB6C2256A for ; Fri, 13 Oct 2017 18:22:23 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1507918939; x=1508782940; bh=f6fOBhlPNPRPNYVp/opw5cl6Q+orOZHqeRj jP6ADhc0=; b=HsUapC9H6q93AqZI2A/3fzNvV3iMn1a6louDZQktQwJdKzhz84W LpNaOET2gqXqLUtzYrG9zRlTRBfhP0Sycj/9U37xMJSaxdfY94ptU5hi+pCHBzk/ zD+U9gT2jvofuXXKGqwmZjV8srnNZx0cC2X6qte+ywDGJP1Jfu4PUa90= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CPcoBnbW9BjU for ; Fri, 13 Oct 2017 18:22:19 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id E9BD822564 for ; Fri, 13 Oct 2017 18:22:17 +0000 (UTC) Date: Fri, 13 Oct 2017 20:28:44 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: incorrect NEWS entry about vc-state faces X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) In the 26.0.90 NEWS file we have: *** The VC state indicator in the mode line now defaults to more colorful faces to make it more obvious to the user what the state is. See the 'vc-faces' customization group. which was added in these commits: * | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator commit 65fa442f2bae42d3f9b06264ca432073ee3197c3 Author: Lars Ingebrigtsen Date: Tue Mar 1 14:31:35 2016 +1100 Add a NEWS entry for the colorful VC indicator * | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b Author: Lars Ingebrigtsen Date: Tue Mar 1 14:25:27 2016 +1100 Use colors in the VC mode lines * lisp/vc/vc-hooks.el: Make the mode line faces default to using colors to more clearly tell the user what the status is. The NEWS entry commit seems to have made it to Emacs 26, but the mode line faces are still the same as in Emacs 25. Looks like commit 2621c29 got lost somehow. Also, not sure why this group is defined (in vc-hooks.el): (defgroup vc-state-faces nil "Faces used in the mode line by the VC state indicator." :group 'vc-faces :group 'mode-line :version "25.1") then never used. It looks like the vc-state-*/vc-*-state faces are meant to inherit from it, but it's not clear. It also makes the customization buffers confusing. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 13 14:42:27 2017 Received: (at 28817) by debbugs.gnu.org; 13 Oct 2017 18:42:27 +0000 Received: from localhost ([127.0.0.1]:38393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34ue-00013s-6f for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:42:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34uZ-00013c-38 for 28817@debbugs.gnu.org; Fri, 13 Oct 2017 14:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e34uP-0003Dk-QX for 28817@debbugs.gnu.org; Fri, 13 Oct 2017 14:42:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e34uP-0003Df-NG; Fri, 13 Oct 2017 14:42:09 -0400 Received: from [176.228.60.248] (port=2897 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e34uO-0007Tt-C1; Fri, 13 Oct 2017 14:42:09 -0400 Date: Fri, 13 Oct 2017 21:41:55 +0300 Message-Id: <83fuamkhzg.fsf@gnu.org> From: Eli Zaretskii To: charles@aurox.ch (Charles A. Roelli) In-reply-to: (charles@aurox.ch) Subject: Re: bug#28817: incorrect NEWS entry about vc-state faces References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28817 Cc: 28817@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Fri, 13 Oct 2017 20:28:44 +0200 > From: charles@aurox.ch (Charles A. Roelli) > > * | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator > commit 65fa442f2bae42d3f9b06264ca432073ee3197c3 > Author: Lars Ingebrigtsen > Date: Tue Mar 1 14:31:35 2016 +1100 > > Add a NEWS entry for the colorful VC indicator > > * | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines > commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b > Author: Lars Ingebrigtsen > Date: Tue Mar 1 14:25:27 2016 +1100 > > Use colors in the VC mode lines > > * lisp/vc/vc-hooks.el: Make the mode line faces default to > using colors to more clearly tell the user what the status is. > > The NEWS entry commit seems to have made it to Emacs 26, but the mode > line faces are still the same as in Emacs 25. Looks like commit > 2621c29 got lost somehow. Some merge snafu, I suppose: this was merged from the emacs-25 branch. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 16 10:34:36 2017 Received: (at 28817) by debbugs.gnu.org; 16 Oct 2017 14:34:36 +0000 Received: from localhost ([127.0.0.1]:43943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e46TQ-0000hV-Qb for submit@debbugs.gnu.org; Mon, 16 Oct 2017 10:34:36 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:54852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e46TM-0000hF-4D for 28817@debbugs.gnu.org; Mon, 16 Oct 2017 10:34:31 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id A08F522578 for <28817@debbugs.gnu.org>; Mon, 16 Oct 2017 14:27:40 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1508164056; x=1509028057; bh=+2bhkb4dZNynm QjwxwolkeqXwwpxelodxHKwOeco+GA=; b=hyBepMsDFrg4lR8GJStT3zb8GECAV sCUX1jVDxrNaI7soDnGTNKadv4KNwFyU4pcD1ZlTV32UFXm+3wjsfYNlKPzRZsDb T1FI+synBw/9UUstfOuls9YQPGz8glHa0ypbpkPKO7tUtprOgXSITpC/1kf1hHz3 7X6H79R3w33DJc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id c4Xl9rDtaVhD for <28817@debbugs.gnu.org>; Mon, 16 Oct 2017 14:27:36 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 928CC22567; Mon, 16 Oct 2017 14:27:35 +0000 (UTC) Date: Mon, 16 Oct 2017 16:34:17 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Eli Zaretskii In-reply-to: <83fuamkhzg.fsf@gnu.org> (message from Eli Zaretskii on Fri, 13 Oct 2017 21:41:55 +0300) Subject: Re: bug#28817: incorrect NEWS entry about vc-state faces References: <83fuamkhzg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28817 Cc: 28817@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Date: Fri, 13 Oct 2017 21:41:55 +0300 > From: Eli Zaretskii > CC: 28817@debbugs.gnu.org > Reply-to: Eli Zaretskii > > > Date: Fri, 13 Oct 2017 20:28:44 +0200 > > From: charles@aurox.ch (Charles A. Roelli) > > > > * | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator > > commit 65fa442f2bae42d3f9b06264ca432073ee3197c3 > > Author: Lars Ingebrigtsen > > Date: Tue Mar 1 14:31:35 2016 +1100 > > > > Add a NEWS entry for the colorful VC indicator > > > > * | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines > > commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b > > Author: Lars Ingebrigtsen > > Date: Tue Mar 1 14:25:27 2016 +1100 > > > > Use colors in the VC mode lines > > > > * lisp/vc/vc-hooks.el: Make the mode line faces default to > > using colors to more clearly tell the user what the status is. > > > > The NEWS entry commit seems to have made it to Emacs 26, but the mode > > line faces are still the same as in Emacs 25. Looks like commit > > 2621c29 got lost somehow. > > Some merge snafu, I suppose: this was merged from the emacs-25 branch. I'm not sure I understand: the commit was made in the master branch. See: https://lists.gnu.org/archive/html/emacs-diffs/2016-02/msg00709.html Ah, I think I understand now. Commit 2621c29 was reverted later: * | | | | | | | | | | | | | | | | | 7882dc6..: John Wiegley 2016-03-06 Revert "Use colors in the VC mode lines" commit 7882dc625e1ec562fcd0e1b743ef11b160cae18e Author: John Wiegley Date: Sun Mar 6 12:51:44 2016 -0800 Revert "Use colors in the VC mode lines" This reverts commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b. and I can't find a revert for commit 65fa442 (the NEWS entry). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 21 14:39:29 2017 Received: (at 28817-done) by debbugs.gnu.org; 21 Nov 2017 19:39:29 +0000 Received: from localhost ([127.0.0.1]:51425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHEOD-0002Vr-L6 for submit@debbugs.gnu.org; Tue, 21 Nov 2017 14:39:29 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:49965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHEO7-0002VY-GD for 28817-done@debbugs.gnu.org; Tue, 21 Nov 2017 14:39:23 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 0D3AE225C8 for <28817-done@debbugs.gnu.org>; Tue, 21 Nov 2017 19:31:57 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1511292715; x=1512156716; bh=oBg3uo02Ht5i0 B7hTrwGDHL8xnx605dePGxaITke8z0=; b=dHyUFxorTv8fFqaTEt35/OjapMY7G 6Ny9rjP7N9VUqqvzwlWHufPcpXGxQ1BejUouvDJEJjvu9W5v7zjHX0LTaof7eVcP nv3306SUEVr0ACadOXdTt0AMTYUnzj2upz7oCxJ88dREUPLjlTkL2/kgLqBrL3qS dJUfQWXhplia9E= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JIMbi81Egvys for <28817-done@debbugs.gnu.org>; Tue, 21 Nov 2017 19:31:55 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 934BF225C3; Tue, 21 Nov 2017 19:31:54 +0000 (UTC) Date: Tue, 21 Nov 2017 20:40:20 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: charles@aurox.ch (Charles A. Roelli) In-reply-to: (charles@aurox.ch) Subject: Re: bug#28817: incorrect NEWS entry about vc-state faces References: <83fuamkhzg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28817-done Cc: eliz@gnu.org, 28817-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Date: Mon, 16 Oct 2017 16:34:17 +0200 > From: charles@aurox.ch (Charles A. Roelli) > > > Date: Fri, 13 Oct 2017 21:41:55 +0300 > > From: Eli Zaretskii > > CC: 28817@debbugs.gnu.org > > Reply-to: Eli Zaretskii > > > > > Date: Fri, 13 Oct 2017 20:28:44 +0200 > > > From: charles@aurox.ch (Charles A. Roelli) > > > > > > * | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator > > > commit 65fa442f2bae42d3f9b06264ca432073ee3197c3 > > > Author: Lars Ingebrigtsen > > > Date: Tue Mar 1 14:31:35 2016 +1100 > > > > > > Add a NEWS entry for the colorful VC indicator > > > > > > * | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines > > > commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b > > > Author: Lars Ingebrigtsen > > > Date: Tue Mar 1 14:25:27 2016 +1100 > > > > > > Use colors in the VC mode lines > > > > > > * lisp/vc/vc-hooks.el: Make the mode line faces default to > > > using colors to more clearly tell the user what the status is. > > > > > > The NEWS entry commit seems to have made it to Emacs 26, but the mode > > > line faces are still the same as in Emacs 25. Looks like commit > > > 2621c29 got lost somehow. > > > > Some merge snafu, I suppose: this was merged from the emacs-25 branch. > > I'm not sure I understand: the commit was made in the master branch. > See: > > https://lists.gnu.org/archive/html/emacs-diffs/2016-02/msg00709.html > > Ah, I think I understand now. Commit 2621c29 was reverted later: > > * | | | | | | | | | | | | | | | | | 7882dc6..: John Wiegley 2016-03-06 Revert "Use colors in the VC mode lines" > commit 7882dc625e1ec562fcd0e1b743ef11b160cae18e > Author: John Wiegley > Date: Sun Mar 6 12:51:44 2016 -0800 > > Revert "Use colors in the VC mode lines" > > This reverts commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b. > > and I can't find a revert for commit 65fa442 (the NEWS entry). It's fixed, closing. commit 11db253c082a06629d9e8baf30339b6024a0af4f Author: Charles A. Roelli Date: Tue Nov 21 20:36:19 2017 +0100 Remove incorrect NEWS item about VC state indicator (Bug#28817) * etc/NEWS (VC and related modes): Remove news item about the VC state indicator. This should have been done with commit 7882dc6 of 2016-03-06 'Revert "Use colors in the VC mode lines"'. From unknown Fri Jun 20 07:19:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Dec 2017 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator