GNU bug report logs - #28815
[PATCH 0/2] Update emacs-ess

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28815 in the body.
You can then email your comments to 28815 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: guix-patches <at> gnu.org
Cc: Kyle Meyer <kyle <at> kyleam.com>
Subject: [PATCH 0/2] Update emacs-ess
Date: Fri, 13 Oct 2017 12:26:19 -0400

  gnu: Add emacs-julia-mode.
  gnu: emacs-ess: Update to 16.10.

 gnu/packages/emacs.scm | 52 +++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 47 insertions(+), 5 deletions(-)

-- 
2.14.2

Message #8 received at 28815 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: 28815 <at> debbugs.gnu.org
Cc: Kyle Meyer <kyle <at> kyleam.com>
Subject: [PATCH 1/2] gnu: Add emacs-julia-mode.
Date: Fri, 13 Oct 2017 12:28:36 -0400

* gnu/packages/emacs.scm (emacs-julia-mode): New variable.
---

This definition hard codes the commit because the package version hasn't
changed since it was initially added in 2014.  I've opened an issue to see if
they'll tag a release:

    https://github.com/JuliaEditorSupport/julia-emacs/issues/46

 gnu/packages/emacs.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 24dfd97ff..a4812ee33 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3321,6 +3321,38 @@ that highlights non-conforming text.  The subset of the English language called
 E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
       (license license:gpl3+))))
 
+(define-public emacs-julia-mode
+  (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
+        (revision "1"))
+    (package
+      (name "emacs-julia-mode")
+      (version (string-append "0.3-" revision "." (string-take commit 8)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/JuliaEditorSupport/julia-emacs.git")
+               (commit commit)))
+         (file-name (string-append name "-" version "-checkout"))
+         (sha256
+          (base32
+           "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-before 'install 'check
+             (lambda _
+               (zero? (system* "emacs" "-batch"
+                               "-l" "julia-mode.el"
+                               "-l" "julia-mode-tests.el"
+                               "-f" "ert-run-tests-batch-and-exit")))))))
+      (home-page "https://github.com/JuliaEditorSupport/julia-emacs")
+      (synopsis "Major mode for Julia")
+      (description "This Emacs package provides a mode for the Julia
+programming language.")
+      (license license:expat))))
+
 (define-public emacs-ess
   (package
     (name "emacs-ess")
-- 
2.14.2

Message #11 received at 28815 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: 28815 <at> debbugs.gnu.org
Cc: Kyle Meyer <kyle <at> kyleam.com>
Subject: [PATCH 2/2] gnu: emacs-ess: Update to 16.10.
Date: Fri, 13 Oct 2017 12:28:37 -0400

* gnu/packages/emacs.scm (emacs-ess): Update to 16.10.
[arguments]: Enable tests.
[source]: Add snippet to prevent build process from trying to download
external julia-mode.el.
---

Despite its build process downloading julia-mode.el, ESS doesn't seem to
require julia-mode.el for building or running, so I haven't included it as an
input.  Should we include it anyway?

 gnu/packages/emacs.scm | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a4812ee33..d1d80488c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3356,19 +3356,26 @@ programming language.")
 (define-public emacs-ess
   (package
     (name "emacs-ess")
-    (version "16.04")
+    (version "16.10")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://ess.r-project.org/downloads/ess/ess-"
                                   version ".tgz"))
               (sha256
                (base32
-                "0w7mbbajn377gdmvnd21mpyr368b2ia46gq6cb99y4y5rspf9pcg"))))
+                "04m8lwp3ylh2vl7k2bjjs7mxbm64j4sdckqpvnm9k0qhaqf02pjk"))
+              (modules '((guix build utils)))
+              (snippet
+               '(begin
+                  ;; Stop ESS from trying to bundle an external julia-mode.el.
+                  (substitute* "lisp/Makefile"
+                    (("^\tjulia-mode.elc\\\\\n") "")
+                    (("^all: \\$\\(ELC\\) ess-custom.el julia-mode.el")
+                     "all: $(ELC) ess-custom.el"))))))
     (build-system gnu-build-system)
     (arguments
      (let ((base-directory "/share/emacs/site-lisp/guix.d/ess"))
-       `(#:tests? #f ; There is no test suite.
-         #:make-flags (list (string-append "PREFIX=" %output)
+       `(#:make-flags (list (string-append "PREFIX=" %output)
                             (string-append "ETCDIR=" %output "/"
                                            ,base-directory "/etc")
                             (string-append "LISPDIR=" %output "/"
@@ -3384,7 +3391,10 @@ programming language.")
            ;; FIXME: the texlive-union insists on regenerating fonts.  It stores
            ;; them in HOME, so it needs to be writeable.
            (add-before 'build 'set-HOME
-             (lambda _ (setenv "HOME" "/tmp") #t))))))
+             (lambda _ (setenv "HOME" "/tmp") #t))
+           (replace 'check
+             (lambda _
+               (zero? (system* "make" "test"))))))))
     (inputs
      `(("emacs" ,emacs-minimal)
        ("r-minimal" ,r-minimal)))
-- 
2.14.2

Message #14 received at 28815 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 28815 <at> debbugs.gnu.org
Subject: Re: [bug#28815] [PATCH 1/2] gnu: Add emacs-julia-mode.
Date: Sat, 14 Oct 2017 16:49:55 +0200

[Message part 1 (text/plain, inline)]

Kyle Meyer <kyle <at> kyleam.com> skribis:

> * gnu/packages/emacs.scm (emacs-julia-mode): New variable.
> ---
>
> This definition hard codes the commit because the package version hasn't
> changed since it was initially added in 2014.  I've opened an issue to see if
> they'll tag a release:
>
>     https://github.com/JuliaEditorSupport/julia-emacs/issues/46

Makes sense.

I’ve committed with this comment:

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index c8d0cac30..e8b44dcff 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3322,6 +3322,8 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
       (license license:gpl3+))))
 
 (define-public emacs-julia-mode
+  ;; XXX: Upstream version remained stuck at 0.3.  See
+  ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
   (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
         (revision "1"))
     (package

[Message part 3 (text/plain, inline)]

Thanks,
Ludo’.

Message #19 received at 28815-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 28815-done <at> debbugs.gnu.org
Subject: Re: [bug#28815] [PATCH 2/2] gnu: emacs-ess: Update to 16.10.
Date: Sat, 14 Oct 2017 16:53:52 +0200

Hi,

Kyle Meyer <kyle <at> kyleam.com> skribis:

> * gnu/packages/emacs.scm (emacs-ess): Update to 16.10.
> [arguments]: Enable tests.
> [source]: Add snippet to prevent build process from trying to download
> external julia-mode.el.

Applied!

> Despite its build process downloading julia-mode.el, ESS doesn't seem to
> require julia-mode.el for building or running, so I haven't included it as an
> input.  Should we include it anyway?

Dunno!  If you found that it works well like this, that’s probably
fine.  We can always revisit it later if needed.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.