GNU bug report logs - #28809
26.0.90; Error running timer ‘image-dired-thumb-queue-run’

Previous Next

Full log

Message #16 received at 28809-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: rotim.davor <at> gmail.com, 28809-done <at> debbugs.gnu.org
Subject: Re: bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’
Date: Mon, 16 Oct 2017 19:28:00 +0300

> Date: Sat, 14 Oct 2017 17:24:59 -0400
> From: Mark Oteiza <mvoteiza <at> udel.edu>
> Cc: Davor Rotim <rotim.davor <at> gmail.com>, 28809 <at> debbugs.gnu.org
> 
> On 13/10/17 at 05:33pm, Eli Zaretskii wrote:
> > > From: Davor Rotim <rotim.davor <at> gmail.com>
> > > Date: Fri, 13 Oct 2017 15:33:24 +0200
> > > 
> > > Started with emacs -Q, opened a dired buffer, navigated to an image and pressed C-t .
> > > on it (image-dired-display-thumb) to generate a thumbnail. That leaves me with only an error message:
> > > 
> > > Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor" 1505334534.0059688)
> > 
> > Mark, could you please look at this?  You changed the code to use
> > floor instead of rounding via format "%.0f", but floor returns an
> > Emacs integer which can overflow on 32-bit hosts for large time
> > values, as happens here.  I think we should use ffloor instead, and if
> > that produces a decimal point, eliminate it with "%.0f" format.
> 
> What you propose sounds fine to me.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.