GNU bug report logs - #28804
[PATCH] gnu: Add emacs-graphviz-dot-mode.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28804: closed ([PATCH] gnu: Add emacs-graphviz-dot-mode.)
Date: Fri, 13 Oct 2017 19:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 13 Oct 2017 20:42:42 +0100
with message-id <20171013204242.7d5423b1 <at> cbaines.net>
and subject line Re: [bug#28804] [PATCH] gnu: Add emacs-graphviz-dot-mode.
has caused the debbugs.gnu.org bug report #28804,
regarding [PATCH] gnu: Add emacs-graphviz-dot-mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28804: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28804
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-graphviz-dot-mode.
Date: Fri, 13 Oct 2017 06:33:42 +0100

* gnu/packages/emacs.scm (graphviz-dot-mode): New variable.
---
 gnu/packages/emacs.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index b29436154..d3f87fdc4 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1245,6 +1245,55 @@ written in the Go programming language.")
 Maps directly inside Emacs.")
     (license license:gpl3+)))
 
+(define-public emacs-graphviz-dot-mode
+  (let ((commit "fdaabbcc95d9156e3dadc84f81a4750c5b692580")
+        (revision "1"))
+    (package
+      (name "emacs-graphviz-dot-mode")
+      (version (string-append "0.3.10-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/ppareit/graphviz-dot-mode.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "1s1qh5r0xp6hs0rl5yz5mkmjhpg04bh449c7vgjbb1pjsl1dl714"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-before 'install 'make-info
+             (lambda* (#:key inputs #:allow-other-keys)
+               (with-directory-excursion "texinfo"
+                 (substitute* "Makefile"
+                   (("\\/usr\\/bin\\/gzip")
+                    (string-append (assoc-ref inputs "gzip") "/bin/gzip")))
+                 (zero?
+                  (system* "make"
+                           "clean"
+                           "info"
+                           (string-append "TEXINFODIR="
+                                          (assoc-ref inputs "texinfo")
+                                          "/bin"))))))
+           (add-after 'install 'install-info
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out  (assoc-ref outputs "out"))
+                      (info (string-append out "/share/info")))
+                 (install-file "texinfo/graphviz-dot-mode.info.gz" info)
+                 #t))))))
+      (native-inputs
+       `(("texinfo" ,texinfo)
+         ("gzip" ,gzip)))
+      (home-page "http://ppareit.github.com/graphviz-dot-mode")
+      (synopsis "Major mode for editing Graphviz Dot files")
+      (description
+       "This Emacs packages helps you to create .dot or .gv files using the
+dot syntax, and use Graphviz to convert these files to diagrams.")
+      (license license:gpl3+))))
+
 (define-public emacs-mmm-mode
   (package
     (name "emacs-mmm-mode")
-- 
2.14.2

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28804-done <at> debbugs.gnu.org
Subject: Re: [bug#28804] [PATCH] gnu: Add emacs-graphviz-dot-mode.
Date: Fri, 13 Oct 2017 20:42:42 +0100

[Message part 4 (text/plain, inline)]

On Fri, 13 Oct 2017 10:52:05 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > * gnu/packages/emacs.scm (graphviz-dot-mode): New variable.  
> 
> [...]
> 
> > +      (synopsis "Major mode for editing Graphviz Dot files")
> > +      (description
> > +       "This Emacs packages helps you to create .dot or .gv files
> > using the  
>                                                    ^        ^
> I’d use @file here but otherwise LGTM.

Awesome, I've updated and pushed. Thanks for the prompt review Ludo :D

[Message part 5 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.