GNU bug report logs - #28803
[PATCH] Fixed compiler warnings for advised functions.

Previous Next

Package: emacs;

Reported by: John Williams <jrw <at> pobox.com>

Date: Thu, 12 Oct 2017 23:04:02 UTC

Severity: minor

Tags: confirmed, fixed, patch

Merged with 14860, 27630

Found in version 26.0.50

Fixed in version 26.1

Done: Noam Postavsky <npostavs <at> users.sourceforge.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: John Williams <jrw <at> pobox.com>
Cc: 28803 <at> debbugs.gnu.org
Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions.
Date: Sun, 22 Oct 2017 09:04:01 -0400
John Williams <jrw <at> pobox.com> writes:

> Hooray, my first official contribution to Emacs! Now I have code—not
> much, but some—in both Emacs and Vim, which I have to think is pretty
> rare.

Congrats :)

> BTW, is posting to this list really the best way to send patches? At
> my job, all changes go through a code review tool similar to Gerrit,
> with code uploaded using a command analogous to "git push", so
> sending a patch as an email attachment feels clumsy and
> anachronistic.

For now at least yes.  There has been some grumbling from others about
the "anachronistic" methods, but nothing much has come of it as of yet.

I have some commands in my init file for smoothing the process of
sending and receiving patches between the bug list and my git repo, but
they're dependent of magit, and I'm still working out the kinks.




This bug report was last modified 7 years and 272 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.