From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: John Williams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Oct 2017 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 28803@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150784939729173 (code B ref -1); Thu, 12 Oct 2017 23:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Oct 2017 23:03:17 +0000 Received: from localhost ([127.0.0.1]:36466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2mVZ-0007aS-8l for submit@debbugs.gnu.org; Thu, 12 Oct 2017 19:03:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2mVX-0007aD-48 for submit@debbugs.gnu.org; Thu, 12 Oct 2017 19:03:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2mVQ-00007X-5B for submit@debbugs.gnu.org; Thu, 12 Oct 2017 19:03:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56239) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e2mVQ-00007S-0J for submit@debbugs.gnu.org; Thu, 12 Oct 2017 19:03:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2mVN-0005Pq-Ub for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 19:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2mVM-00005Z-5R for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 19:03:05 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34968) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2mVL-0008WM-NZ for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 19:03:04 -0400 Received: by mail-wm0-x244.google.com with SMTP id b189so4727735wmd.2 for ; Thu, 12 Oct 2017 16:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=WS4nSTHdSK+1Z9OzUiV8K455PLfs5lJYoZHaHNbO9zA=; b=D5m/geswyZgGAQnu9RM+cZ6PQGeSuwQuINgPSzgKwGCZYnyyQgv0a2OcrBEcVNev/D fHqhH/o4kvsQAkHqW4vZpaUrzupkw/TeSac1HU4MAdPPC/+wei3fc3n+hfz/AkI4VKvr fIIIPxOAWeiX/GaAl+hP+/0sa7IvqQiAQGVw2/G4unaHdOfdtfper7TMwfiQ7B9RJNVy 3EnxnlJNO7ePCiwq1L11EVl3vJNsg5BZ5SLDzzHwla7ikMxYpukAfZpDGyrbJzt8qIhk 6mxXo+rqA/aMvvbn8W5PnHmPgeKPfxPrPKrv3996HjMeKacH27UDEggzu14butKVyqZL dMHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=WS4nSTHdSK+1Z9OzUiV8K455PLfs5lJYoZHaHNbO9zA=; b=uQJFtaI0TzOa6JMEcTNWna93HSyUx+3HhRlMAAwRvgv+U5EdvbL7qtJkJgQI9/Mk7u 0nPi6Syzs9YvPbnlSSgfMOdvkXYhn0bboHQommctpgJikPh3f/OlecjM1XIFG8RcZyo4 VZrGE3J9ALgvEIjb8Gj3axokj4vIk8amW8zGRqTjFrJMTNktdIWggNE4D5JrfdiPet+7 cQS2YetbUHfi2seiJWZCLQRO1shvqwvZSW7l/01kY5vdAE+C4Ph6crvObB2wTEtX4vk3 ZKi0wX4S/8prqlXcYKjyQci6oljLSn6AqmmJV1FcXXGBFiVLIgHd8DbgG3oDaMGNuvDz aTxg== X-Gm-Message-State: AMCzsaXgKK5hR/YFrwGxhl1NT32DfHVbaDARq+Ipnpt7iPyV8MNKHUFw L9eQWZWYSEJ6cu+n7iMBjfErey2WbglLgtq4E5ukNg== X-Google-Smtp-Source: AOwi7QDJ64dCWjm3CQAILvyB2+xbmh8ANhVZZJb+Clu8Pl0AGN/ZIzgptHnrWESAK3/4FKPlIO3oWXmyS99Ld6nso4E= X-Received: by 10.223.148.162 with SMTP id 31mr3719629wrr.149.1507849380704; Thu, 12 Oct 2017 16:03:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.111.93 with HTTP; Thu, 12 Oct 2017 16:02:39 -0700 (PDT) From: John Williams Date: Thu, 12 Oct 2017 16:02:39 -0700 X-Google-Sender-Auth: 2sP1DtZMhmir-siTbyCAZz8QBsw Message-ID: Content-Type: multipart/mixed; boundary="94eb2c0d27a8b652c5055b618a0f" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --94eb2c0d27a8b652c5055b618a0f Content-Type: text/plain; charset="UTF-8" --94eb2c0d27a8b652c5055b618a0f Content-Type: text/x-patch; charset="UTF-8"; name="0001-Fixed-compiler-warnings-for-advised-functions.patch" Content-Disposition: attachment; filename="0001-Fixed-compiler-warnings-for-advised-functions.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j8p2kfdg0 RnJvbSAzNTg5ZWVhOTMyZjVkZWMwMTI1YTNkY2QxNjA2MTM4NWMwZjMwYTVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIFdpbGxpYW1zIDxqcndAcG9ib3guY29tPgpEYXRlOiBU aHUsIDEyIE9jdCAyMDE3IDE1OjU3OjM3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4ZWQgY29t cGlsZXIgd2FybmluZ3MgZm9yIGFkdmlzZWQgZnVuY3Rpb25zLgoKQWRkZWQgdGhlIGZ1bmN0aW9u IGBnZXQtYWR2ZXJ0aXNlZC1jYWxsaW5nLWNvbnZlbnRpb24nLCB3aGljaCBpcwptb3N0bHkgY29w aWVkIGZyb20gYGhlbHAtZnVuY3Rpb24tYXJnbGlzdCcuICBDaGFuZ2VkCmBoZWxwLWZ1bmN0aW9u LWFyZ2xpc3QnIHRvIHVzZSBgZ2V0LWFkdmVydGlzZWQtY2FsbGluZy1jb252ZW50aW9uJy4KQ2hh bmdlZCBuYWR2aWNlLmVsIHRvIHVzZSBgZ2V0LWFkdmVydGlzZWQtY2FsbGluZy1jb252ZW50aW9u JyBpbnN0ZWFkCm9mIGRpcmVjdGx5IHF1ZXJ5aW5nIGBhZHZlcnRpc2VkLXNpZ25hdHVyZS10YWJs ZScuICBBZGRlZCBhIHVuaXQgdGVzdAp0byBzaG93IHRoYXQgcHJldmlvdXNseS1hZHZpc2VkIGZ1 bmN0aW9ucyBub3cgY29tcGlsZSB3aXRob3V0Cndhcm5pbmdzLgotLS0KIGxpc3AvZW1hY3MtbGlz cC9ieXRlLXJ1bi5lbCAgICAgIHwgNzYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLQogbGlzcC9lbWFjcy1saXNwL25hZHZpY2UuZWwgICAgICAgfCAgNyArKy0tCiBsaXNw L2hlbHAuZWwgICAgICAgICAgICAgICAgICAgICB8IDUyICsrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogdGVzdC9hdXRvbWF0ZWQvYnl0ZWNvbXAtdGVzdHMuZWwgfCAxMSArKysrKy0KIHRlc3Qv YXV0b21hdGVkL2NsLWxpYi10ZXN0cy5lbCAgIHwgIDQgKy0tCiA1IGZpbGVzIGNoYW5nZWQsIDk0 IGluc2VydGlvbnMoKyksIDU2IGRlbGV0aW9ucygtKQogbW9kZSBjaGFuZ2UgMTAwNjQ0ID0+IDEw MDc1NSBsaXNwL2VtYWNzLWxpc3AvYnl0ZS1ydW4uZWwKIG1vZGUgY2hhbmdlIDEwMDY0NCA9PiAx MDA3NTUgbGlzcC9lbWFjcy1saXNwL25hZHZpY2UuZWwKIG1vZGUgY2hhbmdlIDEwMDY0NCA9PiAx MDA3NTUgbGlzcC9oZWxwLmVsCiBtb2RlIGNoYW5nZSAxMDA2NDQgPT4gMTAwNzU1IHRlc3QvYXV0 b21hdGVkL2J5dGVjb21wLXRlc3RzLmVsCiBtb2RlIGNoYW5nZSAxMDA2NDQgPT4gMTAwNzU1IHRl c3QvYXV0b21hdGVkL2NsLWxpYi10ZXN0cy5lbAoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlz cC9ieXRlLXJ1bi5lbCBiL2xpc3AvZW1hY3MtbGlzcC9ieXRlLXJ1bi5lbApvbGQgbW9kZSAxMDA2 NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IGRlNjc1NWE0MWM3Li45NzJhMDY5MDg0ZgotLS0gYS9s aXNwL2VtYWNzLWxpc3AvYnl0ZS1ydW4uZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2J5dGUtcnVu LmVsCkBAIC0zMjUsMTMgKzMyNSw4MyBAQCBkZWZzdWJzdAogCiAoZGVmdmFyIGFkdmVydGlzZWQt c2lnbmF0dXJlLXRhYmxlIChtYWtlLWhhc2gtdGFibGUgOnRlc3QgJ2VxIDp3ZWFrbmVzcyAna2V5 KSkKIAorKGRlZnVuIGdldC1hZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiAoZnVuY3Rpb24g Jm9wdGlvbmFsIHByZXNlcnZlLW5hbWVzKQorICAiUmV0dXJuIGEgZm9ybWFsIGFyZ3VtZW50IGxp c3QgZm9yIHRoZSBmdW5jdGlvbiBGVU5DVElPTi4KK0lmIFBSRVNFUlZFLU5BTUVTIGlzIG5vbi1u aWwsIHJldHVybiBhIGZvcm1hbCBhcmdsaXN0IHRoYXQgdXNlcwordGhlIHNhbWUgbmFtZXMgYXMg dXNlZCBpbiB0aGUgb3JpZ2luYWwgc291cmNlIGNvZGUsIHdoZW4gcG9zc2libGUuCisKK0lmIHRo ZSBmdW5jdGlvbiBkZWZpbml0aW9uIGlzIGFuIGF1dG9sb2FkLCByZXR1cm4gJ2F1dG9sb2FkLgor T3RoZXJ3aXNlLCBpZiB0aGUgYXJndW1lbnQgbGlzdCBpcyB1bmF2YWlsYWJsZSwgcmV0dXJuIHQu IgorCisgIChsZXQqICgoZGVmCisgICAgICAgICAgOzsgSGFuZGxlIHN5bWJvbHMgYWxpYXNlZCB0 byBvdGhlciBzeW1ib2xzLgorICAgICAgICAgIChpbmRpcmVjdC1mdW5jdGlvbiBmdW5jdGlvbikp CisgICAgICAgICAoc2lnIChnZXRoYXNoIGRlZiBhZHZlcnRpc2VkLXNpZ25hdHVyZS10YWJsZSB0 KSkpCisgICAgKGlmIChsaXN0cCBzaWcpCisgICAgICAgIHNpZworICAgICAgOzsgQWR2aWNlIHdy YXBwZXJzIGhhdmUgImNhdGNoIGFsbCIgYXJncywgc28gZmV0Y2ggdGhlIGFjdHVhbCB1bmRlcmx5 aW5nCisgICAgICA7OyBmdW5jdGlvbiB0byBmaW5kIHRoZSByZWFsIGFyZ3VtZW50cy4KKyAgICAg ICh3aGlsZSAoYWR2aWNlLS1wIGRlZikgKHNldHEgZGVmIChhZHZpY2UtLWNkciBkZWYpKSkKKyAg ICAgIDs7IElmIGRlZmluaXRpb24gaXMgYSBtYWNybywgZmluZCB0aGUgZnVuY3Rpb24gaW5zaWRl IGl0LgorICAgICAgKGlmIChlcSAoY2FyLXNhZmUgZGVmKSAnbWFjcm8pIChzZXRxIGRlZiAoY2Ry IGRlZikpKQorICAgICAgKGNvbmQKKyAgICAgICAoKGFuZCAoYnl0ZS1jb2RlLWZ1bmN0aW9uLXAg ZGVmKSAobGlzdHAgKGFyZWYgZGVmIDApKSkgKGFyZWYgZGVmIDApKQorICAgICAgICgoZXEgKGNh ci1zYWZlIGRlZikgJ2xhbWJkYSkgKG50aCAxIGRlZikpCisgICAgICAgKChlcSAoY2FyLXNhZmUg ZGVmKSAnY2xvc3VyZSkgKG50aCAyIGRlZikpCisgICAgICAgKChvciAoYW5kIChieXRlLWNvZGUt ZnVuY3Rpb24tcCBkZWYpIChpbnRlZ2VycCAoYXJlZiBkZWYgMCkpKQorICAgICAgICAgICAgKHN1 YnJwIGRlZikpCisgICAgICAgIChvciAod2hlbiBwcmVzZXJ2ZS1uYW1lcworICAgICAgICAgICAg ICAobGV0KiAoKGRvYyAoY29uZGl0aW9uLWNhc2UgbmlsIChkb2N1bWVudGF0aW9uIGRlZikgKGVy cm9yIG5pbCkpKQorICAgICAgICAgICAgICAgICAgICAgKGRvY2FyZ3MgKGlmIGRvYyAoY2FyICho ZWxwLXNwbGl0LWZ1bmRvYyBkb2MgbmlsKSkpKQorICAgICAgICAgICAgICAgICAgICAgKGFyZ2xp c3QgKGlmIGRvY2FyZ3MKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RhciAo cmVhZC1mcm9tLXN0cmluZyAoZG93bmNhc2UgZG9jYXJncykpKSkpCisgICAgICAgICAgICAgICAg ICAgICAodmFsaWQgdCkpCisgICAgICAgICAgICAgICAgOzsgQ2hlY2sgdmFsaWRpdHkuCisgICAg ICAgICAgICAgICAgKGRvbGlzdCAoYXJnIGFyZ2xpc3QpCisgICAgICAgICAgICAgICAgICAodW5s ZXNzIChhbmQgKHN5bWJvbHAgYXJnKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChs ZXQgKChuYW1lIChzeW1ib2wtbmFtZSBhcmcpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChpZiAoZXEgKGFyZWYgbmFtZSAwKSA/JikKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAobWVtcSBhcmcgJygmcmVzdCAmb3B0aW9uYWwpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAobm90IChzdHJpbmctbWF0Y2ggIlxcLiIgbmFtZSkpKSkp CisgICAgICAgICAgICAgICAgICAgIChzZXRxIHZhbGlkIG5pbCkpKQorICAgICAgICAgICAgICAg ICh3aGVuIHZhbGlkIGFyZ2xpc3QpKSkKKyAgICAgICAgICAgIChsZXQqICgoYXJncy1kZXNjIChp ZiAobm90IChzdWJycCBkZWYpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChh cmVmIGRlZiAwKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgoYSAoc3Vi ci1hcml0eSBkZWYpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobG9naW9y IChjYXIgYSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAo bnVtYmVycCAoY2RyIGEpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChsc2ggKGNkciBhKSA4KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAobHNoIDEgNykpKSkpKQorICAgICAgICAgICAgICAgICAgIChtYXggKGxzaCBh cmdzLWRlc2MgLTgpKQorICAgICAgICAgICAgICAgICAgIChtaW4gKGxvZ2FuZCBhcmdzLWRlc2Mg MTI3KSkKKyAgICAgICAgICAgICAgICAgICAocmVzdCAobG9nYW5kIGFyZ3MtZGVzYyAxMjgpKQor ICAgICAgICAgICAgICAgICAgIChhcmdsaXN0ICgpKSkKKyAgICAgICAgICAgICAgKGRvdGltZXMg KGkgbWluKQorICAgICAgICAgICAgICAgIChwdXNoIChpbnRlcm4gKGNvbmNhdCAiYXJnIiAobnVt YmVyLXRvLXN0cmluZyAoMSsgaSkpKSkgYXJnbGlzdCkpCisgICAgICAgICAgICAgICh3aGVuICg+ IG1heCBtaW4pCisgICAgICAgICAgICAgICAgKHB1c2ggJyZvcHRpb25hbCBhcmdsaXN0KQorICAg ICAgICAgICAgICAgIChkb3RpbWVzIChpICgtIG1heCBtaW4pKQorICAgICAgICAgICAgICAgICAg KHB1c2ggKGludGVybiAoY29uY2F0ICJhcmciIChudW1iZXItdG8tc3RyaW5nICgrIDEgaSBtaW4p KSkpCisgICAgICAgICAgICAgICAgICAgICAgICBhcmdsaXN0KSkpCisgICAgICAgICAgICAgICh1 bmxlc3MgKHplcm9wIHJlc3QpIChwdXNoICcmcmVzdCBhcmdsaXN0KSAocHVzaCAncmVzdCBhcmds aXN0KSkKKyAgICAgICAgICAgICAgKG5yZXZlcnNlIGFyZ2xpc3QpKSkpCisgICAgICAgKChhbmQg KGF1dG9sb2FkcCBkZWYpIChub3QgKGVxIChudGggNCBkZWYpICdrZXltYXApKSkKKyAgICAgICAg J2F1dG9sb2FkKQorICAgICAgICh0IHQpKSkpKQorCiAoZGVmdW4gc2V0LWFkdmVydGlzZWQtY2Fs bGluZy1jb252ZW50aW9uIChmdW5jdGlvbiBzaWduYXR1cmUgX3doZW4pCiAgICJTZXQgdGhlIGFk dmVydGlzZWQgU0lHTkFUVVJFIG9mIEZVTkNUSU9OLgogVGhpcyB3aWxsIGFsbG93IHRoZSBieXRl LWNvbXBpbGVyIHRvIHdhcm4gdGhlIHByb2dyYW1tZXIgd2hlbiBzaGUgdXNlcwogYW4gb2Jzb2xl dGUgY2FsbGluZyBjb252ZW50aW9uLiAgV0hFTiBzcGVjaWZpZXMgc2luY2Ugd2hlbiB0aGUgY2Fs bGluZwotY29udmVudGlvbiB3YXMgbW9kaWZpZWQuIgotICAocHV0aGFzaCAoaW5kaXJlY3QtZnVu Y3Rpb24gZnVuY3Rpb24pIHNpZ25hdHVyZQotICAgICAgICAgICBhZHZlcnRpc2VkLXNpZ25hdHVy ZS10YWJsZSkpCitjb252ZW50aW9uIHdhcyBtb2RpZmllZC4KKworRm9yIHN5bW1ldHJ5IHdpdGgg d2l0aCBgZ2V0LWFkdmVydGlzZWQtY2FsbGluZy1jb252ZW50aW9uJywgaWYKK1NJR05BVFVSRSBp cyBub3QgYSBsaXN0LCB0aGUgYWR2ZXJ0aXNlZCBzaWduYXR1cmUgZm9yIEZVTkNUSU9OIGlzCity ZW1vdmVkLiIKKyAgKGlmIChsaXN0cCBzaWduYXR1cmUpCisgICAgICAocHV0aGFzaCAoaW5kaXJl Y3QtZnVuY3Rpb24gZnVuY3Rpb24pIHNpZ25hdHVyZQorICAgICAgICAgICAgICAgYWR2ZXJ0aXNl ZC1zaWduYXR1cmUtdGFibGUpCisgICAgKHJlbWhhc2ggKGluZGlyZWN0LWZ1bmN0aW9uIGZ1bmN0 aW9uKSBhZHZlcnRpc2VkLXNpZ25hdHVyZS10YWJsZSkpKQogCiAoZGVmdW4gbWFrZS1vYnNvbGV0 ZSAob2Jzb2xldGUtbmFtZSBjdXJyZW50LW5hbWUgJm9wdGlvbmFsIHdoZW4pCiAgICJNYWtlIHRo ZSBieXRlLWNvbXBpbGVyIHdhcm4gdGhhdCBmdW5jdGlvbiBPQlNPTEVURS1OQU1FIGlzIG9ic29s ZXRlLgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL25hZHZpY2UuZWwgYi9saXNwL2VtYWNz LWxpc3AvbmFkdmljZS5lbApvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IDVh MTAwYjc5MGYxLi4zZTVjODNhZjkwMgotLS0gYS9saXNwL2VtYWNzLWxpc3AvbmFkdmljZS5lbAor KysgYi9saXNwL2VtYWNzLWxpc3AvbmFkdmljZS5lbApAQCAtMTU3LDE0ICsxNTcsMTcgQEAgYWR2 aWNlLS1tYWtlLWludGVyYWN0aXZlLWZvcm0KIAogKGRlZnVuIGFkdmljZS0tbWFrZS0xIChieXRl LWNvZGUgc3RhY2stZGVwdGggZnVuY3Rpb24gbWFpbiBwcm9wcykKICAgIkJ1aWxkIGEgZnVuY3Rp b24gdmFsdWUgdGhhdCBhZGRzIEZVTkNUSU9OIHRvIE1BSU4uIgotICAobGV0ICgoYWR2LXNpZyAo Z2V0aGFzaCBtYWluIGFkdmVydGlzZWQtc2lnbmF0dXJlLXRhYmxlKSkKKyAgKGxldCAoKGFkdi1z aWcgKGdldC1hZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiBtYWluKSkKICAgICAgICAgKGFk dmljZQogICAgICAgICAgKGFwcGx5ICMnbWFrZS1ieXRlLWNvZGUgMTI4IGJ5dGUtY29kZQogICAg ICAgICAgICAgICAgICh2ZWN0b3IgIydhcHBseSBmdW5jdGlvbiBtYWluIHByb3BzKSBzdGFjay1k ZXB0aCBuaWwKICAgICAgICAgICAgICAgICAoYW5kIChvciAoY29tbWFuZHAgZnVuY3Rpb24pIChj b21tYW5kcCBtYWluKSkKICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChhZHZpY2UtLW1ha2Ut aW50ZXJhY3RpdmUtZm9ybQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZ1bmN0aW9uIG1h aW4pKSkpKSkKLSAgICAod2hlbiBhZHYtc2lnIChwdXRoYXNoIGFkdmljZSBhZHYtc2lnIGFkdmVy dGlzZWQtc2lnbmF0dXJlLXRhYmxlKSkKKyAgICAod2hlbiAobGlzdHAgYWR2LXNpZykKKyAgICAg IDs7IERvbuKAmXQgdXNlIHNldC1hZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiBoZXJlOyBp dCBjYXVzZXMKKyAgICAgIDs7IHN0cmFuZ2UgcHJvYmxlbXMuCisgICAgICAocHV0aGFzaCBhZHZp Y2UgYWR2LXNpZyBhZHZlcnRpc2VkLXNpZ25hdHVyZS10YWJsZSkpCiAgICAgYWR2aWNlKSkKIAog KGRlZnVuIGFkdmljZS0tbWFrZSAod2hlcmUgZnVuY3Rpb24gbWFpbiBwcm9wcykKZGlmZiAtLWdp dCBhL2xpc3AvaGVscC5lbCBiL2xpc3AvaGVscC5lbApvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUg MTAwNzU1CmluZGV4IDY4ZTg4OTBlZTFiLi4zMWFjNDQ5NDE4MwotLS0gYS9saXNwL2hlbHAuZWwK KysrIGIvbGlzcC9oZWxwLmVsCkBAIC0xNDA0LDU0ICsxNDA0LDEwIEBAIGhlbHAtZnVuY3Rpb24t YXJnbGlzdAogICAiUmV0dXJuIGEgZm9ybWFsIGFyZ3VtZW50IGxpc3QgZm9yIHRoZSBmdW5jdGlv biBERUYuCiBJRiBQUkVTRVJWRS1OQU1FUyBpcyBub24tbmlsLCByZXR1cm4gYSBmb3JtYWwgYXJn bGlzdCB0aGF0IHVzZXMKIHRoZSBzYW1lIG5hbWVzIGFzIHVzZWQgaW4gdGhlIG9yaWdpbmFsIHNv dXJjZSBjb2RlLCB3aGVuIHBvc3NpYmxlLiIKLSAgOzsgSGFuZGxlIHN5bWJvbHMgYWxpYXNlZCB0 byBvdGhlciBzeW1ib2xzLgotICAoaWYgKGFuZCAoc3ltYm9scCBkZWYpIChmYm91bmRwIGRlZikp IChzZXRxIGRlZiAoaW5kaXJlY3QtZnVuY3Rpb24gZGVmKSkpCi0gIDs7IElmIGRlZmluaXRpb24g aXMgYSBtYWNybywgZmluZCB0aGUgZnVuY3Rpb24gaW5zaWRlIGl0LgotICAoaWYgKGVxIChjYXIt c2FmZSBkZWYpICdtYWNybykgKHNldHEgZGVmIChjZHIgZGVmKSkpCi0gIChjb25kCi0gICAoKGFu ZCAoYnl0ZS1jb2RlLWZ1bmN0aW9uLXAgZGVmKSAobGlzdHAgKGFyZWYgZGVmIDApKSkgKGFyZWYg ZGVmIDApKQotICAgKChlcSAoY2FyLXNhZmUgZGVmKSAnbGFtYmRhKSAobnRoIDEgZGVmKSkKLSAg ICgoZXEgKGNhci1zYWZlIGRlZikgJ2Nsb3N1cmUpIChudGggMiBkZWYpKQotICAgKChvciAoYW5k IChieXRlLWNvZGUtZnVuY3Rpb24tcCBkZWYpIChpbnRlZ2VycCAoYXJlZiBkZWYgMCkpKQotICAg ICAgICAoc3VicnAgZGVmKSkKLSAgICAob3IgKHdoZW4gcHJlc2VydmUtbmFtZXMKLSAgICAgICAg ICAobGV0KiAoKGRvYyAoY29uZGl0aW9uLWNhc2UgbmlsIChkb2N1bWVudGF0aW9uIGRlZikgKGVy cm9yIG5pbCkpKQotICAgICAgICAgICAgICAgICAoZG9jYXJncyAoaWYgZG9jIChjYXIgKGhlbHAt c3BsaXQtZnVuZG9jIGRvYyBuaWwpKSkpCi0gICAgICAgICAgICAgICAgIChhcmdsaXN0IChpZiBk b2NhcmdzCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2RhciAocmVhZC1mcm9tLXN0 cmluZyAoZG93bmNhc2UgZG9jYXJncykpKSkpCi0gICAgICAgICAgICAgICAgICh2YWxpZCB0KSkK LSAgICAgICAgICAgIDs7IENoZWNrIHZhbGlkaXR5LgotICAgICAgICAgICAgKGRvbGlzdCAoYXJn IGFyZ2xpc3QpCi0gICAgICAgICAgICAgICh1bmxlc3MgKGFuZCAoc3ltYm9scCBhcmcpCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgobmFtZSAoc3ltYm9sLW5hbWUgYXJnKSkpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAoZXEgKGFyZWYgbmFtZSAwKSA/JikKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChtZW1xIGFyZyAnKCZyZXN0ICZvcHRpb25h bCkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5nLW1hdGNoICJc XC4iIG5hbWUpKSkpKQotICAgICAgICAgICAgICAgIChzZXRxIHZhbGlkIG5pbCkpKQotICAgICAg ICAgICAgKHdoZW4gdmFsaWQgYXJnbGlzdCkpKQotICAgICAgICAobGV0KiAoKGFyZ3MtZGVzYyAo aWYgKG5vdCAoc3VicnAgZGVmKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhcmVm IGRlZiAwKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChhIChzdWJyLWFyaXR5 IGRlZikpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxvZ2lvciAoY2FyIGEpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAobnVtYmVycCAoY2RyIGEp KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxzaCAoY2RyIGEp IDgpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxzaCAxIDcpKSkp KSkKLSAgICAgICAgICAgICAgIChtYXggKGxzaCBhcmdzLWRlc2MgLTgpKQotICAgICAgICAgICAg ICAgKG1pbiAobG9nYW5kIGFyZ3MtZGVzYyAxMjcpKQotICAgICAgICAgICAgICAgKHJlc3QgKGxv Z2FuZCBhcmdzLWRlc2MgMTI4KSkKLSAgICAgICAgICAgICAgIChhcmdsaXN0ICgpKSkKLSAgICAg ICAgICAoZG90aW1lcyAoaSBtaW4pCi0gICAgICAgICAgICAocHVzaCAoaW50ZXJuIChjb25jYXQg ImFyZyIgKG51bWJlci10by1zdHJpbmcgKDErIGkpKSkpIGFyZ2xpc3QpKQotICAgICAgICAgICh3 aGVuICg+IG1heCBtaW4pCi0gICAgICAgICAgICAocHVzaCAnJm9wdGlvbmFsIGFyZ2xpc3QpCi0g ICAgICAgICAgICAoZG90aW1lcyAoaSAoLSBtYXggbWluKSkKLSAgICAgICAgICAgICAgKHB1c2gg KGludGVybiAoY29uY2F0ICJhcmciIChudW1iZXItdG8tc3RyaW5nICgrIDEgaSBtaW4pKSkpCi0g ICAgICAgICAgICAgICAgICAgIGFyZ2xpc3QpKSkKLSAgICAgICAgICAodW5sZXNzICh6ZXJvcCBy ZXN0KSAocHVzaCAnJnJlc3QgYXJnbGlzdCkgKHB1c2ggJ3Jlc3QgYXJnbGlzdCkpCi0gICAgICAg ICAgKG5yZXZlcnNlIGFyZ2xpc3QpKSkpCi0gICAoKGFuZCAoYXV0b2xvYWRwIGRlZikgKG5vdCAo ZXEgKG50aCA0IGRlZikgJ2tleW1hcCkpKQotICAgICJbQXJnIGxpc3Qgbm90IGF2YWlsYWJsZSB1 bnRpbCBmdW5jdGlvbiBkZWZpbml0aW9uIGlzIGxvYWRlZC5dIikKLSAgICh0IHQpKSkKKyAgKGxl dCAoKHNpZyAoZ2V0LWFkdmVydGlzZWQtY2FsbGluZy1jb252ZW50aW9uIGRlZiBwcmVzZXJ2ZS1u YW1lcykpKQorICAgIChpZiAoZXEgc2lnICdhdXRvbG9hZCkKKyAgICAgICAgIltBcmcgbGlzdCBu b3QgYXZhaWxhYmxlIHVudGlsIGZ1bmN0aW9uIGRlZmluaXRpb24gaXMgbG9hZGVkLl0iCisgICAg ICBzaWcpKSkKIAogKGRlZnVuIGhlbHAtLW1ha2UtdXNhZ2UgKGZ1bmN0aW9uIGFyZ2xpc3QpCiAg IChjb25zIChpZiAoc3ltYm9scCBmdW5jdGlvbikgZnVuY3Rpb24gJ2Fub255bW91cykKZGlmZiAt LWdpdCBhL3Rlc3QvYXV0b21hdGVkL2J5dGVjb21wLXRlc3RzLmVsIGIvdGVzdC9hdXRvbWF0ZWQv Ynl0ZWNvbXAtdGVzdHMuZWwKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCBm MDcxMzhkM2M1NS4uY2UxMzA2YWJlNjAKLS0tIGEvdGVzdC9hdXRvbWF0ZWQvYnl0ZWNvbXAtdGVz dHMuZWwKKysrIGIvdGVzdC9hdXRvbWF0ZWQvYnl0ZWNvbXAtdGVzdHMuZWwKQEAgLTQyMCwxMCAr NDIwLDE5IEBAIHRlc3QtYnl0ZS1jb21wLWNvbXBpbGUtYW5kLWxvYWQKICAgICAgIChkZWZ1biBk ZWYgKCkgKG0pKSkpCiAgIChzaG91bGQgKGVxdWFsIChmdW5jYWxsICdkZWYpIDQpKSkKIAorKGVy dC1kZWZ0ZXN0IGJ5dGVjb21wLXRlc3RzLS10ZXN0LW5vLXdhcm5pbmdzLXdpdGgtYWR2aWNlICgp CisgIChkZWZ1biBmICgpKQorICAoZGVmaW5lLWFkdmljZSBmICg6YXJvdW5kIChvbGRmdW4gJnJl c3QgYXJncykgdGVzdCkKKyAgICAoYXBwbHkgb2xkZnVuIGFyZ3MpKQorICAod2l0aC1jdXJyZW50 LWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgIipDb21waWxlLUxvZyoiKQorICAgIChsZXQgKChp bmhpYml0LXJlYWQtb25seSB0KSkgKGVyYXNlLWJ1ZmZlcikpKQorICAodGVzdC1ieXRlLWNvbXAt Y29tcGlsZS1hbmQtbG9hZCB0ICcoZGVmdW4gZiAoKSkpCisgICh3aXRoLWN1cnJlbnQtYnVmZmVy IChnZXQtYnVmZmVyLWNyZWF0ZSAiKkNvbXBpbGUtTG9nKiIpCisgICAgKGdvdG8tY2hhciAocG9p bnQtbWluKSkKKyAgICAoc2hvdWxkLW5vdCAoc2VhcmNoLWZvcndhcmQgIldhcm5pbmciIG5pbCB0 KSkpKQogCiA7OyBMb2NhbCBWYXJpYWJsZXM6CiA7OyBuby1ieXRlLWNvbXBpbGU6IHQKIDs7IEVu ZDoKIAogKHByb3ZpZGUgJ2J5dGUtb3B0LXRlc3RzdWl0ZSkKLQpkaWZmIC0tZ2l0IGEvdGVzdC9h dXRvbWF0ZWQvY2wtbGliLXRlc3RzLmVsIGIvdGVzdC9hdXRvbWF0ZWQvY2wtbGliLXRlc3RzLmVs Cm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggNWVkYzNlNzJiZjIuLmQ0ZTc4 N2U1NmE2Ci0tLSBhL3Rlc3QvYXV0b21hdGVkL2NsLWxpYi10ZXN0cy5lbAorKysgYi90ZXN0L2F1 dG9tYXRlZC9jbC1saWItdGVzdHMuZWwKQEAgLTIzMCw4ICsyMzAsOCBAQAogKGVydC1kZWZ0ZXN0 IGNsLWxpYi1hcmdsaXN0LXBlcmZvcm1hbmNlICgpCiAgIDs7IEFuIGAmYXV4JyBzaG91bGQgbm90 IGNhdXNlIGxhbWJkYSdzIGFyZ2xpc3QgdG8gYmUgdHVybmVkIGludG8gYW4gJnJlc3QKICAgOzsg dGhhdCdzIHBhcnNlZCBieSBoYW5kLgotICAoc2hvdWxkIChlcXVhbCAoKSAoaGVscC1mdW5jdGlv bi1hcmdsaXN0ICdjbC1saWItLWNvbi0xKSkpCi0gIChzaG91bGQgKHBjYXNlIChoZWxwLWZ1bmN0 aW9uLWFyZ2xpc3QgJ2NsLWxpYi0tY29uLTIpCisgIChzaG91bGQgKGVxdWFsICgpIChnZXQtYWR2 ZXJ0aXNlZC1jYWxsaW5nLWNvbnZlbnRpb24gJ2NsLWxpYi0tY29uLTEpKSkKKyAgKHNob3VsZCAo cGNhc2UgKGdldC1hZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiAnY2wtbGliLS1jb24tMikK ICAgICAgICAgICAgIChgKCZvcHRpb25hbCAsXykgdCkpKSkKIAogKGVydC1kZWZ0ZXN0IGNsLXRo ZSAoKQotLSAKMi4xNS4wLnJjMC4yNzEuZzM2YjY2OWVkY2MtZ29vZwoK --94eb2c0d27a8b652c5055b618a0f-- From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 05:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Williams Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150796028928120 (code B ref 28803); Sat, 14 Oct 2017 05:52:01 +0000 Received: (at 28803) by debbugs.gnu.org; 14 Oct 2017 05:51:29 +0000 Received: from localhost ([127.0.0.1]:38676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3FM9-0007JU-81 for submit@debbugs.gnu.org; Sat, 14 Oct 2017 01:51:29 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:48727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3FM6-0007JE-VF for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 01:51:27 -0400 Received: by mail-it0-f52.google.com with SMTP id c3so13640945itc.3 for <28803@debbugs.gnu.org>; Fri, 13 Oct 2017 22:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=anNotlxsdJdZtXdEcDPY8acRM8Y94eGjdc//vkPdrGA=; b=YNMnktFGOac7bX4K865JyO1bA+XRUZcLHqpM1RBFZapy5vDOAITF4OM6OmHFG+0/EG uITPzfprsC8IxBDkDuTkD4WvWaWX+2w9q7uFOk3H5Q3CiU61oY/nM5yACSwWQSfx5+uD 0MKYjSAO6AOjTG0+jKxkjaVJooV4E+/goOwUmZbiFFNXrlapTR+yFNzO9kJNN9/PrS5U 6xlypRaN1Wbc9F4nxI2yKodgAbs4cwpATGk4AKiigGP03fx7GeFFNG+I8sM8mI3HcwsL mFw4JGiydZe6gex5EMa5mjfxMbsXedeaA1GCFxwbc+9kRie3gLV3VV1hcbiX4iylJjfH DJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=anNotlxsdJdZtXdEcDPY8acRM8Y94eGjdc//vkPdrGA=; b=qCakUatNXdcL5ymjY8Y4H+AmOUpFQH1RVqZvH0+ghwJ1pJtkPtPUyyXc+F6fyXK4B3 T33hvpr2fBi8JWmbcUrv3e+4Y8LN8xGRSCUgNr4v+Udi7SGQ8i5s7006QdeqsU3GK1bz MxkltUJy0T8aC5YnvzXO5hHYyhNuLxxGVu5t7HAKuZAcProucSjpmGWCxpYLkUDvasNG bFGn1yMLnK+/QkeZvnSnFlWeyf3ni+x2vwLSnJs23risQak743/tWiW/+jzZ/ywR7EIf I8b1qUDszCIA0JZpn2S2uBvVSJIQ9ogFpLi6me09Zh55y1LcSVeKoVljaPRdH26gamOi eWdA== X-Gm-Message-State: AMCzsaXD3WIHchm8T3cnMuk9xAV1tuvxjH7NTcGv3Cn+yiqm9teZgBni MctqSL8czk/tMwAo8Jqab3sogA== X-Google-Smtp-Source: ABhQp+QgvRpJpi39zDIZPrwwhmzq1Pjqd+Nvt1RxniZJYyrr7FsLOyX9qe11BHUsr0ZonWALH9FaYA== X-Received: by 10.36.237.134 with SMTP id r128mr3527097ith.100.1507960281058; Fri, 13 Oct 2017 22:51:21 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e37sm1289077ioi.70.2017.10.13.22.51.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 22:51:19 -0700 (PDT) From: Noam Postavsky References: Date: Sat, 14 Oct 2017 01:51:18 -0400 In-Reply-To: (John Williams's message of "Thu, 12 Oct 2017 16:02:39 -0700") Message-ID: <87infi9t0p.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) John Williams writes: > Subject: [PATCH] Fixed compiler warnings for advised functions. I think this bug was already fixed in emacs-26, see [1: 6e2d6d54e1], Bug#14860 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14860). [1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400 * lisp/emacs-lisp/bytecomp.el: Fix bug#14860. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6e2d6d54e1236216462c13655ea1fe573d9672e7 From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: John Williams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150802172926227 (code B ref 28803); Sat, 14 Oct 2017 22:56:02 +0000 Received: (at 28803) by debbugs.gnu.org; 14 Oct 2017 22:55:29 +0000 Received: from localhost ([127.0.0.1]:40721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3VL7-0006ox-8r for submit@debbugs.gnu.org; Sat, 14 Oct 2017 18:55:29 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:46285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3VL6-0006ol-7M for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 18:55:28 -0400 Received: by mail-wm0-f46.google.com with SMTP id m72so27115918wmc.1 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 15:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=b+v2L4EGdi8EbeimWs+BKpGqBtrcjnCU5BzbE8PJfIw=; b=gseRhJhA1lR9LdhytWzzd8qLGyePs+9P8TA2bLFV91gzCt0t6EaELTNyFEjpS1E/0g ZDi8vQW2U0OXF8Zw8tn+Ez6fuKvk/4gJxBBVOsREZkIewPgKnN6PNkdg8VhnxBX/9/5L zGdeJbi/I9Mm0urjdDsElIm4NKHmybKp0ruPeSxmxYJhuqM0EhXXnicLdEurIgxOh0t1 wpKj3A2SbWgpddwU2P6yXvoZ0hyS0Nso6PvogU2cFGbSvm4nJmBEikEM9sH5FnFwSxwO dxBJVNvVLZ6SofdlzhvDsufRtS+alxx6Sqai1ehp4WDSSLSaipD8YeY61DybA0l/eYou 7Mdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=b+v2L4EGdi8EbeimWs+BKpGqBtrcjnCU5BzbE8PJfIw=; b=sn4WSNVwRIzD+MPqHdxeVN2a1abdhg95VldykHo4TfX1u3ms+1FA0ksHy/Z7BDVXfU CnxFINRV58PZy1AEKmq1dAxm1Yarnqp6L35EnG7/0Nts/pKI/IxNGnJrAj7LsICGC1uc Rro6yL3G76rJ+ZjtWWvSmTw7Jsje1DUZPy2w6LB+VmG/o9VnPQig/i6sHAejyjFb77p6 ceTk4h74p9DXgVUv80l7TmMgATqPIlX0rr2/+xAJWVkSwVh4YNrxnBPZ7SO9R6Ob/5tU aIrwMemA8G5sb1OQK7gfsSsQLYLJYFtMcamen0r5crELWZKCCziiyxhuq4J+um9Dw/l+ SNCg== X-Gm-Message-State: AMCzsaXS7ck1AV37u9PaFM+ovKl3vhB0IazaZRIX7JygPcoEaMtYu+4K JQa+dIRce1HOcY6g4UyguYobH8xwx8ZwaG088kmLMw== X-Google-Smtp-Source: AOwi7QDzD2c4ETe38UccwWy4bchouQY8itIjM/pQujKDrh+dPhTCIQwLYAOOdcFPOOV8xu6XySlrSLRQpDTRQDdZqr0= X-Received: by 10.28.71.25 with SMTP id u25mr3993513wma.22.1508021722502; Sat, 14 Oct 2017 15:55:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.111.93 with HTTP; Sat, 14 Oct 2017 15:55:21 -0700 (PDT) Received: by 10.28.111.93 with HTTP; Sat, 14 Oct 2017 15:55:21 -0700 (PDT) In-Reply-To: References: <87infi9t0p.fsf@users.sourceforge.net> From: John Williams Date: Sat, 14 Oct 2017 15:55:21 -0700 X-Google-Sender-Auth: mg74a6Fk8cCHxaah158HT47AEXI Message-ID: Content-Type: multipart/alternative; boundary="94eb2c06d8ac155f71055b89ab5d" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c06d8ac155f71055b89ab5d Content-Type: text/plain; charset="UTF-8" Oops. Is there anything that can be salvaged from my patch? Aside from fixing the bug, it also adds a unit test and refactors the logic for finding a function's argument list into a separate function that's not part of the help system. On Oct 13, 2017 10:51 PM, "Noam Postavsky" wrote: John Williams writes: > Subject: [PATCH] Fixed compiler warnings for advised functions. I think this bug was already fixed in emacs-26, see [1: 6e2d6d54e1], Bug#14860 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14860). [1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400 * lisp/emacs-lisp/bytecomp.el: Fix bug#14860. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id= 6e2d6d54e1236216462c13655ea1fe573d9672e7 --94eb2c06d8ac155f71055b89ab5d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oops. Is there anything that can be salvaged from my patc= h? Aside from fixing the bug, it also adds a unit test and refactors the lo= gic for finding a function's argument list into a separate function tha= t's not part of the help system.

On Oct 13, 2017 10:51 PM, "Noam Postavsky&quo= t; <npostavs@users.sou= rceforge.net> wrote:
jrw@pobox.com> = writes:

> Subject: [PATCH] Fixed compiler warnings for advised functions.

I think this bug was already fixed in emacs-26, see [1: 6e2d6d54e1],
Bug#14860 (https://debbugs.gnu.org/cgi/bug= report.cgi?bug=3D14860).

[1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400
=C2=A0 * lisp/emacs-lisp/bytecomp.el: Fix bug#14860.
=C2=A0 http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D6e2d6d= 54e1236216462c13655ea1fe573d9672e7

--94eb2c06d8ac155f71055b89ab5d-- From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 23:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Williams Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.15080248465913 (code B ref 28803); Sat, 14 Oct 2017 23:48:02 +0000 Received: (at 28803) by debbugs.gnu.org; 14 Oct 2017 23:47:26 +0000 Received: from localhost ([127.0.0.1]:40740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3W9N-0001XH-PP for submit@debbugs.gnu.org; Sat, 14 Oct 2017 19:47:26 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:46585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3W9L-0001X2-Jl for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 19:47:24 -0400 Received: by mail-io0-f177.google.com with SMTP id 101so12480413ioj.3 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 16:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HtQjyUHBi5FsczsJRvR8lO8/sHDr2FXSShavAtLSlfk=; b=LfwjzJ5ei+E0ibip6BHJ2ghw/X1P23rO7QwnUVsXpoexhFFXs41GAwzEyKPFPQd0VK 1Qny3abnDIEJMzPGni+cYoU/Mlr9NjZNNHRpke/Mj0jZuUcBXMlX0ixVXETagnzywbGw 1en0vHQJ+yljm3LlO8hYO3HRx2N5HqFQoilZa48i+dyatm3Z65BIVzLM2pLxdUfjnWdQ PnJnYEHbYQvD0d3GhBQyWwgiCKf85mteFUjfrsZgiOTmCbgbzYXp+hPc2adjVJobT7V5 Pl1OuncCZUPZp+G1Z4ajNY2dHLjYKdp6dRr1X1R+td28dckgkZY5XMkoOd2fYSAcsC1w 2SFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=HtQjyUHBi5FsczsJRvR8lO8/sHDr2FXSShavAtLSlfk=; b=R5fLsbJ7RwnXu7bNB6t8pUdve0cYODHTIAEGGlnG04MBQpZAV0mU1RgZMldCmE/StN VgH3vbs5LJ6b6hOOaeL7L6t+n2gT0BGviwPRe8p4oSBozGhitUEvdTqakfsuFZzvVNdn 9WKHeT+wK1+1xyjip46Gm2DEN5eYHavYpSzdE0LH/ULzeBm6kDIJ2TncqVbp0vOhkrxL uuWBlOxpbI93k4/194MRJN8rggGeF48UHNXzLiGLj8nsuNzl3HgKoQ8DGuS8/OGQ5hDT QRAJYQOCnH/nBiKpAKF+G5b6y8qzrRVQgnORdV5h7stJuia61d9heJeY5P2y1AtYBv8U NaUw== X-Gm-Message-State: AMCzsaXtI8sI/fagaF+BuT4WB2vqEqHg3DA2qkdS9Njr4Z1tecx5PMNS EQl0xWl+MRrLCl9Dmi9/ASVOkg== X-Google-Smtp-Source: ABhQp+RT8lXJUuET9HiKiP8f2HdFuTZaGFDerOhtWu96Q3Gsvq/ImTvc5aps2TpL3aXHlj4QhapsGA== X-Received: by 10.107.159.5 with SMTP id i5mr6572261ioe.300.1508024837599; Sat, 14 Oct 2017 16:47:17 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c13sm2201089itd.32.2017.10.14.16.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 16:47:16 -0700 (PDT) From: Noam Postavsky References: <87infi9t0p.fsf@users.sourceforge.net> Date: Sat, 14 Oct 2017 19:47:15 -0400 In-Reply-To: (John Williams's message of "Sat, 14 Oct 2017 15:55:21 -0700") Message-ID: <874lr19trw.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) John Williams writes: > Oops. Is there anything that can be salvaged from my patch? Aside > from fixing the bug, it also adds a unit test and refactors the logic > for finding a function's argument list into a separate function > that's not part of the help system. We could add the test, it seems to be passing in emacs-26. Have you assigned copyright to Emacs? (It's okay if you haven't, the patch is small enough to go in regardless, we would just need to mark it.) I don't think there's much need for moving the function argument retrieval out of the help system. (By the way, if you've spent some time looking at help-function-arglist, perhaps you have some ideas about Bug#26270? https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26270) From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: John Williams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2017 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150802747517732 (code B ref 28803); Sun, 15 Oct 2017 00:32:01 +0000 Received: (at 28803) by debbugs.gnu.org; 15 Oct 2017 00:31:15 +0000 Received: from localhost ([127.0.0.1]:40761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Wpm-0004bv-RW for submit@debbugs.gnu.org; Sat, 14 Oct 2017 20:31:15 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:50540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Wpl-0004bc-5B for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 20:31:13 -0400 Received: by mail-wm0-f49.google.com with SMTP id u138so27221910wmu.5 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 17:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=gTEVo3Ti98Nd/DW2Ofgs5uMEll7CBDJcxjiPcHd6nOc=; b=IktOUXfc4u+CFGJninPaVU72Q4tCdp/wE0GQmGb3dpH6NPfJSqK3oehR2j3/Ro5AnI a3ZZ4kMJwO46XUw+Rw4EI+E2304B6MA9m/HGFiGXrkmQgnfV7yUuW4G2hMJyGpyrjulj z8maTsm34HlN7nBsf05nBPJSsQjGdRUbKa32YxrG4ja3YsT+f/VmYkyhe1cgu7Ray6oH Nr7yRFPG9c2uDKiIjwybmp9CiICpj349ZxZX3KUxEP3WjK47IMA72twSBG7/Vt7gVD/s 7QBUWY/1nIhPvps294WuLNnVkZ22RmgBycG90o8kTjdgSaETUDizBvhrV3kiceyAPE4N zmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=gTEVo3Ti98Nd/DW2Ofgs5uMEll7CBDJcxjiPcHd6nOc=; b=Qgj5CjBtV09raHtaFrYYDbgCgJ0uIEnfedkn9srj+hBd/dlrb15eye67OXJba1b92A 0G04n180nt5Kg8Zx4VlNe1J4eRtyAAY4OyTegCfx5uGCGJ9V9j26yTOxqlNt410WtZY0 SKxjRj5b/q0rkJ72qMgo9lt60DkZC4WW+sexyOv22u4Ttg12n3usNIroba5vjT/qWrzU 9Pom1ZNjvueExM4176Uki4DNGM1vUAIxAzB59ubQuFuLglWolnJbfpPXvs6JWjfUtt3l c4qjg2KBqcf2Q2vNXOab7NIlZc0lwNG9peejpANmH76rijU8FXkGUr52MVXvgVNvvr1a Y4wg== X-Gm-Message-State: AMCzsaUwiHtTBArbdg1KOx2+6GTtzouvx+JsMzJOitgXuCSfkt5WKzRT XQdtdcY7QkD6xTAqD6XjN/vZZDY1lMmrfZyymoM= X-Google-Smtp-Source: AOwi7QBDgP/cm1uGVYssF0kHd5BuplNIj2TPMu8u8pR2AskUPBtv1PJe3tmVmPaqeUkZ99TUuQDhequgGNhWDPsEiXo= X-Received: by 10.28.63.145 with SMTP id m139mr4929238wma.5.1508027467273; Sat, 14 Oct 2017 17:31:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.111.93 with HTTP; Sat, 14 Oct 2017 17:30:46 -0700 (PDT) In-Reply-To: <874lr19trw.fsf@users.sourceforge.net> References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> From: John Williams Date: Sat, 14 Oct 2017 17:30:46 -0700 X-Google-Sender-Auth: NAKosUoMCTPqDP_fXXhxSPpLVDE Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Sat, Oct 14, 2017 at 4:47 PM, Noam Postavsky wrote: > John Williams writes: > >> Oops. Is there anything that can be salvaged from my patch? Aside >> from fixing the bug, it also adds a unit test and refactors the logic >> for finding a function's argument list into a separate function >> that's not part of the help system. > > We could add the test, it seems to be passing in emacs-26. Have you > assigned copyright to Emacs? (It's okay if you haven't, the patch is > small enough to go in regardless, we would just need to mark it.) No; how would I go about doing that? The organization of the dev site is a bit confusing to me. > I don't think there's much need for moving the function argument > retrieval out of the help system. It's not a huge deal to me, but it seems weird that something like nadvice.el would depend on the help system (which it would in my patch if I hadn't moved that function--I assume the fix that was already committed does something similar). > (By the way, if you've spent some time looking at help-function-arglist, > perhaps you have some ideas about Bug#26270? > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26270) I took a look at your patch, and without having tried running it, it seems pretty reasonable to me. A unit test of some sort would be nice, but since there don't seem to be any for help-function-arglist yet, accepting the patch as-is would leave the unit test situation no worse than it was before. I'm not a regular contributor, though, so my opinion is worth what you paid for it. From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2017 01:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Williams Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150802925120434 (code B ref 28803); Sun, 15 Oct 2017 01:01:02 +0000 Received: (at 28803) by debbugs.gnu.org; 15 Oct 2017 01:00:51 +0000 Received: from localhost ([127.0.0.1]:40766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3XIR-0005JW-98 for submit@debbugs.gnu.org; Sat, 14 Oct 2017 21:00:51 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:55880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3XIP-0005JI-8o for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 21:00:49 -0400 Received: by mail-io0-f175.google.com with SMTP id p186so6411341ioe.12 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 18:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TphaxSEOgo7eMctpaHWQZFGMeQf5c2L1AKeJJGrUrQY=; b=uL90nIWzi/zNy0tbA8iNArqUvY5xqs7hFiT6rdr0xlAhRo/if22q0GBSj5CqjZYIWL a3Ed+x8Bbta8HDiGSPaBzvHcD+ss2dmxUNDbqC3MYjNP07+xomHgbKXpPhB8XLnMdMkC mDc3RCLHUnVI9Aexzia2Gp7tZDEXmb6A3nfxWQU+mH6SaqQ3u0GJNkQCNfKGIg1Lm58N vJ0ssZaPClzMlAZbrUD8Pty0DgoUXcoDwwgOkE/nrSFosOkwjtFSr5sDTS6v36REh8iA wSbyhgZvW3b8wbUlV0T8orWSFMnnAnhzyq7BNVZqYppCjEj1SSrRQDtUtDpkVCPUDY0g 6ObQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=TphaxSEOgo7eMctpaHWQZFGMeQf5c2L1AKeJJGrUrQY=; b=XDE0r/CZ+WxjqAhyFx1c4quRj6PD6ZPePuhCSz9PCS6scW7NEhu0gixkIGOh3XtJje W7PrvSVSElGjIbPR5D2NlP3f7+9B9zPTO3wCdWFAfWB2/KyzihsIL3fU7MxAIFjX6CIF 1JJqwddespEKxOPTc6BZGvro12R9aqzNEZL2MMdwFBTMVYV2oQPzALEekzr1HVctKVXk hyJVYTj1Pr31BC7n6VZoZ4QraXUSqveg1XZrMa1Lhnm+pw9Bkf5jqo9nk07weHg/6pgY 3NAQ2CPRnu29ck3mgZ/OlgCbikTT/gDuAMMCtyQgX/+015tqyMOujm5Dq0XJ0UrxfYi6 fRyg== X-Gm-Message-State: AMCzsaWKRTJH1cTuG9+VPhvMoKu2EIGrUs9TbpcBn6QyIz6uzs3mreHa 8AnYWbihtoYr7ST2fGjuME9MbA== X-Google-Smtp-Source: ABhQp+Qn6EZQoUDuNNg9DBPehA5LF8ZFUX1pz8zDIQ0dNv/DIhQi9xjhofhE5TqnQDDMNVFtD5XqSQ== X-Received: by 10.107.187.2 with SMTP id l2mr6692014iof.136.1508029243008; Sat, 14 Oct 2017 18:00:43 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d143sm2298884itd.8.2017.10.14.18.00.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 18:00:41 -0700 (PDT) From: Noam Postavsky References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> Date: Sat, 14 Oct 2017 21:00:40 -0400 In-Reply-To: (John Williams's message of "Sat, 14 Oct 2017 17:30:46 -0700") Message-ID: <87zi8t8bt3.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) John Williams writes: >> We could add the test, it seems to be passing in emacs-26. Have you >> assigned copyright to Emacs? (It's okay if you haven't, the patch is >> small enough to go in regardless, we would just need to mark it.) > > No; how would I go about doing that? The organization of the dev site > is a bit confusing to me. You fill in this form: http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program and send it to fsf-records@gnu.org, then wait for further instructions (in my experience it takes a little over a month to get a response). >> I don't think there's much need for moving the function argument >> retrieval out of the help system. > > It's not a huge deal to me, but it seems weird that something like > nadvice.el would depend on the help system (which it would in my patch > if I hadn't moved that function--I assume the fix that was already > committed does something similar). The other patch doesn't change nadvice.el. There is another existing call to help-function-arglist in advice--make-docstring, but since it is used to create a docstring, to me it seems appropriate to depend on the help system. From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Williams Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150862881415929 (code B ref 28803); Sat, 21 Oct 2017 23:34:02 +0000 Received: (at 28803) by debbugs.gnu.org; 21 Oct 2017 23:33:34 +0000 Received: from localhost ([127.0.0.1]:54750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Go-00048m-EV for submit@debbugs.gnu.org; Sat, 21 Oct 2017 19:33:34 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:51373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Gm-00048R-6x; Sat, 21 Oct 2017 19:33:32 -0400 Received: by mail-it0-f43.google.com with SMTP id o135so2314348itb.0; Sat, 21 Oct 2017 16:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=eiEVajC15xE0qEzs5jU1bxznQEaR3R4Pu7WbhlX5x66PTkmy1LdEZZp3wRXMI77XoU uz6ww7LZLJreQKE8XzS4vJ6u1RceUZKx0RdUJbtdT7H7EEfginO2L+VUsxx362xwPULp plY36O5FnpwE/SB4wGmC9IlNruMNmifS+DrcC8hRJOQUYMfUQVtzOH1Z7RRCZRCWLNgq d7OKOHcbSGFKV8hLbdTf+5lAW9HrrZTpLDd4kW27mV4CkyxhR28sr0AEq0xZeVPtKb+B 7rx1EvnvIkDrmj59FarRaaLLpV/yfoKW/A3XGXqorhTg4FqD4X2vUKu2kzmSVVzenlj8 mQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=HCryJwJUl7Hlq3fuvkbp5PYwOPTUc0t95t3lerjdPBuFXXQFXs8a8/mOITYmcmrfdS MDOMzsXthBUiH/kmlNTmLYIiK4MyFy02Dwf4ykl8EsJBOyFRIUPKkF+9gbsivrRq2W7L wsUO3WqXTxWJWEf/sSt2ugrkqFYnLRCrXJi7YJyhjtxwzbWfujnHXuh7ObXxqSb52NV9 a6hNnbg8M+WgGvJwBp/qpk0AnasJTO2cmOWy86DJlt3PEm56u0f5uYeVJ/I9KJakqpHb 9jCeT3oN7/IdXAaTcXXgcYvoYsu4U6smGaI2D16o50pLMagSwy6o8Uq9gDxZto068L9o cHnA== X-Gm-Message-State: AMCzsaVcOe/xL0XlfNYsvEjnL/mDk0iPCqc87NDrtV8pLaoghGcG1SNF lX1SFwoWnPzJYZBQ/XXvkxMuNw== X-Google-Smtp-Source: ABhQp+QINMEhCpDuMyXNJcHA063fGxGA+DN4ZJXp2iqyIO2+aFRD/r91xTsX/rxzAr43Dr4ZYKWucQ== X-Received: by 10.36.164.75 with SMTP id v11mr4211998iti.33.1508628806353; Sat, 21 Oct 2017 16:33:26 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m12sm903590ita.17.2017.10.21.16.33.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 16:33:25 -0700 (PDT) From: Noam Postavsky References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> Date: Sat, 21 Oct 2017 19:33:23 -0400 In-Reply-To: <874lr19trw.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 14 Oct 2017 19:47:15 -0400") Message-ID: <87zi8kcbzw.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 28803 fixed close 28803 26.1 unarchive 14860 merge 28803 14860 quit Noam Postavsky writes: > John Williams writes: > >> Oops. Is there anything that can be salvaged from my patch? Aside >> from fixing the bug, it also adds a unit test and refactors the logic >> for finding a function's argument list into a separate function >> that's not part of the help system. > > We could add the test, it seems to be passing in emacs-26. I've pushed the test. [1: 237e96bc52]: 2017-10-21 19:20:46 -0400 Test that advice doesn't trigger bytecomp warnings (Bug#28803) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=237e96bc5259e59ac5623a93a47f64abffab4e0b From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: John Williams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2017 02:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed patch To: Noam Postavsky Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150863904313878 (code B ref 28803); Sun, 22 Oct 2017 02:25:02 +0000 Received: (at 28803) by debbugs.gnu.org; 22 Oct 2017 02:24:03 +0000 Received: from localhost ([127.0.0.1]:54812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e65vn-0003bm-J4 for submit@debbugs.gnu.org; Sat, 21 Oct 2017 22:24:03 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:51435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e65vl-0003bG-RH for 28803@debbugs.gnu.org; Sat, 21 Oct 2017 22:24:02 -0400 Received: by mail-wr0-f173.google.com with SMTP id j15so2098018wre.8 for <28803@debbugs.gnu.org>; Sat, 21 Oct 2017 19:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=s21nSYAAfNrfsymcx0WmFUTct3ihpaownk49FhI0mH8=; b=gnNINqJ5/NMlXHbqoWDZ4FJQXqyr8BRS11kQ/tNtycAZoqnBnLvOFac/jGt8FfhTuI 52+SlKLWHuIqa9fDsirKnI+HaQxMnFRYxhMacIOmkSvDOvtalR6t9rzM/JaFsK7NBxCb 7GWw9IyvGV1rrxrQVLGRh7ChlJmpY0n3T1FX/ypyyBPK9Vbtf7uPnzMsHbA8gHqjNRGU O+HX65yNsaEc8dm/N1czu+bywXY10dyLWOF03omeMxpby26mbNDcnjj0hH+NljVdlgtD +3ldLqAC475DOSuRr9ODAy8Qyy/aq5LntgniIiRdPRXWZo0++UPNN6xx2IaHpxtjLBl2 hFmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=s21nSYAAfNrfsymcx0WmFUTct3ihpaownk49FhI0mH8=; b=akIRVaWzzbqjjUxJiir8bO1/IzQN7nMaiWTlfiP06mYR1sl84medYBCQZix5+XcPew z06j+jqm7RaD5xHJRZ2V+rcQwjw5a9mqgpQf3DfSQ1WqE9Hch/3o3bASO4aOLQVIiec/ yTOg6O4/Z6swLCIVj9+X1psPRNHWT71IaDSZi62Afgs4DteSio+7i6vVchc9gk5XDkov a9dpIYMYfD6bb93n6fepMfYauQE1yk7evotg66oC9pxIQ6Em4p0wOmpaASBtLg//91Cz AfVHKiZP1HSnOt1rE4axPIdmv17MlOaRh1yQr/pk/W/Vkg+FZvODUtZLBcZMTwPtMExn dYRA== X-Gm-Message-State: AMCzsaXfWxT+A5unVZM7azBZaLZ20F+Siu/be8XOY/NK12fJdsJHaq9D 9fnOMiVxldMDjC1XVo5WQ8AX6QuMMLRtRNhhE4U= X-Google-Smtp-Source: ABhQp+TL0ylWZ4mCKt1XUg1zDPLDPt1EDKFbyZse8f179Vtia6psTmdvVQFpz6Lq6xUrW0tccjlilJtY7pYcVLsxLOU= X-Received: by 10.223.148.162 with SMTP id 31mr8615040wrr.149.1508639035721; Sat, 21 Oct 2017 19:23:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.111.93 with HTTP; Sat, 21 Oct 2017 19:23:35 -0700 (PDT) In-Reply-To: <87zi8kcbzw.fsf@users.sourceforge.net> References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> <87zi8kcbzw.fsf@users.sourceforge.net> From: John Williams Date: Sat, 21 Oct 2017 19:23:35 -0700 X-Google-Sender-Auth: sWHNsu891e7_EGFBtzmN1Vnx_cI Message-ID: Content-Type: multipart/alternative; boundary="94eb2c0d27a8d18ced055c1965ed" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --94eb2c0d27a8d18ced055c1965ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hooray, my first official contribution to Emacs! Now I have code=E2=80=94no= t much, but some=E2=80=94in both Emacs and Vim, which I have to think is pretty rar= e. BTW, is posting to this list really the best way to send patches? At my job, all changes go through a code review tool similar to Gerrit , with code uploaded using a command analogous to "git push", so sending a patch as an email attachment feels clumsy and anachronistic. On Oct 21, 2017 4:33 PM, "Noam Postavsky" wrote: > tags 28803 fixed > close 28803 26.1 > unarchive 14860 > merge 28803 14860 > quit > > Noam Postavsky writes: > > > John Williams writes: > > > >> Oops. Is there anything that can be salvaged from my patch? Aside > >> from fixing the bug, it also adds a unit test and refactors the logic > >> for finding a function's argument list into a separate function > >> that's not part of the help system. > > > > We could add the test, it seems to be passing in emacs-26. > > I've pushed the test. > > [1: 237e96bc52]: 2017-10-21 19:20:46 -0400 > Test that advice doesn't trigger bytecomp warnings (Bug#28803) > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D237e9 > 6bc5259e59ac5623a93a47f64abffab4e0b > --94eb2c0d27a8d18ced055c1965ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hooray, my first official contribution t= o Emacs! Now I have code=E2=80=94not much, but some=E2=80=94in both Emacs a= nd Vim, which I have to think is pretty rare.

BTW, is posting to this list really the best way to send pa= tches? At my job, all changes go through a code review tool similar to=C2= =A0Gerrit, with code uplo= aded using a command analogous to "git push", so sending a patch = as an email attachment feels clumsy and anachronistic.

On Oct 21, 2017 4:33 PM, &= quot;Noam Postavsky" <npostavs@users.sourceforge.net> wrote:
tags 28803 fixed
close 28803 26.1
unarchive 14860
merge 28803 14860
quit

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> John Williams <j= rw@pobox.com> writes:
>
>> Oops. Is there anything that can be salvaged from my patch? Aside<= br> >> from fixing the bug, it also adds a unit test and refactors the lo= gic
>> for finding a function's argument list into a separate functio= n
>> that's not part of the help system.
>
> We could add the test, it seems to be passing in emacs-26.

I've pushed the test.

[1: 237e96bc52]: 2017-10-21 19:20:46 -0400
=C2=A0 Test that advice doesn't trigger bytecomp warnings (Bug#28803) =C2=A0 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D237e96bc5259e59ac5623a93a47f64abffab4e0b
--94eb2c0d27a8d18ced055c1965ed-- From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2017 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed patch To: John Williams Cc: 28803@debbugs.gnu.org Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150867745216620 (code B ref 28803); Sun, 22 Oct 2017 13:05:01 +0000 Received: (at 28803) by debbugs.gnu.org; 22 Oct 2017 13:04:12 +0000 Received: from localhost ([127.0.0.1]:54979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6FvH-0004Jz-Mm for submit@debbugs.gnu.org; Sun, 22 Oct 2017 09:04:12 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:56797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6FvF-0004Jn-Vx for 28803@debbugs.gnu.org; Sun, 22 Oct 2017 09:04:10 -0400 Received: by mail-io0-f172.google.com with SMTP id m81so17454515ioi.13 for <28803@debbugs.gnu.org>; Sun, 22 Oct 2017 06:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=6NDUgXf5iCmNP6urKBbHBgBrONUte9rCVT/iNJa/tHI=; b=vOHM/lR2ESg+fcjAGZ2K0gQ4mEgNs+Wal8xgfR9gBroo5VE1iwOh38QyHgOn5+ds8t 0nAtlvu7bE1V2NnTUE8AEhPeG7LtoAqL378Za1Qt08x8tBbYNtZbH0KdFGxNh43TGmBT y8tRUrXsaLLarWPjTqa2qC8SSxvdMxUZFpYIeN1x8XBfZFBDPyqIa7VGmpSEubqPBzN4 kqVhlz/umBAL8t3kixSuCLn0tdXc4ApbRTp3t4gRfuFl7kPNyq5CZrdCXsnVqjO6/goi iLisKBYWIpqYOnQ4DnJWpOiUg4NabVWRD3fUxg6NtHdkTIfR6f4BtgpcMMUTwF0ZMH2e G1Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=6NDUgXf5iCmNP6urKBbHBgBrONUte9rCVT/iNJa/tHI=; b=NVH+Zllzn6020vx2KI4c0cDrHuUaT7p5pIK0VUT1VJshCvvONyXeQMVj7Z0lfIO6WV VI0dbTfEnW9ia/BCtzaLg26z/VAv6Y0odyqOtd254PEh4v/phNeA2oW8ZkKo2mDFcqY8 X1bHEMtrtQtlkr8LVijEdh4T+gPmd4yZ9DtmV92MxRDF8esw8nrzD42qTuDX9gGCenux eQOX7LlbEg5LOohVPFKEryJaRpNBiJXbZtzw2Iznpksthw9oDP2BqArGPn5QtwX6WYTP QIHdAHhF29fCO1smoY+yJUSDY/x1GgIauDJVzqmIwVtAjWc6HwjVoLap8g0WiG2x0Pi5 1DpQ== X-Gm-Message-State: AMCzsaVDpqci2yShdhomwW+mtRer04IfFaSJFixZAtESS8pytNh9dLA0 BXIMGffnfoK0hWlQqe6EQo1SDQ== X-Google-Smtp-Source: ABhQp+QduWJc8VlUNjyuuX7WhRlW0AXi0BLxpm9CbYTIfBgMiL99g6ty8dOwzgym22afSWIeN4/edw== X-Received: by 10.107.7.156 with SMTP id g28mr14156169ioi.38.1508677444237; Sun, 22 Oct 2017 06:04:04 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e68sm1445909ite.0.2017.10.22.06.04.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Oct 2017 06:04:02 -0700 (PDT) From: Noam Postavsky References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> <87zi8kcbzw.fsf@users.sourceforge.net> Date: Sun, 22 Oct 2017 09:04:01 -0400 In-Reply-To: (John Williams's message of "Sat, 21 Oct 2017 19:23:35 -0700") Message-ID: <87r2tvcp1a.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) John Williams writes: > Hooray, my first official contribution to Emacs! Now I have code=E2=80=94= not > much, but some=E2=80=94in both Emacs and Vim, which I have to think is pr= etty > rare. Congrats :) > BTW, is posting to this list really the best way to send patches? At > my job, all changes go through a code review tool similar to=C2=A0Gerrit, > with code uploaded using a command analogous to "git push", so > sending a patch as an email attachment feels clumsy and > anachronistic. For now at least yes. There has been some grumbling from others about the "anachronistic" methods, but nothing much has come of it as of yet. I have some commands in my init file for smoothing the process of sending and receiving patches between the bug list and my git repo, but they're dependent of magit, and I'm still working out the kinks. From unknown Sun Jun 22 11:48:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2017 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed patch To: John Williams Cc: 28803@debbugs.gnu.org, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150868110123215 (code B ref 28803); Sun, 22 Oct 2017 14:05:02 +0000 Received: (at 28803) by debbugs.gnu.org; 22 Oct 2017 14:05:01 +0000 Received: from localhost ([127.0.0.1]:55989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Gs9-00062G-7A for submit@debbugs.gnu.org; Sun, 22 Oct 2017 10:05:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Gs8-000623-5U for 28803@debbugs.gnu.org; Sun, 22 Oct 2017 10:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6Gs0-00042i-0n for 28803@debbugs.gnu.org; Sun, 22 Oct 2017 10:04:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6Grz-00042e-TV; Sun, 22 Oct 2017 10:04:51 -0400 Received: from [176.228.60.248] (port=1257 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e6Grz-0004jo-9i; Sun, 22 Oct 2017 10:04:51 -0400 Date: Sun, 22 Oct 2017 17:04:47 +0300 Message-Id: <83h8urb7nk.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from John Williams on Sat, 21 Oct 2017 19:23:35 -0700) References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> <87zi8kcbzw.fsf@users.sourceforge.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: John Williams > Date: Sat, 21 Oct 2017 19:23:35 -0700 > Cc: 28803@debbugs.gnu.org > > Hooray, my first official contribution to Emacs! Now I have code—not much, but some—in both Emacs and > Vim, which I have to think is pretty rare. Welcome on board, and thanks for your contribution. > BTW, is posting to this list really the best way to send patches? You are not posting to a list, you are sending to our issue tracker. Having your patches sent to a mailing list is just one of the interfaces provided by the tracker; there are others (like an Emacs interface, see the debbugs package in ELPA. > At my job, all changes go through a code > review tool similar to Gerrit, with code uploaded using a command analogous to "git push", so sending a patch > as an email attachment feels clumsy and anachronistic. For large changesets, we recommend a scratch branch.