From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Oct 2017 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 28797@debbugs.gnu.org, drew.adams@oracle.com, npostavs@gmail.com, tino.calancha@gmail.com X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" , Drew Adams , Noam Postavsky , Tino Calancha Received: via spool by submit@debbugs.gnu.org id=B.15078202006047 (code B ref -1); Thu, 12 Oct 2017 14:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Oct 2017 14:56:40 +0000 Received: from localhost ([127.0.0.1]:36221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2eue-0001ZT-BZ for submit@debbugs.gnu.org; Thu, 12 Oct 2017 10:56:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2euc-0001ZE-Bd for submit@debbugs.gnu.org; Thu, 12 Oct 2017 10:56:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2euV-0007VM-3p for submit@debbugs.gnu.org; Thu, 12 Oct 2017 10:56:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e2euU-0007V9-Te for submit@debbugs.gnu.org; Thu, 12 Oct 2017 10:56:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2euS-0000OA-V1 for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 10:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2euN-0007RD-40 for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 10:56:29 -0400 Received: from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e]:54453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2euM-0007Qz-WE for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 10:56:23 -0400 Received: by mail-qt0-x22e.google.com with SMTP id z19so14096978qtg.11 for ; Thu, 12 Oct 2017 07:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qk+Hu3kPZY77XXzZXwks3+RzNEEorQA0yjsFNpUs4ag=; b=T1XyWJBkgON0Dmi1HCptadPlvOD6KIbyDXUy8VwfaBe3FxC/tKI3mubi9NMzGtvfit IhgBbVwZCGYUD9tLrIp8wPE7M1WUYFx1i79fJ6kmtt73foWX4WZ9DMOQwIMYCfXmCWN3 MlWSZ8zF92sAyBfRdkAcS/k08J1Yr1E30OUnh1mz+0n+/wsdIJ8pKwOXur9PtHEBc+iX ENWAsJsI2dqx7GvjSAQ1A4gn8n353zTVWaIp+rZ9tAB+GRTjWMXa53UhfJ6sQV+crlGN 4FpyOktKrFmKF5bxKn9agEufgqA5m/8bR87Cs8dchDwCYQysJpJOyP5MzkbfxsETP2bq HK3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qk+Hu3kPZY77XXzZXwks3+RzNEEorQA0yjsFNpUs4ag=; b=bnglNmMaqrWhQSFOCHVyy+Jmi3DtnKxTklMJMvjN0MT3lRzVn2fAeGQ2qdVa2XqaAl Yt9nFgl6GS6Nms4tVv0x+ZqG2RAr0BEXARHzQtxHr63tDlOCj9TQpc/9AxnBAUG4dsPQ vSZfUFHe01bOVqME8xjVZWFxSlGdpBA6Otf3c+CTnoUoUbqNflPnPiIfsuyJl1td6VfI sY1Uy4PDK8oZC7kHjR9ETwU5OXHo2+1U9brXlCj7dIORGHh6UELga68rnvrQtlxq8guO S9icA3LtS9AOQCxOiwhCtwg+d1H9zz6uK+F0H5Ohc5lHWbKnAUzhE37sLnqg3auhrsuU 3mdw== X-Gm-Message-State: AMCzsaWRnMd/zJe7PM7OfROtUaLTSTZpaT+FhuPo6L7eKmg8lMJNpJQQ wzp9/rbAteZaX8wiYqm31b2pjOsTISuWVBRBXKs= X-Google-Smtp-Source: AOwi7QCkQIUQYwhDqmYHubJd4yxaFZ1nG3iy4pS/bYPCMLaFKWBwf2eTfRz+4uf/xV83yUBcjevsEqTOqMXi1FKyN4I= X-Received: by 10.37.102.15 with SMTP id a15mr1889891ybc.389.1507820178853; Thu, 12 Oct 2017 07:56:18 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Thu, 12 Oct 2017 14:56:08 +0000 Message-ID: Content-Type: multipart/alternative; boundary="089e08287c48255640055b5abe5b" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e08287c48255640055b5abe5b Content-Type: text/plain; charset="UTF-8" Hello, This is a spin-off bug report from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28792#29 This bug report is to do with: 1. Improving the format of error messages generated by catching error signals from C, so that the errors look almost like readable English instead of a dump of a list. 2. Those errors should generate a backtrace.. right now, a user needs to update the debug-on-message variable to force back traces for such messages which is, first: more cumbersome than doing M-x toggle-debug-on-error and then recreating the error, and second: not a common knowledge. Excerpt from the above referenced debbugs thread for continuity: ===== OK, but it seems non-standard compared to error messages from Elisp land. Shouldn't (file-error Non-regular file Is a directory /home/kmodi/.emacs.d/foo) look like: file-error: Non-regular file: /home/kmodi/.emacs.d/foo is a directory - Why those parentheses? - Why are "N" and "I" capitalized in-between that "sentence".. error messages are usually sentences without ending in period, right? - Above instead looks like a list printed with 3 elements. Also, the error is not-informative.. the user is trying to trash foo/ and knows that foo/ is a directory.. so how would the below help? (file-error Non-regular file Is a directory /home/kmodi/.emacs.d/foo) ===== -- Kaushal Modi --089e08287c48255640055b5abe5b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

This is a spin-off bug report fr= om=C2=A0https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28792#29
This bug report is to do with:

1. Imp= roving the format of error messages generated by catching error signals fro= m C, so that the errors look almost like readable English instead of a dump= of a list.
2. Those errors should generate a backtrace.. right n= ow, a user needs to update the debug-on-message variable to force back trac= es for such messages which is, first: more cumbersome than doing M-x toggle= -debug-on-error and then recreating the error, and second: not a common kno= wledge.

Excerpt from the above referenced debbugs = thread for continuity:

=3D=3D=3D=3D=3D
<= div style=3D"color:rgb(33,33,33);font-size:13px">OK, but it seems non-stand= ard compared to error messages from Elisp land.

Shouldn't

(file-er= ror Non-regular file Is a directory /home/kmodi/.emacs.d/foo)

look like:

file-error: Non-regular file: /home/kmodi/.emacs.d/foo is a director= y

- Why those parentheses?
- Why are "N" and = "I" capitalized in-between that "sentence".. error mess= ages are usually sentences without ending in period, right?
- Above instead looks like a list p= rinted with 3 elements.

Also, the e= rror is not-informative.. the user is trying to trash foo/ and knows that f= oo/ is a directory.. so how would the below help?

(file-error Non-regular file Is a directory /home/kmodi/.ema= cs.d/foo)=C2=A0
=3D= =3D=3D=3D=3D
<= br>

=
--

Kaushal Modi

--089e08287c48255640055b5abe5b-- From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Oct 2017 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kaushal Modi Cc: 28797@debbugs.gnu.org, Drew Adams , Tino Calancha Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15078209397340 (code B ref 28797); Thu, 12 Oct 2017 15:09:02 +0000 Received: (at 28797) by debbugs.gnu.org; 12 Oct 2017 15:08:59 +0000 Received: from localhost ([127.0.0.1]:36236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2f6Z-0001uK-1F for submit@debbugs.gnu.org; Thu, 12 Oct 2017 11:08:59 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:44180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2f6X-0001u3-M7 for 28797@debbugs.gnu.org; Thu, 12 Oct 2017 11:08:57 -0400 Received: by mail-wm0-f47.google.com with SMTP id 196so24332852wma.1 for <28797@debbugs.gnu.org>; Thu, 12 Oct 2017 08:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=by8PEmjzAZSPJ9ZG5gz57yaFlaTSbokPhb4u6+wsOs4=; b=tZCV5VfGV6LUG+ocepfW6+Wp421pqI6dc0mXcWJ2Tkl1Z2eWV2EMYHua5ocuFXOkoa +AsRJBaN+S5fvRvm2o43EtdtEJS4JfIWu/dLFSgy+orq7Sd7cjDZZTJQJEtVq9WxPih0 RXQvx+q+9byNkdyL2y1e665dLc3dh4PY6HgkOFGiLXPixzLNDc24WRV+K2yuGWXqb+Pu H2GZtf+SGvNrjnG6TT+F4Xc5CfCA7L9HMy5AB1ojx7RTKflhpNhROx+9q7DbWpc1bSCb depS9Y0mRqZ3+HUmbKiF+e8UnqVRBU7UR0/cCQ6LEyfBfab3YbgKjxMnYhCV0jrX9RZQ KkbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=by8PEmjzAZSPJ9ZG5gz57yaFlaTSbokPhb4u6+wsOs4=; b=lfGq0LFTg0h4dmR35yRdqMdLfZLfAIBNnEXcNTptUjeyXRQcbIni4smjXhN1+Hywt2 wyiCMQq9ku+QpZNhmNVw4jXxeAvYxX6XnEtcB6XjWjXNtYypXWl2GsqUgt8q+KH4IQ/+ gwWuw2cAsD272JuRPimbWhzz+3YpwXMhjKKtjI2Cc+n9/jmnVwrRP1FHG2ovhOc7L+Ti bBIHQmHc2leJeGRBfa8fZjzT0SARMLf5xXHzOck1aPzO8tr8E4FXZHWVaPEMIprAckHq vce+tVipVnVONa++EOhLk+ZuPxTteB5OObuRdQgaTTtRDtg8IoP1iq+fm+MfmsuVTNa+ YDBw== X-Gm-Message-State: AMCzsaVDqxnTlWbo4tna86C6tqzH1SY/hX0ZqwPYlBjyRm8O07MuZGvz V1E0vYRf1R8VuWOj80uAqqphnW018b/DrAwMqg0= X-Google-Smtp-Source: AOwi7QCEEwWjCzm+qGoQSpqBSeBUQs2B3RhqXFj9T6U5RkxeRFqltYJKzVz0gf7KNEnHyIiLU1RH4CJ3ZNc3pKPorw4= X-Received: by 10.223.129.99 with SMTP id 90mr2225855wrm.243.1507820932110; Thu, 12 Oct 2017 08:08:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.146.193 with HTTP; Thu, 12 Oct 2017 08:08:51 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Thu, 12 Oct 2017 11:08:51 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Thu, Oct 12, 2017 at 10:56 AM, Kaushal Modi wrote: > 2. Those errors should generate a backtrace.. right now, a user needs to > update the debug-on-message variable to force back traces for such messages > which is, first: more cumbersome than doing M-x toggle-debug-on-error and > then recreating the error, and second: not a common knowledge. Another possibility is setting debug-on-signal, see (elisp) Handling Errors. PS. please use X-Debbugs-CC to Cc bugs to people other than the bug list, that we get the version of the mail with the bug number, see https://debbugs.gnu.org/Reporting.html From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 03:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kaushal Modi Cc: 28797@debbugs.gnu.org, drew.adams@oracle.com, tino.calancha@gmail.com Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.150786459927659 (code B ref 28797); Fri, 13 Oct 2017 03:17:01 +0000 Received: (at 28797) by debbugs.gnu.org; 13 Oct 2017 03:16:39 +0000 Received: from localhost ([127.0.0.1]:36566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2qSl-0007Bl-5s for submit@debbugs.gnu.org; Thu, 12 Oct 2017 23:16:39 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:43934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2qSi-00073u-Ip; Thu, 12 Oct 2017 23:16:36 -0400 Received: by mail-io0-f180.google.com with SMTP id 134so3380276ioo.0; Thu, 12 Oct 2017 20:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2/evnU9XidgWF0EuCvp7xThXfLNTfAKD9T5UIVUeO7U=; b=Lq3fSL6WI6+YCSvwL+mP0l2VQbumBvvV/YOD/v6fRKC7SfzVEXpOQT+eeAjfVTfdM+ iLsrAH2SuYg3zhxsF/++/qtM1FWSbHzrWa+s+3R8hO5UFXgVX7Q4BIWTApYhNqXZs3Lc JfDeBKJ9sLkIZBL42wKsq0DhMjFIFDhQfy3RFfCJcHjRxmAPkwid1010d93kalXRIgYI eVTFKSTynh1z7wanNKYAukmZ/8rIqsD7rXZOv57buTxxoDmzFoR4kAWRaoeowb0PvsVi 3+tXbbBPrNBMcklsm+frERrcszEuoTQYS3IZrBW/Wh9+GosnjPVPCARG/8cvYeMQ1Pt5 H2JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=2/evnU9XidgWF0EuCvp7xThXfLNTfAKD9T5UIVUeO7U=; b=pzWL4SIQ2DqJi22QuXxUloCaHFGdA769gwuS1ICqVnFdzQ+6ubSeagqeWz36k3Pj6N QwIQLtF7pznR6bDiHzi4hHLiU9A2c2jpGUwNHa5JGvGdXQjtBt7mn6AHEQTHUvTFgi4E hnFCJIS9wTNcShwflTEfCelpMT8WYe7gY0rIfqu3xLhjyiWNNtiapUCXtp84QCuPDLN/ HoRoiTMSMppq6rV+XqJ1RetED8zazDZyw4aE6O6JxbLJIiql/qXCQMTPDb7mDEsdSYr/ fYV6PdQVePRWGOOCQBVEMBeiHYKz8kjAZ6MhgDwg5rVcbWdmJw+2JS7S1IO2MrKOsLVL Oobg== X-Gm-Message-State: AMCzsaVDnrsWEBeV19CLa/9W++vlSDNyJYmdtzlxUP429j77Eytwd5QI tvqsGeIkFvr5fynnVGzqOQORyE+f X-Google-Smtp-Source: AOwi7QDJmnSIPMUkzmc3rmTuVU2tEgch5Hz9yyfBScjhjN80p93lEGy+OpaUYUZP7YKVPBJ0wG4geg== X-Received: by 10.107.201.69 with SMTP id z66mr48032iof.118.1507864590891; Thu, 12 Oct 2017 20:16:30 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u125sm5564725ioe.65.2017.10.12.20.16.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 20:16:29 -0700 (PDT) From: Noam Postavsky References: Date: Thu, 12 Oct 2017 23:16:28 -0400 In-Reply-To: (Kaushal Modi's message of "Thu, 12 Oct 2017 14:56:08 +0000") Message-ID: <87a80vbuur.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain severity 28797 minor tags 28797 + patch quit Kaushal Modi writes: > 1. Improving the format of error messages generated by catching error > signals from C, so that the errors look almost like readable English > instead of a dump of a list. > 2. Those errors should generate a backtrace.. right now, a user needs > to update the debug-on-message variable to force back traces for such > messages which is, first: more cumbersome than doing M-x > toggle-debug-on-error and then recreating the error, and second: not > a common knowledge. Here's a patch, uses error-message-string for #1, condition-case-unless-debug for #2. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Improve-dired-deletion-error-handling-Bug-28797.patch Content-Description: patch >From a150d99f8e278e9b90240e4b0c460ca974b32aeb Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 12 Oct 2017 23:12:00 -0400 Subject: [PATCH v1] Improve dired deletion error handling (Bug#28797) * lisp/dired.el (dired-internal-do-deletions): Use condition-case-unless-debug. Use `error-message-string' to produce a human readable error message. --- lisp/dired.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/dired.el b/lisp/dired.el index 9e09d349f7..b24fea703a 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -3132,7 +3132,7 @@ dired-internal-do-deletions (while l (goto-char (cdr (car l))) (let ((inhibit-read-only t)) - (condition-case err + (condition-case-unless-debug err (let ((fn (car (car l)))) (dired-delete-file fn dired-recursive-deletes trash) ;; if we get here, removing worked @@ -3143,7 +3143,7 @@ dired-internal-do-deletions #'dired-delete-entry fn)) (quit (throw '--delete-cancel (message "OK, canceled"))) (error ;; catch errors from failed deletions - (dired-log "%s\n" err) + (dired-log "%s: %s\n" (car err) (error-message-string err)) (setq failures (cons (car (car l)) failures))))) (setq l (cdr l))) (if (not failures) -- 2.11.0 --=-=-=-- From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com Reply-To: Eli Zaretskii Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.150788515928253 (code B ref 28797); Fri, 13 Oct 2017 09:00:02 +0000 Received: (at 28797) by debbugs.gnu.org; 13 Oct 2017 08:59:19 +0000 Received: from localhost ([127.0.0.1]:36861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2voN-0007Lc-9J for submit@debbugs.gnu.org; Fri, 13 Oct 2017 04:59:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2voK-0007LM-HF for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 04:59:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2voE-00045V-Kn for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 04:59:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2vo8-00041s-2L; Fri, 13 Oct 2017 04:59:04 -0400 Received: from [176.228.60.248] (port=1271 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e2vo5-0002ky-G0; Fri, 13 Oct 2017 04:59:02 -0400 Date: Fri, 13 Oct 2017 11:58:52 +0300 Message-Id: <83y3ofjuer.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87a80vbuur.fsf@users.sourceforge.net> (message from Noam Postavsky on Thu, 12 Oct 2017 23:16:28 -0400) References: <87a80vbuur.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Thu, 12 Oct 2017 23:16:28 -0400 > Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com > > > 1. Improving the format of error messages generated by catching error > > signals from C, so that the errors look almost like readable English > > instead of a dump of a list. > > 2. Those errors should generate a backtrace.. right now, a user needs > > to update the debug-on-message variable to force back traces for such > > messages which is, first: more cumbersome than doing M-x > > toggle-debug-on-error and then recreating the error, and second: not > > a common knowledge. > > Here's a patch, uses error-message-string for #1, This doesn't handle all of the parts of the complaint, does it? > condition-case-unless-debug for #2. This is quite a radical change in very old behavior, so if it is deemed a good idea, it should go to master. Thanks. From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 28797@debbugs.gnu.org, kaushal.modi@gmail.com, tino.calancha@gmail.com Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.1507900511981 (code B ref 28797); Fri, 13 Oct 2017 13:16:02 +0000 Received: (at 28797) by debbugs.gnu.org; 13 Oct 2017 13:15:11 +0000 Received: from localhost ([127.0.0.1]:36994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2znz-0000Fl-7W for submit@debbugs.gnu.org; Fri, 13 Oct 2017 09:15:11 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:47177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2znx-0000FV-QZ for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 09:15:10 -0400 Received: by mail-io0-f172.google.com with SMTP id h70so8932311ioi.4 for <28797@debbugs.gnu.org>; Fri, 13 Oct 2017 06:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Vz69gFYmAmU8oNKKZE2ifE0ARMevVmbYuuVdOlHBP8k=; b=sffdQQ4gU13VrNKpQEjgup7zJRJ7V2+3zonHs2+VQrRFwTHKpK/TDl1qX7mGqZXhCr y7JH1ykq5aqC2EJla2WkS6f0GIL0Dd0/r0wEgrCT1Td8X5AFS5WW63FjYGoDE3HipkAY NpDUJzMhSQ4Pd0va7WIRnilkxQAl+pgGtKV36bkWXZLOQ3W3CMjEzvCZy8+LqPpGhM27 waJQLrQl/FCSK2V1Zi5SkY2NpIOzrE00msin3YX+kIL6VK0GvgpI1/xVyoE5CdzEfciN bPE0JUV53McZFo6GecZlJ8xFo2XiyNVBAAhoSTnOvSik/nvTq9mWkYpJvTDbfZEdb9SH junw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Vz69gFYmAmU8oNKKZE2ifE0ARMevVmbYuuVdOlHBP8k=; b=jD2LpuJaaHXP2XyaRJUMAHQA3LedaLbmnCI6pw78JwSJrSOdTUBjV5sjHwJHV3MuVD 8qRYHyaFTMgJv+OUE8DwmkNyyaJ09Rbl9v8anqyN1+dxfV7StsCZa8sSYFHrR5x290uY J0CtiAUyOhyM5x0Fv6rMf0tRsLe2mbmnpTobz8D5PU/BMm8L/WltTQ+JTP2TDjc6hGio KqHIpWS/KSOE1aGVp0J4+r2Gkx3dnWaW3KzukSZxBauXDjmNLt/7U3BwLw3LhwWKRVfc vL/MxdRf/dPpH34uJLNry/w8CtniYz590ifrn8NmCaEjg9gB7xgILecPPxfZMrx6RV3z QdwQ== X-Gm-Message-State: AMCzsaXGU1oDoeAlAaFah1pHSDbcuCMUx1UeYfVh9988VT60ou/Gsj0B TmFKoYJPz9jfuEtZcL+aXc0= X-Google-Smtp-Source: AOwi7QCW6bMoXsBN2eZJHio0qJuWRd8PqVcFJm5mkFZ5jHNrD2NMtk6HYYkSLNinKIwzC2h3h5Mivg== X-Received: by 10.107.46.199 with SMTP id u68mr1719293iou.174.1507900504010; Fri, 13 Oct 2017 06:15:04 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r65sm683635ith.1.2017.10.13.06.15.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 06:15:02 -0700 (PDT) From: Noam Postavsky References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> Date: Fri, 13 Oct 2017 09:15:01 -0400 In-Reply-To: <83y3ofjuer.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Oct 2017 11:58:52 +0300") Message-ID: <871sm7b356.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Eli Zaretskii writes: >> Here's a patch, uses error-message-string for #1, > > This doesn't handle all of the parts of the complaint, does it? The resulting error will look like file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo It's not quite the perfect sentence envisioned on the OP, but it gets all the information across, with punctuation separating the parts. Shouldn't (file-error Non-regular file Is a directory /home/kmodi/.emacs.d/foo) look like: file-error: Non-regular file: /home/kmodi/.emacs.d/foo is a directory - Why those parentheses? - Why are "N" and "I" capitalized in-between that "sentence".. error messages are usually sentences without ending in period, right? - Above instead looks like a list printed with 3 elements. For this part: Also, the error is not-informative.. the user is trying to trash foo/ and knows that foo/ is a directory.. so how would the below help? I guess what would help is printing "there is a bug with Emacs renaming a directory across filesystems", but that seems a bit out of reach for a simple error formatting function... >> condition-case-unless-debug for #2. > > This is quite a radical change in very old behavior, so if it is > deemed a good idea, it should go to master. Hmm, it doesn't seem that radical to me, but I don't have a problem putting it only to master, or even not doing that at all and just saying the user should use debug-on-signal. From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 28797@debbugs.gnu.org, kaushal.modi@gmail.com, tino.calancha@gmail.com Reply-To: Eli Zaretskii Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15079022434763 (code B ref 28797); Fri, 13 Oct 2017 13:45:01 +0000 Received: (at 28797) by debbugs.gnu.org; 13 Oct 2017 13:44:03 +0000 Received: from localhost ([127.0.0.1]:37032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e30Fv-0001Ek-Gb for submit@debbugs.gnu.org; Fri, 13 Oct 2017 09:44:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e30Ft-0001Dx-AP for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 09:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e30Fj-00017G-92 for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 09:43:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e30FY-0000sm-TO; Fri, 13 Oct 2017 09:43:40 -0400 Received: from [176.228.60.248] (port=2107 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e30FY-0004yZ-AE; Fri, 13 Oct 2017 09:43:40 -0400 Date: Fri, 13 Oct 2017 16:43:33 +0300 Message-Id: <83o9pbjh8b.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <871sm7b356.fsf@users.sourceforge.net> (message from Noam Postavsky on Fri, 13 Oct 2017 09:15:01 -0400) References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com > Date: Fri, 13 Oct 2017 09:15:01 -0400 > > Eli Zaretskii writes: > > >> Here's a patch, uses error-message-string for #1, > > > > This doesn't handle all of the parts of the complaint, does it? > > The resulting error will look like > > file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo > > It's not quite the perfect sentence envisioned on the OP, but it gets > all the information across, with punctuation separating the parts. OK, close enough for me. > >> condition-case-unless-debug for #2. > > > > This is quite a radical change in very old behavior, so if it is > > deemed a good idea, it should go to master. > > Hmm, it doesn't seem that radical to me, but I don't have a problem > putting it only to master, or even not doing that at all and just saying > the user should use debug-on-signal. It's radical because we never produce backtrace in similar cases anywhere else in Emacs. Let's wait to hear what others think about this part. Thanks. From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2017 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15086897024142 (code B ref 28797); Sun, 22 Oct 2017 16:29:02 +0000 Received: (at 28797) by debbugs.gnu.org; 22 Oct 2017 16:28:22 +0000 Received: from localhost ([127.0.0.1]:56103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6J6s-00014k-51 for submit@debbugs.gnu.org; Sun, 22 Oct 2017 12:28:22 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:47145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6J6q-00014V-1m for 28797@debbugs.gnu.org; Sun, 22 Oct 2017 12:28:20 -0400 Received: by mail-it0-f52.google.com with SMTP id p138so3421276itp.2 for <28797@debbugs.gnu.org>; Sun, 22 Oct 2017 09:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2HYUlva+MUvhihtJEZK6D07/qG1uyOMp66NI9rAZ1Gk=; b=o8enw7qeJ/Gfpfh0zbw5aTX3vWbLSFKu4vehR5DX2pIW1KtH6rl60nZPUcB+uQa9oV bcbeCS5ixvl9sGO5UBR/A478Ex4BxhVhS8r38jlJXca+RRuPQOjrXvl1JeIJfTjWuK9S MvOpcjflQDq++7FMjYdjnkF6ZP29fWlNiDKBpE+OPv2mSvAWNELBg4W3QR4zx/Wl0EhG vEC8YMaktULPJhXjm8BTsTwohZgBiTD3nw1cC0wVTecCqCjJ0y/ErgdPbs/itnxgJCi7 LuldqvPlt4TDlyyzj3TK9RmXFRuMv3UoJvYk5kL3yzurqOttxUPiS9MRp5ykWRQk14bI 5WuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=2HYUlva+MUvhihtJEZK6D07/qG1uyOMp66NI9rAZ1Gk=; b=Oecd+4h0qALb8oWxwn6tdRWeUqtqupY6b7279lkoKM2yHpOY+7GL6GO/5U8numuXNk Uwdo+EAnIsOZhOhwgR/Qse52qi72wLVCOry2WTEJ9Gyf4FT2DYuTN5e7UBW7keAjoEMM EhI4GQEz78gTpGEhcMOyOivqzUyLaH4wAB77KEUsZOu8VW0wlo1spKes+N+54lkJEs6j SlEff7eJ5neOTE2skRe8QKoUZDOe2olSHc8F1o0ZtPXIRm7qqxcxGA+mYCJiaGSkvz3F PiN9c26Jg77dh5A4vQjPntMLuHdoIgR7H/nMCsVxy9cMs0AbOJ8UeNh/ok2CWQGb3JYa ZzPg== X-Gm-Message-State: AMCzsaUd3Ato5h3AKONYRzx0bJ8Y8UhRoc8j4KcZMOAU4VHI/9NWeBaN 3cAnm+vyZ+uY57wU/J6uDVs= X-Google-Smtp-Source: ABhQp+Rw3/JhFt433HK1yvC0Rwom/b0CLRuoZqNVO6+uBeynfUnvT+IH0LArBYLiUFg9HjbZwRqXLg== X-Received: by 10.36.95.2 with SMTP id r2mr6410340itb.25.1508689694299; Sun, 22 Oct 2017 09:28:14 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e89sm1557108itd.3.2017.10.22.09.28.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Oct 2017 09:28:13 -0700 (PDT) From: Noam Postavsky References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> <83o9pbjh8b.fsf@gnu.org> Date: Sun, 22 Oct 2017 12:28:11 -0400 In-Reply-To: <83o9pbjh8b.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Oct 2017 16:43:33 +0300") Message-ID: <87o9ozcfl0.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Eli Zaretskii writes: >> >> condition-case-unless-debug for #2. >> > >> > This is quite a radical change in very old behavior, so if it is >> > deemed a good idea, it should go to master. >> >> Hmm, it doesn't seem that radical to me, but I don't have a problem >> putting it only to master, or even not doing that at all and just saying >> the user should use debug-on-signal. > > It's radical because we never produce backtrace in similar cases > anywhere else in Emacs. I'm not sure which cases you consider "similar". > Let's wait to hear what others think about this part. Not seeing any opinions, so here is a fact: due to bug#11218, changing this breaks dired-test-bug27940 [1]. Fixing #11218 would involve some major changes to ert internals. [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27940#65 From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2017 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: Eli Zaretskii , Tino Calancha , 28797@debbugs.gnu.org, kaushal.modi@gmail.com Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15088596965027 (code B ref 28797); Tue, 24 Oct 2017 15:42:02 +0000 Received: (at 28797) by debbugs.gnu.org; 24 Oct 2017 15:41:36 +0000 Received: from localhost ([127.0.0.1]:60050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e71Ki-0001J1-1N for submit@debbugs.gnu.org; Tue, 24 Oct 2017 11:41:36 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:56486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e71Kf-0001In-Je for 28797@debbugs.gnu.org; Tue, 24 Oct 2017 11:41:33 -0400 Received: by mail-wm0-f50.google.com with SMTP id z3so10229237wme.5 for <28797@debbugs.gnu.org>; Tue, 24 Oct 2017 08:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=R8VeUir9hUh3ECgpwa7EWS2DMDeJHgk2gqErf2fP2Oc=; b=uOdCgkRKn2EuYZh4Co7U4qZloCJT5P8bbxQHk3weB1Otd7jF1JUfB4DrmIJj4ct5jI MiVq2/v8HigKzGsMPRRcW82oXTrTNBQ2krqZkyTb/JwlDgDoXOAo89TC4cwgurtP/OMD e2Z8KQDhTDZQDIYqPgOezlEqAisKfPrgmkXKQBi8WvTQ31mBWUiWDClxuDPnr6xPCN66 3zutQaT7bSJwHe9k8CPJ0J/9l0XSQtdCnoanG0OUeboz1zdd90LJ4RU23WrG5Ru58YmW PCoJceQy4UYt7WLYOvK+mJGlNpMUirYCBgEzietLZ4NpuU5KZPV0THZP0L23UvsgkP4i ozOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=R8VeUir9hUh3ECgpwa7EWS2DMDeJHgk2gqErf2fP2Oc=; b=EGImE5k+5LB1/QPxxRcqHx6W9/sfXLwYftUKOOrv2FmtJKHSl6taR0xBKgFJA2sqnt vKwzS+yewQM7F33vnVaaG34zRZzVad9B2rnLQ9JC58N8WXrXRJp/B/FgPuvgmE7fHdeI 4PtNyxGI5wZpww+z6WhAmDVHY6Vkx0QMtY6km+kfU19zzA7XB1zOyo0yGDraJ1juvWRH vBWNrS31lRsg0w/owbBLHbso5SYAWrjFW294OAtANdrnD5Id/tHdXUpMlzpbkC1rnzHp j25iU4aOKGi2hKjogLfYCmugSjxG10vIW4tIPVeLyGXupzYXvxneC0EFCR3eBMgaikte x70w== X-Gm-Message-State: AMCzsaU0yjqItCSWY6leJr8rry0FLV1+QN9BzmquzjvdV7FRwpFYIOd6 fUd0EmbfCWJNgjJHTmBZ9I4= X-Google-Smtp-Source: ABhQp+Q0X95/H67i9Y1HseMBkAiu1ot4LwB7emZzQ5HZ3coBESYLVjJr2eSCxNT4YaDAAuiGWLlrcg== X-Received: by 10.28.19.130 with SMTP id 124mr8158163wmt.108.1508859687604; Tue, 24 Oct 2017 08:41:27 -0700 (PDT) Received: from calancha-pc (44.red-79-159-65.dynamicip.rima-tde.net. [79.159.65.44]) by smtp.gmail.com with ESMTPSA id s67sm479690wmd.23.2017.10.24.08.41.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 08:41:25 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 25 Oct 2017 00:41:23 +0900 (JST) X-X-Sender: calancha@calancha-pc In-Reply-To: <87o9ozcfl0.fsf@users.sourceforge.net> Message-ID: References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> <83o9pbjh8b.fsf@gnu.org> <87o9ozcfl0.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sun, 22 Oct 2017, Noam Postavsky wrote: >> Let's wait to hear what others think about this part. > > Not seeing any opinions, so here is a fact: due to bug#11218, changing > this breaks dired-test-bug27940 [1]. Fixing #11218 would involve some > major changes to ert internals. > > [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27940#65 >The "no" case of dired-test-bug27940 is failing now. I guess if >RECURSIVE is set to nil, we should not try to delete non-empty >directories, or maybe just catch the error if it happens? I think that might be OK. Following add that change on top of your original patch: --8<-----------------------------cut here---------------start------------->8--- commit 36c924fca0b4cde3a320b10d40e9453e55170a0f Author: Tino Calancha Date: Wed Oct 25 00:38:56 2017 +0900 Improve dired deletion error handling (Bug#28797) * lisp/dired (dired-delete-file): If the dir is non-empty and RECURSIVE is nil then return 'skip and don't try to delete the dir (Bug#28797). * lisp/dired.el (dired-internal-do-deletions): Use condition-case-unless-debug. Use `error-message-string' to produce a human readable error message. Don't call dired-fun-in-all-buffers if `dired-delete-file' returns 'skip. diff --git a/lisp/dired.el b/lisp/dired.el index 1ec3ac4f99..74a37da992 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -3062,7 +3062,10 @@ dired-delete-file ('"no" (setq recursive nil)) ('"quit" (keyboard-quit))))) (setq recursive nil)) ; Empty dir or recursive is nil. - (delete-directory file recursive trash)))) + ;; Don't delete non-empty dirs when recursive is nil. + (if (and (not empty-dir-p) (not recursive)) + 'skip + (delete-directory file recursive trash))))) (defun dired-do-flagged-delete (&optional nomessage) "In Dired, delete the files flagged for deletion. @@ -3134,18 +3137,19 @@ dired-internal-do-deletions (while l (goto-char (cdr (car l))) (let ((inhibit-read-only t)) - (condition-case err + (condition-case-unless-debug err (let ((fn (car (car l)))) - (dired-delete-file fn dired-recursive-deletes trash) - ;; if we get here, removing worked - (setq succ (1+ succ)) - (progress-reporter-update progress-reporter succ) - (dired-fun-in-all-buffers - (file-name-directory fn) (file-name-nondirectory fn) - #'dired-delete-entry fn)) + (if (eq 'skip (dired-delete-file fn dired-recursive-deletes trash)) + nil + ;; if we get here, removing worked + (setq succ (1+ succ)) + (progress-reporter-update progress-reporter succ) + (dired-fun-in-all-buffers + (file-name-directory fn) (file-name-nondirectory fn) + #'dired-delete-entry fn))) (quit (throw '--delete-cancel (message "OK, canceled"))) (error ;; catch errors from failed deletions - (dired-log "%s\n" err) + (dired-log "%s: %s\n" (car err) (error-message-string err)) (setq failures (cons (car (car l)) failures))))) (setq l (cdr l))) (if (not failures) --8<-----------------------------cut here---------------end--------------->8--- From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2017 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tino Calancha Cc: Eli Zaretskii , 28797@debbugs.gnu.org, kaushal.modi@gmail.com Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.15088880214449 (code B ref 28797); Tue, 24 Oct 2017 23:34:02 +0000 Received: (at 28797) by debbugs.gnu.org; 24 Oct 2017 23:33:41 +0000 Received: from localhost ([127.0.0.1]:60411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78hY-00019h-Tr for submit@debbugs.gnu.org; Tue, 24 Oct 2017 19:33:41 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:52648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78hX-00019Q-H5 for 28797@debbugs.gnu.org; Tue, 24 Oct 2017 19:33:39 -0400 Received: by mail-it0-f42.google.com with SMTP id j140so12079482itj.1 for <28797@debbugs.gnu.org>; Tue, 24 Oct 2017 16:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=a7R/fD4yq8iqbWF90C/z1NERRaHULSEQtzRaK1I/g/o=; b=ZhnWISqA6xnksRTPfrLtQ9HKnVgvyfqvpkIA8FCrdU3097d6b9RrJ799VyEl1eT7cr sOuHwmO+jng6gz5rqgyyQgqagUSeyt6EHrfjM1ebKTPS8p4tMfPCJ/pxJfGhCBRKNQZp 1MlHZ5vMNC/eR7fTtl1asoiSQy+xaqRauu1FFtbWp6XDfTfKmQkM0bKh5PuDD+9qO2tW sMdLhGkq93RWjR4O97vGi2cNCeXyI68/eTFBt06EqfgeDkuAzbuOjQj7Q0WcCObv4ocw 5Q1sOc8vVjqkS0YtKoVNbWPRpIzBvbMSiiltMkpB2oj+7d4G9CnwZEouW8Z7dwLfAj9b 34TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=a7R/fD4yq8iqbWF90C/z1NERRaHULSEQtzRaK1I/g/o=; b=I5YI6z3Ibgisol7g/ZaJ7+3YaoepcBczfHt4jQEKDSIo/1BICDVaQrA0r0ynTsOxqz EVbQ1laPvKR05A/qiMUe8IkobrdcBjsyuZSXxoXulzsPkyIF8UqUhIjdRctw7X0uO0yc l/lN03+Os+rulKe3Mw9CRqO0UKSdgTxK5u2PTgNnVwJ0tbcr9IQYbynixw9XR3RcedP3 rVi9L1PP/zJ1Me8rFbWIRnVGqazjj8D6/oaB4aCKF1PFFxnzBQTshpLHIeP2ZiB/rNQt JblcZybvqI5Duh65OtVQj3P2hr8qYf/hQQQNUPAsgD34q45sg9yTJQM51FhhRk+pX4LG X9xQ== X-Gm-Message-State: AMCzsaXaX25ReRXGH7M4jLJzS/pwvOsAa7QgjyNaiXUvIQkEB6nrVAT9 UoKpwL/F4deSjvxE8CcpdRc= X-Google-Smtp-Source: ABhQp+SbrWpvXjdqf3b9V+VKrkRHQ8e5ZWMvJ7N78THxv92zE6GLfPuH6d100fd8im8RUJwfuFeYNQ== X-Received: by 10.36.77.131 with SMTP id l125mr301430itb.7.1508888013919; Tue, 24 Oct 2017 16:33:33 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b66sm669797itb.28.2017.10.24.16.33.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 16:33:32 -0700 (PDT) From: Noam Postavsky References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> <83o9pbjh8b.fsf@gnu.org> <87o9ozcfl0.fsf@users.sourceforge.net> Date: Tue, 24 Oct 2017 19:33:30 -0400 In-Reply-To: (Tino Calancha's message of "Wed, 25 Oct 2017 00:41:23 +0900 (JST)") Message-ID: <87a80gce9h.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Tino Calancha writes: > On Sun, 22 Oct 2017, Noam Postavsky wrote: > >>The "no" case of dired-test-bug27940 is failing now. I guess if >>RECURSIVE is set to nil, we should not try to delete non-empty >>directories, or maybe just catch the error if it happens? Just to clarify, I wrote this before I had figured the Bug#11218 issue. We *are* currently catching the error, but due to Bug#11218 catching with condition-case-unless-debug (as opposed to condition-case) doesn't work inside ert tests. > * lisp/dired (dired-delete-file): If the dir is non-empty and > RECURSIVE is nil then return 'skip and don't try to delete > the dir (Bug#28797). I think it's okay to do this if we think it would be better for users to avoid triggering the error messages altogether. But it should be a separate decision from whether we want condition-case or condition-case-unless-debug. From unknown Sun Jun 15 08:50:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2017 17:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.150990241224225 (code B ref 28797); Sun, 05 Nov 2017 17:21:02 +0000 Received: (at 28797) by debbugs.gnu.org; 5 Nov 2017 17:20:12 +0000 Received: from localhost ([127.0.0.1]:52501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOai-0006Ia-J0 for submit@debbugs.gnu.org; Sun, 05 Nov 2017 12:20:12 -0500 Received: from mail-io0-f176.google.com ([209.85.223.176]:55591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOaf-0006IF-Pw; Sun, 05 Nov 2017 12:20:10 -0500 Received: by mail-io0-f176.google.com with SMTP id p186so13327873ioe.12; Sun, 05 Nov 2017 09:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WrF80aVkjfln+ikQ9KVqRVhyepZNL4at+aa4gl5J0IQ=; b=tOXpdUkpskZ5ZM3+B000e/AfDaUBfzTfEmMCFWeamD5fWJfpt341XfiMaypvn37v12 2uiJWdij/cmcBd2OGIhrpYBBSsVloFMIo5TtTvgy3QYUYgo0JlYpPQcmFOCR3+YgEJNo be0slZxTi5zeRbKl+NlUuJJ0pqBrh1K414EsP7pEQX32vE7Qa4aAj3KdId6a7Obl0AcF 31Nw8AEmEE43vXdUQASu6hoI5QNU0yJLL4Ir15+yPKGXzm61iSKhH4LcuQPveCEIaA7e PiOJKOVcEQaY86YnC/xwej0hsbKCLS9YOes+hm62DjK2ByMCgSsD/lpaV5DBu0KXLNAa 300g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=WrF80aVkjfln+ikQ9KVqRVhyepZNL4at+aa4gl5J0IQ=; b=VJKi+vBEbbKm3ukpb5fbQTPuQ3eV/ily0jB4hlPjh0FGvD0qRhrG6OtWIHc3htH8An 9Py3yz5kS4g5snACR+kwfyMMut7KFGijC5RnQ+J1ak9R5KuJHQEfQrVLzQfUY153S+70 3BN+uiGo28pJuUllEGx7w+YjrhfcV/oymElyz2dtSlfXnVasVbFQcA1Ex+rU3Hx3BB+b a4mmg766cshzFC4oAfIRq/UecNkOlCZpDC0+wKaRiZCoAcDzUIGgNIu+2e0PduMfoKJS 4kU8O79alLsAQOAqdK91awXgzsEMxdp2N9DjOI+uDqKUZ2XrWkHOAHCTB6waoLCdmcs3 lhHw== X-Gm-Message-State: AJaThX4TfM3gjHoqhA6fL354U1mwW2dmEdOdZQydaieiQq6WeLXxajU4 3aVffO/2khMkU6du4LAuyHWJEw== X-Google-Smtp-Source: ABhQp+SbIHGNr2hvghqO5RAYRk5EAHH8az0ZndxKtbIxhsTg5t8bUNF9H4gRC8CUTfX8zDL7BNE/iQ== X-Received: by 10.107.112.3 with SMTP id l3mr17064778ioc.105.1509902404180; Sun, 05 Nov 2017 09:20:04 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id j71sm4356414itj.2.2017.11.05.09.20.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 09:20:03 -0800 (PST) From: Noam Postavsky References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> <871sm7b356.fsf@users.sourceforge.net> <83o9pbjh8b.fsf@gnu.org> Date: Sun, 05 Nov 2017 12:20:02 -0500 In-Reply-To: <83o9pbjh8b.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Oct 2017 16:43:33 +0300") Message-ID: <87d14w7id9.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 28797 fixed close 28797 26.1 quit Eli Zaretskii writes: >> The resulting error will look like >> >> file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo >> >> It's not quite the perfect sentence envisioned on the OP, but it gets >> all the information across, with punctuation separating the parts. > > OK, close enough for me. > >> >> condition-case-unless-debug for #2. >> > >> > This is quite a radical change in very old behavior, so if it is >> > deemed a good idea, it should go to master. >> >> Hmm, it doesn't seem that radical to me, but I don't have a problem >> putting it only to master, or even not doing that at all and just saying >> the user should use debug-on-signal. > > It's radical because we never produce backtrace in similar cases > anywhere else in Emacs. > > Let's wait to hear what others think about this part. I've pushed just the error-message-string part to emacs-26. Setting debug-on-signal is the documented way of getting a backtrace in this sort of case, so I think it's good enough to just leave as is. I think Tino's patch is probably a good idea, but it's not related to this bug, so I'm closing it now. [1: efd0371c23]: 2017-11-05 11:38:38 -0500 Improve dired deletion error handling (Bug#28797) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=efd0371c23c5dd04d73980b42d7cf64bbceccb9a