GNU bug report logs - #2878
bindat-pack returns unibyte string for emacs 22 but multibyte string for emacs 23

Previous Next

Full log

View this message in rfc822 format

From: Yee Keat Phuah <ykphuah <at> gmail.com>
To: 2878 <at> debbugs.gnu.org
Subject: bug#2878: Acknowledgement (bindat-pack returns unibyte string for  emacs 22 but multibyte string for emacs 23)
Date: Sat, 4 Apr 2009 00:01:12 +0800

Hi,

snogglethorpe from #emacs have suggested this patch and it worked for
my elisp code

diff --git a/lisp/emacs-lisp/bindat.el b/lisp/emacs-lisp/bindat.el
index 4843e27..154bffe 100644
--- a/lisp/emacs-lisp/bindat.el
+++ b/lisp/emacs-lisp/bindat.el
@@ -609,9 +609,9 @@ Optional fourth arg BINDAT-IDX is the starting
offset into BINDAT-RAW."
   (let ((no-return bindat-raw))
     (unless bindat-idx (setq bindat-idx 0))
     (unless bindat-raw
-      (setq bindat-raw (make-vector (+ bindat-idx (bindat-length spec
struct)) 0)))
+      (setq bindat-raw (make-string (+ bindat-idx (bindat-length spec
struct)) 0)))
     (bindat--pack-group struct spec)
-    (if no-return nil (concat bindat-raw))))
+    (if no-return nil bindat-raw)))


On Fri, Apr 3, 2009 at 11:25 PM, Emacs bug Tracking System
<owner <at> emacsbugs.donarmstrong.com> wrote:
>
> Thank you for filing a new bug report with Emacs.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  Emacs Bugs <bug-gnu-emacs <at> gnu.org>
>
> If you wish to submit further information on this problem, please
> send it to 2878 <at> emacsbugs.donarmstrong.com, as before.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
>
> --
> 2878: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2878
> Emacs Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems
>



-- 
Cheers,
Phuah Yee Keat

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.