GNU bug report logs - #28774
[ido] Can't add text property to built-in function name.

Previous Next

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>, Ilya Khaprov <ilya.khaprov <at> publitechs.com>
Cc: 28774 <at> debbugs.gnu.org
Subject: bug#28774: Master, emacs-26: Can't add text property to built-in function name.
Date: Tue, 10 Oct 2017 07:01:52 -0700 (PDT)

> It seems ido-completions relies on (format "%s" str) to return a copy of
> str.  This fixes it:

If `format' no longer always copies STR in this context then
its doc should be updated, I think.

This:

 Format a string out of a format-string and arguments.
 The first argument is a format control string.
 The other arguments are substituted into it to make the
 result, a string.

suggests that it creates a new string, or at most reuses
the format string (e.g., "%s"), modifying it by substituting
STR for %s in it.  If in fact it can sometimes simply return
STR then this should be mentioned explicitly, to avoid confusion.

(And why was this change made?  Was it just to save a string
copy?)

This is an incompatible Lisp change, if it is new.  In that
case, it should be documented as such.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.