From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 03:45:07 2017 Received: (at submit) by debbugs.gnu.org; 10 Oct 2017 07:45:07 +0000 Received: from localhost ([127.0.0.1]:59049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pDv-0005sO-6O for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:45:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pDu-0005rc-6c for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1pDn-0000D6-R0 for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:45:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1pDn-0000Cj-Nr for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:44:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pDm-0005wA-JL for guix-patches@gnu.org; Tue, 10 Oct 2017 03:44:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1pDj-00006W-GE for guix-patches@gnu.org; Tue, 10 Oct 2017 03:44:58 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:39149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pDj-0008WV-9m for guix-patches@gnu.org; Tue, 10 Oct 2017 03:44:55 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 0549414761D; Tue, 10 Oct 2017 08:44:53 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id D7C8A14761C for ; Tue, 10 Oct 2017 08:44:52 +0100 (BST) Date: Tue, 10 Oct 2017 08:44:52 +0100 From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] Wrap bin files in the ruby build system. Message-ID: <20171010084452.036b3052@cbaines.net> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/OPSxk6zecE8TdZ.6WguXl40"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --Sig_/OPSxk6zecE8TdZ.6WguXl40 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable This is a bit experimental. There is some description of the motivation behind this approach, as well as the downsides in the commit messages. I don't know how to wrap binaries with the GEM_PATH, but somehow excluding inputs specified as native-inputs, so I'd be very interested if anyone has ideas about this. Christopher Baines (3): ruby-build-system: Add wrap-ruby-program. ruby-build-system: Add a new wrap phase. gnu: Remove redundant wrapping from packages using ruby-build-system. gnu/packages/databases.scm | 13 +--- gnu/packages/ruby.scm | 18 +----- guix/build/ruby-build-system.scm | 131 +++++++++++++++++++++++++++++++++++= +++- 3 files changed, 133 insertions(+), 29 deletions(-) --Sig_/OPSxk6zecE8TdZ.6WguXl40 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlncenRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xc28Q/+J7ybER59IzVfKI1dB5zI9N+mb4SdxtEUxJFRFIccrMIVWxRFdBk04/bN Ou2lO1h7i7EGa3vZKwNfyAvWYoMLxCzLQsBv5EaJ3gBJTXl+1/HmOoYlbFet8lMp puUHLohIQNwA/Fgq+Hnk1gwL8zJmvH9kVD+3tAsLbVI0CmCvWH1fNFh5B7CosQCi PLIBprV1Sxr+1a8G8Xh7jL15oxUmC8O1t3ol2y+gOrbgwVogE+UFJtmPVM42gXxH LK1oeb/1//pSC7Frp17f6VmFf9SmZRr+rdVk82lgrQ89pyhNtgV5ERFK+9jMhdVg az4SvhoXjGnHZRxawVfc5t+85drMHKTCOIBtb4vZ2BlHSMf5Mx1wMDK0eww2w926 6REIUE0HADZVOI+cNevc7YJEqGPcCT/N6N31ox8rnGIQWKDoX5HF6aVRsg+QSKvh 4HSKyzgXcEGAnZIxRua49SnBxyPmxauoR30hc4dOvXLxWzDSLWXtFNiJ69bbEx0L Wgm265CmRnFIH0EMB1UNhP+dqYhWQalRRvBqLaCJGshXx83HZammlSES/xr3SUBi Sy8rzIxYqYIAa7Ji5lPhrzBpFwnJXBc1ofqy4rvXosStarr2ugjfwsuETepKIEEW F61JEhXQ5gAido3CkpyuQ8e1Yn/iXufAmZ1OFVIx+CUdtuYP8oQ= =xJyy -----END PGP SIGNATURE----- --Sig_/OPSxk6zecE8TdZ.6WguXl40-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 03:47:08 2017 Received: (at 28773) by debbugs.gnu.org; 10 Oct 2017 07:47:08 +0000 Received: from localhost ([127.0.0.1]:59057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pFs-0005wA-Ha for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:47:08 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:52672 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pFr-0005vq-6i for 28773@debbugs.gnu.org; Tue, 10 Oct 2017 03:47:07 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 82B8A14761D; Tue, 10 Oct 2017 08:47:06 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 408B014761E for <28773@debbugs.gnu.org>; Tue, 10 Oct 2017 08:47:06 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id bcd41ea6 for <28773@debbugs.gnu.org>; Tue, 10 Oct 2017 07:47:05 +0000 (UTC) From: Christopher Baines To: 28773@debbugs.gnu.org Subject: [PATCH 3/3] gnu: Remove redundant wrapping from packages using ruby-build-system. Date: Tue, 10 Oct 2017 08:47:05 +0100 Message-Id: <20171010074705.5676-3-mail@cbaines.net> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171010074705.5676-1-mail@cbaines.net> References: <20171010074705.5676-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28773 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Now that the build system does wrapping automatically, it can be removed from the packages that do it manually. * gnu/packages/databases.scm (es-dump-restore)[arguments]: Remove #:phases. * gnu/packages/ruby.scm (ruby-redcloth)[arguments]: Remove #:phases. (ruby-httpclient)[arguments]: Remove 'wrap-bin-httpclient from the modified phases. --- gnu/packages/databases.scm | 13 +------------ gnu/packages/ruby.scm | 18 ++---------------- 2 files changed, 3 insertions(+), 28 deletions(-) diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index 62f940e90..69bb9fd7d 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -273,18 +273,7 @@ SQL, Key/Value, XML/XQuery or Java Object storage for their data model.") "020yk7f1hw48clmf5501z3xv9shsdchyymcv0y2cci2c1xvr1mim")))) (build-system ruby-build-system) (arguments - '(#:tests? #f ;; No testsuite. - #:phases - (modify-phases %standard-phases - (add-after 'install 'wrap-bin-es_dump_restore - (lambda* (#:key outputs #:allow-other-keys) - (wrap-program (string-append (assoc-ref outputs "out") - "/bin/es_dump_restore") - `("GEM_PATH" ":" prefix (,(string-append - (getenv "GEM_PATH") - ":" - (getenv "GEM_HOME"))))) - #t))))) + '(#:tests? #f)) ;; No testsuite. (propagated-inputs `(("ruby-httpclient" ,ruby-httpclient) ("ruby-multi-json" ,ruby-multi-json) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index f2333dbcb..83e106d3c 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -2896,15 +2896,7 @@ alternative to Marshal for Object serialization. ") ;; existing gemspec. (replace 'build (lambda _ - (zero? (system* "gem" "build" "redcloth.gemspec")))) - ;; Make sure that the "redcloth" executable finds required Ruby - ;; libraries. - (add-after 'install 'wrap-bin-redcloth - (lambda* (#:key outputs #:allow-other-keys) - (wrap-program (string-append (assoc-ref outputs "out") - "/bin/redcloth") - `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME")))) - #t))))) + (zero? (system* "gem" "build" "redcloth.gemspec"))))))) (native-inputs `(("bundler" ,bundler) ("ruby-diff-lcs" ,ruby-diff-lcs) @@ -3752,13 +3744,7 @@ It has built-in support for the legacy @code{cookies.txt} and (system* "ruby" "-Ilib" "test/runner.rb")) - #t))) - (add-after 'install 'wrap-bin-httpclient - (lambda* (#:key outputs #:allow-other-keys) - (wrap-program (string-append (assoc-ref outputs "out") - "/bin/httpclient") - `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME")))) - #t))))) + #t)))))) (native-inputs `(("ruby-rack" ,ruby-rack))) (synopsis -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 03:47:09 2017 Received: (at 28773) by debbugs.gnu.org; 10 Oct 2017 07:47:09 +0000 Received: from localhost ([127.0.0.1]:59059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pFs-0005wC-PX for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:47:08 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:52673 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pFr-0005vs-JG for 28773@debbugs.gnu.org; Tue, 10 Oct 2017 03:47:07 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 5A47414761F; Tue, 10 Oct 2017 08:47:06 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 3280B14761D for <28773@debbugs.gnu.org>; Tue, 10 Oct 2017 08:47:06 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id c9133385 for <28773@debbugs.gnu.org>; Tue, 10 Oct 2017 07:47:05 +0000 (UTC) From: Christopher Baines To: 28773@debbugs.gnu.org Subject: [PATCH 2/3] ruby-build-system: Add a new wrap phase. Date: Tue, 10 Oct 2017 08:47:04 +0100 Message-Id: <20171010074705.5676-2-mail@cbaines.net> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171010074705.5676-1-mail@cbaines.net> References: <20171010074705.5676-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28773 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Wrap files in bin/ and sbin/ with the location of the gem itself (GEM_HOME) and the location of any other gems in use (GEM_PATH). This ensures that the bin files will run with the right environment when executed. It does however mean that native-inputs will also get wrapped up in any binaries, which is not good, as it increases the size of the closure, and risks this code being used at runtime. * guix/build/ruby-build-system.scm (wrap): New procedure. (%standard-phases): Add the wrap phase. --- guix/build/ruby-build-system.scm | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/guix/build/ruby-build-system.scm b/guix/build/ruby-build-system.scm index af193b9ce..b6f0fc941 100644 --- a/guix/build/ruby-build-system.scm +++ b/guix/build/ruby-build-system.scm @@ -21,6 +21,7 @@ (define-module (guix build ruby-build-system) #:use-module ((guix build gnu-build-system) #:prefix gnu:) #:use-module (guix build utils) + #:use-module (ice-9 ftw) #:use-module (ice-9 match) #:use-module (ice-9 popen) #:use-module (ice-9 regex) @@ -269,6 +270,30 @@ extended with definitions for VARS." (chmod prog-tmp #o755) (rename-file prog-tmp prog)))) +(define* (wrap #:key inputs outputs #:allow-other-keys) + (define (list-of-files dir) + (map (cut string-append dir "/" <>) + (or (scandir dir (lambda (f) + (let ((s (stat (string-append dir "/" f)))) + (eq? 'regular (stat:type s))))) + '()))) + + (define bindirs + (append-map (match-lambda + ((_ . dir) + (list (string-append dir "/bin") + (string-append dir "/sbin")))) + outputs)) + + (let* ((out (assoc-ref outputs "out")) + (var `("GEM_PATH" prefix + (,(getenv "GEM_HOME") ,(getenv "GEM_PATH"))))) + (for-each (lambda (dir) + (let ((files (list-of-files dir))) + (for-each (cut wrap-ruby-program <> var) + files))) + bindirs))) + (define (log-file-deletion file) (display (string-append "deleting '" file "' for reproducibility\n"))) @@ -280,7 +305,8 @@ extended with definitions for VARS." (add-after 'extract-gemspec 'replace-git-ls-files replace-git-ls-files) (replace 'build build) (replace 'check check) - (replace 'install install))) + (replace 'install install) + (add-after 'install 'wrap wrap))) (define* (ruby-build #:key inputs (phases %standard-phases) #:allow-other-keys #:rest args) -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 03:47:09 2017 Received: (at 28773) by debbugs.gnu.org; 10 Oct 2017 07:47:09 +0000 Received: from localhost ([127.0.0.1]:59061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pFt-0005wJ-0q for submit@debbugs.gnu.org; Tue, 10 Oct 2017 03:47:09 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:52674 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1pFr-0005vt-J3 for 28773@debbugs.gnu.org; Tue, 10 Oct 2017 03:47:08 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 233F214761E; Tue, 10 Oct 2017 08:47:07 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 2094714761C for <28773@debbugs.gnu.org>; Tue, 10 Oct 2017 08:47:06 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 782877cd for <28773@debbugs.gnu.org>; Tue, 10 Oct 2017 07:47:05 +0000 (UTC) From: Christopher Baines To: 28773@debbugs.gnu.org Subject: [PATCH 1/3] ruby-build-system: Add wrap-ruby-program. Date: Tue, 10 Oct 2017 08:47:03 +0100 Message-Id: <20171010074705.5676-1-mail@cbaines.net> X-Mailer: git-send-email 2.14.2 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28773 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) A modified copy of wrap-program from (guix build utils). The wrap-program procedure doesn't work well for Ruby scripts, as it breaks using the -S flag with ruby to execute the script, as when -S is passed to ruby, it expects the script on the PATH to use ruby in the shebang, and not bash. Therefore, to wrap the program, but keep the shebang as ruby, wrap it with a ruby script instead. wrap-ruby-program uses .real/foo rather than .foo-real, as this might be neater. This procedure also includes a call to Gem.clear_paths to make it possible to set the GEM_PATH through this method, and for it to take effect. * gnu/build/ruby-build-system.scm (wrap-ruby-program): New procedure. --- guix/build/ruby-build-system.scm | 103 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 103 insertions(+) diff --git a/guix/build/ruby-build-system.scm b/guix/build/ruby-build-system.scm index c2d276627..af193b9ce 100644 --- a/guix/build/ruby-build-system.scm +++ b/guix/build/ruby-build-system.scm @@ -166,6 +166,109 @@ GEM-FLAGS are passed to the 'gem' invokation, if present." "Makefile"))))) #t)))) +(define* (wrap-ruby-program prog #:key (gem-clear-paths #t) #:rest vars) + "Make a wrapper for PROG. VARS should look like this: + + '(VARIABLE DELIMITER POSITION LIST-OF-DIRECTORIES) + +where DELIMITER is optional. ':' will be used if DELIMITER is not given. + +For example, this command: + + (wrap-ruby-program \"foo\" + '(\"PATH\" \":\" = (\"/gnu/.../bar/bin\")) + '(\"CERT_PATH\" suffix (\"/gnu/.../baz/certs\" + \"/qux/certs\"))) + +will copy 'foo' to '.real/fool' and create the file 'foo' with the following +contents: + + #!location/of/bin/ruby + ENV['PATH'] = \"/gnu/.../bar/bin\" + ENV['CERT_PATH'] = (ENV.key?('CERT_PATH') ? (ENV['CERT_PATH'] + ':') : '') + '/gnu/.../baz/certs:/qux/certs' + load location/of/.real/foo + +This is useful for scripts that expect particular programs to be in $PATH, for +programs that expect particular gems to be in the GEM_PATH. + +This is preferable to wrap-program, which uses a bash script, as this prevents +ruby scripts from being executed with @command{ruby -S ...}. + +If PROG has previously been wrapped by 'wrap-ruby-program', the wrapper is +extended with definitions for VARS." + (define wrapped-file + (string-append (dirname prog) "/.real/" (basename prog))) + + (define already-wrapped? + (file-exists? wrapped-file)) + + (define (last-line port) + ;; Return the last line read from PORT and leave PORT's cursor right + ;; before it. + (let loop ((previous-line-offset 0) + (previous-line "") + (position (seek port 0 SEEK_CUR))) + (match (read-line port 'concat) + ((? eof-object?) + (seek port previous-line-offset SEEK_SET) + previous-line) + ((? string? line) + (loop position line (+ (string-length line) position)))))) + + (define (export-variable lst) + ;; Return a string that exports an environment variable. + (match lst + ((var sep '= rest) + (format #f "ENV['~a'] = '~a'" + var (string-join rest sep))) + ((var sep 'prefix rest) + (format #f "ENV['~a'] = '~a' + (ENV.key?('~a') ? ('~a' + ENV['~a']) : '')" + var (string-join rest sep) var sep var)) + ((var sep 'suffix rest) + (format #f "ENV['~a'] = (ENV.key?('~a') ? (ENV['~a'] + '~a') : '') + '~a'" + var var var sep (string-join rest sep))) + ((var '= rest) + (format #f "ENV['~a'] = '~a'" + var (string-join rest ":"))) + ((var 'prefix rest) + (format #f "ENV['~a'] = '~a' + (ENV.key?('~a') ? (':' + ENV['~a']) : '')" + var (string-join rest ":") var var)) + ((var 'suffix rest) + (format #f "ENV['~a'] = (ENV.key?('~a') ? (ENV['~a'] + ':') : '') + '~a'" + var var var (string-join rest ":"))))) + + (if already-wrapped? + + ;; PROG is already a wrapper: add the new "export VAR=VALUE" lines just + ;; before the last line. + (let* ((port (open-file prog "r+")) + (last (last-line port))) + (for-each (lambda (var) + (display (export-variable var) port) + (newline port)) + vars) + (display last port) + (close-port port)) + + ;; PROG is not wrapped yet: create a shell script that sets VARS. + (let ((prog-tmp (string-append wrapped-file "-tmp"))) + (mkdir-p (dirname prog-tmp)) + (link prog wrapped-file) + + (call-with-output-file prog-tmp + (lambda (port) + (format port + "#!~a~%~a~%~a~%load '~a'~%" + (which "ruby") + (string-join (map export-variable vars) "\n") + ;; This ensures that if the GEM_PATH has been changed, + ;; then that change will be noticed. + (if gem-clear-paths "Gem.clear_paths" "") + (canonicalize-path wrapped-file)))) + + (chmod prog-tmp #o755) + (rename-file prog-tmp prog)))) + (define (log-file-deletion file) (display (string-append "deleting '" file "' for reproducibility\n"))) -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 16 09:19:12 2017 Received: (at 28773) by debbugs.gnu.org; 16 Oct 2017 13:19:12 +0000 Received: from localhost ([127.0.0.1]:42645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e45IW-00058y-AB for submit@debbugs.gnu.org; Mon, 16 Oct 2017 09:19:12 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:32865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e45IU-00058q-OF for 28773@debbugs.gnu.org; Mon, 16 Oct 2017 09:19:11 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 68F48F121; Mon, 16 Oct 2017 15:19:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1q5tI_K10acM; Mon, 16 Oct 2017 15:19:10 +0200 (CEST) Received: from ribbon (unknown [193.50.110.215]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A84B04DF; Mon, 16 Oct 2017 15:19:10 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Christopher Baines Subject: Re: [bug#28773] [PATCH] Wrap bin files in the ruby build system. References: <20171010084452.036b3052@cbaines.net> Date: Mon, 16 Oct 2017 15:19:09 +0200 In-Reply-To: <20171010084452.036b3052@cbaines.net> (Christopher Baines's message of "Tue, 10 Oct 2017 08:44:52 +0100") Message-ID: <877evvdycy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28773 Cc: Ben Woodcroft , 28773@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Chris, Christopher Baines skribis: > This is a bit experimental. There is some description of the motivation > behind this approach, as well as the downsides in the commit messages. > > I don't know how to wrap binaries with the GEM_PATH, but somehow > excluding inputs specified as native-inputs, so I'd be very interested > if anyone has ideas about this. > > Christopher Baines (3): > ruby-build-system: Add wrap-ruby-program. > ruby-build-system: Add a new wrap phase. > gnu: Remove redundant wrapping from packages using ruby-build-system. Cc=E2=80=99ing Ben who is another Serious Ruby User I think. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 02:04:08 2017 Received: (at control) by debbugs.gnu.org; 18 Oct 2017 06:04:08 +0000 Received: from localhost ([127.0.0.1]:47167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4hSa-0002ZD-Co for submit@debbugs.gnu.org; Wed, 18 Oct 2017 02:04:08 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:57692 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4hSX-0002Yg-Rx for control@debbugs.gnu.org; Wed, 18 Oct 2017 02:04:07 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 757BD1476DC; Wed, 18 Oct 2017 07:04:05 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 4ECB51476CA for ; Wed, 18 Oct 2017 07:04:05 +0100 (BST) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 85dfbf55 for ; Wed, 18 Oct 2017 06:04:05 +0000 (UTC) Date: Wed, 18 Oct 2017 07:04:05 +0100 Message-Id: <87po9lvvoq.fsf@cbaines.net> To: control@debbugs.gnu.org From: Christopher Baines Subject: control message for bug #28885 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) block 28885 by 28773 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 06:40:09 2017 Received: (at 28773) by debbugs.gnu.org; 18 Oct 2017 10:40:09 +0000 Received: from localhost ([127.0.0.1]:47332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4llh-0004uC-4c for submit@debbugs.gnu.org; Wed, 18 Oct 2017 06:40:09 -0400 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:37090 helo=newmailhub.uq.edu.au) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4lle-0004u0-7U for 28773@debbugs.gnu.org; Wed, 18 Oct 2017 06:40:07 -0400 Received: from smtp2.soe.uq.edu.au (smtp2.soe.uq.edu.au [10.138.113.41]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id v9IAdvfk026618; Wed, 18 Oct 2017 20:39:58 +1000 Received: from [192.168.1.105] ([123.200.134.98]) (authenticated bits=0) by smtp2.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id v9IAdsa6027107 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 18 Oct 2017 20:39:56 +1000 Subject: Re: [bug#28773] [PATCH] Wrap bin files in the ruby build system. To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , Christopher Baines References: <20171010084452.036b3052@cbaines.net> <877evvdycy.fsf@gnu.org> From: Ben Woodcroft Message-ID: Date: Wed, 18 Oct 2017 20:39:53 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <877evvdycy.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-UQ-FilterTime: 1508323199 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28773 Cc: 28773@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, On 16/10/17 23:19, Ludovic Courtès wrote: > Hi Chris, > > Christopher Baines skribis: > >> This is a bit experimental. There is some description of the motivation >> behind this approach, as well as the downsides in the commit messages. >> >> I don't know how to wrap binaries with the GEM_PATH, but somehow >> excluding inputs specified as native-inputs, so I'd be very interested >> if anyone has ideas about this. >> >> Christopher Baines (3): >> ruby-build-system: Add wrap-ruby-program. >> ruby-build-system: Add a new wrap phase. >> gnu: Remove redundant wrapping from packages using ruby-build-system. > Cc’ing Ben who is another Serious Ruby User I think. :-) Maybe sometimes. I'll try to get a review back to you in the next week or so. ben From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 16:47:42 2018 Received: (at 28773) by debbugs.gnu.org; 11 Jan 2018 21:47:43 +0000 Received: from localhost ([127.0.0.1]:52584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZkhK-0004tB-Nb for submit@debbugs.gnu.org; Thu, 11 Jan 2018 16:47:42 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:35550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZkhJ-0004t3-PQ for 28773@debbugs.gnu.org; Thu, 11 Jan 2018 16:47:42 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1602810959; Thu, 11 Jan 2018 22:47:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8hW7u6QIDSNW; Thu, 11 Jan 2018 22:47:39 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 25249101B9; Thu, 11 Jan 2018 22:47:39 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Ben Woodcroft Subject: Re: [bug#28773] [PATCH] Wrap bin files in the ruby build system. References: <20171010084452.036b3052@cbaines.net> <877evvdycy.fsf@gnu.org> Date: Thu, 11 Jan 2018 22:47:38 +0100 In-Reply-To: (Ben Woodcroft's message of "Wed, 18 Oct 2017 20:39:53 +1000") Message-ID: <87k1wom5j9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28773 Cc: Christopher Baines , 28773@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello! Ben Woodcroft skribis: > On 16/10/17 23:19, Ludovic Court=C3=A8s wrote: >> Hi Chris, >> >> Christopher Baines skribis: >> >>> This is a bit experimental. There is some description of the motivation >>> behind this approach, as well as the downsides in the commit messages. >>> >>> I don't know how to wrap binaries with the GEM_PATH, but somehow >>> excluding inputs specified as native-inputs, so I'd be very interested >>> if anyone has ideas about this. >>> >>> Christopher Baines (3): >>> ruby-build-system: Add wrap-ruby-program. >>> ruby-build-system: Add a new wrap phase. >>> gnu: Remove redundant wrapping from packages using ruby-build-system. >> Cc=E2=80=99ing Ben who is another Serious Ruby User I think. :-) > > Maybe sometimes. I'll try to get a review back to you in the next week > or so. Ahem. :-) Chris, if you=E2=80=99re confident, I=E2=80=99d say you can go ahead. It d= oes sound like an improvement so it=E2=80=99d be sad to lose it. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 12 01:51:19 2018 Received: (at 28773) by debbugs.gnu.org; 12 Jan 2018 06:51:19 +0000 Received: from localhost ([127.0.0.1]:52805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZtBP-0002PS-GG for submit@debbugs.gnu.org; Fri, 12 Jan 2018 01:51:19 -0500 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:33393 helo=newmailhub.uq.edu.au) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZtBN-0002PI-3i for 28773@debbugs.gnu.org; Fri, 12 Jan 2018 01:51:18 -0500 Received: from smtp1.soe.uq.edu.au (smtp1.soe.uq.edu.au [10.138.113.40]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id w0C6p9ZM046524; Fri, 12 Jan 2018 16:51:09 +1000 Received: from [192.168.1.105] ([123.200.134.98]) (authenticated bits=0) by smtp1.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id w0C6p71P019635 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 12 Jan 2018 16:51:08 +1000 Subject: Re: [bug#28773] [PATCH] Wrap bin files in the ruby build system. To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20171010084452.036b3052@cbaines.net> <877evvdycy.fsf@gnu.org> <87k1wom5j9.fsf@gnu.org> From: Ben Woodcroft Message-ID: <1b7ecb41-7ba7-2fa9-2e7d-c2e6cc008314@uq.edu.au> Date: Fri, 12 Jan 2018 16:51:07 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <87k1wom5j9.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-UQ-FilterTime: 1515739871 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28773 Cc: Christopher Baines , 28773@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello! On 12/01/18 07:47, Ludovic Courtès wrote: > Hello! > > Ben Woodcroft skribis: > >> On 16/10/17 23:19, Ludovic Courtès wrote: >>> Hi Chris, >>> >>> Christopher Baines skribis: >>> >>>> This is a bit experimental. There is some description of the motivation >>>> behind this approach, as well as the downsides in the commit messages. >>>> >>>> I don't know how to wrap binaries with the GEM_PATH, but somehow >>>> excluding inputs specified as native-inputs, so I'd be very interested >>>> if anyone has ideas about this. >>>> >>>> Christopher Baines (3): >>>> ruby-build-system: Add wrap-ruby-program. >>>> ruby-build-system: Add a new wrap phase. >>>> gnu: Remove redundant wrapping from packages using ruby-build-system. >>> Cc’ing Ben who is another Serious Ruby User I think. :-) >> Maybe sometimes. I'll try to get a review back to you in the next week >> or so. > Ahem. :-) > > Chris, if you’re confident, I’d say you can go ahead. It does sound > like an improvement so it’d be sad to lose it. Ah yes, my apologies. Yes, this series LGTM, and it worked fine when I applied it in local packages too. Thanks. ben From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 17:22:23 2018 Received: (at 28773) by debbugs.gnu.org; 14 Jan 2018 22:22:23 +0000 Received: from localhost ([127.0.0.1]:56417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqfW-0002wd-QX for submit@debbugs.gnu.org; Sun, 14 Jan 2018 17:22:23 -0500 Received: from li622-129.members.linode.com ([212.71.249.129]:59544 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqfU-0002wV-Sa for 28773@debbugs.gnu.org; Sun, 14 Jan 2018 17:22:21 -0500 Received: by mira.cbaines.net (Postfix, from userid 113) id D81B014084F; Sun, 14 Jan 2018 22:22:19 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 2D60514084E; Sun, 14 Jan 2018 22:22:19 +0000 (GMT) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id f630b7c9; Sun, 14 Jan 2018 22:22:18 +0000 (UTC) References: <20171010084452.036b3052@cbaines.net> <877evvdycy.fsf@gnu.org> <87k1wom5j9.fsf@gnu.org> User-agent: mu4e 0.9.18; emacs 25.3.1 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#28773] [PATCH] Wrap bin files in the ruby build system. In-reply-to: <87k1wom5j9.fsf@gnu.org> Date: Sun, 14 Jan 2018 22:22:15 +0000 Message-ID: <87h8rot71k.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28773 Cc: 28773@debbugs.gnu.org, Ben Woodcroft X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello! > > Ben Woodcroft skribis: > >> On 16/10/17 23:19, Ludovic Court=C3=A8s wrote: >>> Hi Chris, >>> >>> Christopher Baines skribis: >>> >>>> This is a bit experimental. There is some description of the motivation >>>> behind this approach, as well as the downsides in the commit messages. >>>> >>>> I don't know how to wrap binaries with the GEM_PATH, but somehow >>>> excluding inputs specified as native-inputs, so I'd be very interested >>>> if anyone has ideas about this. >>>> >>>> Christopher Baines (3): >>>> ruby-build-system: Add wrap-ruby-program. >>>> ruby-build-system: Add a new wrap phase. >>>> gnu: Remove redundant wrapping from packages using ruby-build-syste= m. >>> Cc=E2=80=99ing Ben who is another Serious Ruby User I think. :-) >> >> Maybe sometimes. I'll try to get a review back to you in the next week >> or so. > > Ahem. :-) > > Chris, if you=E2=80=99re confident, I=E2=80=99d say you can go ahead. It= does sound > like an improvement so it=E2=80=99d be sad to lose it. Great, I've now pushed this, along with the other ruby build system change. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpb2BdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfNVg//Sk6nw5J+rAEq4Z2mPg2MF/1FrrXp+Jzk2/yRjPvO/FdQCI5ly6Qi+azN G4f+yV/uQtEpZj1XpREBwpOvIAln8GcWmr/X+G6mQPj0rymlEaFazH6H+7q22neC ot/8q/PAkcRLtx8qaDn/IV2681Vo6wSEqgw68V2+VXt2hDJBQMkEwSZDx/jKfx0f AYXfIHaoa3qiFO6xaGPZYnlyAFLBGqxgOFTelJIcXK+sn2E5fWkePuKAkPzPDedZ jYafB6SZDBv/HqWGWKk+qIHNJvCCxQ7UW+Z7GwDfPX71vBZ7o3nLan17fskI4J1b /8wZuLoE8W3VOYsRQl9DD8661GNiEipG8Ikulsfpq8bl9/6wC0ZNVEprofXZFT2f RjevR5JdhXtOeglrK8ylQxKlMSwpr4y5mIl3flpotHPvh4sA1E0qnhLzspGO99J3 nHgBbYhJOjN9Y9qi5WUap+y1oE8OGfJDfKe2+AeJRUtHQSicEZEiBIljy4y18qK3 QeLCZjnLftN32mqgmIvlPyTjV7LaKWFKNuqOMCqLqGjuIxo87jK8LLLmvcBa0ebr i9E9ZE0VJ8mddiHmICSpDvypgmASNQwDsTLfA8LqKIUNGTO6L8+cRr5pdyLuhIgW 7Rz26lkG8WTv0qqD+0lUb3f91qC3NvKzcB9RJCHMoI1wVHPnWts= =g7of -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 17:22:54 2018 Received: (at 28773) by debbugs.gnu.org; 14 Jan 2018 22:22:54 +0000 Received: from localhost ([127.0.0.1]:56420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqg2-0002xK-3c for submit@debbugs.gnu.org; Sun, 14 Jan 2018 17:22:54 -0500 Received: from li622-129.members.linode.com ([212.71.249.129]:59560 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqg0-0002xD-R5 for 28773@debbugs.gnu.org; Sun, 14 Jan 2018 17:22:53 -0500 Received: by mira.cbaines.net (Postfix, from userid 113) id 6CD44140851; Sun, 14 Jan 2018 22:22:52 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id E6EA414084E; Sun, 14 Jan 2018 22:22:51 +0000 (GMT) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 044b5425; Sun, 14 Jan 2018 22:22:51 +0000 (UTC) References: <20171010084452.036b3052@cbaines.net> <877evvdycy.fsf@gnu.org> <87k1wom5j9.fsf@gnu.org> <1b7ecb41-7ba7-2fa9-2e7d-c2e6cc008314@uq.edu.au> User-agent: mu4e 0.9.18; emacs 25.3.1 From: Christopher Baines To: Ben Woodcroft Subject: Re: [bug#28773] [PATCH] Wrap bin files in the ruby build system. In-reply-to: <1b7ecb41-7ba7-2fa9-2e7d-c2e6cc008314@uq.edu.au> Date: Sun, 14 Jan 2018 22:22:51 +0000 Message-ID: <87fu78t70k.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28773 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 28773@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ben Woodcroft writes: > Hello! > > > On 12/01/18 07:47, Ludovic Court=C3=A8s wrote: >> Hello! >> >> Ben Woodcroft skribis: >> >>> On 16/10/17 23:19, Ludovic Court=C3=A8s wrote: >>>> Hi Chris, >>>> >>>> Christopher Baines skribis: >>>> >>>>> This is a bit experimental. There is some description of the motivati= on >>>>> behind this approach, as well as the downsides in the commit messages. >>>>> >>>>> I don't know how to wrap binaries with the GEM_PATH, but somehow >>>>> excluding inputs specified as native-inputs, so I'd be very interested >>>>> if anyone has ideas about this. >>>>> >>>>> Christopher Baines (3): >>>>> ruby-build-system: Add wrap-ruby-program. >>>>> ruby-build-system: Add a new wrap phase. >>>>> gnu: Remove redundant wrapping from packages using ruby-build-sys= tem. >>>> Cc=E2=80=99ing Ben who is another Serious Ruby User I think. :-) >>> Maybe sometimes. I'll try to get a review back to you in the next week >>> or so. >> Ahem. :-) >> >> Chris, if you=E2=80=99re confident, I=E2=80=99d say you can go ahead. I= t does sound >> like an improvement so it=E2=80=99d be sad to lose it. > Ah yes, my apologies. Yes, this series LGTM, and it worked fine when I=20 > applied it in local packages too. Super, thanks for taking a look Ben :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpb2DtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfp6w/+OfSwTeu9W2ocfFBuNanJhMq0kDiXezm4mFhb1AHAii4AD3ORlFR5Ub6t TznQMfag3764g8RjA7BIuVlpCaGWAI1lur4RxXDyoBUnCjuBYFe47ovIuSxuq8U5 f1Hkd14/aKCdZw/ZA7GFIPTs2cRES+Ygk1iBg1Vq6UXYVjCpDQ6RqCREL0y9pFRT WjHhlO/K5utPC+dfuipjrH3Y99QtcY9mTxialIXgz6q7jL2IWLZvAHDgpA0+3hTR QTbkAJ0wdIW+X6YXU0WfF+71nZ1dQh9kvnre4dJ3Vn7qUlp0kfZVGvyWimFLbO3o LulpTzwV48dbLLr482atHkL5rPf7+x98GiDqXbkHF5UilY0UdKI1gvlsQsKuavSB WdDU1GxQxdQhpmLe7nekTfBaoVxdmwrG11n/s9lp8In4Fb/07xa4phuuUynnnQsQ OyIa7y3ltWgokhySuUdMs4w+/RjO/q6HZAyXpOl5JSXJesWT+GXK1OVhg+ztDyMB HEq8K85crGD3Rkq4ctnw/yr03L231/AGMSR9sTT7hkPtmPV1FVHDm5oU2EpX7X9+ cbYAencAG6fhKT3ph0eVWnURpDy/ncRWrZAHXdclvw8kL8PQ7b6NZ3HbhAQwjm6D oHTaU/1ADGDvLhZXCfjHhDTPTk1wwyu9TsZFinOVg56x5FlSX50= =NQmc -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 17:25:32 2018 Received: (at 28773-done) by debbugs.gnu.org; 14 Jan 2018 22:25:32 +0000 Received: from localhost ([127.0.0.1]:56432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqiZ-00032K-QC for submit@debbugs.gnu.org; Sun, 14 Jan 2018 17:25:31 -0500 Received: from li622-129.members.linode.com ([212.71.249.129]:59590 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaqiV-00032A-V3 for 28773-done@debbugs.gnu.org; Sun, 14 Jan 2018 17:25:28 -0500 Received: by mira.cbaines.net (Postfix, from userid 113) id 889CD14084F; Sun, 14 Jan 2018 22:25:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 6575814084E for <28773-done@debbugs.gnu.org>; Sun, 14 Jan 2018 22:25:27 +0000 (GMT) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 864fb9ab for <28773-done@debbugs.gnu.org>; Sun, 14 Jan 2018 22:25:27 +0000 (UTC) User-agent: mu4e 0.9.18; emacs 25.3.1 From: Christopher Baines To: 28773-done@debbugs.gnu.org Subject: [PATCH] Specify native search path for all ruby packages Date: Sun, 14 Jan 2018 22:25:26 +0000 Message-ID: <87d12ct6w9.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28773-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Closing, as I've now pushed this patch. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpb2NZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xe9Gw/9F0aWJpNjiktuyYzI661aJ8d/TtIkd+UKQWBR+3zWTiCu3KHLqjl3B9f+ JN1daL4ayS1VLuUdFOIV2DzAiSNXYBsoLSc7S9b9kEJDkqGapvsKW2e9Tt82VR60 4wUCgDU4WlRZsdtWiIAnxjinUxheRZb/cImiPr033cMMy7r3raQDKfQyq+nnFlaZ 9TAr7ZDU7Tmd0yk7cHoK0f/RvL6z8ZQ7REo2fRmY3VZ2VuLUn9QACvO7z4tSBwPn u3Pnup1sjeoVsMuKL3JyTrZyWY7UoJAmRNOytIdCKtjdsk7JvGujqKz3Fv13g09N klkklVZwB9zBs6+ZPM75HhdqmKmKvEZ3xFP3pOG80NrUrKsAz7PZKTik0ZBxy5FE oY40kuzEka4io4Kx4drFfQLT17S4i9na75gPLLYT6xabj7pLRYhkJwVc7sUchv7b qy56TY19pYfLxwGsiw8uZUXMxtVAmfUY52ytGcvWZLLbyuFQ33blGvCQM8E2G6sH vWc5sbZEdH/EHU4o7UzIbRwPZD8EE1yhC7T5Tr8SEsNt2OfA1p++raPjNYb+Doku dz4uIXIZj7HTkzQBEedn/mDB71vEh8xPyC9UCpLR993IekyZklIBQNxKOne4yobs wEs8KtYXXlKWOZ39WoCrmHMOPFPZkCvUAvKZLknRB+JHq9cjaIk= =vz3l -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 13 10:42:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Feb 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator