GNU bug report logs - #28769
[PATCH] gnu: services: Add php-fpm.

Previous Next

Full log

Message #8 received at 28769 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: nee <nee <at> cock.li>
Cc: 28769 <at> debbugs.gnu.org
Subject: Re: [bug#28769] [PATCH] gnu: services: Add php-fpm.
Date: Fri, 13 Oct 2017 21:06:08 +0100

[Message part 1 (text/plain, inline)]

On Mon, 9 Oct 2017 23:54:24 +0200
nee <nee <at> cock.li> wrote:

> Subject: [PATCH 1/2] guix: utils: add version-major.
> 
> * guix/utils.scm (version-major): New function.

I think procedure, rather than function is the usual, at least within
the context of commit messages in the guix repository.

> ---
>  guix/utils.scm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/guix/utils.scm b/guix/utils.scm
> index de4aa6531..cec209a8f 100644
> --- a/guix/utils.scm
> +++ b/guix/utils.scm
> @@ -72,6 +72,7 @@
>              version>=?  
>              version-prefix
>              version-major+minor
> +            version-major
>              guile-version>?
>              string-replace-substring
>              arguments-from-environment-variable
> @@ -488,6 +489,10 @@ For example, (version-prefix \"2.1.47.4.23\" 3)
> returns \"2.1.47\"" minor version numbers from version-string."
>    (version-prefix version-string 2))
>  
> +(define (version-major version-string)
> +  "Return the major version number as string from the
> version-string."
> +  (version-prefix version-string 1))
> +

Seems fine to me. I'm guessing that you added this because it was
convenient, but I can't see it being used in the next patch, have I
missed it?

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.