GNU bug report logs - #28769
[PATCH] gnu: services: Add php-fpm.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28769: closed ([PATCH] gnu: services: Add php-fpm.)
Date: Tue, 12 Dec 2017 21:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 12 Dec 2017 21:41:41 +0000
with message-id <87vahb62ui.fsf <at> cbaines.net>
and subject line Re: [bug#28769] [PATCH] gnu: services: Add php-fpm.
has caused the debbugs.gnu.org bug report #28769,
regarding [PATCH] gnu: services: Add php-fpm.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28769
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: nee <nee <at> cock.li>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: services: Add php-fpm.
Date: Mon, 9 Oct 2017 23:54:24 +0200

[Message part 3 (text/plain, inline)]

Hello, this adds a php-fpm service. php-fpm is an alternative fcgi
implementation that is already build with the php package.

About the accounts:
Nginx needs write access to the unix socket of php-fpm. I didn't want to
set nginx as default user for php-fpm in case we add other webservers,
so I added the nginx to the newly created www-data group.

Thank you for reading. I'm looking forward to the revisions,
and happy Hacking!

[0001-guix-utils-add-version-major.patch (text/x-patch, attachment)]

[0002-gnu-services-Add-php-fpm.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: nee <nee <at> cock.li>
Cc: 28769-done <at> debbugs.gnu.org
Subject: Re: [bug#28769] [PATCH] gnu: services: Add php-fpm.
Date: Tue, 12 Dec 2017 21:41:41 +0000

[Message part 7 (text/plain, inline)]

nee <nee <at> cock.li> writes:

> Am 09.12.2017 um 23:08 schrieb Christopher Baines:
>> I've attached some changes that I thought would be good when I was
>> looking through this. To give a rough summary:
>> 
>>  - Minor improvements to the docs, either content, markup or formatting.
>>  - Removing trailing whitespace.
>>  - Removing the changes to the nginx-service, in favour of changing the
>>    default socket group.
>>  - Change some indentation to avoid long lines.
>> 
>> By changing the default socket group, the system test passes, even
>> without the changes to the nginx service. I think this is a bit better,
>> and while it's definately not perfect, I think it would be ok to merge
>> with this change.
>> 
> Looks all good to me. Thanks for all these style fixes.
>
>> To also try and move the first patch forward, I've submitted that within
>> #29629, with an additional patch to get other services using
>> version-major.
>> 
> Thanks, good to see it used at some other spots already.
>
>> It would be good to get your thoughts on the changes in the attached
>> patch, and then if you could send an updated set of patches, that would
>> be great. As far as I remember, the changes to the nginx service were
>> the only thing I felt needed addressing before merging this.
>
> The changes look good to me.
> I have no edits to add, imo the patches can be squashed merged.

Great, I've now rebased and pushed this. Good job :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.