From unknown Fri Jun 20 19:48:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28765 <28765@debbugs.gnu.org> To: bug#28765 <28765@debbugs.gnu.org> Subject: Status: [PATCH] config: Conditionally configure daemon offload script. Reply-To: bug#28765 <28765@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:48:36 +0000 retitle 28765 [PATCH] config: Conditionally configure daemon offload script. reassign 28765 guix-patches submitter 28765 Eric Bavier severity 28765 normal tag 28765 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 15:08:37 2017 Received: (at submit) by debbugs.gnu.org; 9 Oct 2017 19:08:37 +0000 Received: from localhost ([127.0.0.1]:58572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1dPp-0005DT-Fu for submit@debbugs.gnu.org; Mon, 09 Oct 2017 15:08:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1dPn-0005DE-He for submit@debbugs.gnu.org; Mon, 09 Oct 2017 15:08:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1dPh-0000uL-HI for submit@debbugs.gnu.org; Mon, 09 Oct 2017 15:08:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1dPh-0000u9-Ba for submit@debbugs.gnu.org; Mon, 09 Oct 2017 15:08:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1dPg-0004Ex-C4 for guix-patches@gnu.org; Mon, 09 Oct 2017 15:08:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1dPd-0000tH-6c for guix-patches@gnu.org; Mon, 09 Oct 2017 15:08:28 -0400 Received: from esa2.cray.iphmx.com ([68.232.143.164]:16678) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1dPc-0000sw-PW for guix-patches@gnu.org; Mon, 09 Oct 2017 15:08:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cray.com; i=@cray.com; q=dns/txt; s=cray1024; t=1507576104; x=1539112104; h=from:to:subject:date:message-id:mime-version; bh=ThIDeC9K8/C2uxQjyFUJn7ZLsEw6QK3BKWy5MsIxXVo=; b=kAMncWHk/xl7sK6F+yBHF2I2zg9ldo6jpxSyljFOAri3ERJx8z2JtuPk h5gsfsCjYGKVqhJTGfrRvyVR88KD+yzn0fZG7jSZ/E8TU8cbx9og4Ibkd /fmq1RtdE1van9HY92WgSNfK6HC+1pGdFNb5m+phOlWWc35+rk4V5phHw I=; X-IronPort-AV: E=Sophos;i="5.42,501,1500937200"; d="scan'208,223";a="15915423" X-Cray-OBMMKR: 1433258124 15915423 Received: from cray-smtp-2.cray.com (HELO CFWEX01.americas.cray.com) ([136.162.34.11]) by esa2.cray.iphmx.com with ESMTP/TLS/AES256-SHA; 09 Oct 2017 20:08:23 +0100 Received: from CFWEXHYBRID.americas.cray.com (172.30.88.178) by CFWEX01.americas.cray.com (172.30.88.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Oct 2017 14:08:22 -0500 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (207.46.163.24) by mail.cray.com (172.30.88.178) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Oct 2017 14:08:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crayinc.onmicrosoft.com; s=selector1-cray-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pSTJxLoYtp6ZZwlq6zoYsYd+dhRJOawbo8suOEYiU+o=; b=zHmdzDJkdOumpL/u6FXM5olwKzfbV3z5cKU3+98QMWcRf6KnC3iq70+Wk1cbrIJRDqF/ur9Rqn4nXGYuRUQDQf3khAA5qd0CjLjwTprWURi/20ujApJ+wHg1SrrL2YgCIgOYbeeJclfVP9pt214knzTz/nJfHCWudVrkVvcLkBk= Received: from CY4PR11MB1718.namprd11.prod.outlook.com (10.169.255.151) by CY4PR11MB1718.namprd11.prod.outlook.com (10.169.255.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 9 Oct 2017 19:08:21 +0000 Received: from CY4PR11MB1718.namprd11.prod.outlook.com ([10.169.255.151]) by CY4PR11MB1718.namprd11.prod.outlook.com ([10.169.255.151]) with mapi id 15.20.0077.020; Mon, 9 Oct 2017 19:08:21 +0000 From: Eric Bavier To: "guix-patches@gnu.org" Subject: [PATCH] config: Conditionally configure daemon offload script. Thread-Topic: [PATCH] config: Conditionally configure daemon offload script. Thread-Index: AQHTQTHMaPIT74wCpkOxQe8Oh8EfDQ== Date: Mon, 9 Oct 2017 19:08:21 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=bavier@cray.com; x-originating-ip: [136.162.2.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR11MB1718; 6:khuKzRXdJIzP90E0G/PFXUJVOtcE86ewgX3IMLMRVcbp/5mFr0k3+ertyba+OKWfeOFBjy3L5mL7oiMRougijWwwmeyETkTnyI/LAazzlBRcMSb/4dvlKad8HAmspkjLxP+EoDRkFI2BlCiBo02Z5P+DOt5fVtP2Z+1qKtjtTDF4NwZEHLjcVAzcMAmWkhssOaOp/mA6cDin5uz8Hr9BErMIWF5Bs3bJ1tZ5vLsSEqz0+0sBk319XEFjTlNsoVfQ3+EhjX07CAZDtK1wautOcnJrX6KC5gwyeTCeMXa6rlYJJ77bsrU1HiJZr1wp1C8Oxslbjcv6Ydn8GfIdg4mNkg==; 5:uWZw2pAlN1jwOZKaK/Xb7Q8T4lHkGCiCprq1u4tH2tm5rUof4p/o4Ffybv49OZmUWwLBQEqgGszuirGn6Z5Ry6b+ycjlYHZo5Od2XOZuvvOfBmU6bMcG6n2PE6p6a3+sNbyiLymKtW3Gr1SyCSloCA==; 24:nHEB4yCxO3lhh+l7ZckaHKADI9HZIgWuQAJbRLQgzlWvsp22Tc+nDqiK03Txpnl4As6xwz/g0+0/qNb6176dlWmUuiJ7ciuMn+ZnObbqy6M=; 7:K4EwIOUej8KEkpXENJG60KprjdPC8GCvzAGNgBxo7AFF7MyV9cOMFlvSiKSAObGng2rVc6v9na3VlSoeF3SV/R0xHa+ke+y26zxQQBpWNBotiDWVq3OYRRGpC1RvSNTN5jXnpnjSoyRM6L3dYZfVDxToQqvQlVrfv3Yr3GCS+M1cRIlIx8NoNfkcyDQ3I975ugIgI7kk31MWDp5m5RW/ar+EOHHDeCrVVvoBwGIJmt0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 9609b84f-69bb-49a7-1670-08d50f491ba3 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(49563074)(201703131423075)(201703031133081)(201702281549075); SRVR:CY4PR11MB1718; x-ms-traffictypediagnostic: CY4PR11MB1718: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123564025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR11MB1718; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR11MB1718; x-forefront-prvs: 045584D28C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39830400002)(376002)(346002)(189002)(199003)(478600001)(189998001)(7696004)(5640700003)(68736007)(53936002)(50986999)(54356999)(99936001)(74316002)(101416001)(66066001)(33656002)(7736002)(6916009)(3660700001)(305945005)(86362001)(3846002)(102836003)(6116002)(25786009)(2906002)(99286003)(55016002)(2501003)(3280700002)(14454004)(8676002)(8936002)(9686003)(81156014)(81166006)(77096006)(6506006)(2900100001)(5660300001)(6436002)(558084003)(97736004)(2351001)(106356001)(316002)(105586002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR11MB1718; H:CY4PR11MB1718.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_CY4PR11MB17189D487BEBC3AA8150097AB7740CY4PR11MB1718namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2017 19:08:21.2245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e7b8488a-c0cd-4614-aae1-996bfabec247 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1718 X-OriginatorOrg: cray.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --_002_CY4PR11MB17189D487BEBC3AA8150097AB7740CY4PR11MB1718namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable This prevents pre-inst-env from exporting NIX_BUILD_HOOK when guile-ssh is = not available. Eric Bavier, Scientific Libraries, Cray Inc. --_002_CY4PR11MB17189D487BEBC3AA8150097AB7740CY4PR11MB1718namp_ Content-Type: text/x-patch; name="0001-config-Conditionally-configure-daemon-offload-script.patch" Content-Description: 0001-config-Conditionally-configure-daemon-offload-script.patch Content-Disposition: attachment; filename="0001-config-Conditionally-configure-daemon-offload-script.patch"; size=1024; creation-date="Mon, 09 Oct 2017 19:07:07 GMT"; modification-date="Mon, 09 Oct 2017 19:07:07 GMT" Content-Transfer-Encoding: base64 RnJvbSA5ODRlMzI0MzcwYzJjMTdkOGQxYTk4MmFkZjI4ODQxMTJjOWU2NGI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmljIEJhdmllciA8YmF2aWVyQGNyYXkuY29tPgpEYXRlOiBN b24sIDkgT2N0IDIwMTcgMTM6NTg6MDQgLTA1MDAKU3ViamVjdDogW1BBVENIXSBjb25maWc6IENv bmRpdGlvbmFsbHkgY29uZmlndXJlIGRhZW1vbiBvZmZsb2FkIHNjcmlwdC4KCiogY29uZmlnLWRh ZW1vbi5hYyAobml4L3NjcmlwdHMvb2ZmbG9hZCk6IENvbmZpZ3VyZSBvbmx5IGlmIG9mZmxvYWRp bmcgZW5hYmxlZC4KLS0tCiBjb25maWctZGFlbW9uLmFjIHwgNiArKysrLS0KIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY29uZmln LWRhZW1vbi5hYyBiL2NvbmZpZy1kYWVtb24uYWMKaW5kZXggNDJiNTk4MS4uODQxZTBhYyAxMDA2 NDQKLS0tIGEvY29uZmlnLWRhZW1vbi5hYworKysgYi9jb25maWctZGFlbW9uLmFjCkBAIC0xNTks OCArMTU5LDEwIEBAIGlmIHRlc3QgIngkZ3VpeF9idWlsZF9kYWVtb24iID0gInh5ZXMiOyB0aGVu CiAgICAgW2NobW9kICt4IG5peC9zY3JpcHRzL3N1YnN0aXR1dGVdKQogICBBQ19DT05GSUdfRklM RVMoW25peC9zY3JpcHRzL2d1aXgtYXV0aGVudGljYXRlXSwKICAgICBbY2htb2QgK3ggbml4L3Nj cmlwdHMvZ3VpeC1hdXRoZW50aWNhdGVdKQotICBBQ19DT05GSUdfRklMRVMoW25peC9zY3JpcHRz L29mZmxvYWRdLAotICAgIFtjaG1vZCAreCBuaXgvc2NyaXB0cy9vZmZsb2FkXSkKKyAgaWYgdGVz dCAieCRndWl4X2J1aWxkX2RhZW1vbl9vZmZsb2FkIiA9ICJ4eWVzIjsgdGhlbgorICAgIEFDX0NP TkZJR19GSUxFUyhbbml4L3NjcmlwdHMvb2ZmbG9hZF0sCisgICAgICBbY2htb2QgK3ggbml4L3Nj cmlwdHMvb2ZmbG9hZF0pCisgIGZpCiBmaQogCiBBTV9DT05ESVRJT05BTChbQlVJTERfREFFTU9O XSwgW3Rlc3QgIngkZ3VpeF9idWlsZF9kYWVtb24iID0gInh5ZXMiXSkKLS0gCjEuOC41LjYKCg== --_002_CY4PR11MB17189D487BEBC3AA8150097AB7740CY4PR11MB1718namp_-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 17:07:23 2017 Received: (at 28765) by debbugs.gnu.org; 9 Oct 2017 21:07:23 +0000 Received: from localhost ([127.0.0.1]:58719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1fGl-0000Rp-0A for submit@debbugs.gnu.org; Mon, 09 Oct 2017 17:07:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1fGh-0000RZ-9F for 28765@debbugs.gnu.org; Mon, 09 Oct 2017 17:07:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1fGb-0006Ux-6Q for 28765@debbugs.gnu.org; Mon, 09 Oct 2017 17:07:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1fGb-0006Ur-2M; Mon, 09 Oct 2017 17:07:13 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=41046 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1fGa-0005fS-Jn; Mon, 09 Oct 2017 17:07:12 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eric Bavier Subject: Re: [bug#28765] [PATCH] config: Conditionally configure daemon offload script. References: Date: Mon, 09 Oct 2017 23:07:10 +0200 In-Reply-To: (Eric Bavier's message of "Mon, 9 Oct 2017 19:08:21 +0000") Message-ID: <87vajoowsh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28765 Cc: 28765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eric Bavier skribis: > From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Mon, 9 Oct 2017 13:58:04 -0500 > Subject: [PATCH] config: Conditionally configure daemon offload script. ^ Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things build-rel= ated. > * config-daemon.ac (nix/scripts/offload): Configure only if offloading en= abled. It LGTM, but is it helpful? guix-daemon does not invoke =E2=80=98guix offl= oad=E2=80=99 when it=E2=80=99s missing, as can be seen in guix-daemon.cc: #ifdef HAVE_DAEMON_OFFLOAD_HOOK /* Use our build hook for distributed builds by default. */ =E2=80=A6 Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 20:08:09 2017 Received: (at 28765) by debbugs.gnu.org; 10 Oct 2017 00:08:09 +0000 Received: from localhost ([127.0.0.1]:58868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1i5h-0002NP-94 for submit@debbugs.gnu.org; Mon, 09 Oct 2017 20:08:09 -0400 Received: from mail.centurylink.net ([205.219.233.9]:42039 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1i5g-0002NA-37 for 28765@debbugs.gnu.org; Mon, 09 Oct 2017 20:08:08 -0400 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1507594082; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=TFqXqNu62j75GkmxE+w0Y7nxL3Q=; b=w/MkgdPLaygUTjFeRSON69Q/fppKLdHnf5b5yVUNna9b1J7l/DS8PN1/TeEfU+LQ YQuUC/bGbeL4QZcAPYuO0b1FWkKdJTXH/u+LvfMF6h/4kcdeyt1m5R4uIyckJt6+ Vzk/atbBi4f5+wbHTbq44nOt1UwnVRiv9M6MRCwcaBLOX2h3QEO+y2IPuZ2l+1tG A3NONFHVfJI2EV+HzlaapogcNwOtSpcPW7xdQp0mwJJyK0RSRLJ29jAzkHYQ2VS+ zO3f5HxliXYBPfl/96R89p5NWOnzAAOrP7AdW1UjBu8o/SZvq5iKe1rIJmP8DA02 Co/qPNpDG1JPN0anzcYduQ==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=SrHS07G0 c=1 sm=1 tr=0 a=vYGdbaltFBZNd9BlzHJvqw==:117 a=vYGdbaltFBZNd9BlzHJvqw==:17 a=KGjhK52YXX0A:10 a=IkcTkHD0fZMA:10 a=1x0kU5LsU6YA:10 a=02M-m0pO-4AA:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=kBl-OI3rAAAA:8 a=1_nRspQ2AZxWCPLN_6kA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=pLxN2xGgR0OPbCgNAGn6:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp01.agate.dfw.synacor.com smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.109.77] ([97.116.109.77:2866] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.5.1.37854 r(Momo-dev:3.5.1.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id FD/56-31736-26F0CD95; Mon, 09 Oct 2017 20:08:02 -0400 Date: Mon, 9 Oct 2017 19:08:01 -0500 From: Eric Bavier To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#28765] [PATCH] config: Conditionally configure daemon offload script. Message-ID: <20171009190801.22685b19@centurylink.net> In-Reply-To: <87vajoowsh.fsf@gnu.org> References: <87vajoowsh.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 28765 Cc: Eric Bavier , 28765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On Mon, 09 Oct 2017 23:07:10 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Eric Bavier skribis: >=20 > > From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 2001 > > From: Eric Bavier > > Date: Mon, 9 Oct 2017 13:58:04 -0500 > > Subject: [PATCH] config: Conditionally configure daemon offload script.= =20 > ^ > Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things build-r= elated. >=20 > > * config-daemon.ac (nix/scripts/offload): Configure only if offloading = enabled. =20 >=20 > It LGTM, but is it helpful? guix-daemon does not invoke =E2=80=98guix of= fload=E2=80=99 > when it=E2=80=99s missing, as can be seen in guix-daemon.cc: >=20 > #ifdef HAVE_DAEMON_OFFLOAD_HOOK > /* Use our build hook for distributed builds by default. */ > =E2=80=A6 Or maybe something like this would be preferable, to avoid exporting NIX_BUILD_HOOK if Guix has been configured to disable the daemon offload hook? --- a/build-aux/pre-inst-env.in +++ b/build-aux/pre-inst-env.in @@ -50,13 +50,9 @@ NIX_LIBEXEC_DIR=3D"@abs_top_builddir@/nix/scripts" # for= 'guix-authenticate' export NIX_ROOT_FINDER NIX_SUBSTITUTERS NIX_LIBEXEC_DIR =20 NIX_BUILD_HOOK=3D"$abs_top_builddir/nix/scripts/offload" -if [ -x "$NIX_BUILD_HOOK" ] -then - export NIX_BUILD_HOOK -else - # No offloading support. - unset NIX_BUILD_HOOK -fi +@BUILD_DAEMON_OFFLOAD_TRUE@export NIX_BUILD_HOOK +@BUILD_DAEMON_OFFLOAD_FALSE@# No offloading support. +@BUILD_DAEMON_OFFLOAD_FALSE@unset NIX_BUILD_HOOK =20 # The 'guix-register' program. GUIX_REGISTER=3D"$abs_top_builddir/guix-register" From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 02:50:04 2017 Received: (at 28765) by debbugs.gnu.org; 10 Oct 2017 06:50:04 +0000 Received: from localhost ([127.0.0.1]:59016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1oMd-0004Vf-Ub for submit@debbugs.gnu.org; Tue, 10 Oct 2017 02:50:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1oMb-0004V5-LW for 28765@debbugs.gnu.org; Tue, 10 Oct 2017 02:50:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1oMT-0006CV-G4 for 28765@debbugs.gnu.org; Tue, 10 Oct 2017 02:49:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1oMT-0006CN-C9; Tue, 10 Oct 2017 02:49:53 -0400 Received: from [193.50.110.208] (port=40536 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1oMS-0001CU-TJ; Tue, 10 Oct 2017 02:49:53 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eric Bavier Subject: Re: [bug#28765] [PATCH] config: Conditionally configure daemon offload script. References: <87vajoowsh.fsf@gnu.org> <20171009190801.22685b19@centurylink.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 10 Oct 2017 08:49:49 +0200 In-Reply-To: <20171009190801.22685b19@centurylink.net> (Eric Bavier's message of "Mon, 9 Oct 2017 19:08:01 -0500") Message-ID: <87zi8zpkdu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28765 Cc: Eric Bavier , 28765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, Eric Bavier skribis: > On Mon, 09 Oct 2017 23:07:10 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Eric Bavier skribis: >>=20 >> > From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 2001 >> > From: Eric Bavier >> > Date: Mon, 9 Oct 2017 13:58:04 -0500 >> > Subject: [PATCH] config: Conditionally configure daemon offload script= .=20=20 >> ^ >> Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things build-= related. >>=20 >> > * config-daemon.ac (nix/scripts/offload): Configure only if offloading= enabled.=20=20 >>=20 >> It LGTM, but is it helpful? guix-daemon does not invoke =E2=80=98guix o= ffload=E2=80=99 >> when it=E2=80=99s missing, as can be seen in guix-daemon.cc: >>=20 >> #ifdef HAVE_DAEMON_OFFLOAD_HOOK >> /* Use our build hook for distributed builds by default. */ >> =E2=80=A6 > > Or maybe something like this would be preferable, to avoid exporting > NIX_BUILD_HOOK if Guix has been configured to disable the daemon > offload hook? > > --- a/build-aux/pre-inst-env.in > +++ b/build-aux/pre-inst-env.in > @@ -50,13 +50,9 @@ NIX_LIBEXEC_DIR=3D"@abs_top_builddir@/nix/scripts" # f= or 'guix-authenticate' > export NIX_ROOT_FINDER NIX_SUBSTITUTERS NIX_LIBEXEC_DIR >=20=20 > NIX_BUILD_HOOK=3D"$abs_top_builddir/nix/scripts/offload" > -if [ -x "$NIX_BUILD_HOOK" ] > -then > - export NIX_BUILD_HOOK > -else > - # No offloading support. > - unset NIX_BUILD_HOOK > -fi > +@BUILD_DAEMON_OFFLOAD_TRUE@export NIX_BUILD_HOOK > +@BUILD_DAEMON_OFFLOAD_FALSE@# No offloading support. > +@BUILD_DAEMON_OFFLOAD_FALSE@unset NIX_BUILD_HOOK It=E2=80=99s nicer (you=E2=80=99re welcome to push this change!), but it=E2= =80=99s equivalent to what=E2=80=99s already here, no? Is there a problem that we are trying to solve in the first place, or is it more about making things nicer? Thank you, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 09:00:35 2017 Received: (at 28765) by debbugs.gnu.org; 10 Oct 2017 13:00:36 +0000 Received: from localhost ([127.0.0.1]:59400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1u9A-0002mM-6O for submit@debbugs.gnu.org; Tue, 10 Oct 2017 09:00:35 -0400 Received: from mail.centurylink.net ([205.219.233.9]:25808 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1u95-0002m5-I6 for 28765@debbugs.gnu.org; Tue, 10 Oct 2017 09:00:31 -0400 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1507640421; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=QIUipSy4gaB8ZRko7oHHSvpL8io=; b=EC4GF28X6j3ToIvLvhq+EIUEUchX3z2jC/38FdKCy99nxSiIGiOfIc2bgnmwiBpw egwsowxZ6Y6BZr06rgDqqalJv8vhx+Pf0SeeCZ1p1RIfeSfJhEGUULPUHgvIUcjU roFP9TPpmRVCo2LsbSYfTmAH/iGSvshagxj09YpgT7pHk1XpeLtLbRLJE8rchO2n iFBxm9XHwPZuFNAhoaWnd+bZ6g1iNVKCb63A1k8uXBEQZX1uPCEAwvV0QnsR/Gwc mGusmYkG9v6CAbzaW3ocZmLt3tF7iKjWFE6wl0vZ01r5tDD/kGrHQVWVkcZlXIbZ zLkCFT2/MNsBcV00X/0muQ==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=Y9K6iVWN c=1 sm=1 tr=0 a=vYGdbaltFBZNd9BlzHJvqw==:117 a=vYGdbaltFBZNd9BlzHJvqw==:17 a=KGjhK52YXX0A:10 a=IkcTkHD0fZMA:10 a=1x0kU5LsU6YA:10 a=02M-m0pO-4AA:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=I_5RNyk1AAAA:8 a=kBl-OI3rAAAA:8 a=E3eTlX-H3IZiNaCPxbkA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=Eh9yxdLE6B1twWrs3SXz:22 a=pLxN2xGgR0OPbCgNAGn6:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp03.agate.dfw.synacor.com smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.109.77] ([97.116.109.77:17914] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.5.1.37854 r(Momo-dev:3.5.1.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 8E/0B-31187-464CCD95; Tue, 10 Oct 2017 09:00:21 -0400 Date: Tue, 10 Oct 2017 08:00:19 -0500 From: Eric Bavier To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#28765] [PATCH] config: Conditionally configure daemon offload script. Message-ID: <20171010080019.19341e92@centurylink.net> In-Reply-To: <87zi8zpkdu.fsf@gnu.org> References: <87vajoowsh.fsf@gnu.org> <20171009190801.22685b19@centurylink.net> <87zi8zpkdu.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28765 Cc: Eric Bavier , 28765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Tue, 10 Oct 2017 08:49:49 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello, >=20 > Eric Bavier skribis: >=20 > > On Mon, 09 Oct 2017 23:07:10 +0200 > > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > =20 > >> Eric Bavier skribis: > >> =20 > >> > From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 20= 01 > >> > From: Eric Bavier > >> > Date: Mon, 9 Oct 2017 13:58:04 -0500 > >> > Subject: [PATCH] config: Conditionally configure daemon offload scri= pt. =20 > >> ^ > >> Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things buil= d-related. > >> =20 > >> > * config-daemon.ac (nix/scripts/offload): Configure only if offloadi= ng enabled. =20 > >>=20 > >> It LGTM, but is it helpful? guix-daemon does not invoke =E2=80=98guix= offload=E2=80=99 > >> when it=E2=80=99s missing, as can be seen in guix-daemon.cc: > >>=20 > >> #ifdef HAVE_DAEMON_OFFLOAD_HOOK > >> /* Use our build hook for distributed builds by default. */ > >> =E2=80=A6 =20 > > > > Or maybe something like this would be preferable, to avoid exporting > > NIX_BUILD_HOOK if Guix has been configured to disable the daemon > > offload hook? > > > > --- a/build-aux/pre-inst-env.in > > +++ b/build-aux/pre-inst-env.in > > @@ -50,13 +50,9 @@ NIX_LIBEXEC_DIR=3D"@abs_top_builddir@/nix/scripts" #= for 'guix-authenticate' > > export NIX_ROOT_FINDER NIX_SUBSTITUTERS NIX_LIBEXEC_DIR > > =20 > > NIX_BUILD_HOOK=3D"$abs_top_builddir/nix/scripts/offload" > > -if [ -x "$NIX_BUILD_HOOK" ] > > -then > > - export NIX_BUILD_HOOK > > -else > > - # No offloading support. > > - unset NIX_BUILD_HOOK > > -fi > > +@BUILD_DAEMON_OFFLOAD_TRUE@export NIX_BUILD_HOOK > > +@BUILD_DAEMON_OFFLOAD_FALSE@# No offloading support. > > +@BUILD_DAEMON_OFFLOAD_FALSE@unset NIX_BUILD_HOOK =20 >=20 > It=E2=80=99s nicer (you=E2=80=99re welcome to push this change!), but it= =E2=80=99s equivalent to > what=E2=80=99s already here, no? It's not quite equivalent. The current situation would end up always exporting NIX_BUILD_HOOK because it is always generated by config.status. >=20 > Is there a problem that we are trying to solve in the first place, or is > it more about making things nicer? The problem is libstore/build.cc executing NIX_BUILD_HOOK even if the daemon offload hook is disabled, i.e. when guile-ssh is missing. Make sense? `~Eric From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 10:18:06 2017 Received: (at 28765) by debbugs.gnu.org; 10 Oct 2017 14:18:06 +0000 Received: from localhost ([127.0.0.1]:60731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1vM9-000514-2V for submit@debbugs.gnu.org; Tue, 10 Oct 2017 10:18:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1vM7-00050s-9v for 28765@debbugs.gnu.org; Tue, 10 Oct 2017 10:18:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1vLy-0005qC-44 for 28765@debbugs.gnu.org; Tue, 10 Oct 2017 10:17:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1vLy-0005q0-0W; Tue, 10 Oct 2017 10:17:50 -0400 Received: from [193.50.110.208] (port=44470 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1vLw-0006pL-J4; Tue, 10 Oct 2017 10:17:48 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eric Bavier Subject: Re: [bug#28765] [PATCH] config: Conditionally configure daemon offload script. References: <87vajoowsh.fsf@gnu.org> <20171009190801.22685b19@centurylink.net> <87zi8zpkdu.fsf@gnu.org> <20171010080019.19341e92@centurylink.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 10 Oct 2017 16:17:46 +0200 In-Reply-To: <20171010080019.19341e92@centurylink.net> (Eric Bavier's message of "Tue, 10 Oct 2017 08:00:19 -0500") Message-ID: <87sherm6id.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28765 Cc: Eric Bavier , 28765@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eric Bavier skribis: > On Tue, 10 Oct 2017 08:49:49 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Hello, >>=20 >> Eric Bavier skribis: >>=20 >> > On Mon, 09 Oct 2017 23:07:10 +0200 >> > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >> >=20=20 >> >> Eric Bavier skribis: >> >>=20=20=20 >> >> > From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 2= 001 >> >> > From: Eric Bavier >> >> > Date: Mon, 9 Oct 2017 13:58:04 -0500 >> >> > Subject: [PATCH] config: Conditionally configure daemon offload scr= ipt.=20=20=20=20 >> >> ^ >> >> Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things bui= ld-related. >> >>=20=20=20 >> >> > * config-daemon.ac (nix/scripts/offload): Configure only if offload= ing enabled.=20=20=20=20 >> >>=20 >> >> It LGTM, but is it helpful? guix-daemon does not invoke =E2=80=98gui= x offload=E2=80=99 >> >> when it=E2=80=99s missing, as can be seen in guix-daemon.cc: >> >>=20 >> >> #ifdef HAVE_DAEMON_OFFLOAD_HOOK >> >> /* Use our build hook for distributed builds by default. */ >> >> =E2=80=A6=20=20 >> > >> > Or maybe something like this would be preferable, to avoid exporting >> > NIX_BUILD_HOOK if Guix has been configured to disable the daemon >> > offload hook? >> > >> > --- a/build-aux/pre-inst-env.in >> > +++ b/build-aux/pre-inst-env.in >> > @@ -50,13 +50,9 @@ NIX_LIBEXEC_DIR=3D"@abs_top_builddir@/nix/scripts" = # for 'guix-authenticate' >> > export NIX_ROOT_FINDER NIX_SUBSTITUTERS NIX_LIBEXEC_DIR >> >=20=20 >> > NIX_BUILD_HOOK=3D"$abs_top_builddir/nix/scripts/offload" >> > -if [ -x "$NIX_BUILD_HOOK" ] >> > -then >> > - export NIX_BUILD_HOOK >> > -else >> > - # No offloading support. >> > - unset NIX_BUILD_HOOK >> > -fi >> > +@BUILD_DAEMON_OFFLOAD_TRUE@export NIX_BUILD_HOOK >> > +@BUILD_DAEMON_OFFLOAD_FALSE@# No offloading support. >> > +@BUILD_DAEMON_OFFLOAD_FALSE@unset NIX_BUILD_HOOK=20=20 >>=20 >> It=E2=80=99s nicer (you=E2=80=99re welcome to push this change!), but it= =E2=80=99s equivalent to >> what=E2=80=99s already here, no? > > It's not quite equivalent. The current situation would end up always > exporting NIX_BUILD_HOOK because it is always generated by > config.status. Oooh, got it. >> Is there a problem that we are trying to solve in the first place, or is >> it more about making things nicer? > > The problem is libstore/build.cc executing NIX_BUILD_HOOK even if the > daemon offload hook is disabled, i.e. when guile-ssh is missing. > > Make sense? Yes, definitely. Then you can definitely commit the pre-inst-env.in patch; the config-daemon.ac patch can=E2=80=99t hurt either. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 00:18:44 2017 Received: (at 28765-done) by debbugs.gnu.org; 11 Oct 2017 04:18:44 +0000 Received: from localhost ([127.0.0.1]:32907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e28Tj-0004LP-Mq for submit@debbugs.gnu.org; Wed, 11 Oct 2017 00:18:43 -0400 Received: from mail.centurylink.net ([205.219.233.9]:22162 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e28Tf-0004L3-7m for 28765-done@debbugs.gnu.org; Wed, 11 Oct 2017 00:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1507695512; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=ZDC7UOdrfkI/P1ZcNaTpcKUMOZw=; b=hdwSV2hJAyNutvC5zbiJIDoYVKEwudiypIthMJxfF7otwJXCAjCfIcnyzrnqspg0 7hcFX/IJ0zOeZgG2kyGtuN3fDRVkNiRwsshHMhNxfpUS15kk9iE63dECcKmuWRNL rorvIo3qqK2sKzgx4P7CJiQtli1TPuLr6tehvRxJ9vU5W+n06V1bZo0C7rT0eAJ9 AWQuUgw8y/7kZERlUonn+xEtai819Rgybrwb7htwtCVwywIk/Qh9CM+l7B48rA7Z z97xfVxQuwxzyKt1hOf7+8LKl2z5CfnSEDF/Ob6bzyugv3yW3XK9FZ9Nt6KG2TIu rmWpo8xmv0UdolskOjxJyQ==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=V5k/6qvi c=1 sm=1 tr=0 a=vYGdbaltFBZNd9BlzHJvqw==:117 a=vYGdbaltFBZNd9BlzHJvqw==:17 a=KGjhK52YXX0A:10 a=IkcTkHD0fZMA:10 a=1x0kU5LsU6YA:10 a=02M-m0pO-4AA:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=I_5RNyk1AAAA:8 a=kBl-OI3rAAAA:8 a=r9auyhiRKhPQuw2-C4YA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=Eh9yxdLE6B1twWrs3SXz:22 a=pLxN2xGgR0OPbCgNAGn6:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp01.agate.dfw.synacor.com smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.109.77] ([97.116.109.77:51638] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.5.1.37854 r(Momo-dev:3.5.1.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 1B/76-06541-89B9DD95; Wed, 11 Oct 2017 00:18:32 -0400 Date: Tue, 10 Oct 2017 23:18:31 -0500 From: Eric Bavier To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#28765] [PATCH] config: Conditionally configure daemon offload script. Message-ID: <20171010231831.587b03db@centurylink.net> In-Reply-To: <87sherm6id.fsf@gnu.org> References: <87vajoowsh.fsf@gnu.org> <20171009190801.22685b19@centurylink.net> <87zi8zpkdu.fsf@gnu.org> <20171010080019.19341e92@centurylink.net> <87sherm6id.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28765-done Cc: 28765-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On Tue, 10 Oct 2017 16:17:46 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Eric Bavier skribis: >=20 > > On Tue, 10 Oct 2017 08:49:49 +0200 > > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > =20 > >> Hello, > >>=20 > >> Eric Bavier skribis: > >> =20 > >> > On Mon, 09 Oct 2017 23:07:10 +0200 > >> > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> > =20 > >> >> Eric Bavier skribis: > >> >> =20 > >> >> > From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00= 2001 > >> >> > From: Eric Bavier > >> >> > Date: Mon, 9 Oct 2017 13:58:04 -0500 > >> >> > Subject: [PATCH] config: Conditionally configure daemon offload s= cript. =20 > >> >> ^ > >> >> Nitpick: rather =E2=80=9Cbuild:=E2=80=9D, which is for all things b= uild-related. > >> >> =20 > >> >> > * config-daemon.ac (nix/scripts/offload): Configure only if offlo= ading enabled. =20 > >> >>=20 > >> >> It LGTM, but is it helpful? guix-daemon does not invoke =E2=80=98g= uix offload=E2=80=99 > >> >> when it=E2=80=99s missing, as can be seen in guix-daemon.cc: > >> >>=20 > >> >> #ifdef HAVE_DAEMON_OFFLOAD_HOOK > >> >> /* Use our build hook for distributed builds by default. */ > >> >> =E2=80=A6 =20 > >> > > >> > Or maybe something like this would be preferable, to avoid exporting > >> > NIX_BUILD_HOOK if Guix has been configured to disable the daemon > >> > offload hook? > >> > > >> > --- a/build-aux/pre-inst-env.in > >> > +++ b/build-aux/pre-inst-env.in > >> > @@ -50,13 +50,9 @@ NIX_LIBEXEC_DIR=3D"@abs_top_builddir@/nix/scripts= " # for 'guix-authenticate' > >> > export NIX_ROOT_FINDER NIX_SUBSTITUTERS NIX_LIBEXEC_DIR > >> > =20 > >> > NIX_BUILD_HOOK=3D"$abs_top_builddir/nix/scripts/offload" > >> > -if [ -x "$NIX_BUILD_HOOK" ] > >> > -then > >> > - export NIX_BUILD_HOOK > >> > -else > >> > - # No offloading support. > >> > - unset NIX_BUILD_HOOK > >> > -fi > >> > +@BUILD_DAEMON_OFFLOAD_TRUE@export NIX_BUILD_HOOK > >> > +@BUILD_DAEMON_OFFLOAD_FALSE@# No offloading support. > >> > +@BUILD_DAEMON_OFFLOAD_FALSE@unset NIX_BUILD_HOOK =20 > >>=20 > >> It=E2=80=99s nicer (you=E2=80=99re welcome to push this change!), but = it=E2=80=99s equivalent to > >> what=E2=80=99s already here, no? =20 > > > > It's not quite equivalent. The current situation would end up always > > exporting NIX_BUILD_HOOK because it is always generated by > > config.status. =20 >=20 > Oooh, got it. >=20 > >> Is there a problem that we are trying to solve in the first place, or = is > >> it more about making things nicer? =20 > > > > The problem is libstore/build.cc executing NIX_BUILD_HOOK even if the > > daemon offload hook is disabled, i.e. when guile-ssh is missing. > > > > Make sense? =20 >=20 > Yes, definitely. >=20 > Then you can definitely commit the pre-inst-env.in patch; the > config-daemon.ac patch can=E2=80=99t hurt either. pre-inst-env patch pushed as 7740228e3523e3e0e4c007eb1f1b224575d16574 From unknown Fri Jun 20 19:48:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Nov 2017 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator