Subject: [bug#28765] [PATCH] config: Conditionally configure daemon offload script.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 09 Oct 2017 23:07:10 +0200

Eric Bavier <[email-masked]> skribis:

> From 984e324370c2c17d8d1a982adf2884112c9e64b7 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <[email-masked]>
> Date: Mon, 9 Oct 2017 13:58:04 -0500
> Subject: [PATCH] config: Conditionally configure daemon offload script.
                   ^
Nitpick: rather “build:”, which is for all things build-related.

> * config-daemon.ac (nix/scripts/offload): Configure only if offloading enabled.

It LGTM, but is it helpful?  guix-daemon does not invoke ‘guix offload’
when it’s missing, as can be seen in guix-daemon.cc:

  #ifdef HAVE_DAEMON_OFFLOAD_HOOK
        /* Use our build hook for distributed builds by default.  */
  …

Thanks,
Ludo’.