GNU bug report logs - #28747
26.0.60; Usage of "&rest body" in Edebug specs

Previous Next

Full log

View this message in rfc822 format

From: Gemini Lasswell <gazally <at> runbox.com>
To: 28747 <at> debbugs.gnu.org
Subject: bug#28747: 26.0.60; Usage of "&rest body" in Edebug specs
Date: Sun, 08 Oct 2017 08:02:56 -0700

The symbol &rest in an Edebug spec has a different meaning than it has
in an argument list. In particular, "&rest body" in an Edebug spec is
erroneous usage because it is asking Edebug to match something that
can match nothing (body) as many times as it can, which makes an
infinite loop.

To repro, navigate to the definition of crm-completion-help in
lisp/emacs-lisp/crm.el and:

M-x eval-buffer RET
C-u C-M-x

Result: Too deep - perhaps infinite loop in spec?

Here are the macros I've found that have this incorrect usage of &rest
in their Edebug specs:

crm--completion-command
easy-mmode-define-navigation
inline--letlisteval
inline--leteval
ses--letref

Edebug specs have been using &rest for a really long time and it
mostly gets used correctly. But &repeat would be better, since it
actually describes the functionality and doesn't have a completely
different and more common usage in argument lists.

Here's a little example of what an Edebug spec would look like with
&repeat in place of &rest:

(defmacro msgmac (&rest args)
  (declare (debug ("start" [&repeat "middle"] "end")))
  `(message "%s" ',args))

(defun use-msgmac ()
  (msgmac start end)
  (msgmac start middle end)
  (msgmac start middle middle end))

Does anyone have thoughts on the idea of adding &repeat as a synonym
for &rest in Edebug specs, with the goal of moving &rest towards
obsolescence eventually?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.