From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2017 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 28732@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150739033213865 (code B ref -1); Sat, 07 Oct 2017 15:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Oct 2017 15:32:12 +0000 Received: from localhost ([127.0.0.1]:54858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0r5I-0003bZ-5Y for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0r5H-0003bN-AU for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0r5B-00043L-9u for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0r5B-00043H-6p for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0r5A-0008Ds-3n for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 11:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0r56-0003w6-31 for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 11:32:04 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:54603) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0r55-0003rD-Qc for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 11:32:00 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id A960A22568 for ; Sat, 7 Oct 2017 15:25:16 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1507389915; x=1508253916; bh=dU9SHwind3PBTIGizzREbc5pD4cPQQehFwb 55rxDmRE=; b=HhUZQYJHZul/W+Pxg38Zsd7cURalzxWtvX2kTKPWrzW79sOL+K/ XQ08MDD8QpVT5v6PbKRoCMOLW+cwcmNBodwK5FY9cX/YGMGYmKEwB4dPrj378rgr hAqe0Z4UtLzSHMYht2sx8OEXGdGVn9W6QS+p9+UxirB5QP2XCKb2SDjE= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id c1sd86rCeFP2 for ; Sat, 7 Oct 2017 15:25:15 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 43F892255D for ; Sat, 7 Oct 2017 15:25:15 +0000 (UTC) Date: Sat, 07 Oct 2017 17:31:36 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) The flymake mode line mouse-wheel scroll thing needs the following fix to be more portable. This change also removes an extra newline at the end of the tooltip, which doesn't have to be there as far as I can see. diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 45f0adf..007de8f 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -951,11 +951,13 @@ flymake--mode-line-format keymap ,(let ((map (make-sparse-keymap)) (type type)) - (define-key map [mode-line mouse-4] + (define-key map (vector 'mode-line + mouse-wheel-down-event) (lambda (_event) (interactive "e") (flymake-goto-prev-error 1 (list type) t))) - (define-key map [mode-line mouse-5] + (define-key map (vector 'mode-line + mouse-wheel-up-event) (lambda (_event) (interactive "e") (flymake-goto-next-error 1 (list type) t))) @@ -967,7 +969,9 @@ flymake--mode-line-format 'face face) (propertize (format "%s" type) 'face face)) - "mouse-4/mouse-5: previous/next of this type\n")) + (format "%s/%s: previous/next of this type" + mouse-wheel-down-event + mouse-wheel-up-event))) into forms finally return `((:propertize "[") From unknown Fri Aug 15 16:58:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: charles@aurox.ch (Charles A. Roelli) Subject: bug#28732: closed (Re: bug#28732: flymake mouse-wheel portability fix) Message-ID: References: X-Gnu-PR-Message: they-closed 28732 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 28732@debbugs.gnu.org Date: Sat, 21 Oct 2017 13:07:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1508591221-24459-1" This is a multi-part message in MIME format... ------------=_1508591221-24459-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28732: flymake mouse-wheel portability fix which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28732@debbugs.gnu.org. --=20 28732: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28732 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1508591221-24459-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28732-done) by debbugs.gnu.org; 21 Oct 2017 13:06:16 +0000 Received: from localhost ([127.0.0.1]:53157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5tTk-0006LV-CR for submit@debbugs.gnu.org; Sat, 21 Oct 2017 09:06:16 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:58055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5tTi-0006LE-Qc for 28732-done@debbugs.gnu.org; Sat, 21 Oct 2017 09:06:15 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 0A82922585 for <28732-done@debbugs.gnu.org>; Sat, 21 Oct 2017 12:59:21 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1508590759; x=1509454760; bh=au/DnvUIEqZm1 f5cmGTY4Ebnh35uaM+qTqi7D+m2Fl8=; b=XWYo59bl001ytNpgr2wQnbammV3mD XbGmzUtm9xxsZ9u3hIzW3VkbrhZn916BVia1FZFNh49e95nhOpJ+PPM3FklDoLSP uC5vzJlD5u9NnX3nnKztdkHVi3ealYXa7iuXD/UptZUWmBUd77XK6xigVntFKLK4 mHIlBR/xiU10zc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QjuX5_CjTS6s for <28732-done@debbugs.gnu.org>; Sat, 21 Oct 2017 12:59:19 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 85DF222564 for <28732-done@debbugs.gnu.org>; Sat, 21 Oct 2017 12:59:17 +0000 (UTC) Date: Sat, 21 Oct 2017 15:06:28 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: 28732-done@debbugs.gnu.org In-reply-to: (charles@aurox.ch) Subject: Re: bug#28732: flymake mouse-wheel portability fix References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28732-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Date: Sat, 07 Oct 2017 17:31:36 +0200 > From: charles@aurox.ch (Charles A. Roelli) > > The flymake mode line mouse-wheel scroll thing needs the following fix > to be more portable. > > This change also removes an extra newline at the end of the tooltip, > which doesn't have to be there as far as I can see. > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 45f0adf..007de8f 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -951,11 +951,13 @@ flymake--mode-line-format > keymap > ,(let ((map (make-sparse-keymap)) > (type type)) > - (define-key map [mode-line mouse-4] > + (define-key map (vector 'mode-line > + mouse-wheel-down-event) > (lambda (_event) > (interactive "e") > (flymake-goto-prev-error 1 (list type) t))) > - (define-key map [mode-line mouse-5] > + (define-key map (vector 'mode-line > + mouse-wheel-up-event) > (lambda (_event) > (interactive "e") > (flymake-goto-next-error 1 (list type) t))) > @@ -967,7 +969,9 @@ flymake--mode-line-format > 'face face) > (propertize (format "%s" type) > 'face face)) > - "mouse-4/mouse-5: previous/next of this type\n")) > + (format "%s/%s: previous/next of this type" > + mouse-wheel-down-event > + mouse-wheel-up-event))) > into forms > finally return > `((:propertize "[") It's pushed, closing. commit 75bb4827637111a210c79583f45dd1c5d59a745f Date: Sat Oct 21 14:56:59 2017 +0200 Make flymake's mouse-wheel interaction portable (Bug#28732) * lisp/progmodes/flymake.el (flymake--mode-line-format): Bind 'mouse-wheel-down-event' and 'mouse-wheel-up-event' instead of 'mouse-4' and 'mouse-5'. Update the tooltip text accordingly, and remove a stray newline in it. ------------=_1508591221-24459-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Oct 2017 15:32:12 +0000 Received: from localhost ([127.0.0.1]:54858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0r5I-0003bZ-5Y for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0r5H-0003bN-AU for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0r5B-00043L-9u for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0r5B-00043H-6p for submit@debbugs.gnu.org; Sat, 07 Oct 2017 11:32:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0r5A-0008Ds-3n for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 11:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0r56-0003w6-31 for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 11:32:04 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:54603) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0r55-0003rD-Qc for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 11:32:00 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id A960A22568 for ; Sat, 7 Oct 2017 15:25:16 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1507389915; x=1508253916; bh=dU9SHwind3PBTIGizzREbc5pD4cPQQehFwb 55rxDmRE=; b=HhUZQYJHZul/W+Pxg38Zsd7cURalzxWtvX2kTKPWrzW79sOL+K/ XQ08MDD8QpVT5v6PbKRoCMOLW+cwcmNBodwK5FY9cX/YGMGYmKEwB4dPrj378rgr hAqe0Z4UtLzSHMYht2sx8OEXGdGVn9W6QS+p9+UxirB5QP2XCKb2SDjE= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id c1sd86rCeFP2 for ; Sat, 7 Oct 2017 15:25:15 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 43F892255D for ; Sat, 7 Oct 2017 15:25:15 +0000 (UTC) Date: Sat, 07 Oct 2017 17:31:36 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: flymake mouse-wheel portability fix X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) The flymake mode line mouse-wheel scroll thing needs the following fix to be more portable. This change also removes an extra newline at the end of the tooltip, which doesn't have to be there as far as I can see. diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 45f0adf..007de8f 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -951,11 +951,13 @@ flymake--mode-line-format keymap ,(let ((map (make-sparse-keymap)) (type type)) - (define-key map [mode-line mouse-4] + (define-key map (vector 'mode-line + mouse-wheel-down-event) (lambda (_event) (interactive "e") (flymake-goto-prev-error 1 (list type) t))) - (define-key map [mode-line mouse-5] + (define-key map (vector 'mode-line + mouse-wheel-up-event) (lambda (_event) (interactive "e") (flymake-goto-next-error 1 (list type) t))) @@ -967,7 +969,9 @@ flymake--mode-line-format 'face face) (propertize (format "%s" type) 'face face)) - "mouse-4/mouse-5: previous/next of this type\n")) + (format "%s/%s: previous/next of this type" + mouse-wheel-down-event + mouse-wheel-up-event))) into forms finally return `((:propertize "[") ------------=_1508591221-24459-1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 16:39:22 2018 Received: (at control) by debbugs.gnu.org; 26 Feb 2018 21:39:22 +0000 Received: from localhost ([127.0.0.1]:34024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQUT-0005aX-Rn for submit@debbugs.gnu.org; Mon, 26 Feb 2018 16:39:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQUS-0005aK-Mf for control@debbugs.gnu.org; Mon, 26 Feb 2018 16:39:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqQUM-0001nu-Sl for control@debbugs.gnu.org; Mon, 26 Feb 2018 16:39:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqQUM-0001np-Ob for control@debbugs.gnu.org; Mon, 26 Feb 2018 16:39:14 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eqQUM-0007Br-Gx for control@debbugs.gnu.org; Mon, 26 Feb 2018 16:39:14 -0500 Subject: control message for bug 28732 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 26 Feb 2018 16:39:14 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unarchive 28732 From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Feb 2018 21:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: charles@aurox.ch (Charles A. Roelli) Cc: 28732@debbugs.gnu.org Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.151968144621933 (code B ref 28732); Mon, 26 Feb 2018 21:45:01 +0000 Received: (at 28732) by debbugs.gnu.org; 26 Feb 2018 21:44:06 +0000 Received: from localhost ([127.0.0.1]:34030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQZ4-0005hg-Cc for submit@debbugs.gnu.org; Mon, 26 Feb 2018 16:44:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqQZ3-0005h6-76 for 28732@debbugs.gnu.org; Mon, 26 Feb 2018 16:44:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqQYx-0003ZD-9V for 28732@debbugs.gnu.org; Mon, 26 Feb 2018 16:44:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqQYx-0003Z8-6P for 28732@debbugs.gnu.org; Mon, 26 Feb 2018 16:43:59 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eqQYw-0007Yj-Ry for 28732@debbugs.gnu.org; Mon, 26 Feb 2018 16:43:59 -0500 Resent-To: 28732@debbugs.gnu.org Resent-From: Glenn Morris Resent-Date: Mon, 26 Feb 2018 16:43:58 -0500 Resent-Message-ID: Resent-User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-From-Line: nobody Mon Feb 26 16:38:52 2018 From: Glenn Morris References: X-Spook: pipeline Craig Livingstone $400 million in gold bullion X-Ran: +'O]Wt/~+E)713+$|^}#gOq[H{6Er-.J!^ymppfl,,!YOc~?iMI%kB[<|~(cOY2Ks_J#_> X-Hue: green X-Attribution: GM Date: Mon, 26 Feb 2018 16:38:50 -0500 In-Reply-To: (Charles A. Roelli's message of "Sat, 07 Oct 2017 17:31:36 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Lines: 56 User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, This change causes errors in without-x builds. At compile-time: In flymake--mode-line-format: progmodes/flymake.el:1086:49:Warning: reference to free variable `mouse-wheel-down-event' progmodes/flymake.el:1092:49:Warning: reference to free variable `mouse-wheel-up-event' At run-time: Error during redisplay: (eval (flymake--mode-line-format)) signaled (void-variable mouse-wheel-down-event) Charles A. Roelli wrote: > The flymake mode line mouse-wheel scroll thing needs the following fix > to be more portable. > > This change also removes an extra newline at the end of the tooltip, > which doesn't have to be there as far as I can see. > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 45f0adf..007de8f 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -951,11 +951,13 @@ flymake--mode-line-format > keymap > ,(let ((map (make-sparse-keymap)) > (type type)) > - (define-key map [mode-line mouse-4] > + (define-key map (vector 'mode-line > + mouse-wheel-down-event) > (lambda (_event) > (interactive "e") > (flymake-goto-prev-error 1 (list type) t))) > - (define-key map [mode-line mouse-5] > + (define-key map (vector 'mode-line > + mouse-wheel-up-event) > (lambda (_event) > (interactive "e") > (flymake-goto-next-error 1 (list type) t))) > @@ -967,7 +969,9 @@ flymake--mode-line-format > 'face face) > (propertize (format "%s" type) > 'face face)) > - "mouse-4/mouse-5: previous/next of this type\n")) > + (format "%s/%s: previous/next of this type" > + mouse-wheel-down-event > + mouse-wheel-up-event))) > into forms > finally return > `((:propertize "[") From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Feb 2018 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Glenn Morris Cc: 28732@debbugs.gnu.org Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.151975910924612 (code B ref 28732); Tue, 27 Feb 2018 19:19:01 +0000 Received: (at 28732) by debbugs.gnu.org; 27 Feb 2018 19:18:29 +0000 Received: from localhost ([127.0.0.1]:35967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqklh-0006Ot-J3 for submit@debbugs.gnu.org; Tue, 27 Feb 2018 14:18:29 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:50688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqklf-0006Oe-7a for 28732@debbugs.gnu.org; Tue, 27 Feb 2018 14:18:28 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 47658226AF for <28732@debbugs.gnu.org>; Tue, 27 Feb 2018 19:18:49 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1519759127; x=1520623128; bh=Sb4bmxA2+OzoJ rG8c00aD1OvUANgRQQoqoJT94spOvo=; b=Hn41nIIU7S7a+lFEKG8NyM0ZhAyH9 b+REmfQAdwgsJeOWoku5wvsagpjkwCcNa5DdM+ZHfDKa+V6hXcTwz5CgLJEF7mQL nbsRyqDMXKsvh10lfZmktwdVmcD8YCImcrBpKTsNuTgTaRGgtHA/aeG+2a/3TuZ6 +yk2WRV6MpFgI8= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tiMvWfq-vhgk for <28732@debbugs.gnu.org>; Tue, 27 Feb 2018 19:18:47 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 6674A22688; Tue, 27 Feb 2018 19:18:47 +0000 (UTC) Date: Tue, 27 Feb 2018 20:28:42 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) In-reply-to: (message from Glenn Morris on Mon, 26 Feb 2018 16:38:50 -0500) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > From: Glenn Morris > Cc: 28732@debbugs.gnu.org > Date: Mon, 26 Feb 2018 16:38:50 -0500 > > Hi, > > This change causes errors in without-x builds. > At compile-time: > > In flymake--mode-line-format: > progmodes/flymake.el:1086:49:Warning: reference to free variable > `mouse-wheel-down-event' > progmodes/flymake.el:1092:49:Warning: reference to free variable > `mouse-wheel-up-event' > > At run-time: > Error during redisplay: (eval (flymake--mode-line-format)) signaled > (void-variable mouse-wheel-down-event) > > > Charles A. Roelli wrote: > > > The flymake mode line mouse-wheel scroll thing needs the following fix > > to be more portable. > > > > This change also removes an extra newline at the end of the tooltip, > > which doesn't have to be there as far as I can see. > > > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > > index 45f0adf..007de8f 100644 > > --- a/lisp/progmodes/flymake.el > > +++ b/lisp/progmodes/flymake.el > > @@ -951,11 +951,13 @@ flymake--mode-line-format > > keymap > > ,(let ((map (make-sparse-keymap)) > > (type type)) > > - (define-key map [mode-line mouse-4] > > + (define-key map (vector 'mode-line > > + mouse-wheel-down-event) > > (lambda (_event) > > (interactive "e") > > (flymake-goto-prev-error 1 (list type) t))) > > - (define-key map [mode-line mouse-5] > > + (define-key map (vector 'mode-line > > + mouse-wheel-up-event) > > (lambda (_event) > > (interactive "e") > > (flymake-goto-next-error 1 (list type) t))) > > @@ -967,7 +969,9 @@ flymake--mode-line-format > > 'face face) > > (propertize (format "%s" type) > > 'face face)) > > - "mouse-4/mouse-5: previous/next of this type\n")) > > + (format "%s/%s: previous/next of this type" > > + mouse-wheel-down-event > > + mouse-wheel-up-event))) > > into forms > > finally return > > `((:propertize "[") > Thanks. Is the following change (ignoring whitespace differences) good for emacs-26? diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 58bad8f..d58c5943 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1078,7 +1078,9 @@ face ,face mouse-face mode-line-highlight keymap - ,(let ((map (make-sparse-keymap)) + ,(when (and (boundp 'mouse-wheel-down-event) + (boundp 'mouse-wheel-up-event)) + (let ((map (make-sparse-keymap)) (type type)) (define-key map (vector 'mode-line mouse-wheel-down-event) @@ -1092,9 +1094,11 @@ (interactive "e") (with-selected-window (posn-window (event-start event)) (flymake-goto-next-error 1 (list type) t)))) - map) + map)) help-echo - ,(concat (format "%s diagnostics of type %s\n" + ,(when (and (boundp 'mouse-wheel-down-event) + (boundp 'mouse-wheel-up-event)) + (concat (format "%s diagnostics of type %s\n" (propertize (format "%d" (length diags)) 'face face) @@ -1102,7 +1106,7 @@ 'face face)) (format "%s/%s: previous/next of this type" mouse-wheel-down-event - mouse-wheel-up-event))) + mouse-wheel-up-event)))) into forms finally return `((:propertize "[") From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Feb 2018 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: charles@aurox.ch (Charles A. Roelli) Cc: rgm@gnu.org, 28732@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.151975990025798 (code B ref 28732); Tue, 27 Feb 2018 19:32:02 +0000 Received: (at 28732) by debbugs.gnu.org; 27 Feb 2018 19:31:40 +0000 Received: from localhost ([127.0.0.1]:35975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqkyS-0006i1-3b for submit@debbugs.gnu.org; Tue, 27 Feb 2018 14:31:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqkyP-0006ho-RA for 28732@debbugs.gnu.org; Tue, 27 Feb 2018 14:31:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqkyH-0003st-Hi for 28732@debbugs.gnu.org; Tue, 27 Feb 2018 14:31:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqkyH-0003sp-FE; Tue, 27 Feb 2018 14:31:29 -0500 Received: from [176.228.60.248] (port=2600 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eqkyG-0007lU-NJ; Tue, 27 Feb 2018 14:31:29 -0500 Date: Tue, 27 Feb 2018 21:31:33 +0200 Message-Id: <83woyyz0tm.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (charles@aurox.ch) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Tue, 27 Feb 2018 20:28:42 +0100 > From: charles@aurox.ch (Charles A. Roelli) > Cc: 28732@debbugs.gnu.org > > Thanks. Is the following change (ignoring whitespace differences) > good for emacs-26? > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 58bad8f..d58c5943 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -1078,7 +1078,9 @@ > face ,face > mouse-face mode-line-highlight > keymap > - ,(let ((map (make-sparse-keymap)) > + ,(when (and (boundp 'mouse-wheel-down-event) > + (boundp 'mouse-wheel-up-event)) > + (let ((map (make-sparse-keymap)) Is there any reason you cannot simply require mwheel in flymake? Or does loading mwheel in a --without-x build fail? From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Feb 2018 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: rgm@gnu.org, 28732@debbugs.gnu.org Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.151984396029746 (code B ref 28732); Wed, 28 Feb 2018 18:53:02 +0000 Received: (at 28732) by debbugs.gnu.org; 28 Feb 2018 18:52:40 +0000 Received: from localhost ([127.0.0.1]:37829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1er6qG-0007jg-2I for submit@debbugs.gnu.org; Wed, 28 Feb 2018 13:52:40 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:51253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1er6qE-0007jQ-Or for 28732@debbugs.gnu.org; Wed, 28 Feb 2018 13:52:39 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id CE519226B1 for <28732@debbugs.gnu.org>; Wed, 28 Feb 2018 18:53:01 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1519843940; x=1520707941; bh=TEkHPTPvQ7TnA fgcsrhVBCvnw8/kwW189FIK1AS/G3Y=; b=a9CRdQQHmkDuJeZsrSjLp/o6jR3yK qTUy1J0sK3PCW5VBr11U4lgsEwR2JNuk3TuAx5DLfzhXFJgnaEYop8Ktk//8TLgs eFybZZeir1F9bwuuqk/+iSNtWQieGEpjtFw1n0OjdVKE8+SDSfaKZ/MIi2/5wW82 BU2kueiQyOj5lk= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CbMCOubrCB22 for <28732@debbugs.gnu.org>; Wed, 28 Feb 2018 18:52:20 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 1708222688; Wed, 28 Feb 2018 18:52:19 +0000 (UTC) Date: Wed, 28 Feb 2018 20:02:22 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) In-reply-to: <83woyyz0tm.fsf@gnu.org> (message from Eli Zaretskii on Tue, 27 Feb 2018 21:31:33 +0200) References: <83woyyz0tm.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Date: Tue, 27 Feb 2018 21:31:33 +0200 > From: Eli Zaretskii > > > Date: Tue, 27 Feb 2018 20:28:42 +0100 > > From: charles@aurox.ch (Charles A. Roelli) > > Cc: 28732@debbugs.gnu.org > > > > Thanks. Is the following change (ignoring whitespace differences) > > good for emacs-26? > > > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > > index 58bad8f..d58c5943 100644 > > --- a/lisp/progmodes/flymake.el > > +++ b/lisp/progmodes/flymake.el > > @@ -1078,7 +1078,9 @@ > > face ,face > > mouse-face mode-line-highlight > > keymap > > - ,(let ((map (make-sparse-keymap)) > > + ,(when (and (boundp 'mouse-wheel-down-event) > > + (boundp 'mouse-wheel-up-event)) > > + (let ((map (make-sparse-keymap)) > > Is there any reason you cannot simply require mwheel in flymake? Or > does loading mwheel in a --without-x build fail? Good point. Can someone with a "--without-x" build handy check that? "mwheel.elc" is in src/lisp.mk, so it confuses me that it would not be immediately available. From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Feb 2018 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: charles@aurox.ch (Charles A. Roelli) Cc: rgm@gnu.org, 28732@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.151984997421468 (code B ref 28732); Wed, 28 Feb 2018 20:33:02 +0000 Received: (at 28732) by debbugs.gnu.org; 28 Feb 2018 20:32:54 +0000 Received: from localhost ([127.0.0.1]:37893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1er8PD-0005aB-QE for submit@debbugs.gnu.org; Wed, 28 Feb 2018 15:32:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1er8PA-0005Zw-LO for 28732@debbugs.gnu.org; Wed, 28 Feb 2018 15:32:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er8P2-0001mb-8h for 28732@debbugs.gnu.org; Wed, 28 Feb 2018 15:32:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er8P2-0001mV-4p; Wed, 28 Feb 2018 15:32:40 -0500 Received: from [176.228.60.248] (port=3814 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1er8P1-0004cF-9O; Wed, 28 Feb 2018 15:32:39 -0500 Date: Wed, 28 Feb 2018 22:32:48 +0200 Message-Id: <83y3jcyhvz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (charles@aurox.ch) References: <83woyyz0tm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Wed, 28 Feb 2018 20:02:22 +0100 > From: charles@aurox.ch (Charles A. Roelli) > CC: rgm@gnu.org, 28732@debbugs.gnu.org > > "mwheel.elc" is in src/lisp.mk, so it confuses me that it would not be > immediately available. You will see in loadup.el that it is not preloaded in --without-x builds. From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Mar 2018 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: rgm@gnu.org, 28732@debbugs.gnu.org Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.151993277714914 (code B ref 28732); Thu, 01 Mar 2018 19:33:01 +0000 Received: (at 28732) by debbugs.gnu.org; 1 Mar 2018 19:32:57 +0000 Received: from localhost ([127.0.0.1]:39741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erTwn-0003sU-1K for submit@debbugs.gnu.org; Thu, 01 Mar 2018 14:32:57 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:51759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erTwk-0003sB-J2 for 28732@debbugs.gnu.org; Thu, 01 Mar 2018 14:32:55 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 9F6D9226B3 for <28732@debbugs.gnu.org>; Thu, 1 Mar 2018 19:33:18 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1519932797; x=1520796798; bh=z46V4+YDcMyKM 7N0Ug590wWBQBCweB6PIIPnHZEIFAI=; b=qBqFS2fiyzLwOfdmfi6YfAYHlQBhC XLRX2YsxG1dz2T0OlfyZzAkTWj5f8vElMp/D3+P8klfHamcFWBk/jIlNEAXF3nVy LlL0ogJ5ZgLTC7u9FRleP3sCaboedKh4lUpTawrzWDRHkeyuNuQ0qBpXNEf/+IPY QyDG02G3Yb8Ixc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id iv1sYCx5O7fi for <28732@debbugs.gnu.org>; Thu, 1 Mar 2018 19:33:17 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id BA3EE22688; Thu, 1 Mar 2018 19:33:16 +0000 (UTC) Date: Thu, 01 Mar 2018 20:43:20 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) In-reply-to: <83y3jcyhvz.fsf@gnu.org> (message from Eli Zaretskii on Wed, 28 Feb 2018 22:32:48 +0200) References: <83woyyz0tm.fsf@gnu.org> <83y3jcyhvz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > "mwheel.elc" is in src/lisp.mk, so it confuses me that it would not be > > immediately available. > > You will see in loadup.el that it is not preloaded in --without-x > builds. Thanks. As you suggested, explicitly requiring `mwheel' is probably the best solution then. From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Mar 2018 02:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: charles@aurox.ch (Charles A. Roelli) Cc: rgm@gnu.org, Eli Zaretskii , 28732@debbugs.gnu.org Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.15199566607039 (code B ref 28732); Fri, 02 Mar 2018 02:11:01 +0000 Received: (at 28732) by debbugs.gnu.org; 2 Mar 2018 02:11:00 +0000 Received: from localhost ([127.0.0.1]:39923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1era9z-0001pT-PJ for submit@debbugs.gnu.org; Thu, 01 Mar 2018 21:10:59 -0500 Received: from mail-io0-f178.google.com ([209.85.223.178]:43557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1era9y-0001pF-3X for 28732@debbugs.gnu.org; Thu, 01 Mar 2018 21:10:58 -0500 Received: by mail-io0-f178.google.com with SMTP id l12so9288130ioc.10 for <28732@debbugs.gnu.org>; Thu, 01 Mar 2018 18:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8sgpc0ywfs8VQiGluvq2O5L/SrqKo2eTZBwQRGqImOw=; b=Yzz3tXoc1uFANfz0xA458f1osagin/9qoW2n+utxbAZBYYZPRcfAicMyezpWMZyok0 uu9E6cOZBE3pY5F0yRKBZgXw2NbleGD80KocugprZaC1Kt9tcu0QesAQy39UvA6wsCUE MJFOuruMkx2JmS7TQlCkm7TFiJ+oUlXJmuVkwYH3fcxgGnzQGh/DnesJONA7y/ohGv3N f/4mRMxiNctnJiY37iCtPQB1esLmsh/L9OnfzaiQOSEzrFlhv2Jt9Zg0w2Qwh4/Z0Nc9 363/TATZLBcvKC63J+ECoJuCWfe97IuAgBUL/Ub0c6kVKxlC7mVbzZmRnnQzcssgg4rv QwMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8sgpc0ywfs8VQiGluvq2O5L/SrqKo2eTZBwQRGqImOw=; b=lanZPXJvyDaOGrogPzS2oBqtyIukfLJCfkPmdEfjJfHvCM2SyvpbeKmE/RoI3OKhdi spRnArYoe3YyZrmC7NtIDQCaIyv1BxXsfAsXdJr9pDAStCod9hYKAT7X47oRHj4l4zzY XOhc3XYmJg7ReZ3qC+GyZPUscD7fSd2PwvWQOR/Rjvza+5JTKVb/XD/FWJfUimBaSYZU ZxIx6/9b0TUsAvI57vE8FE2or5znMETCJOyCoOm/FO1hhQDKRJfVREh5U+9h9Oij/vi/ 8hvardwqKO0hhK1HQBCLr05N0YiRxTS6PxzrXk1gIrRchfcpKrwnvqBaSWqeB+QklXqO 2J+g== X-Gm-Message-State: APf1xPAJj+otIumSk3Z5PQna6dVT8xRC0xNlHKRjcFvL4mkhLcVfA3Jg fFrDL0fYK+7XjJ65iSINaHydRw== X-Google-Smtp-Source: AG47ELvVBw4zxKiFRzx0w1GddryAG3enSFpejUEdtM6A1RHfGNWo+WNmeg9jKVP7axjwQLPONklRcA== X-Received: by 10.107.153.79 with SMTP id b76mr4643791ioe.192.1519956652117; Thu, 01 Mar 2018 18:10:52 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d184sm312439ite.4.2018.03.01.18.10.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Mar 2018 18:10:51 -0800 (PST) From: Noam Postavsky References: <83woyyz0tm.fsf@gnu.org> Date: Thu, 01 Mar 2018 21:10:50 -0500 In-Reply-To: (Charles A. Roelli's message of "Wed, 28 Feb 2018 20:02:22 +0100") Message-ID: <87h8pz447p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) charles@aurox.ch (Charles A. Roelli) writes: >> Is there any reason you cannot simply require mwheel in flymake? Or >> does loading mwheel in a --without-x build fail? > > Good point. Can someone with a "--without-x" build handy check that? > "mwheel.elc" is in src/lisp.mk, so it confuses me that it would not be > immediately available. mwheel loads without errors for me in a --without-x build. From unknown Fri Aug 15 16:58:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#28732: flymake mouse-wheel portability fix Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Mar 2018 10:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: rgm@gnu.org, charles@aurox.ch, 28732@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 28732-submit@debbugs.gnu.org id=B28732.152007378316729 (code B ref 28732); Sat, 03 Mar 2018 10:44:02 +0000 Received: (at 28732) by debbugs.gnu.org; 3 Mar 2018 10:43:03 +0000 Received: from localhost ([127.0.0.1]:41817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1es4d5-0004Ll-I7 for submit@debbugs.gnu.org; Sat, 03 Mar 2018 05:43:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1es4d0-0004LC-PC for 28732@debbugs.gnu.org; Sat, 03 Mar 2018 05:43:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1es4cq-0003SI-Rc for 28732@debbugs.gnu.org; Sat, 03 Mar 2018 05:42:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1es4cq-0003S0-NZ; Sat, 03 Mar 2018 05:42:48 -0500 Received: from [176.228.60.248] (port=4514 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1es4cp-0007mP-S6; Sat, 03 Mar 2018 05:42:48 -0500 Date: Sat, 03 Mar 2018 12:43:02 +0200 Message-Id: <83bmg5v3rd.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87h8pz447p.fsf@gmail.com> (message from Noam Postavsky on Thu, 01 Mar 2018 21:10:50 -0500) References: <83woyyz0tm.fsf@gnu.org> <87h8pz447p.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: Eli Zaretskii , rgm@gnu.org, 28732@debbugs.gnu.org > Date: Thu, 01 Mar 2018 21:10:50 -0500 > > charles@aurox.ch (Charles A. Roelli) writes: > > >> Is there any reason you cannot simply require mwheel in flymake? Or > >> does loading mwheel in a --without-x build fail? > > > > Good point. Can someone with a "--without-x" build handy check that? > > "mwheel.elc" is in src/lisp.mk, so it confuses me that it would not be > > immediately available. > > mwheel loads without errors for me in a --without-x build. Thanks, I pushed the required change.