GNU bug report logs - #28723
Add HDF-Java. [PATCH 1/2] gnu: Add java-slf4-simple.

Previous Next

Package: guix-patches;

Reported by: Thomas Danckaert <post <at> thomasdanckaert.be>

Date: Fri, 6 Oct 2017 16:11:02 UTC

Severity: normal

Tags: patch

Done: Thomas Danckaert <post <at> thomasdanckaert.be>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 28723 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: leo <at> famulari.name
Cc: 28723 <at> debbugs.gnu.org
Subject: Re: [bug#28723] [PATCH 2/2] gnu: Add hdf-java.
Date: Tue, 10 Oct 2017 08:48:42 +0200 (CEST)

From: Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#28723] [PATCH 2/2] gnu: Add hdf-java.
Date: Mon, 9 Oct 2017 15:27:02 -0400

>> +        (add-before 'check 'build-examples
>> +          (lambda _
>> +            (apply system* `("javac"
>> +                             ,@(find-files "examples" ".*\\.java")))
>> +            #t)))
> 
> Do we have to explicity return #t here? Does the javac call not return
> a value that we can pass to (zero? ...)?

Yes, I'm pretty sure this can be improved.  Good catch!

Thanks for taking a look.

Thomas
This bug report was last modified 7 years and 318 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.