GNU bug report logs - #28718
[PATCH] gnu: qemu: Add sysconfdir to configure-flags.

Previous Next

Full log

Message #23 received at 28718 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28718 <at> debbugs.gnu.org
Subject: Re: [bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.
Date: Mon, 09 Oct 2017 14:24:42 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

ludo <at> gnu.org (Ludovic Courtès) writes:

[...]

>>>> I've used this patch to run a QEMU VM with bridge interface.
>>>>
>>>> $ mkdir -p /tmp/etc/qemu
>>>> $ echo 'allow bridge0' | tee -a /tmp/etc/qemu/bridge.conf
>>>> # ip link add bridge0 type bridge
>>>> # ip link set dev enp6s0 master bridge0
>>>> # ip link up bridge0
>>>> # dhclient bridge0
>>>> # qemu-system-x86_64 -net nic -net bridge,br=bridge0 # …
>>>
>>> It feels wrong to me to default to /tmp/etc instead of /etc.
>>>
>>> Setting up a bridge requires root privileges anyway, so why not stick to
>>> /etc instead of /tmp/etc?
>>
>> It's inspired by libvirt package recipe :-)
>
> Looking at commit a4b9392151 for libvirt, I think it’s a trick here: we
> do pass --sysconfdir=/etc, and sysconfdir=/tmp/etc is passed only during
> the install phase, which I think is a trick to avoid errors while
> creating $(sysconfdir).  But /etc is the actual sysconfdir AIUI.
>
> So, WDYT?  :-)

Thank you for investigation.  I saw no reason not to use file-system
convention at the beginning of discussion.  Here is an another patch.
Build finished successfully for me.

[0001-gnu-qemu-Add-sysconfdir-to-configure-flags.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.