From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 15:48:59 2017 Received: (at submit) by debbugs.gnu.org; 4 Oct 2017 19:48:59 +0000 Received: from localhost ([127.0.0.1]:49240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpf8-0004nq-TZ for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:48:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpf6-0004nc-Vf for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:48:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzpf0-0003bK-SU for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:48:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzpf0-0003b6-Oo for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:48:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzpez-0004Zf-Ia for guix-patches@gnu.org; Wed, 04 Oct 2017 15:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzpey-0003aH-KR for guix-patches@gnu.org; Wed, 04 Oct 2017 15:48:49 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzpev-0003Yy-Mv; Wed, 04 Oct 2017 15:48:45 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=42752 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzpeu-0000Zn-IP; Wed, 04 Oct 2017 15:48:45 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/3] Detect wrong UUIDs/labels in 'guix system init/reconfigure' Date: Wed, 4 Oct 2017 21:48:31 +0200 Message-Id: <20171004194831.4524-1-ludo@gnu.org> X-Mailer: git-send-email 2.14.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello Guix! At the GHM we were discussing that a common mistake when installing GuixSD is to specify a wrong file system UUID or label in the config. You would run the whole install to completion, reboot into the new system, just to find that it fails to boot because you passed the wrong UUID or label. And then you have to reinstall again. Roel’s report at is another instance of that (though Roel could easily roll back in that case.) With this patch such mistakes are detected early on, upon ‘guix system init’ or ‘guix system reconfigure’: configuration.scm:32:23: error: file system with UUID 'c78e0703-373f-4c4d-9652-5633f072eae6' not found configuration.scm:42:23: error: file system with UUID '1234-ABCD' not found The behavior is to stop altogether when such a problem is found. I wondered whether it should be a warning instead, on the grounds that it could be annoying if the mistake-prevention logic wrongfully raised an error for some reason. However, I figured that a warning would be much less efficient (people wouldn’t notice), and I think ‘check-file-system-availability’ avoids the obvious pitfalls by filtering out irrelevant file systems. Thoughts? Thanks, Ludo’. Ludovic Courtès (3): uuid: Add 'uuid=?' and use it. file-systems: Add a 'location' field to . guix system: Error out when passed a wrong file system UUID/label. gnu/build/file-systems.scm | 4 +-- gnu/system/file-systems.scm | 6 ++++- gnu/system/uuid.scm | 13 +++++++++ guix/scripts/system.scm | 65 +++++++++++++++++++++++++++++++++++++++++++++ tests/uuid.scm | 6 +++++ 5 files changed, 91 insertions(+), 3 deletions(-) -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 15:52:16 2017 Received: (at 28706) by debbugs.gnu.org; 4 Oct 2017 19:52:16 +0000 Received: from localhost ([127.0.0.1]:49250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpiK-0004uA-Ji for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpiJ-0004tr-8f for 28706@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzpiD-0006pG-DT for 28706@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzpiB-0006mK-60; Wed, 04 Oct 2017 15:52:07 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=42834 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzpiA-0000qB-Mw; Wed, 04 Oct 2017 15:52:07 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 28706@debbugs.gnu.org Subject: [PATCH 1/3] =?UTF-8?q?uuid:=20Add=20'uuid=3D=3F'=20and=20use=20it?= =?UTF-8?q?.?= Date: Wed, 4 Oct 2017 21:51:43 +0200 Message-Id: <20171004195145.4743-1-ludo@gnu.org> X-Mailer: git-send-email 2.14.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28706 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/system/uuid.scm (uuid=?): New procedure. * tests/uuid.scm ("uuid=?"): New test. * gnu/build/file-systems.scm (partition-uuid-predicate) (luks-partition-uuid-predicate): Use it instead of 'bytevector=?'. --- gnu/build/file-systems.scm | 4 ++-- gnu/system/uuid.scm | 13 +++++++++++++ tests/uuid.scm | 6 ++++++ 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 32885f1d2..140bcb414 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -415,12 +415,12 @@ was READ is = to the given value." (partition-predicate read-partition-label string=?)) (define partition-uuid-predicate - (partition-predicate read-partition-uuid bytevector=?)) + (partition-predicate read-partition-uuid uuid=?)) (define luks-partition-uuid-predicate (partition-predicate (partition-field-reader read-luks-header luks-header-uuid) - bytevector=?)) + uuid=?)) (define (find-partition predicate) "Return the first partition found that matches PREDICATE, or #f if none diff --git a/gnu/system/uuid.scm b/gnu/system/uuid.scm index 6470abb8c..e422e06a6 100644 --- a/gnu/system/uuid.scm +++ b/gnu/system/uuid.scm @@ -29,6 +29,7 @@ uuid? uuid-type uuid-bytevector + uuid=? bytevector->uuid @@ -281,3 +282,15 @@ corresponding bytevector; otherwise return #f." ((_ . (? procedure? unparse)) (unparse bv)))) (((? uuid? uuid)) (uuid->string (uuid-bytevector uuid) (uuid-type uuid))))) + +(define uuid=? + ;; Return true if A is equal to B, comparing only the actual bits. + (match-lambda* + (((? bytevector? a) (? bytevector? b)) + (bytevector=? a b)) + (((? uuid? a) (? bytevector? b)) + (bytevector=? (uuid-bytevector a) b)) + (((? uuid? a) (? uuid? b)) + (bytevector=? (uuid-bytevector a) (uuid-bytevector b))) + ((a b) + (uuid=? b a)))) diff --git a/tests/uuid.scm b/tests/uuid.scm index aacce7723..68676f775 100644 --- a/tests/uuid.scm +++ b/tests/uuid.scm @@ -57,4 +57,10 @@ "1234-ABCD" (uuid->string (uuid "1234-abcd" 'fat32))) +(test-equal "uuid=?" + (and (uuid=? (uuid-bytevector (uuid "1234-abcd" 'fat32)) + (uuid "1234-abcd" 'fat32)) + (uuid=? (uuid "1234-abcd" 'fat32) + (uuid "1234-abcd" 'fat)))) + (test-end) -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 15:52:17 2017 Received: (at 28706) by debbugs.gnu.org; 4 Oct 2017 19:52:17 +0000 Received: from localhost ([127.0.0.1]:49252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpiK-0004uG-SQ for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpiK-0004ts-11 for 28706@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzpiE-0006pu-6M for 28706@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzpiC-0006ns-5x; Wed, 04 Oct 2017 15:52:08 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=42834 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzpiB-0000qB-Kk; Wed, 04 Oct 2017 15:52:08 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 28706@debbugs.gnu.org Subject: [PATCH 2/3] file-systems: Add a 'location' field to . Date: Wed, 4 Oct 2017 21:51:44 +0200 Message-Id: <20171004195145.4743-2-ludo@gnu.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171004195145.4743-1-ludo@gnu.org> References: <20171004195145.4743-1-ludo@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28706 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/system/file-systems.scm ()[location]: New field. --- gnu/system/file-systems.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 52f16676f..92f040425 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -38,6 +38,7 @@ file-system-check? file-system-create-mount-point? file-system-dependencies + file-system-location file-system-type-predicate @@ -101,7 +102,10 @@ (create-mount-point? file-system-create-mount-point? ; Boolean (default #f)) (dependencies file-system-dependencies ; list of - (default '()))) ; or + (default '())) ; or + (location file-system-location + (default (current-source-location)) + (innate))) ;; Note: This module is used both on the build side and on the host side. ;; Arrange not to pull (guix store) and (guix config) because the latter -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 15:52:20 2017 Received: (at 28706) by debbugs.gnu.org; 4 Oct 2017 19:52:20 +0000 Received: from localhost ([127.0.0.1]:49255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpiO-0004uZ-3C for submit@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzpiL-0004tv-Fe for 28706@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzpiF-0006r4-IF for 28706@debbugs.gnu.org; Wed, 04 Oct 2017 15:52:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzpiD-0006p1-77; Wed, 04 Oct 2017 15:52:09 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=42834 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzpiC-0000qB-LS; Wed, 04 Oct 2017 15:52:09 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 28706@debbugs.gnu.org Subject: [PATCH 3/3] guix system: Error out when passed a wrong file system UUID/label. Date: Wed, 4 Oct 2017 21:51:45 +0200 Message-Id: <20171004195145.4743-3-ludo@gnu.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171004195145.4743-1-ludo@gnu.org> References: <20171004195145.4743-1-ludo@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28706 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * guix/scripts/system.scm (check-file-system-availability): New procedure. (perform-action): Use it. --- guix/scripts/system.scm | 65 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 567d8bb64..e50f1d8ac 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -37,6 +37,8 @@ #:use-module (guix scripts graph) #:use-module (guix build utils) #:use-module (gnu build install) + #:autoload (gnu build file-systems) + (find-partition-by-label find-partition-by-uuid) #:use-module (gnu system) #:use-module (gnu bootloader) #:use-module (gnu system file-systems) @@ -404,6 +406,7 @@ NUMBERS, which is a list of generation numbers." "Roll back the system profile to its previous generation. STORE is an open connection to the store." (switch-to-system-generation store "-1")) + ;;; ;;; Switch generations. @@ -555,6 +558,61 @@ PATTERN, a string. When PATTERN is #f, display all the system generations." (leave (G_ "invalid syntax: ~a~%") pattern)))) +;;; +;;; File system declaration checks. +;;; + +(define (check-file-system-availability file-systems) + "Check whether the UUIDs or partition labels that FILE-SYSTEMS refer to, if +any, are available. Raise an error if they're not." + (define relevant + (filter (lambda (fs) + (and (file-system-mount? fs) + (not (string=? "tmpfs" (file-system-type fs))) + (not (memq 'bind-mount (file-system-flags fs))))) + file-systems)) + + (define labeled + (filter (lambda (fs) + (eq? (file-system-title fs) 'label)) + relevant)) + + (define uuid + (filter (lambda (fs) + (eq? (file-system-title fs) 'uuid)) + relevant)) + + (define fail? #f) + + (define (file-system-location* fs) + (location->string + (source-properties->location + (file-system-location fs)))) + + (let-syntax ((error (syntax-rules () + ((_ args ...) + (begin + (set! fail? #t) + (format (current-error-port) + args ...)))))) + (for-each (lambda (fs) + (unless (find-partition-by-label (file-system-device fs)) + (error (G_ "~a: error: file system with label '~a' not found~%") + (file-system-location* fs) + (file-system-device fs)))) + labeled) + (for-each (lambda (fs) + (unless (find-partition-by-uuid (file-system-device fs)) + (error (G_ "~a: error: file system with UUID '~a' not found~%") + (file-system-location* fs) + (uuid->string (file-system-device fs))))) + uuid) + + (when fail? + ;; Better be safe than sorry. + (exit 1)))) + + ;;; ;;; Action. ;;; @@ -637,6 +695,13 @@ output when building a system derivation, such as a disk image." (when (eq? action 'reconfigure) (maybe-suggest-running-guix-pull)) + ;; Check whether the declared file systems exist. This is better than + ;; instantiating a broken configuration. Assume that we can only check if + ;; running as root. + (when (and (memq action '(init reconfigure)) + (zero? (getuid))) + (check-file-system-availability (operating-system-file-systems os))) + (mlet* %store-monad ((sys (system-derivation-for-action os action #:file-system-type file-system-type -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 02:11:09 2017 Received: (at 28706) by debbugs.gnu.org; 5 Oct 2017 06:11:09 +0000 Received: from localhost ([127.0.0.1]:49609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzzND-0003Up-Fa for submit@debbugs.gnu.org; Thu, 05 Oct 2017 02:11:09 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:46822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzzNC-0003Ue-5h for 28706@debbugs.gnu.org; Thu, 05 Oct 2017 02:11:06 -0400 Received: from localhost (77.118.177.146.wireless.dyn.drei.com [77.118.177.146]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 1FF891CA020C; Thu, 5 Oct 2017 08:11:04 +0200 (CEST) Date: Thu, 5 Oct 2017 08:11:02 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#28706] [PATCH 1/3] uuid: Add 'uuid=?' and use it. Message-ID: <20171005081102.02f49b68@scratchpost.org> In-Reply-To: <20171004195145.4743-1-ludo@gnu.org> References: <20171004194831.4524-1-ludo@gnu.org> <20171004195145.4743-1-ludo@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28706 Cc: 28706@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 02:11:29 2017 Received: (at 28706) by debbugs.gnu.org; 5 Oct 2017 06:11:29 +0000 Received: from localhost ([127.0.0.1]:49612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzzNZ-0003VR-FK for submit@debbugs.gnu.org; Thu, 05 Oct 2017 02:11:29 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:46858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzzNY-0003VK-9T for 28706@debbugs.gnu.org; Thu, 05 Oct 2017 02:11:28 -0400 Received: from localhost (77.118.177.146.wireless.dyn.drei.com [77.118.177.146]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 520231CA020C; Thu, 5 Oct 2017 08:11:27 +0200 (CEST) Date: Thu, 5 Oct 2017 08:11:23 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#28706] [PATCH 2/3] file-systems: Add a 'location' field to . Message-ID: <20171005081123.10bfa611@scratchpost.org> In-Reply-To: <20171004195145.4743-2-ludo@gnu.org> References: <20171004195145.4743-1-ludo@gnu.org> <20171004195145.4743-2-ludo@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28706 Cc: 28706@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 02:12:24 2017 Received: (at 28706) by debbugs.gnu.org; 5 Oct 2017 06:12:25 +0000 Received: from localhost ([127.0.0.1]:49617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzzOS-0003X8-MB for submit@debbugs.gnu.org; Thu, 05 Oct 2017 02:12:24 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:46958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzzOR-0003X1-KR for 28706@debbugs.gnu.org; Thu, 05 Oct 2017 02:12:23 -0400 Received: from localhost (77.118.177.146.wireless.dyn.drei.com [77.118.177.146]) by dd1012.kasserver.com (Postfix) with ESMTPSA id AF0A71CA020C; Thu, 5 Oct 2017 08:12:22 +0200 (CEST) Date: Thu, 5 Oct 2017 08:12:18 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#28706] [PATCH 3/3] guix system: Error out when passed a wrong file system UUID/label. Message-ID: <20171005081218.1bc3d9b7@scratchpost.org> In-Reply-To: <20171004195145.4743-3-ludo@gnu.org> References: <20171004195145.4743-1-ludo@gnu.org> <20171004195145.4743-3-ludo@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28706 Cc: 28706@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 06:12:29 2017 Received: (at 28706-done) by debbugs.gnu.org; 5 Oct 2017 10:12:29 +0000 Received: from localhost ([127.0.0.1]:49766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e038n-0000wf-Eo for submit@debbugs.gnu.org; Thu, 05 Oct 2017 06:12:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e038l-0000wL-AM for 28706-done@debbugs.gnu.org; Thu, 05 Oct 2017 06:12:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e038a-0007Jf-MN for 28706-done@debbugs.gnu.org; Thu, 05 Oct 2017 06:12:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e038a-0007Jb-Ii; Thu, 05 Oct 2017 06:12:16 -0400 Received: from [193.50.110.164] (port=47036 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e038a-000159-0r; Thu, 05 Oct 2017 06:12:16 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#28706] [PATCH 3/3] guix system: Error out when passed a wrong file system UUID/label. References: <20171004195145.4743-1-ludo@gnu.org> <20171004195145.4743-3-ludo@gnu.org> <20171005081218.1bc3d9b7@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 05 Oct 2017 12:12:14 +0200 In-Reply-To: <20171005081218.1bc3d9b7@scratchpost.org> (Danny Milosavljevic's message of "Thu, 5 Oct 2017 08:12:18 +0200") Message-ID: <87bmll9a4h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28706-done Cc: 28706-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > LGTM! Thanks for checking. Pushed as 9d80d0e95c9eab042ddd8250ad9a231ed0c458dc. Note that the change breaks the ABI, so =E2=80=9Cmake clean-g= o=E2=80=9D is needed! Ludo=E2=80=99. From unknown Wed Jun 25 09:10:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Nov 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator