From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 12:25:31 2017 Received: (at submit) by debbugs.gnu.org; 4 Oct 2017 16:25:32 +0000 Received: from localhost ([127.0.0.1]:49113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzmUF-0006Ob-IH for submit@debbugs.gnu.org; Wed, 04 Oct 2017 12:25:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzmKL-000695-JW for submit@debbugs.gnu.org; Wed, 04 Oct 2017 12:15:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzmK9-0002BO-2f for submit@debbugs.gnu.org; Wed, 04 Oct 2017 12:15:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36512) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzmK8-0002BK-Vl for submit@debbugs.gnu.org; Wed, 04 Oct 2017 12:15:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzmK6-00032R-HZ for bug-gnu-emacs@gnu.org; Wed, 04 Oct 2017 12:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzmK3-00027E-7i for bug-gnu-emacs@gnu.org; Wed, 04 Oct 2017 12:15:02 -0400 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]:56114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzmK3-00026u-0E for bug-gnu-emacs@gnu.org; Wed, 04 Oct 2017 12:14:59 -0400 Received: by mail-it0-x230.google.com with SMTP id p185so5803680itc.4 for ; Wed, 04 Oct 2017 09:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=radix-trading-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=BddbxXrRxE2JcGK8sC0Bofp9NI00PRGOZQ/T0COj1oo=; b=y8Fp5n32+UQTZ6QL90PW7m/p0b2PY05L6zYqIVuQU+FbC80PAO5rHF72aKoeWhOk38 /+TGoxm6c2wAljucyzSMtXUU34UXSGmxExAASPYoADQ8f+0X6ckLw1RaOFMp0YvGzbWq DjXFbNxzgeF2EgdZpDkdDTIsQeINlh1LgmkxvpPC/SC0BizkYZS7w9aHgEXTwznP3j9b NAJoGYaG3YqWiGsXFUE7/l2Oj2CVl1r2kjHlCXj+a3XwsC7Ifi1BE/QJ3AMDC0s7Eskb y5yRQ3A+QWQRELV+5NMdfwJTzdLrXRSgyAs2GFkvTY1DRXhaTdpct5AP7Xu8mXWzIGbr XkGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=BddbxXrRxE2JcGK8sC0Bofp9NI00PRGOZQ/T0COj1oo=; b=FLnV6mcEgkKKGRUvCiHsA+v4nIlRCQtfgGXFeMWMa40s2wzBXDXpj90LHtRC7L49Up S5eHMpibK306dyBqFq7S4HtdglWeora5OazHxhKPbzaHcEeRhjOzA5DFRyCkBMmiW6um HoJ8l6heO1z17qoXgUyZ8ejLwIImHrJIhM+RS2+bU7SsssiIRUo0puq9oRHLGZmxQBPr jn0UZWqtC406UkbQDX4aHNoxS0tNCqbsioxSkLcv5/9ZDNfU9ujZHpKvvXzXKARR4HwA VgF8yGB2B/PbI8ReR+3QvylayqyhbyKNJy6pVG04eP6kfutzCe1gURsUICR3fES7iidd J5VA== X-Gm-Message-State: AHPjjUjTh+kY+IvTzULH+0/kKz+R2Rc5F5QBpZtyBrGUWUQTVvX6SLX/ s7zgngXYypqGxmUTDWZU7xwSGxlG X-Google-Smtp-Source: AOwi7QC5jizhwuZbxJwF+BBADuAMwCggC67BJDIaTB7BYNw/YJjomhwHswURtPnLGCc+dy4rK3JaEA== X-Received: by 10.36.83.20 with SMTP id n20mr31487161itb.120.1507133697628; Wed, 04 Oct 2017 09:14:57 -0700 (PDT) Received: from rdx-ws-030 ([38.104.242.198]) by smtp.gmail.com with ESMTPSA id b190sm7346244ioe.1.2017.10.04.09.14.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Oct 2017 09:14:56 -0700 (PDT) From: Joseph Garvin To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Sorting packages list slow when using display-line-numbers-type visual Date: Wed, 04 Oct 2017 11:14:56 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 04 Oct 2017 12:25:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Starting with emacs -Q: Evaluate this in the scratch buffer: ;; make the packages list long enough to notice (when (>= emacs-major-version 24) (require 'package) (package-initialize) (setq package-archives '(("gnu" . "https://elpa.gnu.org/packages/") ("marmalade" . "https://marmalade-repo.org/packages/") ("melpa-stable" . "http://stable.melpa.org/packages/") ("melpa" . "https://melpa.org/packages/"))) (when (not (package-installed-p 'use-package)) (package-refresh-contents) (package-install 'use-package))) ;; enable mode to cause the problem (when (>= emacs-major-version 26) (global-display-line-numbers-mode) (setq display-line-numbers-type 'visual)) Then run: M-x list-packages Then click on one of the column headers to trigger sorting by that column, e.g. Status. Emacs will freeze for a couple of minutes. Profiler reveals: - command-execute 25144 98% - call-interactively 25144 98% - funcall-interactively 25144 98% - tabulated-list-col-sort 24960 97% - tabulated-list--sort-by-column-name 24960 97% - tabulated-list-print 24956 97% - apply 24916 97% - tabulated-list-print-entry 24903 97% - tabulated-list-line-number-width 24736 96% # 2 0% So it looks like all of the time is spent inside tabulated-list-line-number-width. In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.14.13) of 2017-10-03 built on rdx-ws-030 Repository revision: 92045f4546b9708dc9f69954799d211c1f56ff1e Windowing system distributor 'The X.Org Foundation', version 11.0.11702000 System Description: CentOS Linux release 7.3.1611 (Core) Recent messages: No more unseen articles Mark set [4 times] Quit Type "q" in help window to restore its previous buffer, C-M-v to scroll help. nnimap read 0k from imap.gmail.com Saving file /home/jgarvin/.newsrc-dribble... Wrote /home/jgarvin/.newsrc-dribble [2 times] (Saved .newsrc-dribble) Making find-file-hook buffer-local while locally let-bound! Giving new frame mandimus cursor color. [3 times] Configured using: 'configure --prefix=/home/jgarvin/opt --with-x-toolkit=gtk3' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: recentf-mode: t global-subword-mode: t subword-mode: t drag-stuff-global-mode: t drag-stuff-mode: t winpoint-mode: t delete-selection-mode: t global-hl-line-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t helm-mode: t savehist-mode: t save-place-mode: t erc-services-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-mode: t global-undo-tree-mode: t undo-tree-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t projectile-global-mode: t projectile-mode: t diff-auto-refine-mode: t magit-auto-revert-mode: t global-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t helm-autoresize-mode: t override-global-mode: t cl-old-struct-compat-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t hs-minor-mode: t Load-path shadows: None found. Features: (shadow emacsbug helm-command helm-elisp helm-eval edebug eieio-opt speedbar sb-image ezimage dframe help-fns radix-tree qp shr-color rfc2104 cl-print debug mailalias smtpmail sendmail sort gnus-cite smiley mail-extr gnus-async gnus-bcklg nnir winner gnus-ml nndraft nnmh nnfolder utf-7 gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig nntp gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader time cc-mode-expansions cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs vc-git elec-pair cus-edit cus-start cus-load hexl rect md-belt-impl misc paren tramp-cache tramp-sh recentf tree-widget cap-words superword subword drag-stuff winpoint delsel hl-line cyberpunk-theme ...) Memory information: ((conses 16 808014 278796) (symbols 48 65569 8) (miscs 40 345 1483) (strings 32 196288 21363) (string-bytes 1 6314604) (vectors 16 106791) (vector-slots 8 2268095 150701) (floats 8 639 1928) (intervals 56 1103 789) (buffers 992 45) (heap 1024 96654 13947)) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 04:09:44 2017 Received: (at 28704) by debbugs.gnu.org; 5 Oct 2017 08:09:44 +0000 Received: from localhost ([127.0.0.1]:49656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e01E0-0006HE-9W for submit@debbugs.gnu.org; Thu, 05 Oct 2017 04:09:44 -0400 Received: from mout.gmx.net ([212.227.17.22]:58070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e01Dy-0006H0-4Y for 28704@debbugs.gnu.org; Thu, 05 Oct 2017 04:09:42 -0400 Received: from [192.168.1.100] ([212.95.7.239]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M1SLt-1dAvsH0BVR-00tQsd; Thu, 05 Oct 2017 10:09:36 +0200 Message-ID: <59D5E8B5.5030701@gmx.at> Date: Thu, 05 Oct 2017 10:09:25 +0200 From: martin rudalics MIME-Version: 1.0 To: Joseph Garvin , 28704@debbugs.gnu.org Subject: Re: bug#28704: 27.0.50; Sorting packages list slow when using display-line-numbers-type visual References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:B1s90+s+C3HMlwfrVmJhR7gnq0hX3oq0JXMePpjML7bTQI6doY0 jmw25cR77mc1PaYq3/ZfjtcyHbsD/EjkS/Jd7baxHF770rpqMWC3U1hnKRDrfemjw3/f6ST fv7TYfCO+XOMataGfxaVGr3PRhLYPH8UL00iIwc2IVFNOdL+NyIwPd3WAl8/yk5XYDfreP2 Q2gNS+wO8XllMr9N3Zruw== X-UI-Out-Filterresults: notjunk:1;V01:K0:WtiZY9OTn3s=:bnvJQJtwSGEM7lbxD5R7Cn SzVmyUV++CrztHa8QJosB4QdeIrxiUbgQCbVJx92FgMm8ypfNxKOMqXg+tl24WHvesGnw2wX7 nR/ILedPsGMD+wmNkUbLf6ra686FlARxCW3BLtzYW2PtftmEw4q1oy7AvfSSDNRLH5j8Mg4Rt DHnFRgEeMzv/HMBySgb4RUUhjRdnfnIX7PAaP+NHrdl8/QX/0GkSEoWcM+Yv8qpmJLB7iE+Ts hioWtZINeh2ttIEXuy0RXV90gcucylculTYOEajS+Ru31o+MIzQBMQpKO7K8Qd6XY0VutIM1k KuVtKkv15b6AejqXU6EZ8L8b4CicAhIsrUIPv/TCpjEGafTNqMq65zvKNJlf+XVAxUmetaB9y qInTR18++Fbg+aks1dS0YkAbqK23JOhgtXOK7+tWH7P+dmR+ucQPSUUIlamqaOFzEtBcO+T9p kkfYq8lhjtLkjd0Ocw1TD4UM1MW14nS8lxWnsdEmD1f01GbDXSSeOg2AT3MZvVwy9zuCEQopm 5cBc+QDcSYbznQB1gwXu07SB4wJWTkqBsOCsmagNm1JKEb2sc6McYp2j/5/EBEsMZTPUT/kcL rq4ywYO5EJPXG4NAfMWEnfSgC74tU65MzbOf20arhIWGaR+P4xW5lxDjibB3BkeXnWf2MqW03 pLR/xDgZzdIkZJwh/EJtyeAAq8y/3ogeQKOaRcj2b+YfEgGdO9CEmPObTaaBnba2ZIUpLz0pz bUsR9I8b/+bibxvH0tN0+Ig/ns3PWVNNs2qj002BQ/2BTDNLpoVaRAPqBNFLPoE6LdE3iiO2m WWDhV1TNpfjecJZs2UHaG3sPoHUBKfoLu1M8akqwsYm4zZMLndrGCWtZ6xUK+xu4IiG/2pM X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28704 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Then run: M-x list-packages > > Then click on one of the column headers to trigger sorting by that > column, e.g. Status. Emacs will freeze for a couple of minutes. > > Profiler reveals: > > - command-execute 25144 = 98% > - call-interactively 25144= 98% > - funcall-interactively 25144= 98% > - tabulated-list-col-sort 24960= 97% > - tabulated-list--sort-by-column-name 24960= 97% > - tabulated-list-print 24956= 97% > - apply 24916= 97% > - tabulated-list-print-entry 24903= 97% > - tabulated-list-line-number-width 24736= 96% > # 2= 0% > > So it looks like all of the time is spent inside tabulated-list-line-n= umber-width. =E2=80=98tabulated-list-print=E2=80=99 should calculate =E2=80=98line-num= ber-display-width=E2=80=99 once and =E2=80=98tabulated-list-line-number-width=E2=80=99 should use that va= lue. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 05:44:06 2017 Received: (at 28704-done) by debbugs.gnu.org; 5 Oct 2017 09:44:06 +0000 Received: from localhost ([127.0.0.1]:49743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e02hJ-0000Dj-V3 for submit@debbugs.gnu.org; Thu, 05 Oct 2017 05:44:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e02hI-0000Cb-Fq for 28704-done@debbugs.gnu.org; Thu, 05 Oct 2017 05:44:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e02hA-0000G7-5w for 28704-done@debbugs.gnu.org; Thu, 05 Oct 2017 05:43:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e02hA-0000Fz-2c; Thu, 05 Oct 2017 05:43:56 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2838 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e02h8-0007Hz-KH; Thu, 05 Oct 2017 05:43:55 -0400 Date: Thu, 05 Oct 2017 12:43:43 +0300 Message-Id: <837ewax73k.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <59D5E8B5.5030701@gmx.at> (message from martin rudalics on Thu, 05 Oct 2017 10:09:25 +0200) Subject: Re: bug#28704: 27.0.50; Sorting packages list slow when using display-line-numbers-type visual References: <59D5E8B5.5030701@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28704-done Cc: joe.garvin@radix-trading.com, 28704-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Thu, 05 Oct 2017 10:09:25 +0200 > From: martin rudalics > > ‘tabulated-list-print’ should calculate ‘line-number-display-width’ once > and ‘tabulated-list-line-number-width’ should use that value. Indeed, thanks. I've made a similar change on the release branch. From unknown Tue Jun 24 20:53:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Nov 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator