GNU bug report logs - #28693
[PATCH] gnu: Add missing input to python-py3status.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: bug#28693: closed (Re: [PATCH] gnu: Add missing input to
 python-py3status and fix call path.)
Date: Sun, 08 Oct 2017 11:06:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#28693: [PATCH] gnu: Add missing input to python-py3status.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 28693 <at> debbugs.gnu.org.

-- 
28693: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28693
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 28693-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add missing input to python-py3status and fix call
 path.
Date: Sun, 8 Oct 2017 13:05:32 +0200

[Message part 3 (text/plain, inline)]

On Fri, Oct 06, 2017 at 06:32:50AM +0000, Christopher Baines wrote:
>On Thu,  5 Oct 2017 23:24:39 +0200
>Tomáš Čech <sleep_walker <at> gnu.org> wrote:
>
>> * gnu/packages/python.scm (python-py3status)[inputs, arguments]: Add
>> missing file utility as input, adjust path used to call it.
>
>I would usually put the changelog last, as I think this is more
>consistent with other committers. Also, maybe this could be more
>specific like:
>
>    * gnu/packages/python.scm (python-py3status)[inputs]: Add file.
>      [arguments]: Modify phases to patch py3status to call file with an
>      absolute path.

I applied this change and pushed the commit.

Thanks for your time!

S_W

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: [PATCH] gnu: Add missing input to python-py3status.
Date: Wed,  4 Oct 2017 00:57:57 +0200

* gnu/packages/python.scm (python-py3status): Add missing input.

file is used to determine configuration file encoding and py3status fails to
run when this tool is missing.
---
 gnu/packages/python.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6ffd468b3..88f7ff1e4 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -11468,6 +11468,8 @@ to occurrences in strings and comments.")
         (base32
          "0i283z1pivmir61z8kbiycigc94l61v33ygzkhczf1ifq7cppyds"))))
     (build-system python-build-system)
+    (inputs
+     `(("file" ,file)))
     (arguments
      '(#:tests? #f)) ; TODO: Requires many libraries not in Guix.
     (home-page "https://github.com/ultrabug/py3status")
-- 
2.14.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.