From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status. Resent-From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Oct 2017 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28693@debbugs.gnu.org Cc: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150707150013504 (code B ref -1); Tue, 03 Oct 2017 22:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Oct 2017 22:58:20 +0000 Received: from localhost ([127.0.0.1]:46987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzW8q-0003Vk-6C for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzW8n-0003VT-Ts for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzW8h-0008VR-TG for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzW8h-0008V8-QF for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzW8g-0008Pe-EE for guix-patches@gnu.org; Tue, 03 Oct 2017 18:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzW8d-0008Qm-Aa for guix-patches@gnu.org; Tue, 03 Oct 2017 18:58:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:48850 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzW8d-0008MY-3t; Tue, 03 Oct 2017 18:58:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 47FE5AC8B; Tue, 3 Oct 2017 22:58:02 +0000 (UTC) From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Date: Wed, 4 Oct 2017 00:57:57 +0200 Message-Id: <20171003225757.28335-1-sleep_walker@gnu.org> X-Mailer: git-send-email 2.14.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/python.scm (python-py3status): Add missing input. file is used to determine configuration file encoding and py3status fails to run when this tool is missing. --- gnu/packages/python.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 6ffd468b3..88f7ff1e4 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -11468,6 +11468,8 @@ to occurrences in strings and comments.") (base32 "0i283z1pivmir61z8kbiycigc94l61v33ygzkhczf1ifq7cppyds")))) (build-system python-build-system) + (inputs + `(("file" ,file))) (arguments '(#:tests? #f)) ; TODO: Requires many libraries not in Guix. (home-page "https://github.com/ultrabug/py3status") -- 2.14.2 From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2017 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Cc: 28693@debbugs.gnu.org Received: via spool by 28693-submit@debbugs.gnu.org id=B28693.15071003964297 (code B ref 28693); Wed, 04 Oct 2017 07:00:02 +0000 Received: (at 28693) by debbugs.gnu.org; 4 Oct 2017 06:59:56 +0000 Received: from localhost ([127.0.0.1]:47339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzdet-00017F-Ux for submit@debbugs.gnu.org; Wed, 04 Oct 2017 02:59:56 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:48340 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzder-000176-VP for 28693@debbugs.gnu.org; Wed, 04 Oct 2017 02:59:54 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 36BA713E654; Wed, 4 Oct 2017 07:59:53 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 254A013E652; Wed, 4 Oct 2017 07:59:51 +0100 (BST) Date: Wed, 4 Oct 2017 07:59:44 +0100 From: Christopher Baines Message-ID: <20171004075944.1e5a7cbf@cbaines.net> In-Reply-To: <20171003225757.28335-1-sleep_walker@gnu.org> References: <20171003225757.28335-1-sleep_walker@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/H5F5S74kOUCvkSPwBXvli=2"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/H5F5S74kOUCvkSPwBXvli=2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 4 Oct 2017 00:57:57 +0200 Tom=C3=A1=C5=A1 =C4=8Cech wrote: > * gnu/packages/python.scm (python-py3status): Add missing input. >=20 > file is used to determine configuration file encoding and py3status > fails to run when this tool is missing. Hey Tom=C3=A1=C5=A1, I don't know much about python-py3status, but I had a look at building it with and without this patch, and it worked for me both times. When building with this patch, so with file as an additional input, the resulting store item does not reference the file store item (which you can check using guix size, which lists the referenced store items [1]). Given file is used at runtime, it would be good if the resulting store item for python-py3status referenced file. As far as I can see, file is used here [2], so you could use the substitute* procedure to replace the command name with an absolute path to the binary in the store. This absolute path would then mean that file is recorded as a "runtime" dependency of python-py3status. Other approaches include wrapping the py3status binary to ensure the PATH environment variable includes the dependencies (like file), or adding file as to propagated-inputs (rather than inputs), which ensures its installed when py3status is installed. All of these 3 approaches I've mentioned have some downsides. Patching the files is tricky, and what is used where can change in later releases. As for wrapping, that is inelegant, and wouldn't help if this is used as a python library. Propagated inputs can conflict with other packages and propagated inputs, which can cause issues for people installing and upgrading packages. =46rom the number of occurrences of the subprocess module in this package, this seems to be a problem not limited to the file tool, but a large number of programs. I'm imagining that you use this, so let me know what you think, and if you have any questions? Thanks for the patch, Chris 1:=20 =E2=86=92 guix size python-py3status store item total s= elf /gnu/store/ks27x0mf95gir0cdgb9h573xbava6v1k-python-3.5.3 171.5 = 65.2 36.7% /gnu/store/n6nvxlk2j8ysffjh3jphn1k5silnakh6-glibc-2.25 38.5 = 37.1 20.9% /gnu/store/3x53yv4v144c9xp02rs64z7j597kkqax-gcc-5.4.0-lib 68.6 = 30.1 16.9% /gnu/store/42d5rjrdkln6nwvzwdc8dyd4w6iy3n5j-coreutils-8.27 86.8 = 14.8 8.3% /gnu/store/m0m6bwzi8lx7kv8zbn3hjrim6flmgnf4-openssl-1.0.2l 74.6 = 5.9 3.3% /gnu/store/09j7scnl3hahcmql986fsjpzj6gqsmzv-ncurses-6.0 74.3 = 5.7 3.2% /gnu/store/b7y66db86k57vbb03nr4bfn9svmks4gf-bash-4.4.12 81.0 = 5.4 3.1% /gnu/store/mpl9b9w60gjzsq470zka5l8p2bmy7r8v-sqlite-3.19.3 79.0 = 3.5 1.9% /gnu/store/5jl21csvr3jmsa4a7d08sqa2waks3f09-gmp-6.1.2 71.2 = 2.6 1.5% /gnu/store/zhrajv6qf2hzn9c3g2bb07559hyrz5xp-bash-static-4.4.12 1.4 = 1.4 0.8% /gnu/store/mipizipnr4y2hly9b429j8id1albbgqi-readline-7.0 75.6 = 1.3 0.7% /gnu/store/g3nari57wcfnm00kv9bnpyzdzfq4h8pk-xz-5.2.2 70.7 = 1.1 0.6% /gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn-bash-minimal-4.4.12 39.5 = 1.0 0.5% /gnu/store/9ym4jxs5jhzjbf0dy5wz3ghdd8mp72r8-python-py3status-3.1 177.7 = 0.8 0.5% /gnu/store/47jgabf5wx296alb06pb5iig6cqbmx0v-gdbm-1.13 69.2 = 0.6 0.3% /gnu/store/5lrk6d5cjsv2s29vfji6j59gyf18rb5m-acl-2.2.52 69.3 = 0.4 0.2% /gnu/store/sfx1wh27i6gsrk21p87rdyikc64v7d51-zlib-1.2.11 69.0 = 0.4 0.2% /gnu/store/yz1lf55ag0904w9ib0q2kcjpdx33y7wm-attr-2.4.47 68.9 = 0.2 0.1% /gnu/store/jnbb8ffxxvrw2b4z18zn0g08kqk9rsgl-libffi-3.2.1 68.8 = 0.1 0.1% /gnu/store/yzlmd2nlcyjhx0ydbap7x32zjqxc3hz9-libcap-2.25 68.8 = 0.1 0.1% /gnu/store/v4i3zfiwk6vl0mhdz580diqs0p6sc8vg-python-wrapper-3.5.3 176.9 = 0.0 0.0% total: 177.7 MiB 2: lib/python3.5/site-packages/py3status/parse_config.py --Sig_/H5F5S74kOUCvkSPwBXvli=2 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnUhuBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeE6hAArB5K445KJQSPfnkBh+Ip952AMQZnh3z/ZE1f2TFwqrkm5u/a4dRNc5p1 Bnq2SXJCuwzJQ5se5BjHaOaoAiGQ+UiQutAbp/Kmi4pZPv8hSRpQE6woABcLaBaj RKoLSBm8xbn+Cf4HNQgzSOCeHf9F8PGM5ATdaoUN/QAKkZx31qWeT/vbrn56nSkh Jw5FVvkxuAWHWVjwQSqxPa/tMXqIsmKpUIamD7US2YcjeMOaXDoIppl7UEkWBb0C GpvE7r8yD5O9B4uKpVzKdVqe1NC43w/snRqAdvTiwV+xL2PcYhXBF3sYdePf3gAv 5aK7BBtUMsY/2HoNM/ECF4hBv/uWVIb8GbXoskcLGDiwNBvZOuy41WYL1V1MO2Ub I8Bc+YM89FK1aUE+U9XWDRAoYh7mt/Dfrhus+5DqvrGxQKL4YsSwPjBCrHW3HTtA WvC94bQFHVNpED/Y+Tc0lnr8e9SMl/ILZpATxmoalW98yQ8Wa+9xjdVkvEhZ4Mhk YJOsBqQgra4vCaFckV9C1pJVUsE3qxCKghq2819eP1p+wPOS8yCxL/qt1tuVyKFU X8p6kOG2yg6loqenGcTB+ICmR1gKWmoA8aGNpJ0IuezCkwmCBt3RvNi88QXsEbee MYOb2qIzi60/7jnyRQ/qCmRIj5LCNy72M+S0Xq2UnuAVjVk5V5I= =Ev19 -----END PGP SIGNATURE----- --Sig_/H5F5S74kOUCvkSPwBXvli=2-- From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status. Resent-From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2017 21:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 28693@debbugs.gnu.org Received: via spool by 28693-submit@debbugs.gnu.org id=B28693.150723774721530 (code B ref 28693); Thu, 05 Oct 2017 21:10:02 +0000 Received: (at 28693) by debbugs.gnu.org; 5 Oct 2017 21:09:07 +0000 Received: from localhost ([127.0.0.1]:51852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0DOE-0005bC-QK for submit@debbugs.gnu.org; Thu, 05 Oct 2017 17:09:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:54084 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0DOD-0005b4-BB for 28693@debbugs.gnu.org; Thu, 05 Oct 2017 17:09:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B6499ADDF; Thu, 5 Oct 2017 21:09:03 +0000 (UTC) Date: Thu, 5 Oct 2017 23:08:57 +0200 From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Message-ID: <20171005210857.5soxmlej6kgvqxrf@penguin> References: <20171003225757.28335-1-sleep_walker@gnu.org> <20171004075944.1e5a7cbf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mcx6isf2mlddbxia" Content-Disposition: inline In-Reply-To: <20171004075944.1e5a7cbf@cbaines.net> User-Agent: NeoMutt/20170912 (1.9.0) X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --mcx6isf2mlddbxia Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Christopher, first, let me thank you for your long explanatory review, I really appreciate it. On Wed, Oct 04, 2017 at 06:59:44AM +0000, Christopher Baines wrote: >On Wed, 4 Oct 2017 00:57:57 +0200 >Tom=C3=A1=C5=A1 =C4=8Cech wrote: > >> * gnu/packages/python.scm (python-py3status): Add missing input. >> >> file is used to determine configuration file encoding and py3status >> fails to run when this tool is missing. > >Hey Tom=C3=A1=C5=A1, > >I don't know much about python-py3status, but I had a look at building >it with and without this patch, and it worked for me both times. That is correct. >When building with this patch, so with file as an additional input, the >resulting store item does not reference the file store item (which you >can check using guix size, which lists the referenced store items [1]). > >Given file is used at runtime, it would be good if the resulting store >item for python-py3status referenced file. As far as I can see, file is >used here [2], so you could use the substitute* procedure to replace >the command name with an absolute path to the binary in the store. This >absolute path would then mean that file is recorded as a "runtime" >dependency of python-py3status. I have taken this approach as it seems to me as the most clean one. It works and `guix size' command now shows the file store in the list. >Other approaches include wrapping the py3status binary to ensure the >PATH environment variable includes the dependencies (like file), or >adding file as to propagated-inputs (rather than inputs), which ensures >its installed when py3status is installed. > >All of these 3 approaches I've mentioned have some downsides. Patching >the files is tricky, and what is used where can change in later >releases. It adds burden to maintainer to verify sufficiency and need for every code change but besides that it looks as proper solution. >As for wrapping, that is inelegant, and wouldn't help if this >is used as a python library. Agreed. >Propagated inputs can conflict with other >packages and propagated inputs, which can cause issues for people >installing and upgrading packages. This point is interesting to me - can you please give me example? >>From the number of occurrences of the subprocess module in this >package, this seems to be a problem not limited to the file tool, but a >large number of programs. That is correct but other occurences are related to plugins providing functionality. User has to prepare configuration to use that code. Problem I'm trying to fix is causing hard-to-catch confusing error right after start for everyone who is missing file in PATH. I somehow miss expressing optional run-time dependencies in Guix which would suit for this. I guess I'd go here with lazy approach and provide basic functionality my problem and let advanced user to deal with plugin problems by himself. Otherwise the closure would grow beyond reason. What do you think? Can this be the way here? Best regards, S_W --mcx6isf2mlddbxia Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEDOrssfr9jDQthC2PSiPjT6AzQ20FAlnWn2AACgkQSiPjT6Az Q233gw/+J6pP6/pKdl/hmPP6QSbQvj3qJuhUbVjUJK/pHIyWnV9SWvDzLTEUv8sn Kx3RKn1nKIYQha1eKnC/hU5D8aif5b743TF6fHw3fO+1A1oU5jAJngZoDHz9IN2w ig7hOmpJTeSxYzN5ZOAEfSpDwDN9ej2IvYAi2uhyJI4TaamBBWLVqj/cO1nKTG6C O2Gbq7Pc0H5M1xcmY9Nah5UOPYUh18ofJv6/DRKnj7WUUaEqQgibfJpuJRv5o8qr ZSZxIHINQc7RSAT5GyEFgxKq6VQsn/0bBiOyX3n+NA/2Hdbg2EQoyMnI0DmmX85i otcfyd2hRXMpV6YhTJ0qsrfS9Q3fiLgItvd3E6En8Vnc1JX3zK4OE+vbQLDF4wUF K1JEnIgX+nBO9p5ULDuOaZm1XM3B8nkglDJDTJqtRajNLqJubizN8nOKXVVoZfVq ULqSywO4ajcGJ/W3SUjVk4Q+pVt0N6iICHtze3aqdIYLIefFGrP9vhI1M5EybkRG rgV90+vfv5naNbrJmctIH4u48Ww4+mdx7OnNa/0UhkVmenaVOIlP/2k6URorTeCO +b+w4CxwRAEpvG3AMb6uhgRl4UtFxP1tiD42qJ4jsnpSEfT/DdyzbGuYCjaCFGQS xO0Nio6uT6nG9z6kPAuAQpCV92PtavBdpIjZaos8l0WEVvOMjOQ= =rrJ9 -----END PGP SIGNATURE----- --mcx6isf2mlddbxia-- From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status and fix call path. Resent-From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2017 21:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= , 28693@debbugs.gnu.org Received: via spool by 28693-submit@debbugs.gnu.org id=B28693.150723868930291 (code B ref 28693); Thu, 05 Oct 2017 21:25:01 +0000 Received: (at 28693) by debbugs.gnu.org; 5 Oct 2017 21:24:49 +0000 Received: from localhost ([127.0.0.1]:51877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0DdQ-0007sV-Mt for submit@debbugs.gnu.org; Thu, 05 Oct 2017 17:24:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:55391 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0DdO-0007sM-PF for 28693@debbugs.gnu.org; Thu, 05 Oct 2017 17:24:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6FD00ADE7; Thu, 5 Oct 2017 21:24:45 +0000 (UTC) From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Date: Thu, 5 Oct 2017 23:24:39 +0200 Message-Id: <20171005212439.26407-1-sleep_walker@gnu.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171004075944.1e5a7cbf@cbaines.net> References: <20171004075944.1e5a7cbf@cbaines.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/python.scm (python-py3status)[inputs, arguments]: Add missing file utility as input, adjust path used to call it. file is used to determine configuration file encoding and py3status fails to start when this tool is missing. --- gnu/packages/python.scm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 6ffd468b3..426ff12eb 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -11468,8 +11468,21 @@ to occurrences in strings and comments.") (base32 "0i283z1pivmir61z8kbiycigc94l61v33ygzkhczf1ifq7cppyds")))) (build-system python-build-system) + (inputs + `(("file" ,file))) (arguments - '(#:tests? #f)) ; TODO: Requires many libraries not in Guix. + '(#:phases + (modify-phases %standard-phases + ;; 'file' is used for detection of configuration file encoding + ;; let's make link the dependency to particular input + (add-before 'build 'patch-file-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((file-path (assoc-ref inputs "file"))) + (substitute* "py3status/parse_config.py" + (("check_output\\(\\['file'") + (string-append "check_output(['" file-path "/bin/file'"))) + #t)))) + #:tests? #f)) ; TODO: Requires many libraries not in Guix. (home-page "https://github.com/ultrabug/py3status") (synopsis "Extensible i3status wrapper written in Python") (description "py3status is an i3status wrapper which extends i3status -- 2.14.2 From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status and fix call path. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2017 22:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= , Christopher Baines Cc: 28693@debbugs.gnu.org Received: via spool by 28693-submit@debbugs.gnu.org id=B28693.15072421353580 (code B ref 28693); Thu, 05 Oct 2017 22:23:02 +0000 Received: (at 28693) by debbugs.gnu.org; 5 Oct 2017 22:22:15 +0000 Received: from localhost ([127.0.0.1]:51905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0EX0-0000vf-Vp for submit@debbugs.gnu.org; Thu, 05 Oct 2017 18:22:15 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0EWz-0000vW-6y for 28693@debbugs.gnu.org; Thu, 05 Oct 2017 18:22:13 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1157520B8E; Thu, 5 Oct 2017 18:22:13 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Thu, 05 Oct 2017 18:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=v/Xy94VZoht8X+1nVTkh+L9UZNidtJD04OYQ7Oqah ZI=; b=vknXLzJurQbdt06s5dfjYijmrRvF9FY7nh0+yt+2xjtQTbnpA9A10jTPy Q6JeMfkeRuKmHEnUi2cvhSl/cs8JSD+fSge8DlH+H2BZbif+nR9qt6KEguzHxOYv M2MlVk/H1HCP6UpqHt26bQS7eeTl634WAeyQvEI4aQ/w9gnnVchHfJ+WFK/EnU7C 0sMTJOgCLW7C66M9ESVX8b+tbhq63A/PAzvbG2LZN2oRqr7xA6ofTvcOemgdHN+O HOgAu1DKwPvVYQjJ29FGC23OtLw2U8/r9Lje4LEE4k9SQr6n1ikDfdVIgdR2RCpu W4O7ozEgBbDt6Yf0UT+rD9ro4B/2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=v/Xy94VZoht8X+1nVT kh+L9UZNidtJD04OYQ7OqahZI=; b=pYYn+iLA7nukxT89vuXbL5Oau3eSlp+nBa rifsb7cwdFVuyeresvy/BRDToyhhCtyOwijaOwJT4OJDY2t1WZMSBAwuV/mwFS2J mCKV5eqXmq9GVK1dtKtm3sZKLMoOx/5bB2wOXWBj02btA9HhMXGEVIr6WqTI8gVb /Tciei6PofCEZXWh3GSV5yAXFx8jZ4zojoJ1LgNRCe3MB7wLb2rRBY9eqnWbVL8S /jagEJJ6Bv6Z1P3Tgj3sFq4bsgBnRbbNMVy9kD6qyqiwQa9iWcwZerxUUMnZWruu xK6Xhm0m9gRdzhzzIfOKLHeIC7DceVdlYnZTlJp/hPcdabb6zXFA== X-ME-Sender: X-Sasl-enc: /ABFOCJb+rZlPCdoe3ZCRadlsWc0PjE/Mth50jOQIRxa 1507242132 Received: from localhost (cm-84.214.173.174.getinternet.no [84.214.173.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 909807F91F; Thu, 5 Oct 2017 18:22:12 -0400 (EDT) From: Marius Bakke In-Reply-To: <20171005212439.26407-1-sleep_walker@gnu.org> References: <20171004075944.1e5a7cbf@cbaines.net> <20171005212439.26407-1-sleep_walker@gnu.org> User-Agent: Notmuch/0.25.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Fri, 06 Oct 2017 00:22:11 +0200 Message-ID: <87d161ck18.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tom=C3=A1=C5=A1 =C4=8Cech writes: > * gnu/packages/python.scm (python-py3status)[inputs, arguments]: Add miss= ing > file utility as input, adjust path used to call it. > > file is used to determine configuration file encoding and py3status fails= to > start when this tool is missing. LGTM, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlnWsJMACgkQoqBt8qM6 VPq+7QgAqQ8jjiyBisS+AlksyiuACg3izPvr0GoGQ8PMsGamQTiW6UtxRbEWE2ga uwERl4/yb2bTFLR6RbWImXMTzO48N8dzf0dtdjoRovZRgal4KCY/Drjh37ZvP1uA Ymjda2gNZvXX+8s25wZzYV4SosIp+5sr+TI4bR8YoA4WkuKEHm1YWfTVoXvR6zK8 uHAzhwvqJ6On2rELltbcCmS9jV3KcSuwrQiJ5Y86xfgk1u0elo+wHvpr5ZvZPFkj UI6cU+pPOdnZHcClHWzh2Z7PZeI9tYhH1UiA/u4U3qQUhdKGW22SB9rR9iPJymtV uc5/vPEiR0EpzazMqXwZgcCdwOB6Gg== =Qm60 -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 Oct 2017 06:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Cc: 28693@debbugs.gnu.org Received: via spool by 28693-submit@debbugs.gnu.org id=B28693.15072713782565 (code B ref 28693); Fri, 06 Oct 2017 06:30:01 +0000 Received: (at 28693) by debbugs.gnu.org; 6 Oct 2017 06:29:38 +0000 Received: from localhost ([127.0.0.1]:52048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0M8f-0000fI-UP for submit@debbugs.gnu.org; Fri, 06 Oct 2017 02:29:38 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:49908 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0M8e-0000f9-6T for 28693@debbugs.gnu.org; Fri, 06 Oct 2017 02:29:37 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 5F55813E3A7; Fri, 6 Oct 2017 07:29:35 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 146AB13E3A5; Fri, 6 Oct 2017 07:29:33 +0100 (BST) Date: Fri, 6 Oct 2017 07:29:31 +0100 From: Christopher Baines Message-ID: <20171006072931.6caf481c@cbaines.net> In-Reply-To: <20171005210857.5soxmlej6kgvqxrf@penguin> References: <20171003225757.28335-1-sleep_walker@gnu.org> <20171004075944.1e5a7cbf@cbaines.net> <20171005210857.5soxmlej6kgvqxrf@penguin> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/t2KX6=o1YIkOmd7KzNHDF3y"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/t2KX6=o1YIkOmd7KzNHDF3y Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 5 Oct 2017 23:08:57 +0200 Tom=C3=A1=C5=A1 =C4=8Cech wrote: > Hi Christopher, >=20 > first, let me thank you for your long explanatory review, I really > appreciate it. You're welcome :) > On Wed, Oct 04, 2017 at 06:59:44AM +0000, Christopher Baines wrote: > >On Wed, 4 Oct 2017 00:57:57 +0200 > >Tom=C3=A1=C5=A1 =C4=8Cech wrote: > > =20 > >> * gnu/packages/python.scm (python-py3status): Add missing input. > >> > >> file is used to determine configuration file encoding and py3status > >> fails to run when this tool is missing. =20 > > > >Hey Tom=C3=A1=C5=A1, > > > >I don't know much about python-py3status, but I had a look at > >building it with and without this patch, and it worked for me both > >times. =20 >=20 > That is correct. >=20 > >When building with this patch, so with file as an additional input, > >the resulting store item does not reference the file store item > >(which you can check using guix size, which lists the referenced > >store items [1]). > > > >Given file is used at runtime, it would be good if the resulting > >store item for python-py3status referenced file. As far as I can > >see, file is used here [2], so you could use the substitute* > >procedure to replace the command name with an absolute path to the > >binary in the store. This absolute path would then mean that file is > >recorded as a "runtime" dependency of python-py3status. =20 >=20 > I have taken this approach as it seems to me as the most clean one. It > works and `guix size' command now shows the file store in the list. Great :) > >Other approaches include wrapping the py3status binary to ensure the > >PATH environment variable includes the dependencies (like file), or > >adding file as to propagated-inputs (rather than inputs), which > >ensures its installed when py3status is installed. > > > >All of these 3 approaches I've mentioned have some downsides. > >Patching the files is tricky, and what is used where can change in > >later releases. =20 >=20 > It adds burden to maintainer to verify sufficiency and need for every > code change but besides that it looks as proper solution. >=20 > >As for wrapping, that is inelegant, and wouldn't help if this > >is used as a python library. =20 >=20 > Agreed. >=20 > >Propagated inputs can conflict with other > >packages and propagated inputs, which can cause issues for people > >installing and upgrading packages. =20 >=20 > This point is interesting to me - can you please give me example? So say a user has the file package installed in their profile, and also has python-py3status installed in their profile. If python-py3status propagates file, there is the opportunity for conflicts. A profile directory is a union of some of the files in the component packages. So, file from the profile has something for bin/file and file propagated from python-py3status will also have bin/file. If you installed the file package in your profile a while ago, and only installed the python-py3status package recently, then there is a possibility that they differ. When this happens, there is an error shown, I found an example here [1]. 1: https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00001.html I'm not sure how good this explanation is, so let me know if its helpful or not. > >From the number of occurrences of the subprocess module in this > >package, this seems to be a problem not limited to the file tool, > >but a large number of programs. =20 >=20 > That is correct but other occurences are related to plugins providing > functionality. User has to prepare configuration to use that code. Ok, that's good. > Problem I'm trying to fix is causing hard-to-catch confusing error > right after start for everyone who is missing file in PATH. >=20 > I somehow miss expressing optional run-time dependencies in Guix which > would suit for this. I guess I'd go here with lazy approach and > provide basic functionality my problem and let advanced user to deal > with plugin problems by himself. >=20 > Otherwise the closure would grow beyond reason. >=20 > What do you think? Can this be the way here? Compared to optional dependencies in other systems like Debian, they still leave the user to sort out problems like this. I guess Guix could offer a way of having optional inputs, but I'm not sure how that would help. Also, multiple outputs to separate out the dependencies might be more appropriate, but probably too much effort to do right now. I'll reply to the patch separately. --Sig_/t2KX6=o1YIkOmd7KzNHDF3y Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnXIstfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdBFA//WLGgOmJ7BoqKLL3LqPpNIiOeg5V0/kfLDNHQmmJQqxZHRFPs4VMTxrB/ DPJjV4Z5xVBCHEB0UhM92QE98KenVBHd7UaLyQFjmGvjmeLUWdmoTlNwIr4laQMz gmCjS8UqWYEl2JtjRQW3qnhw9JEuZHgD+Yu7cuapuDbWNBvvCQsCfusN4vQV/rPf ikus7sqvaIXR9dwjAYySD+lwlkQqnfgyMWt+RVcAjt823djgvZu5kOCqRV+cfqMv hB7nPbWAx8fkh9TfKBj9wnWeYcSWMCHV/blwN+Rw5hMngZ0LCzorbeebnssxY17P K5ITTUvmBvAOSJCdiz20aEgVmRJkw/6DTUZBv3oZBmVKI1HU2bUUNVWwG0rTjgxz loUPo5eAUCsDJDOHSFVgQlme0frZh7Hr6dBNfgk6FPB7JMkK+ZKW6Jts2uYTIuax 25T0nSmxrX+XXlkT9shTBTxlw1JF//M5IpQnCNimJa9rQVPu7uyuwXrOR4Yw180p 0sD/v3RL7SsRKjlRY2UV0ypFKnXgh0kOuHeK0smthxBsdJ+ZxPs6NLYqhRWCI01N AhQ+8YBjrzwsXZvy1XodEf2foqFn6xpYV6v762tllmAVw0gK1/oZVRmp//KpgtNs csNUnZuEC0fC+KEk8dukp/l3l9WEJ+kHG8m0qti5kCCXA/9IN/k= =35IV -----END PGP SIGNATURE----- --Sig_/t2KX6=o1YIkOmd7KzNHDF3y-- From unknown Tue Aug 19 23:13:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28693] [PATCH] gnu: Add missing input to python-py3status and fix call path. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 Oct 2017 06:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Cc: 28693@debbugs.gnu.org Received: via spool by 28693-submit@debbugs.gnu.org id=B28693.15072715742946 (code B ref 28693); Fri, 06 Oct 2017 06:33:02 +0000 Received: (at 28693) by debbugs.gnu.org; 6 Oct 2017 06:32:54 +0000 Received: from localhost ([127.0.0.1]:52052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0MBq-0000lS-Gx for submit@debbugs.gnu.org; Fri, 06 Oct 2017 02:32:54 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:49912 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0MBo-0000lK-Se for 28693@debbugs.gnu.org; Fri, 06 Oct 2017 02:32:53 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 754E313E3A7; Fri, 6 Oct 2017 07:32:52 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 03BCE13E3A5; Fri, 6 Oct 2017 07:32:51 +0100 (BST) Date: Fri, 6 Oct 2017 07:32:50 +0100 From: Christopher Baines Message-ID: <20171006073250.4ecbd100@cbaines.net> In-Reply-To: <20171005212439.26407-1-sleep_walker@gnu.org> References: <20171004075944.1e5a7cbf@cbaines.net> <20171005212439.26407-1-sleep_walker@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/1v6rAbrwWNG2STEGZoVefcv"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/1v6rAbrwWNG2STEGZoVefcv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 5 Oct 2017 23:24:39 +0200 Tom=C3=A1=C5=A1 =C4=8Cech wrote: > * gnu/packages/python.scm (python-py3status)[inputs, arguments]: Add > missing file utility as input, adjust path used to call it. I would usually put the changelog last, as I think this is more consistent with other committers. Also, maybe this could be more specific like: * gnu/packages/python.scm (python-py3status)[inputs]: Add file. [arguments]: Modify phases to patch py3status to call file with an absolute path. > file is used to determine configuration file encoding and py3status > fails to start when this tool is missing. > --- > gnu/packages/python.scm | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 6ffd468b3..426ff12eb 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -11468,8 +11468,21 @@ to occurrences in strings and comments.") > (base32 > "0i283z1pivmir61z8kbiycigc94l61v33ygzkhczf1ifq7cppyds")))) > (build-system python-build-system) > + (inputs > + `(("file" ,file))) > (arguments > - '(#:tests? #f)) ; TODO: Requires many libraries not in Guix. > + '(#:phases > + (modify-phases %standard-phases > + ;; 'file' is used for detection of configuration file > encoding > + ;; let's make link the dependency to particular input > + (add-before 'build 'patch-file-path > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((file-path (assoc-ref inputs "file"))) > + (substitute* "py3status/parse_config.py" > + (("check_output\\(\\['file'") > + (string-append "check_output(['" file-path > "/bin/file'"))) > + #t)))) > + #:tests? #f)) ; TODO: Requires many libraries not in Guix. > (home-page "https://github.com/ultrabug/py3status") > (synopsis "Extensible i3status wrapper written in Python") > (description "py3status is an i3status wrapper which extends > i3status This change looks fine to me, and I checked that it builds as well. Please push :) --Sig_/1v6rAbrwWNG2STEGZoVefcv Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnXI5JfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfd6Q/9GiXUlG7vbV9k4iiMcJkJqcpyoGzENzXXsxNalc0rxPfbHa98TgV+7ucN VRrz4YNhdvsdfvgyvSo5dWjG3BXT8FPbP58p1XRNZyJkBaVYQHKiqZfLtlQ9AV2P VmI3rD6Mc2dI+7HTR2ma9BI0XCmoLqq7ZXeTObQmiWcGtrx6/y+JcepIJm2xikwf 123MyBZlYdIV8rjIYiDp3T6ft7f++WjOoid9xWozsIklIDBeiNXWTQlb+/kjMCU+ L7xuHOHnCnVujcuqaBiH3AZd0ChlY1KWN7LfK0C1zNmWJcfEQFa17gwVzhmemwfo KgdanJYhmyoHkHmFNt8pMyxWmRwQgmarIHyzjcGOqpB8NgKVm6AJFoGC9l156Ewl IPcFnOxTVWV0jNlr6rN3o4jKaMaaKgqo7kHpyatC/1XtShENa1yP4xxqSQWpgAPj Hgmf46QPZhal0yX43sHeIkzmuJ8jAKla6BHf3m2xc34qjCathdmy1zlVEwFx8llL WubO8cCrR5BgaO5Z46F1YTJB0EFcAj9CbShzUtNEaTQJCcK1h635J6SISLczrGSt pDLNq13gbOlW13MC3pjzBL++jLeqqqm28vdCMFAIbGPpcCi5ZmFSqOjJYLwZWuWR H0LLcyz8oxptU5rEeLOnha0fA98WQzDHPXLzpl/w2iICwpRJQfE= =Xh4g -----END PGP SIGNATURE----- --Sig_/1v6rAbrwWNG2STEGZoVefcv-- From unknown Tue Aug 19 23:13:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Subject: bug#28693: closed (Re: [PATCH] gnu: Add missing input to python-py3status and fix call path.) Message-ID: References: <20171008110532.2rcw3jotp3xm42d5@penguin> <20171003225757.28335-1-sleep_walker@gnu.org> X-Gnu-PR-Message: they-closed 28693 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28693@debbugs.gnu.org Date: Sun, 08 Oct 2017 11:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1507460762-18411-1" This is a multi-part message in MIME format... ------------=_1507460762-18411-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28693: [PATCH] gnu: Add missing input to python-py3status. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28693@debbugs.gnu.org. --=20 28693: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28693 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1507460762-18411-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28693-done) by debbugs.gnu.org; 8 Oct 2017 11:05:38 +0000 Received: from localhost ([127.0.0.1]:55524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e19Or-0004mB-Um for submit@debbugs.gnu.org; Sun, 08 Oct 2017 07:05:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:48929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e19Op-0004lz-QA for 28693-done@debbugs.gnu.org; Sun, 08 Oct 2017 07:05:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5CE955CB21; Sun, 8 Oct 2017 11:05:34 +0000 (UTC) Date: Sun, 8 Oct 2017 13:05:32 +0200 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= To: Christopher Baines Subject: Re: [PATCH] gnu: Add missing input to python-py3status and fix call path. Message-ID: <20171008110532.2rcw3jotp3xm42d5@penguin> References: <20171004075944.1e5a7cbf@cbaines.net> <20171005212439.26407-1-sleep_walker@gnu.org> <20171006073250.4ecbd100@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2ucpuuskb3vtbqqq" Content-Disposition: inline In-Reply-To: <20171006073250.4ecbd100@cbaines.net> User-Agent: NeoMutt/20170912 (1.9.0) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28693-done Cc: Marius Bakke , 28693-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --2ucpuuskb3vtbqqq Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 06, 2017 at 06:32:50AM +0000, Christopher Baines wrote: >On Thu, 5 Oct 2017 23:24:39 +0200 >Tom=C3=A1=C5=A1 =C4=8Cech wrote: > >> * gnu/packages/python.scm (python-py3status)[inputs, arguments]: Add >> missing file utility as input, adjust path used to call it. > >I would usually put the changelog last, as I think this is more >consistent with other committers. Also, maybe this could be more >specific like: > > * gnu/packages/python.scm (python-py3status)[inputs]: Add file. > [arguments]: Modify phases to patch py3status to call file with an > absolute path. I applied this change and pushed the commit. Thanks for your time! S_W --2ucpuuskb3vtbqqq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEDOrssfr9jDQthC2PSiPjT6AzQ20FAlnaBnwACgkQSiPjT6Az Q22lMA//U6why1C33tsuyVZKDzXKFzzkUTZyCW1WXbtLBKqax2jCLmJcsD7foM5I aJ+fjN0SkbVcthGE4jXMR1xsLahsv/a3WsMKfBx/XLeOsC4KX88tziAOR9MDnwkO DW+bG2Exug5i7nW0TUtH3o7jsoy2WMisRDhsPVH27hDZT2Xv3Xel6u494b3r1Y+I 8CXyqcTO7W7nHjpk2cpj7giHnlcZdUMRr/KOxr57LYYmGXhmd7iRw2UcxOi1q3+e jSFLoP9oM0/UcaicFVrMQLkkQ3KY/DyJCfX3lC5TZeej/A0RmeSGxskpPtkmUr35 SuPhG+gXZEMdvYBIiV7zSsnbvOGfa/vNGSOrDil6qecBvymGmoHPt7W7GViXw1oj C/7XklNFg2SUJ8UJZk/0pIHnp5B9IymEpMC+L8U/sl1NdmFWMhjfPbyKfYgK/msE GcF5rQGfIdnGxHFs3KHyN5DDNYPDQvCYfaxiSsySR1JBsCCVJl+RFCzSKf/UsJp/ 6YZhVa9zjWa8E2Sj5moI3FP989nlKtbG4yUizF5HRr/VsG8ouJ3N0/TH/ajoJiiJ lKuLWwXzU5uan6FL/sCxGSX5VQ3uMkrvROOAryPaIBLhhTaBm/heZnrwuoVAJvLM dZC9w6ANeUplesIPP+EWNn1PdtLiHOqG57g6V4YAeeSdFCucNoA= =AeTR -----END PGP SIGNATURE----- --2ucpuuskb3vtbqqq-- ------------=_1507460762-18411-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Oct 2017 22:58:20 +0000 Received: from localhost ([127.0.0.1]:46987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzW8q-0003Vk-6C for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzW8n-0003VT-Ts for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzW8h-0008VR-TG for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzW8h-0008V8-QF for submit@debbugs.gnu.org; Tue, 03 Oct 2017 18:58:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzW8g-0008Pe-EE for guix-patches@gnu.org; Tue, 03 Oct 2017 18:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzW8d-0008Qm-Aa for guix-patches@gnu.org; Tue, 03 Oct 2017 18:58:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:48850 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzW8d-0008MY-3t; Tue, 03 Oct 2017 18:58:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 47FE5AC8B; Tue, 3 Oct 2017 22:58:02 +0000 (UTC) From: =?UTF-8?q?Tom=C3=A1=C5=A1=20=C4=8Cech?= To: guix-patches@gnu.org Subject: [PATCH] gnu: Add missing input to python-py3status. Date: Wed, 4 Oct 2017 00:57:57 +0200 Message-Id: <20171003225757.28335-1-sleep_walker@gnu.org> X-Mailer: git-send-email 2.14.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Tom=C3=A1=C5=A1=20=C4=8Cech?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/python.scm (python-py3status): Add missing input. file is used to determine configuration file encoding and py3status fails to run when this tool is missing. --- gnu/packages/python.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 6ffd468b3..88f7ff1e4 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -11468,6 +11468,8 @@ to occurrences in strings and comments.") (base32 "0i283z1pivmir61z8kbiycigc94l61v33ygzkhczf1ifq7cppyds")))) (build-system python-build-system) + (inputs + `(("file" ,file))) (arguments '(#:tests? #f)) ; TODO: Requires many libraries not in Guix. (home-page "https://github.com/ultrabug/py3status") -- 2.14.2 ------------=_1507460762-18411-1--