GNU bug report logs - #28671
25.2; double transfer-encoding in rmailedit for complex mime messages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28671: closed (25.2; double transfer-encoding in rmailedit
 for complex mime messages)
Date: Mon, 09 Oct 2017 13:57:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 09 Oct 2017 16:55:55 +0300
with message-id <83tvz8qvbo.fsf <at> gnu.org>
and subject line Re: bug#28671: 25.2; double transfer-encoding in rmailedit for complex mime messages
has caused the debbugs.gnu.org bug report #28671,
regarding 25.2; double transfer-encoding in rmailedit for complex mime messages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28671: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28671
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
To: bug-gnu-emacs <at> gnu.org
Cc: kdo <at> cosmos.phy.tufts.edu
Subject: 25.2; double transfer-encoding in rmailedit for complex mime messages
Date: Mon, 02 Oct 2017 11:37:46 -0400

[Message part 3 (text/plain, inline)]

When rmail-edit-current-message gets a mime message which is too complex
for it to handle (i.e., anything but one "text/plain" part), it just
gives you the raw message to edit.  If you do so, rmail-cease-edit then
applies the transfer-encoding even though the message wasn't decoded,
and so on.  It also in some circumstances it also moves the marker for
the beginning of the following message.

The attached patch modifies rmail-cease-edit to check the
rmail-old-mime-state flag set by rmail-edit-current-message when it is
editing the raw message.  If set, rmail-cease-edit inserts the
already-encoded body without further processing.  It also deletes the
old body after inserting the new, rather than before, to avoid moving
the next message's marker.

                                        Ken

In GNU Emacs 25.2.2 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars)
 of 2017-05-29 built on olum.org
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:	Ubuntu 16.04.3 LTS

Configured features:
XPM JPEG TIFF GIF PNG SOUND NOTIFY FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS
LUCID X11

[rmailedit.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
Cc: 28671-done <at> debbugs.gnu.org
Subject: Re: bug#28671: 25.2;
 double transfer-encoding in rmailedit for complex mime messages
Date: Mon, 09 Oct 2017 16:55:55 +0300

> From: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
> Cc: 28671 <at> debbugs.gnu.org, kdo <at> cosmos.phy.tufts.edu
> Date: Mon, 02 Oct 2017 13:47:20 -0400
> 
> Here is a test file.  Edit the first message and make some change (e.g.,
> to the subject header).  Then the body will end up base64 encoded
> twice.  If you then go to the next message, the headers will have extra
> lines at the top due to marker problems.  The patch should fix these
> problems.
> 
> Here's a new patch with the simplified code as you suggested, and
> here's a change log entry:

Thanks, pushed to the release branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.