From unknown Fri Jun 13 11:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-From: Thomas Danckaert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 01 Oct 2017 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28660 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28660@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150686187125744 (code B ref -1); Sun, 01 Oct 2017 12:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Oct 2017 12:44:31 +0000 Received: from localhost ([127.0.0.1]:41817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dydbi-0006hA-NH for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dydbh-0006gv-IL for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dydbb-0003mt-HD for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34800) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dydbb-0003mU-E3 for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dydba-0002GE-5o for guix-patches@gnu.org; Sun, 01 Oct 2017 08:44:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dydbV-0003fs-4Q for guix-patches@gnu.org; Sun, 01 Oct 2017 08:44:22 -0400 Received: from s02-out3.spamexperts.axc.nl ([185.175.203.26]:48713) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dydbU-0003Xy-So for guix-patches@gnu.org; Sun, 01 Oct 2017 08:44:17 -0400 Received: from vserver42.axc.nl ([185.182.56.92]) by s02.spamexperts.axc.nl with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dydbL-00011G-Fd for guix-patches@gnu.org; Sun, 01 Oct 2017 14:44:08 +0200 Received: from mail.axc.nl ([185.182.56.42]:59272) by vserver42.axc.nl with esmtp (Exim 4.89) (envelope-from ) id 1dydbK-0006fZ-T7 for guix-patches@gnu.org; Sun, 01 Oct 2017 14:44:07 +0200 Date: Sun, 01 Oct 2017 14:44:04 +0200 (CEST) Message-Id: <20171001.144404.698351802734865623.post@thomasdanckaert.be> From: Thomas Danckaert X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Oct__1_14_44_04_2017_224)--" Content-Transfer-Encoding: 7bit PrimaryMX: Accepted email from trusted host. Hint: This skips spam scanning so make sure other host is not vulnerable X-Relay-Host: 185.182.56.42 SpamTally: Final spam score: 0 X-Originating-IP: 185.182.56.92 X-SpamExperts-Domain: vserver42.axc.nl X-SpamExperts-Username: 185.182.56.92 Authentication-Results: spamexperts.axc.nl; auth=pass smtp.auth=185.182.56.92@vserver42.axc.nl X-SpamExperts-Outgoing-Class: unsure X-SpamExperts-Outgoing-Evidence: Combined (0.30) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5v/IScWBpx3Hn1jArl/RLWUXv9krsgRhBn0ayn6qsUc7Uj/Ish2ZYyAn P2N0jR54boWpvChPF7njB1QaaRxKIJxWENu0Pea+RXSEc4ptxxWRvewkk6VwMLRpM4RHbNcD+lWv x4/5aan/L8AHYrKyAYNxkoVS3en1halL1LQpMACeBqrSizsMP2oaCFtE7vEM6fl6ZRsEfNMLJiIu aYwfhV6r7C0jzCIuxUC9ChcgeZyP+kJo6BlMeAD5U0UgS1og3TZypY1RI3AHog8az25j652lyR0C G1Ys+wMc1TxGZKd49BRWzyLsg7uBj5b+1OcCtva2gwQxdPFXgOEANkyHHYjk6Pnrj57pHasIWjxl 5VQahBN6Fcg3yxWjPLTpdkB5z4T+dVslWfb47s+i1ft+6O+PuTHMPZhJBp1OEgups00y6HPPLuOV zXiNlBYhGfdaOhRAKfWK48mqxd1pWN6R4o1KYgmMk9w/OkIlxo6TEpOpwYGX4o7w1Q52wqkyEyGN BtXw16oLNgXSCcFJXY2d34RMjblaO0Jo1v4tai8E8VPnTbGjAz4sti0XARAwX655k82QjEacgWQU QAfYdS6nDWALz2KSfkHL3KWc6oL+yKY7a65Mg8VCY43kDMgSby+RV1mxgUzuFDNYmxH6w09ayPJo vdtZWqAZORMyvHWzy5ReRhmtTkHoAnWWwwOQdPTQaYool8X0+BvzGRRfxR+ffyiFKHQVcWSisFP9 4cRKUzkuPiSXaBqIYGE3ufkRJnYNaxmfFdNz0VA789lQEMIJmZXK4u09LDa7EjgOj2efgrXtxuyl bpY4FQaSehMXhQ2FP26Wr5gJzUl/0jVvYBlgStyKkJZDFKDdyIGaPMjYq3NN9zRfF4dcYskuJHXf 6IoNdJ0e67MxsyuK+o7tZW1mXbo= X-Report-Abuse-To: spam@s01.spamexperts.axc.nl X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) ----Next_Part(Sun_Oct__1_14_44_04_2017_224)-- Content-Type: Text/Plain; charset=utf-8; format=flowed Content-Transfer-Encoding: base64 SGkgR3VpeCwNCg0KSSBzbGlnaHRseSBib3RjaGVkIHRoZSBsYXN0IG51bXB5IHVwZGF0ZTogc2V0 dGluZyAkU0hFTEwgd29ya3MsIGJ1dCANCnRoZW4gd2UgaGF2ZSB0byBzZXQgJFNIRUxMIGZvciBl dmVyeSBwYWNrYWdlIHdoaWNoIHVzZXMgbnVtcHkncyANCmRpc3R1dGlscy4gIEkgZG9uJ3Qga25v dyBob3cgbWFueSBwYWNrYWdlcyB0aGVyZSBhcmUsIGJ1dCBpdCBpbmNsdWRlcyANCnNjaXB5IGFu ZCBweXRob24taGRmIChhbmQgdGhlcmVmb3JlIHRob3NlIGJ1aWxkcyBhcmUgY3VycmVudGx5IGJy b2tlbiANCm9uIG1hc3Rlci4uLikuDQoNClRoZSBhdHRhY2hlZCBwYXRjaCBzaG91bGQgZml4IHRo ZSBpc3N1ZSBmb3IgYWxsIHBhY2thZ2VzLCBieSBzZXR0aW5nIA0KdGhlIGRlZmF1bHQgc2hlbGwg dG8gdGhlIOKAnC9iaW4vc2jigJ0gb2YgdGhlIGJ1aWxkIGVudmlyb25tZW50J3MgYmFzaCANCnBh Y2thZ2UgKGkuZS4gYmFzaC1taW5pbWFsKS4NCg0KVGhvbWFzDQo= ----Next_Part(Sun_Oct__1_14_44_04_2017_224)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gnu-python-numpy-Give-sh-store-location-instead-of-s.patch" >From cfaebf1b09c71585b5513629005e7cf3c5d17508 Mon Sep 17 00:00:00 2001 From: Thomas Danckaert Date: Sun, 1 Oct 2017 14:32:04 +0200 Subject: [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. * gnu/packages/python.scm (python-numpy): [arguments] Don't set $SHELL in the environment, but embed the location of bash as a default shell. Otherwise, we have to set $SHELL for every package which uses numpy's distutils. --- gnu/packages/python.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index e95c22de1..267715b0f 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -3742,8 +3742,6 @@ between language specification and implementation aspects.") (modify-phases %standard-phases (add-before 'build 'set-environment-variables (lambda* (#:key inputs #:allow-other-keys) - ;; numpy's distutils uses $SHELL to run external commands. - (setenv "SHELL" "bash") (call-with-output-file "site.cfg" (lambda (port) (format port @@ -3762,6 +3760,10 @@ include_dirs = ~a/include (assoc-ref inputs "openblas") (assoc-ref inputs "lapack") (assoc-ref inputs "lapack")))) + ;; Insert bash store location for default shell /bin/sh. + (substitute* "numpy/distutils/exec_command.py" + (("(os.environ.get\\('SHELL', ')(/bin/sh'\\))" match match-start match-end) + (string-append match-start (assoc-ref inputs "bash") match-end))) ;; Use "gcc" executable, not "cc". (substitute* "numpy/distutils/system_info.py" (("c = distutils\\.ccompiler\\.new_compiler\\(\\)") -- 2.14.1 ----Next_Part(Sun_Oct__1_14_44_04_2017_224)---- From unknown Fri Jun 13 11:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2017 06:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28660 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thomas Danckaert Cc: 28660@debbugs.gnu.org Received: via spool by 28660-submit@debbugs.gnu.org id=B28660.15070986511292 (code B ref 28660); Wed, 04 Oct 2017 06:31:01 +0000 Received: (at 28660) by debbugs.gnu.org; 4 Oct 2017 06:30:51 +0000 Received: from localhost ([127.0.0.1]:47286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzdCl-0000Km-CK for submit@debbugs.gnu.org; Wed, 04 Oct 2017 02:30:51 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:48292 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzdCk-0000Kf-8p for 28660@debbugs.gnu.org; Wed, 04 Oct 2017 02:30:50 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 92EAA13E653; Wed, 4 Oct 2017 07:30:49 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 5546613E652; Wed, 4 Oct 2017 07:30:49 +0100 (BST) Date: Wed, 4 Oct 2017 07:30:48 +0100 From: Christopher Baines Message-ID: <20171004073048.1187465b@cbaines.net> In-Reply-To: <20171001.144404.698351802734865623.post@thomasdanckaert.be> References: <20171001.144404.698351802734865623.post@thomasdanckaert.be> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/_jmNpOO3ncg33Tx=J=HdMnR"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/_jmNpOO3ncg33Tx=J=HdMnR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 01 Oct 2017 14:44:04 +0200 (CEST) Thomas Danckaert wrote: > Hi Guix, >=20 > I slightly botched the last numpy update: setting $SHELL works, but=20 > then we have to set $SHELL for every package which uses numpy's=20 > distutils. I don't know how many packages there are, but it includes=20 > scipy and python-hdf (and therefore those builds are currently broken=20 > on master...). >=20 > The attached patch should fix the issue for all packages, by setting=20 > the default shell to the =E2=80=9C/bin/sh=E2=80=9D of the build environme= nt's bash=20 > package (i.e. bash-minimal). Could bash be specified as an input, and that used instead? This would mean that the behaviour of the package is more isolated from the environment. For example, on non GuixSD systems, /bin/sh could be something other than bash. But, if the numpy package depends on some bash in the store, and uses that, then it would be isolated from this. What do you think? --Sig_/_jmNpOO3ncg33Tx=J=HdMnR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnUgBhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcU7g//XoiEEA5ueJqiTVCOoMA+t30/s9Ncur0oGAOfc/Hjmj9M1YW8TRwEQHZd pCzHcxQQxyKV4wIyCZ5OAM5B6eJoe9pJ9L1ZaRom4BGZ2BQe9GKA9tyhKTZJ07w/ jew+A455lE3JEIiJwT0FMcfKzd8wBO3k8+PDH8w8VCpwHOG1+wUvBcXptp0wnMnm /mg+WcwwxwOac8TyWYABxlXONdIL4J0QlPN9kgpsrq7R3hG6xs5cI12Y6RCnBwiL cUzG8QaBhUXvyIZcK1NfU92ai1HykFPIotiS0AaScAxUj1CPx7XkVQc+U1pLqHeD E32lSqEtbkVgZ814pmYhTCa8zsZqRjtaf31KIqOn6w6r29iTe+DDOKcwfQXkksdn JcXt2zd6PBnZiL6oTWNNGretS0P9Ba97bHxFRXDlH9avr6RSa/Lu+NQAhDpyjNzd 1F6AgiZmCUxp7BJRdpahYOoVSfmf/vAhffLPgLj0Kf1VFb+Nza/tH4UPp1izTS1j SoWb+utzvf1xZcwsYxTFFxflq1rYBq8CgiqEiBhwwAt0Wmytr4+hDm83VCYpKW5c 66rlRyEVyoYkgnUV0zs8ERXv3wRqkYpzzkh4Am9wWSqG3uNZRar39bgVU2xGYtVF Lls/UrtUsV9S20UWfkVe/NIvtFCqPDHypdOPDpZuUqryrNFuPyU= =B1jR -----END PGP SIGNATURE----- --Sig_/_jmNpOO3ncg33Tx=J=HdMnR-- From unknown Fri Jun 13 11:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-From: Thomas Danckaert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2017 07:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28660 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: mail@cbaines.net Cc: 28660@debbugs.gnu.org Received: via spool by 28660-submit@debbugs.gnu.org id=B28660.15071006954909 (code B ref 28660); Wed, 04 Oct 2017 07:05:02 +0000 Received: (at 28660) by debbugs.gnu.org; 4 Oct 2017 07:04:55 +0000 Received: from localhost ([127.0.0.1]:47354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzdji-0001H6-Ut for submit@debbugs.gnu.org; Wed, 04 Oct 2017 03:04:55 -0400 Received: from s02-out2.spamexperts.axc.nl ([185.182.59.57]:56019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzdjh-0001Gp-EJ for 28660@debbugs.gnu.org; Wed, 04 Oct 2017 03:04:54 -0400 Received: from vserver42.axc.nl ([185.182.56.92]) by s02.spamexperts.axc.nl with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dzdjZ-0006Z1-00; Wed, 04 Oct 2017 09:04:45 +0200 Received: from mail.axc.nl ([185.182.56.42]:45676) by vserver42.axc.nl with esmtp (Exim 4.89) (envelope-from ) id 1dzdjY-0004mr-2Q; Wed, 04 Oct 2017 09:04:44 +0200 Date: Wed, 04 Oct 2017 09:04:36 +0200 (CEST) Message-Id: <20171004.090436.431865073991228123.post@thomasdanckaert.be> From: Thomas Danckaert In-Reply-To: <20171004073048.1187465b@cbaines.net> References: <20171001.144404.698351802734865623.post@thomasdanckaert.be> <20171004073048.1187465b@cbaines.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8; format=flowed Content-Transfer-Encoding: base64 PrimaryMX: Accepted email from trusted host. Hint: This skips spam scanning so make sure other host is not vulnerable X-Relay-Host: 185.182.56.42 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "vserver42.axc.nl", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Christopher Baines Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Date: Wed, 4 Oct 2017 07:30:48 +0100 > Could bash be specified as an input, and that used instead? This > would > mean that the behaviour of the package is more isolated from the > environment. [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- SpamTally: Final spam score: 0 X-Originating-IP: 185.182.56.92 X-SpamExperts-Domain: vserver42.axc.nl X-SpamExperts-Username: 185.182.56.92 Authentication-Results: spamexperts.axc.nl; auth=pass smtp.auth=185.182.56.92@vserver42.axc.nl X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.12) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5qpxLJhidLFyEcQJ1Io4feDj1g3/PwYZaTCzSym8uE9HT/za4xwq+4Za ykc6NwNfL8moriPWvEDbB0x4R+YMfbLCarlBjhjSGzDTulmVeXlwi/77mVkkLnpxqOrZwNHqf3oU TpVT87qq3OMdoXgxgvZQyacT2UA9FxLvxR5esQOY4jneRkI1RCzDXYkUSgaX44+5Mcw9mEkGnU4S C6mzTTJcL+MdujCjU5iV47di8pZylAtM3hMeyj3Qw/Sp3zuMaL3KvIJNaHrI6eGWO0FZh0hsmQyB sRL77VLkCKc6a6vT0TyXe6jsMXnTy/o9BuCfMVRiOdn9IcLputfMl/Yd+LC8B5kabb+8+DRlCqSx A333eGCH+SJjE48GzCqfGD0ud53+zxpzqXnGGiQ01PlGSKsJi5lucXozcAWJZZIdG3Z2VOtEHDFK mZKcB0WKucuGpwFR6SwDNBqJZIjKcNwtUeC1ebAKFz3BJlU8QXoFYzw/rSOIPpeqwlm2NDGXIJ2x 7Avp4H15BavZJFRpWeMv2PEt3VgudfMijk+e1MTUNDfyAqIQMeMQw2601pnjfaEuz1/oMiodnH11 pQHQYojNgP8arn5AvWF1NzzPisk+5HBaub9an0Kma+gIp/x48WfkxQICYjafINM6q87t0hXAhgOX pIJHpQIZgroF28rdBsTDD/7Rwl5fb+U9Gl2IOh9znrwhkdH3ZFpxh4PeCHWSC7rQ+XNr4QUyZNz0 uLvRKYxZPoi+cJUurnq+rm6atqTUoHGAbfM5QmIWS572r55Z3dKMCVyyvSJ0TnFKMS2DkUlVRzQG WLi35T7+KkoEvLoCMfhiIU+e4XLaYYaMQ4W62b3umnHcAUI0ZYAVrB+Y0zFKaH3dbQEF04t53UaO IVxkdfri0d1iJsWIPRN8vWBAD0pH8X/4CgA/xGClXBSPP6RaMS+4ayUpOtEhdxekWDmK9g== X-Report-Abuse-To: spam@s01.spamexperts.axc.nl X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) RnJvbTogQ2hyaXN0b3BoZXIgQmFpbmVzIDxtYWlsQGNiYWluZXMubmV0Pg0KU3ViamVjdDogUmU6 IFtidWcjMjg2NjBdIFtQQVRDSF0gZ251OiBweXRob24tbnVtcHk6IEdpdmUgc2ggc3RvcmUgDQps b2NhdGlvbiBpbnN0ZWFkIG9mIHNldHRpbmcgJFNIRUxMLg0KRGF0ZTogV2VkLCA0IE9jdCAyMDE3 IDA3OjMwOjQ4ICswMTAwDQoNCj4gQ291bGQgYmFzaCBiZSBzcGVjaWZpZWQgYXMgYW4gaW5wdXQs IGFuZCB0aGF0IHVzZWQgaW5zdGVhZD8gVGhpcyANCj4gd291bGQNCj4gbWVhbiB0aGF0IHRoZSBi ZWhhdmlvdXIgb2YgdGhlIHBhY2thZ2UgaXMgbW9yZSBpc29sYXRlZCBmcm9tIHRoZQ0KPiBlbnZp cm9ubWVudC4NCg0KU291bmRzIGdvb2QsIGJ1dCBJJ20gYWZyYWlkIEkgZG9uJ3QgdW5kZXJzdGFu ZCB3aGF0IHlvdSBtZWFuIChtYXliZSANCml0J3Mgc3RpbGwgdG9vIGVhcmx5IGluIHRoZSBtb3Ju aW5nKS4gIElmIHdlIGFkZCBhICJiYXNoIiB0byB0aGUgDQpwYWNrYWdlIGlucHV0cywgaXQgd2ls bCBzdGlsbCBjb21lIGZyb20gdGhlIHN0b3JlLiAgU28gcHJvYmFibHkgeW91IA0KbWVhbiBzb21l dGhpbmcgZWxzZSBieSDigJxzcGVjaWZpZWQgYXMgYW4gaW5wdXTigJ0/DQoNCj4gRm9yIGV4YW1w bGUsIG9uIG5vbiBHdWl4U0Qgc3lzdGVtcywgL2Jpbi9zaCBjb3VsZCBiZSBzb21ldGhpbmcgb3Ro ZXINCj4gdGhhbiBiYXNoLiBCdXQsIGlmIHRoZSBudW1weSBwYWNrYWdlIGRlcGVuZHMgb24gc29t ZSBiYXNoIGluIHRoZSANCj4gc3RvcmUsDQo+IGFuZCB1c2VzIHRoYXQsIHRoZW4gaXQgd291bGQg YmUgaXNvbGF0ZWQgZnJvbSB0aGlzLg0KDQpUaGF0J3MgdHJ1ZSwgdGhvdWdoIHVzZXJzIG9uIHN1 Y2ggc3lzdGVtcyBjb3VsZCBzZXQgJFNIRUxMIHRvIA0Kb3ZlcnJpZGUgdGhlIGRlZmF1bHQgb25l IGZyb20gdGhlIHN0b3JlLiAgQnV0IG1heWJlIGF2b2lkaW5nIGhhdmluZyANCnRvIGRvIHRoYXQg aXMgd2hhdCB5b3UgbWVhbiBieSDigJxtb3JlIGlzb2xhdGVkIGZyb20gdGhlIGVudmlyb25tZW50 4oCdPw0KDQpUaGUgc2hlbGwgaXMgdXNlZCBmb3IgdmVyeSBsaW1pdGVkIHB1cnBvc2VzIGFueXdh eSAoZXNzZW50aWFsbHkgdG8gDQpydW4gQyBhbmQgRm9ydHJhbiBjb21waWxlcnMgdG8gYnVpbGQg ZXh0ZW5zdGlvbnMsIEFGQUlVKSwgYnV0IEknbSANCmhhcHB5IHRvIGltcHJvdmUgdGhlIHBhdGNo IGlmIGl0J3MgdXNlZnVsLiAgSWYgeW91IGhhdmUgYSBzb2x1dGlvbiANCnRoYXQgYWxsb3dzIHVz ZXJzIHRvIHVzZSB0aGVpciBvd24gL2Jpbi9zaCBpZiB0aGV5IHdhbnQsIGJ1dCBzdGlsbCANCndv cmtzIGZvciBhbGwgYnVpbGRzIG9mIGRlcGVuZGVudCBwYWNrYWdlcyBvbiBHdWl4LCBwbGVhc2Ug ZXhwbGFpbiA6LSkNCg0KVGhvbWFzDQo= From unknown Fri Jun 13 11:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2017 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28660 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thomas Danckaert Cc: 28660@debbugs.gnu.org Received: via spool by 28660-submit@debbugs.gnu.org id=B28660.15071033929711 (code B ref 28660); Wed, 04 Oct 2017 07:50:02 +0000 Received: (at 28660) by debbugs.gnu.org; 4 Oct 2017 07:49:52 +0000 Received: from localhost ([127.0.0.1]:47408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzeRE-0002WX-GZ for submit@debbugs.gnu.org; Wed, 04 Oct 2017 03:49:52 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:48394 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzeRC-0002WO-8z for 28660@debbugs.gnu.org; Wed, 04 Oct 2017 03:49:51 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 0E8F213E655; Wed, 4 Oct 2017 08:49:48 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id B349313E654; Wed, 4 Oct 2017 08:49:47 +0100 (BST) Date: Wed, 4 Oct 2017 08:49:44 +0100 From: Christopher Baines Message-ID: <20171004084944.16af59c8@cbaines.net> In-Reply-To: <20171004.090436.431865073991228123.post@thomasdanckaert.be> References: <20171001.144404.698351802734865623.post@thomasdanckaert.be> <20171004073048.1187465b@cbaines.net> <20171004.090436.431865073991228123.post@thomasdanckaert.be> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/UfDuSVxH8+wWiIjKk1pghlD"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/UfDuSVxH8+wWiIjKk1pghlD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 04 Oct 2017 09:04:36 +0200 (CEST) Thomas Danckaert wrote: > From: Christopher Baines > Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store=20 > location instead of setting $SHELL. > Date: Wed, 4 Oct 2017 07:30:48 +0100 >=20 > > Could bash be specified as an input, and that used instead? This=20 > > would > > mean that the behaviour of the package is more isolated from the > > environment. =20 >=20 > Sounds good, but I'm afraid I don't understand what you mean (maybe=20 > it's still too early in the morning). If we add a "bash" to the=20 > package inputs, it will still come from the store. So probably you=20 > mean something else by =E2=80=9Cspecified as an input=E2=80=9D? >=20 > > For example, on non GuixSD systems, /bin/sh could be something other > > than bash. But, if the numpy package depends on some bash in the=20 > > store, > > and uses that, then it would be isolated from this. =20 >=20 > That's true, though users on such systems could set $SHELL to=20 > override the default one from the store. But maybe avoiding having=20 > to do that is what you mean by =E2=80=9Cmore isolated from the environmen= t=E2=80=9D? >=20 > The shell is used for very limited purposes anyway (essentially to=20 > run C and Fortran compilers to build extenstions, AFAIU), but I'm=20 > happy to improve the patch if it's useful. If you have a solution=20 > that allows users to use their own /bin/sh if they want, but still=20 > works for all builds of dependent packages on Guix, please explain :-) Sorry Thomas, ignore what I originally said. I thought from reading the patch that this was patching numpy to use /bin/sh . Now after building it and looking at the resulting files, I can see that it makes the default use bash from the store [1]. Which was exactly what I was suggesting, but you were already doing that. With this new, hopefully more correct interpretation, this patch looks fine to me :) 1:=20 sh =3D os.environ.get('SHELL', '/gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn= -bash-minimal-4.4.12/bin/sh') --Sig_/UfDuSVxH8+wWiIjKk1pghlD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnUkphfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XePhxAAn6uJ3ZH8K2hfy8RfDkHZFiN7daQzr6VhF4gvHIqBOZE5VMZ+wAQnQuOP rhwpbiQYdL3Z10heu21R8xEfW92eRVGgoAqL6LCNN5FbMxtujYpXJnD3mJw0PIXr RdeGVQ7BgJExpP762nK5exACu2cSWrgPwFJ+cg/ZYpIZTSeOKTkplaYAtoGnGsHl t9ksmUh6RFcIgxUpvgNj/cuezCWF32YJFTFvFxU3Wa+SjzBiLOqeS/H/4oE1CiYx Sfs3C3JeSwweOePederBTTfieDAzhExEG5fPX19LJXjpqj4vm0vyQ4W5clNcLGlH xQpm7jbHgdQwCqparTF9ko08u2UdCYe4g7HaVCXFM5Ojp9/g1ARRv31ZjGZMRWxg NN68qfX5i/q7LPoCsH9T2tDDpGBCCGSh4hhxzOt/COYwbqeZ0wOHMtPxdZ3rAShm OjJNn+0lc+sLLTi+FzHHbxyWmZwHZd1nrMtbWmmO/+mj2bGlE7nbAXJda6AL0y2B ISRFMQ4hPf2xijNr/TSr8Bo1LmJYRDsoKCLxwmutsKxRtZO8kmKYS3vUhxSGSFzU jWZ2BMrBqYX4ZfIgwohSgkpdzKZkd+csCsJFnGSJymI//8qLIZ7D7jMw885+dBNw dLO545nFOmao2e/Hq6rLQNH0FSVEtUt+VMeQE0D1/HBFPvtMfz8= =Zwpp -----END PGP SIGNATURE----- --Sig_/UfDuSVxH8+wWiIjKk1pghlD-- From unknown Fri Jun 13 11:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Resent-From: Thomas Danckaert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2017 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28660 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: mail@cbaines.net, 28660-done@debbugs.gnu.org Cc: 28660@debbugs.gnu.org Received: via spool by 28660-submit@debbugs.gnu.org id=B28660.150711916917819 (code B ref 28660); Wed, 04 Oct 2017 12:13:02 +0000 Received: (at 28660) by debbugs.gnu.org; 4 Oct 2017 12:12:49 +0000 Received: from localhost ([127.0.0.1]:47695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dziXg-0004dG-SK for submit@debbugs.gnu.org; Wed, 04 Oct 2017 08:12:49 -0400 Received: from s02-out2.spamexperts.axc.nl ([185.182.59.57]:45177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dziXe-0004cx-Tz; Wed, 04 Oct 2017 08:12:47 -0400 Received: from vserver42.axc.nl ([185.182.56.92]) by s02.spamexperts.axc.nl with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dziXX-0007TJ-Qg; Wed, 04 Oct 2017 14:12:40 +0200 Received: from mail.axc.nl ([185.182.56.42]:50730) by vserver42.axc.nl with esmtp (Exim 4.89) (envelope-from ) id 1dziXV-0005fU-U1; Wed, 04 Oct 2017 14:12:39 +0200 Date: Wed, 04 Oct 2017 14:12:27 +0200 (CEST) Message-Id: <20171004.141227.1558332285266180058.post@thomasdanckaert.be> From: Thomas Danckaert In-Reply-To: <20171004084944.16af59c8@cbaines.net> References: <20171004073048.1187465b@cbaines.net> <20171004.090436.431865073991228123.post@thomasdanckaert.be> <20171004084944.16af59c8@cbaines.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit PrimaryMX: Accepted email from trusted host. Hint: This skips spam scanning so make sure other host is not vulnerable X-Relay-Host: 185.182.56.42 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "vserver42.axc.nl", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Christopher Baines Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Date: Wed, 4 Oct 2017 08:49:44 +0100 > Sorry Thomas, ignore what I originally said. I thought from reading > the > patch that this was patching numpy to use /bin/sh . Now after > building > it and looking at the resulting files, I can see that it makes the > default use bash from the store. Which was exactly what I was > suggesting, but you were already doing that. > > With this new, hopefully more correct interpretation, this patch > looks > fine to me :) [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: cbaines.net] SpamTally: Final spam score: 0 X-Originating-IP: 185.182.56.92 X-SpamExperts-Domain: vserver42.axc.nl X-SpamExperts-Username: 185.182.56.92 Authentication-Results: spamexperts.axc.nl; auth=pass smtp.auth=185.182.56.92@vserver42.axc.nl X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.05) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5jy8O9qhH6QRafSi272D8qbj1g3/PwYZaTCzSym8uE9HT/za4xwq+4Za ykc6NwNfL3kti8CYg6obIPeoF5RliRpi8wWc+4yCPv0u8PqCFiEnn2vuMZuydGkg5F/3OTaQDwCh 0tTuvoTMkBP4Q3HgGNo+nP92pR3RdPRPak3D0DRcWmuNA8WTybi1JN85FSnfKSMZ6S3yLR82tVTs c5PeRF2y945Y5z9LWGL56e9OF6CAO2g5Y7baeqbbFbMMoF/W9XnuTx4hclXbDLLP7h3yhbm35Ma3 az/bh+xFmgErgr3pWSX3N+sR6ZiujabTPYhDRXuEOX5X+aI07tQv+JNpJZkn7bB5bp6MFPZxaDQ+ O9lvh7P0Jc/Bj5eeJZ8DGbEjFxP6rjSqgKC+fycfgESqsYwDuONzMRaL3IMJceeVmuMY+GQ66azi oBnt+leQ7P/PJdK3qYI+68f9rNp1861lQp4BXtD10+3+aA6m3yQ23IEcXcuEycSx+af23KjB0JNm Z3xcJx3KGCdv408zIIx2WE/onV+E7OMXRvgtdyMlnmWiX+8W3cpgWFZpkIMdqWyi2pezsB0Ocd/l YVH1foUBsjbhYgWljIbCImq8KEJ8+tJCKyc5td7jUYuCeOzfB+Whic/26TsInExS9+UKvGXzmaqk ZPHPElGKHhRXg91665Y4aE/mhG5WKUAw5PZpcWEdj8VmlD4c+akrufRlUEOMEr3JaFyBVUCjPxNU lsSRfx6t72rRW+Xh69lOb5KGbEqM0Vz1pRXWhjh9fdbl44I0Df1YudFHUtMqSKllAK/gP64FXHu/ rN+KkWLTSVdjrE6p81biYFn5RrktxCqpjYQlOmUlaWn1Y8qDhps02rzs6ZU0pDlLGcickW+v6n18 gZqGBVTrRBwxSpmSnAdFirnLhqdeoZeWARMTSI3tydol3KVpchCgit44KZ3RKCQu8YjAbjQRwE5U siSDOk5McDyDxWM= X-Report-Abuse-To: spam@s01.spamexperts.axc.nl X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) From: Christopher Baines Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Date: Wed, 4 Oct 2017 08:49:44 +0100 > Sorry Thomas, ignore what I originally said. I thought from reading > the > patch that this was patching numpy to use /bin/sh . Now after > building > it and looking at the resulting files, I can see that it makes the > default use bash from the store. Which was exactly what I was > suggesting, but you were already doing that. > > With this new, hopefully more correct interpretation, this patch > looks > fine to me :) Yes, that's the purpose exactly :) I've slightly reworded the commit message & comment to hopefully make it less confusing, and pushed. Thanks for taking a look! Thomas From unknown Fri Jun 13 11:18:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thomas Danckaert Subject: bug#28660: closed (Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL.) Message-ID: References: <20171004.141227.1558332285266180058.post@thomasdanckaert.be> <20171001.144404.698351802734865623.post@thomasdanckaert.be> X-Gnu-PR-Message: they-closed 28660 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28660@debbugs.gnu.org Date: Wed, 04 Oct 2017 12:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1507119182-17853-1" This is a multi-part message in MIME format... ------------=_1507119182-17853-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28660: [PATCH] gnu: python-numpy: Give sh store location instead of settin= g $SHELL. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28660@debbugs.gnu.org. --=20 28660: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28660 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1507119182-17853-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28660-done) by debbugs.gnu.org; 4 Oct 2017 12:12:48 +0000 Received: from localhost ([127.0.0.1]:47693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dziXg-0004dE-Kp for submit@debbugs.gnu.org; Wed, 04 Oct 2017 08:12:48 -0400 Received: from s02-out2.spamexperts.axc.nl ([185.182.59.57]:45177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dziXe-0004cx-Tz; Wed, 04 Oct 2017 08:12:47 -0400 Received: from vserver42.axc.nl ([185.182.56.92]) by s02.spamexperts.axc.nl with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dziXX-0007TJ-Qg; Wed, 04 Oct 2017 14:12:40 +0200 Received: from mail.axc.nl ([185.182.56.42]:50730) by vserver42.axc.nl with esmtp (Exim 4.89) (envelope-from ) id 1dziXV-0005fU-U1; Wed, 04 Oct 2017 14:12:39 +0200 Date: Wed, 04 Oct 2017 14:12:27 +0200 (CEST) Message-Id: <20171004.141227.1558332285266180058.post@thomasdanckaert.be> To: mail@cbaines.net, 28660-done@debbugs.gnu.org Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. From: Thomas Danckaert In-Reply-To: <20171004084944.16af59c8@cbaines.net> References: <20171004073048.1187465b@cbaines.net> <20171004.090436.431865073991228123.post@thomasdanckaert.be> <20171004084944.16af59c8@cbaines.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit PrimaryMX: Accepted email from trusted host. Hint: This skips spam scanning so make sure other host is not vulnerable X-Relay-Host: 185.182.56.42 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "vserver42.axc.nl", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Christopher Baines Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Date: Wed, 4 Oct 2017 08:49:44 +0100 > Sorry Thomas, ignore what I originally said. I thought from reading > the > patch that this was patching numpy to use /bin/sh . Now after > building > it and looking at the resulting files, I can see that it makes the > default use bash from the store. Which was exactly what I was > suggesting, but you were already doing that. > > With this new, hopefully more correct interpretation, this patch > looks > fine to me :) [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: cbaines.net] SpamTally: Final spam score: 0 X-Originating-IP: 185.182.56.92 X-SpamExperts-Domain: vserver42.axc.nl X-SpamExperts-Username: 185.182.56.92 Authentication-Results: spamexperts.axc.nl; auth=pass smtp.auth=185.182.56.92@vserver42.axc.nl X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.05) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5jy8O9qhH6QRafSi272D8qbj1g3/PwYZaTCzSym8uE9HT/za4xwq+4Za ykc6NwNfL3kti8CYg6obIPeoF5RliRpi8wWc+4yCPv0u8PqCFiEnn2vuMZuydGkg5F/3OTaQDwCh 0tTuvoTMkBP4Q3HgGNo+nP92pR3RdPRPak3D0DRcWmuNA8WTybi1JN85FSnfKSMZ6S3yLR82tVTs c5PeRF2y945Y5z9LWGL56e9OF6CAO2g5Y7baeqbbFbMMoF/W9XnuTx4hclXbDLLP7h3yhbm35Ma3 az/bh+xFmgErgr3pWSX3N+sR6ZiujabTPYhDRXuEOX5X+aI07tQv+JNpJZkn7bB5bp6MFPZxaDQ+ O9lvh7P0Jc/Bj5eeJZ8DGbEjFxP6rjSqgKC+fycfgESqsYwDuONzMRaL3IMJceeVmuMY+GQ66azi oBnt+leQ7P/PJdK3qYI+68f9rNp1861lQp4BXtD10+3+aA6m3yQ23IEcXcuEycSx+af23KjB0JNm Z3xcJx3KGCdv408zIIx2WE/onV+E7OMXRvgtdyMlnmWiX+8W3cpgWFZpkIMdqWyi2pezsB0Ocd/l YVH1foUBsjbhYgWljIbCImq8KEJ8+tJCKyc5td7jUYuCeOzfB+Whic/26TsInExS9+UKvGXzmaqk ZPHPElGKHhRXg91665Y4aE/mhG5WKUAw5PZpcWEdj8VmlD4c+akrufRlUEOMEr3JaFyBVUCjPxNU lsSRfx6t72rRW+Xh69lOb5KGbEqM0Vz1pRXWhjh9fdbl44I0Df1YudFHUtMqSKllAK/gP64FXHu/ rN+KkWLTSVdjrE6p81biYFn5RrktxCqpjYQlOmUlaWn1Y8qDhps02rzs6ZU0pDlLGcickW+v6n18 gZqGBVTrRBwxSpmSnAdFirnLhqdeoZeWARMTSI3tydol3KVpchCgit44KZ3RKCQu8YjAbjQRwE5U siSDOk5McDyDxWM= X-Report-Abuse-To: spam@s01.spamexperts.axc.nl X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28660-done Cc: 28660@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) From: Christopher Baines Subject: Re: [bug#28660] [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. Date: Wed, 4 Oct 2017 08:49:44 +0100 > Sorry Thomas, ignore what I originally said. I thought from reading > the > patch that this was patching numpy to use /bin/sh . Now after > building > it and looking at the resulting files, I can see that it makes the > default use bash from the store. Which was exactly what I was > suggesting, but you were already doing that. > > With this new, hopefully more correct interpretation, this patch > looks > fine to me :) Yes, that's the purpose exactly :) I've slightly reworded the commit message & comment to hopefully make it less confusing, and pushed. Thanks for taking a look! Thomas ------------=_1507119182-17853-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Oct 2017 12:44:31 +0000 Received: from localhost ([127.0.0.1]:41817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dydbi-0006hA-NH for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dydbh-0006gv-IL for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dydbb-0003mt-HD for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34800) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dydbb-0003mU-E3 for submit@debbugs.gnu.org; Sun, 01 Oct 2017 08:44:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dydba-0002GE-5o for guix-patches@gnu.org; Sun, 01 Oct 2017 08:44:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dydbV-0003fs-4Q for guix-patches@gnu.org; Sun, 01 Oct 2017 08:44:22 -0400 Received: from s02-out3.spamexperts.axc.nl ([185.175.203.26]:48713) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dydbU-0003Xy-So for guix-patches@gnu.org; Sun, 01 Oct 2017 08:44:17 -0400 Received: from vserver42.axc.nl ([185.182.56.92]) by s02.spamexperts.axc.nl with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dydbL-00011G-Fd for guix-patches@gnu.org; Sun, 01 Oct 2017 14:44:08 +0200 Received: from mail.axc.nl ([185.182.56.42]:59272) by vserver42.axc.nl with esmtp (Exim 4.89) (envelope-from ) id 1dydbK-0006fZ-T7 for guix-patches@gnu.org; Sun, 01 Oct 2017 14:44:07 +0200 Date: Sun, 01 Oct 2017 14:44:04 +0200 (CEST) Message-Id: <20171001.144404.698351802734865623.post@thomasdanckaert.be> To: guix-patches@gnu.org Subject: [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. From: Thomas Danckaert X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Oct__1_14_44_04_2017_224)--" Content-Transfer-Encoding: 7bit PrimaryMX: Accepted email from trusted host. Hint: This skips spam scanning so make sure other host is not vulnerable X-Relay-Host: 185.182.56.42 SpamTally: Final spam score: 0 X-Originating-IP: 185.182.56.92 X-SpamExperts-Domain: vserver42.axc.nl X-SpamExperts-Username: 185.182.56.92 Authentication-Results: spamexperts.axc.nl; auth=pass smtp.auth=185.182.56.92@vserver42.axc.nl X-SpamExperts-Outgoing-Class: unsure X-SpamExperts-Outgoing-Evidence: Combined (0.30) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5v/IScWBpx3Hn1jArl/RLWUXv9krsgRhBn0ayn6qsUc7Uj/Ish2ZYyAn P2N0jR54boWpvChPF7njB1QaaRxKIJxWENu0Pea+RXSEc4ptxxWRvewkk6VwMLRpM4RHbNcD+lWv x4/5aan/L8AHYrKyAYNxkoVS3en1halL1LQpMACeBqrSizsMP2oaCFtE7vEM6fl6ZRsEfNMLJiIu aYwfhV6r7C0jzCIuxUC9ChcgeZyP+kJo6BlMeAD5U0UgS1og3TZypY1RI3AHog8az25j652lyR0C G1Ys+wMc1TxGZKd49BRWzyLsg7uBj5b+1OcCtva2gwQxdPFXgOEANkyHHYjk6Pnrj57pHasIWjxl 5VQahBN6Fcg3yxWjPLTpdkB5z4T+dVslWfb47s+i1ft+6O+PuTHMPZhJBp1OEgups00y6HPPLuOV zXiNlBYhGfdaOhRAKfWK48mqxd1pWN6R4o1KYgmMk9w/OkIlxo6TEpOpwYGX4o7w1Q52wqkyEyGN BtXw16oLNgXSCcFJXY2d34RMjblaO0Jo1v4tai8E8VPnTbGjAz4sti0XARAwX655k82QjEacgWQU QAfYdS6nDWALz2KSfkHL3KWc6oL+yKY7a65Mg8VCY43kDMgSby+RV1mxgUzuFDNYmxH6w09ayPJo vdtZWqAZORMyvHWzy5ReRhmtTkHoAnWWwwOQdPTQaYool8X0+BvzGRRfxR+ffyiFKHQVcWSisFP9 4cRKUzkuPiSXaBqIYGE3ufkRJnYNaxmfFdNz0VA789lQEMIJmZXK4u09LDa7EjgOj2efgrXtxuyl bpY4FQaSehMXhQ2FP26Wr5gJzUl/0jVvYBlgStyKkJZDFKDdyIGaPMjYq3NN9zRfF4dcYskuJHXf 6IoNdJ0e67MxsyuK+o7tZW1mXbo= X-Report-Abuse-To: spam@s01.spamexperts.axc.nl X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) ----Next_Part(Sun_Oct__1_14_44_04_2017_224)-- Content-Type: Text/Plain; charset=utf-8; format=flowed Content-Transfer-Encoding: base64 SGkgR3VpeCwNCg0KSSBzbGlnaHRseSBib3RjaGVkIHRoZSBsYXN0IG51bXB5IHVwZGF0ZTogc2V0 dGluZyAkU0hFTEwgd29ya3MsIGJ1dCANCnRoZW4gd2UgaGF2ZSB0byBzZXQgJFNIRUxMIGZvciBl dmVyeSBwYWNrYWdlIHdoaWNoIHVzZXMgbnVtcHkncyANCmRpc3R1dGlscy4gIEkgZG9uJ3Qga25v dyBob3cgbWFueSBwYWNrYWdlcyB0aGVyZSBhcmUsIGJ1dCBpdCBpbmNsdWRlcyANCnNjaXB5IGFu ZCBweXRob24taGRmIChhbmQgdGhlcmVmb3JlIHRob3NlIGJ1aWxkcyBhcmUgY3VycmVudGx5IGJy b2tlbiANCm9uIG1hc3Rlci4uLikuDQoNClRoZSBhdHRhY2hlZCBwYXRjaCBzaG91bGQgZml4IHRo ZSBpc3N1ZSBmb3IgYWxsIHBhY2thZ2VzLCBieSBzZXR0aW5nIA0KdGhlIGRlZmF1bHQgc2hlbGwg dG8gdGhlIOKAnC9iaW4vc2jigJ0gb2YgdGhlIGJ1aWxkIGVudmlyb25tZW50J3MgYmFzaCANCnBh Y2thZ2UgKGkuZS4gYmFzaC1taW5pbWFsKS4NCg0KVGhvbWFzDQo= ----Next_Part(Sun_Oct__1_14_44_04_2017_224)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gnu-python-numpy-Give-sh-store-location-instead-of-s.patch" >From cfaebf1b09c71585b5513629005e7cf3c5d17508 Mon Sep 17 00:00:00 2001 From: Thomas Danckaert Date: Sun, 1 Oct 2017 14:32:04 +0200 Subject: [PATCH] gnu: python-numpy: Give sh store location instead of setting $SHELL. * gnu/packages/python.scm (python-numpy): [arguments] Don't set $SHELL in the environment, but embed the location of bash as a default shell. Otherwise, we have to set $SHELL for every package which uses numpy's distutils. --- gnu/packages/python.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index e95c22de1..267715b0f 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -3742,8 +3742,6 @@ between language specification and implementation aspects.") (modify-phases %standard-phases (add-before 'build 'set-environment-variables (lambda* (#:key inputs #:allow-other-keys) - ;; numpy's distutils uses $SHELL to run external commands. - (setenv "SHELL" "bash") (call-with-output-file "site.cfg" (lambda (port) (format port @@ -3762,6 +3760,10 @@ include_dirs = ~a/include (assoc-ref inputs "openblas") (assoc-ref inputs "lapack") (assoc-ref inputs "lapack")))) + ;; Insert bash store location for default shell /bin/sh. + (substitute* "numpy/distutils/exec_command.py" + (("(os.environ.get\\('SHELL', ')(/bin/sh'\\))" match match-start match-end) + (string-append match-start (assoc-ref inputs "bash") match-end))) ;; Use "gcc" executable, not "cc". (substitute* "numpy/distutils/system_info.py" (("c = distutils\\.ccompiler\\.new_compiler\\(\\)") -- 2.14.1 ----Next_Part(Sun_Oct__1_14_44_04_2017_224)---- ------------=_1507119182-17853-1--