From unknown Mon Aug 18 14:21:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28637 <28637@debbugs.gnu.org> To: bug#28637 <28637@debbugs.gnu.org> Subject: Status: [PATCH] Display commit in package description, if available Reply-To: bug#28637 <28637@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:21:43 +0000 retitle 28637 [PATCH] Display commit in package description, if available reassign 28637 emacs submitter 28637 David Glasser severity 28637 wishlist tag 28637 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 19:23:40 2017 Received: (at submit) by debbugs.gnu.org; 28 Sep 2017 23:23:40 +0000 Received: from localhost ([127.0.0.1]:37271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxi9c-0006Jw-D7 for submit@debbugs.gnu.org; Thu, 28 Sep 2017 19:23:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxht2-0005uP-2S for submit@debbugs.gnu.org; Thu, 28 Sep 2017 19:06:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxhsv-0006qz-Mk for submit@debbugs.gnu.org; Thu, 28 Sep 2017 19:06:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37556) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxhsv-0006qn-Jx for submit@debbugs.gnu.org; Thu, 28 Sep 2017 19:06:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxhsu-0008Q7-Hx for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 19:06:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxhst-0006oM-Lv for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 19:06:24 -0400 Received: from mail-ua0-x232.google.com ([2607:f8b0:400c:c08::232]:56068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxhst-0006lm-GI for bug-gnu-emacs@gnu.org; Thu, 28 Sep 2017 19:06:23 -0400 Received: by mail-ua0-x232.google.com with SMTP id b11so204676uae.12 for ; Thu, 28 Sep 2017 16:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=KK3Jy4aDl28cDNhfTjkUHoQufAVB+T7KGUe121zYCfg=; b=tYwe488Jzr96gLxPa+8FHVJl/FMLEStkXaG7Tp+BykBuWfNEo4ZkHM3MDoMimFDhnq sd6I8lOJ4agXs5R8OOuYKHMkCNuHkiaku/rxDfbN1h1E4usXiioH8vvm6qivYxdLb3BQ wqwjOpQaQd7UU/naScM3k6wxDTAzoZhkivGkZye6TLRXvOOgxPNhc07RDqK0Rm1TiPL5 LzrtllS1w1mHlsfoOlN+qBOLsBeRmkJOPkfZM+zxD42kj/Am0OvTLVyhndGpLmWLMqQH ou5P05h4xRyevrqQ/RQnIw5SP/mXgWPeaMI3CBWm+Ac1OzQMNXGU4UHDgJAlAKN2wf14 LF5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=KK3Jy4aDl28cDNhfTjkUHoQufAVB+T7KGUe121zYCfg=; b=DtpzatMdWn9WqjEpP3CaltFhCQGoLPKhYIRyAf9DedkLQXJFA2J53GI/1jzMhE/9yc b6QQyn5FuRwdtPUhxHDa4OO0Vxhicg+vdap98YgNtVId4xImL/8UBeJCx+U4psKVCdRC 5VB3BCge3zXInruYG+TzbM9CGowaLz1ZuytwgHmom+M5a0bQ6rjPi1tXPZwarfPuA4Li PtNGeDlSzt9ZORUh1rX4eEkK9D5vBZwWoVRjA8XcSBVSeEt2zHhzw3SkJzvb/SYNGdz+ UFtmCN5dL2A8leFo7HSTs7McwbRFdnHOE0gJeTIKmr24rjVElqhOf05t9oUjuJlEATSt 3ptw== X-Gm-Message-State: AHPjjUjTezOLSdbJkIBitwGf0Ef7pQCIPg5NKpLpLFjAr1S/j0CClG+l Tp1ML7vOFZQCwptegEoLkAf85FBGLfVMCOWjsQrc1g== X-Google-Smtp-Source: AOwi7QCsXueHqUzPCAfM1EinxhLoThG12jMzwvLLmoh6TI9ESEWxsRgh+slSxwuxVR7zwfmEzMxVwcbOc/CDI6NjfO4= X-Received: by 10.176.94.175 with SMTP id y47mr3705933uag.95.1506639981174; Thu, 28 Sep 2017 16:06:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.89.175 with HTTP; Thu, 28 Sep 2017 16:06:00 -0700 (PDT) From: David Glasser Date: Thu, 28 Sep 2017 16:06:00 -0700 X-Google-Sender-Auth: NEaIOWDAyQ2KmPdIX-0Q7mUvbhE Message-ID: Subject: [PATCH] Display commit in package description, if available To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 28 Sep 2017 19:23:39 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) MELPA includes a :commit field in its packages (https://github.com/melpa/package-build/pull/6). You can use this to tell if MELPA has processed a recently-merged change. This commit adds that metadata to the package description buffer. * lisp/emacs-lisp/package.el: Display commit in package description --- lisp/emacs-lisp/package.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 8b101c1323..dd05c70dc8 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2260,6 +2260,7 @@ Otherwise no newline is inserted." (archive (if desc (package-desc-archive desc))) (extras (and desc (package-desc-extras desc))) (homepage (cdr (assoc :url extras))) + (commit (cdr (assoc :commit extras))) (keywords (if desc (package-desc--keywords desc))) (built-in (eq pkg-dir 'builtin)) (installable (and archive (not built-in))) @@ -2332,6 +2333,8 @@ Otherwise no newline is inserted." (and version (package--print-help-section "Version" (package-version-join version))) + (when commit + (package--print-help-section "Commit" commit)) (when desc (package--print-help-section "Summary" (package-desc-summary desc))) -- 2.14.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 15:36:28 2017 Received: (at 28637) by debbugs.gnu.org; 10 Oct 2017 19:36:28 +0000 Received: from localhost ([127.0.0.1]:60951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e20KK-0006RZ-GX for submit@debbugs.gnu.org; Tue, 10 Oct 2017 15:36:28 -0400 Received: from mail-vk0-f41.google.com ([209.85.213.41]:48976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e20KH-0006RE-27 for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 15:36:25 -0400 Received: by mail-vk0-f41.google.com with SMTP id g69so14953348vke.5 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 12:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=RpTcHnMWKW45z5camjRAtiToQktJxgP+wpjJmQaAQKw=; b=LknSD6dLMTz4AMeXxcQtEI1V5EtiruePO6pO4oIrhKG5NqrbdJFaD0KyCohzGmaHii BeYEkVNycTZ+3WyXHQSWXpGzjFGZJ7OXo/3b6Ts1Nn68CstU1vtc53gyiT0iN8sq1c3/ LCwkAoRuwjXygJ4s4UiuaK3Aoecn2d+nvfxgDmKNuV0dNShizeQvXE1HX6qTpEiVkDsX bxzAyw0WAMsI0yUupPikc67qEwpaZQt8U4AkZgwI62R8e1WPgurZ/QqRO8zep7eBsZOU 9PV3uxSlOSzfva8qYqurnujYgW5grrVQVahYYeAHE6SplQigFbTmquvNkCXmVcBPAq0q OE8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=RpTcHnMWKW45z5camjRAtiToQktJxgP+wpjJmQaAQKw=; b=hWr5HqfoDRpLw1MMUuCkMuug/dCJal5UH97d/7isEcOKrJSE9nZofS/bnVhc+Pj6a6 2t9M2U09c812IuwGJAY3fZSaMJnlBK775IBWLX87jqimxm3emiRVtENgZvDJdI2SgIOs Ihei2R6jhULvtuFUBuZQiQrr6HFaR8l8CnITRDNRaoUfZMCt/m8k/O/QdnFyAw63qQaR bycMCA2Uy3hD7B3giASqjCJxbIbzKOz1shmotXaaxtJbE8odOFlUmxm15wlXcV4STxR9 BnGXMprDcVQJj3BevV09pM+rcHcvu7L9aMbeLw4TN+/dMQEofqrwQL/op43eCLd2e391 GTrQ== X-Gm-Message-State: AMCzsaU2rDOh0Vk2aUuF3+jtFT0+ZZwW//cUS6u+kTl2kNji/PxGlBBt qNn9kZwABwLwb/du7gJouQ+nd/tkepALdf0Jp2oVTg== X-Google-Smtp-Source: AOwi7QA6CiFZX+oKiebtkNq04mp9F94i8gE6lgVLonJGKotS6rRbTaGsQKoz1+OkO4xC8euE7pjLaS7sSOO2C0vkXes= X-Received: by 10.31.87.195 with SMTP id l186mr7246680vkb.179.1507664179179; Tue, 10 Oct 2017 12:36:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.0.106 with HTTP; Tue, 10 Oct 2017 12:35:58 -0700 (PDT) From: David Glasser Date: Tue, 10 Oct 2017 12:35:58 -0700 X-Google-Sender-Auth: 0GXBsrVGWHwjclAOkUEtd-Axmwg Message-ID: Subject: Display commit in package description, if available To: 28637@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28637 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Can I confirm that this went through successfully? Should I be bringing up this patch on a different email list? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 16:07:39 2017 Received: (at 28637) by debbugs.gnu.org; 10 Oct 2017 20:07:40 +0000 Received: from localhost ([127.0.0.1]:60973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e20oV-0007F0-Or for submit@debbugs.gnu.org; Tue, 10 Oct 2017 16:07:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e20oV-0007En-8c for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 16:07:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e20oN-0007dU-1D for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 16:07:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e20oM-0007dA-Uc; Tue, 10 Oct 2017 16:07:30 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2706 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e20oL-0001HI-Md; Tue, 10 Oct 2017 16:07:30 -0400 Date: Tue, 10 Oct 2017 23:07:12 +0300 Message-Id: <838tgipy1b.fsf@gnu.org> From: Eli Zaretskii To: David Glasser In-reply-to: (message from David Glasser on Tue, 10 Oct 2017 12:35:58 -0700) Subject: Re: bug#28637: Display commit in package description, if available References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28637 Cc: 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: David Glasser > Date: Tue, 10 Oct 2017 12:35:58 -0700 > > Can I confirm that this went through successfully? AFAICT, no one has reviewed this yet. > Should I be bringing up this patch on a different email list? This is the right place, just keep pinging until the patch is reviewed. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 18:06:09 2017 Received: (at 28637) by debbugs.gnu.org; 10 Oct 2017 22:06:09 +0000 Received: from localhost ([127.0.0.1]:32795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e22fB-0001il-5O for submit@debbugs.gnu.org; Tue, 10 Oct 2017 18:06:09 -0400 Received: from mail-vk0-f44.google.com ([209.85.213.44]:49354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e22f9-0001iZ-DP for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 18:06:07 -0400 Received: by mail-vk0-f44.google.com with SMTP id h191so15181533vke.6 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 15:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=IxbGMkgGAJAStGI1rE1C5F2dUhsMgz/Oml24FnUvclI=; b=bQNEyhaSK9+rAkHIQAvWFzidt9/ySUfUMzCSmgKZQDJtRk8RU4hp92EyXV4+0nL/iN nz/YsYRT/yMN6XWhBkCGYuxmsFru1BFmzEl1bs7LQ4J4ruo6YTWZ0tiZU0Cx42q2YDNP 5rR7PFylpOkAyC5QtPo6mNLwoy2mWU7zgB+4QELDulXY3+UB/4m0o1ADrDeyNLeDHb4v t07XGcoJtcfjOpOCdmD0mp0og4j1jIJMcWj0QSPUruxw0d5af8y4dM2QLhjASHw+0ZIG j7C9ITtcgNo07t/onuyzbrAqm3pmL7tnfYcWtYZWjlosTH1JsGDGgwnh+pHG6ZXZyTU+ 7KRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=IxbGMkgGAJAStGI1rE1C5F2dUhsMgz/Oml24FnUvclI=; b=mulr3PC/1gO+doDPEk6tgTn5y2TYe5FfDC21Dfvz+/2EDhw9p1KPsvgq+BYqOiPK9U 6L+lkCmkkhBi1gEiX0r+wwZCKBGVArJyEJZ/p47hbEpoGxPUBgLHL4dJ0W87MQsG4WeD o0zr+Wsjo4U/YeGfpxczRtdL1V1pREFroexuYG9TWA0p8rogU3JtNtmH2WAZr/LvX9Eh dF6VGjLSjrBUDzaD1PTUP+hg2d0zhKduo5SqWFIJaz5M5DXU7/MYBwn61ObN2LXf8E+2 16C3h7RJt+pnzz4SPDUgD+DUwy8bNuEzUr0EtsMvpKO30kW3GzmcoNRFvmAz4SYJ3RmQ Dufw== X-Gm-Message-State: AMCzsaVByJIznYtcQj/IJ20iw5BC31rxAOw7Sie3jN46NjdG0NaF7yLh wsPhJXMGUrJ+ruuPX5dpHC3jE2MUnd+V92EHB80= X-Google-Smtp-Source: AOwi7QAzsvcP8sKvey1/H14Jedju6ycYoZ3z0YfPfHQrUoCtVJm96NiDb0ZnbVgj6H6opbtTnElxWHu4o0sWfMF1BWc= X-Received: by 10.31.61.14 with SMTP id k14mr1820464vka.18.1507673161826; Tue, 10 Oct 2017 15:06:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.0.106 with HTTP; Tue, 10 Oct 2017 15:05:41 -0700 (PDT) In-Reply-To: <838tgipy1b.fsf@gnu.org> References: <838tgipy1b.fsf@gnu.org> From: David Glasser Date: Tue, 10 Oct 2017 15:05:41 -0700 X-Google-Sender-Auth: OnaJsA-I7Iqrg1jVoqDd13J900M Message-ID: Subject: Re: bug#28637: Display commit in package description, if available To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 28637 Cc: 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) OK, sure! I think this is a pretty minimal-impact change which makes the experience of using melpa a lot better. I frequently send PRs to packages that I fetch via melpa, and once I get the "merged" notification, I want to be able to tell whether or not my change is available in the melpa build. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 18:40:45 2017 Received: (at 28637) by debbugs.gnu.org; 10 Oct 2017 22:40:45 +0000 Received: from localhost ([127.0.0.1]:32815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e23Cf-0004Q7-6b for submit@debbugs.gnu.org; Tue, 10 Oct 2017 18:40:45 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:47033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e23Cd-0004Pv-B1 for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 18:40:43 -0400 Received: by mail-it0-f43.google.com with SMTP id f187so622213itb.1 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 15:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RebzV/Ya5S/LZzPh2uJc5fhzYSQiL1zUbC/pFh50wH0=; b=OH0R+l5rxEmeUMhj/0Uy7NA84YFVeDBXUbl4FG4DS4kp68huM2TIc5X25uCPMSB2Ta RNxBJJblwTbabmh0jRJW8WfeWMEuq61joDPeFLn3jnDk+577NAUHFCX2qANiEcnTXRkC rJvq7gAc0gGyivFwPLUIDuFDyxGSBs9zT9Qk6G0dMxGpG+whblmjf/zcy7Q5DC8ehDMe 1519Na42cQpKxEw4UJDVJqoaQVuIWSxoUWzJMsEfF66GFZH+YmjI3AewOIm8WjqzJxcq UGxdeH+bf5/okPfMdPsBum/MRcfjmwqcyN6wikTW96lH2VKUuVxMnr5R2r9MgeXTw/pU I5mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=RebzV/Ya5S/LZzPh2uJc5fhzYSQiL1zUbC/pFh50wH0=; b=CibmMFSRdEKxAG44lC6M/ROTYX0uGLmyzGBcxCD5qqV+cHRtuBUf1CuR6MvHVfdxUf L6ojLCFLsQ8lz6Q63Sr5+pqWCJgKLX6rU/sw9HuAwMXUdRgkxTgehQGPlhzms6QfCsDg mkPg8jp0GSB6gr76q52bwDckiAx0Lfg9mjW3OLpy+StQ3FMr7uJbDqKcaGm4ZrL6AppK SUeK1Kzffb5TkWFVRk9jXncHhOiCFfo7pTyf/qnQ0ylSHWTgn51W2baV/sfrru3/3g95 PUXhz1TLHQd9Z37iDfIluuZTjcLIRLGcsKrlfvVZMEvR5/3OKiHN8LZA5z7mKC6/ev/K u+/Q== X-Gm-Message-State: AMCzsaXxX+3ifHjar0K3o6SBr8Ftu2ONAJDMKFADZxzMU+of96qsMU80 b0O0VoYs4f4ststXFeXbHIdRGg== X-Google-Smtp-Source: AOwi7QDJ/HPZ3ytHfxA5U2tAP3ZA84c6gwT1pauVVcUEsZuWS1gMeUqWFsOzQZHPK7xqcFCFeQePRw== X-Received: by 10.36.169.77 with SMTP id x13mr20630605iti.143.1507675237461; Tue, 10 Oct 2017 15:40:37 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e89sm3594660itd.3.2017.10.10.15.40.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 15:40:35 -0700 (PDT) From: Noam Postavsky To: David Glasser Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: Date: Tue, 10 Oct 2017 18:40:34 -0400 In-Reply-To: (David Glasser's message of "Thu, 28 Sep 2017 16:06:00 -0700") Message-ID: <874lr6d3tp.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28637 Cc: 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) David Glasser writes: > MELPA includes a :commit field in its > packages (https://github.com/melpa/package-build/pull/6). You can use > this to tell if MELPA has processed a recently-merged change. This > commit adds that metadata to the package description buffer. Code looks fine, but could you post a "before and after" picture please? I'm wondering if it might make sense to abbreviate the hash. > * lisp/emacs-lisp/package.el: Display commit in package description I think you should have a period at the end of sentence though. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 18:47:22 2017 Received: (at 28637) by debbugs.gnu.org; 10 Oct 2017 22:47:22 +0000 Received: from localhost ([127.0.0.1]:32819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e23J3-0004aW-TY for submit@debbugs.gnu.org; Tue, 10 Oct 2017 18:47:22 -0400 Received: from mail-ua0-f171.google.com ([209.85.217.171]:53826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e23J2-0004aH-45 for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 18:47:20 -0400 Received: by mail-ua0-f171.google.com with SMTP id s41so30306uab.10 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 15:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lFGlAQc1zLbQEqt0RWrC1h/r8TWrKcJby91ouYJ1sV4=; b=ev7U2ZNoyW7FEBGu8b3FJZWNSC4pRlxhZSrzKEtg17cDozR/mQNZNkVusZjLW9myuz pIsDmNhvRjZ0i7KOr//ExspHr7zLdi8LRjBTzMowZ4juzd3LfP0jH9BDdesG2qwMJQbC WuBfCAcJnVVnDYE1rAZWYrTIwZXepN/dpE3JwsMNDzo69EyQI0i+xxCuJhqUoQokrJci Gt8mz11Or4p/3BagCoftSgL66wmO/mIZlqUneEEKrTNckJMw+C0nK4I8XMosvASBhXv1 nObcAYGlM69NfAAD+OpgU9z0jiaVXAHt/GsUZyl3Sk+HCm0uuj1EKjd+3UL/NcnUz67a K6gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lFGlAQc1zLbQEqt0RWrC1h/r8TWrKcJby91ouYJ1sV4=; b=LaOLRa2zQMFGnoGpOmh+gzV2xZTAwnsk7k3cSn7tsuONUbU4NUPc1HW2B6V5w5jaSy /dVMDIWy/THd7yTknWqYpa5a1oVEr1rPdXPXri8JjyV0G5DmjIPFajgawviQxuydt7UC o9EwFRuezHTOxAI3cezDi1wrbxKWQ4U4folG4w3L/hIEg7lbaHrttesY2fSXNGzwoET+ NGMxhRvdxvWks1kUSZbGHvC+B8ixpq6WVeeK7FlocCpGhkoLDsOaPofekLaCa/F72iP9 gl5PFs1UEEq+/2rgVHyy3iiiKA9F/s8HvUtn+jD6LyazOsnlwbgYVxlmEgU9TCt/PWVN JQPA== X-Gm-Message-State: AMCzsaVH+8+FeP+VHWMEJlx3CfTjninDT5kPT2h573hPBGJGkU71Wo8t BOG7DVzr8NQAQOPszP5tHSh3tv5lBqga4wNM0nQ= X-Google-Smtp-Source: AOwi7QDEW7w3zLuK0uxNu/E8izIG7KANQ28cVGht3fMDUvFRBOIDZS8O7tzDaNPpMNAyDrDMgLmPbBe5b+ScKkTHxFI= X-Received: by 10.176.91.15 with SMTP id u15mr5454167uae.77.1507675634351; Tue, 10 Oct 2017 15:47:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.0.106 with HTTP; Tue, 10 Oct 2017 15:46:53 -0700 (PDT) In-Reply-To: <874lr6d3tp.fsf@users.sourceforge.net> References: <874lr6d3tp.fsf@users.sourceforge.net> From: David Glasser Date: Tue, 10 Oct 2017 15:46:53 -0700 X-Google-Sender-Auth: z9JOmbzbMNe-IHVv9LNwFGDw61g Message-ID: Subject: Re: bug#28637: [PATCH] Display commit in package description, if available To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 28637 Cc: 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Tue, Oct 10, 2017 at 3:40 PM, Noam Postavsky wrote: > David Glasser writes: > >> MELPA includes a :commit field in its >> packages (https://github.com/melpa/package-build/pull/6). You can use >> this to tell if MELPA has processed a recently-merged change. This >> commit adds that metadata to the package description buffer. > > Code looks fine, but could you post a "before and after" picture please? > I'm wondering if it might make sense to abbreviate the hash. Sure! Here's a randomly chosen melpa package's *Help* page: ``` archive-rpm is a new package. Status: New from melpa -- Install Archive: melpa Version: 20171005.1548 Commit: 830158cfb3b43c85cfcb4bd5b92d4457d015c80a Summary: RPM and CPIO support for archive-mode Requires: emacs-24.4 This module adds support for RPM archives to archive-mode. RPM files consist of metadata plus a compressed CPIO archive, so this module relies on `archive-cpio'. ``` This is the "after" picture; the "before" picture lacks the Commit line. Abbreviating the hash might be nice, but it seems like maybe that should be the job of the code that creates the metadata (ie in melpa's package builder) rather than the code that displays it. >> * lisp/emacs-lisp/package.el: Display commit in package description > > I think you should have a period at the end of sentence though. OK, a new version of the patch is below (is this the right way to send a new version of the patch? I am not used to mail-based git workflows): >From a4ebfa2ed35a620e4754399da8181caba13a1eb9 Mon Sep 17 00:00:00 2001 From: David Glasser Date: Thu, 28 Sep 2017 14:00:04 -0700 Subject: [PATCH] Display commit in package description, if available MELPA includes a :commit field in its packages (https://github.com/melpa/package-build/pull/6). You can use this to tell if MELPA has processed a recently-merged change. This commit adds that metadata to the package description buffer. * lisp/emacs-lisp/package.el: Display commit in package description. --- lisp/emacs-lisp/package.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 8b101c1323..dd05c70dc8 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2260,6 +2260,7 @@ Otherwise no newline is inserted." (archive (if desc (package-desc-archive desc))) (extras (and desc (package-desc-extras desc))) (homepage (cdr (assoc :url extras))) + (commit (cdr (assoc :commit extras))) (keywords (if desc (package-desc--keywords desc))) (built-in (eq pkg-dir 'builtin)) (installable (and archive (not built-in))) @@ -2332,6 +2333,8 @@ Otherwise no newline is inserted." (and version (package--print-help-section "Version" (package-version-join version))) + (when commit + (package--print-help-section "Commit" commit)) (when desc (package--print-help-section "Summary" (package-desc-summary desc))) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 21:16:47 2017 Received: (at 28637) by debbugs.gnu.org; 11 Oct 2017 01:16:47 +0000 Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e25df-0008CL-2O for submit@debbugs.gnu.org; Tue, 10 Oct 2017 21:16:47 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:55396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e25dd-0008C5-2O for 28637@debbugs.gnu.org; Tue, 10 Oct 2017 21:16:45 -0400 Received: by mail-io0-f178.google.com with SMTP id z187so595106ioz.12 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 18:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iFEhanQTAE031hM0J3P3EBe7DR6DIi9XJdNHVm67GXU=; b=pTwSzIorePso/kpYImHqKiFWksdUuUo7G6DImxTwdImMaZYLMQQ7NnSn8lCxoabEQm TSx3V3Zsesly0hekKcVN8/NBeJhXZZKhDftSZuQBOPz0Cue7f4bb2YytwOYGcV57FxRI af3KcOApuRdg44Yapsxy+cSXLNTZbJlzEf12u2F1e2V/l8rrT83JpNvVez1sVfh8tSP+ cgjDi3ugcX65KmLoh1iySLFzOfFxYPvonLJI8XEIj/1CABzwsaehWbDLOsNVdvGMBPwL XXR072udFM3uNiH+YBeWC1S1YebLiTk2kkT/zVONilI88hXhQW+f3BzV0o7IRZX0ma5Q rV9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=iFEhanQTAE031hM0J3P3EBe7DR6DIi9XJdNHVm67GXU=; b=W1+NsP0vFUHfal5rMJ1QP2099njY7qgmVeeDV0kkwf9eecPu0NcfodEabm3cZlSqIS ldduTPxmVGAKxYMfNaVeF1NZcINFaFv2mr/L0ucVbc3pN2gHCEHGr74ea8edKgFa3OFN 48co+b+cnoxDjJ/fckq0SfTH5z/W3ZU+JET6v8SEA+kgPCYpJYYyDbVGUOsVKnwOjazl XZc9LasTIVFpevr2797ywb2dhwWDLnS8SicdhbZwmdTsNBtTpVfheZvQUVX+9NvNs9Eu QOhMBpOR1YhyWb6P1jEejvBBRpLX24IWl9vlWXIhzEqXGQwHWUgeIAOM/mAaiNtvgnru OoXg== X-Gm-Message-State: AMCzsaXncKgLejs2NJU4OWeHpWnfoQxeRgoOGHs+lcZJkVywQ9gt2wLv qUzkW1IgxJvq4/Bpl5JOEh/SlQ== X-Google-Smtp-Source: AOwi7QAG8eZsbr1JAFxSlqpVH3GLEHwd8lnOvWnkKkjbHh6bvvej0SEBdugkqRHOgI2P/xmcg3vT7A== X-Received: by 10.107.56.68 with SMTP id f65mr14999796ioa.159.1507684599169; Tue, 10 Oct 2017 18:16:39 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i82sm1352263ioe.62.2017.10.10.18.16.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 18:16:38 -0700 (PDT) From: Noam Postavsky To: David Glasser Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> Date: Tue, 10 Oct 2017 21:16:36 -0400 In-Reply-To: (David Glasser's message of "Tue, 10 Oct 2017 15:46:53 -0700") Message-ID: <871smacwln.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 28637 Cc: 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) David Glasser writes: > Abbreviating the hash might be nice, but it seems like maybe that should be > the job of the code that creates the metadata (ie in melpa's package builder) > rather than the code that displays it. Hmm, I'm not so sure about that, but looking at the result now I think there's no need to abbreviate it anyway. I think this should be okay to go to emacs-26; it's not strictly speaking a bug fix, but it's obviously safe and this info is often useful for package maintainers fielding bug reports, so it would be good to have it more widely available. Eli? > OK, a new version of the patch is below (is this the right way to send > a new version of the patch? I am not used to mail-based git > workflows): Yup, that's fine. You can also use the -v option to git-format-patch in order to make it more obvious that the patch is new. For small stuff like this, it's not really important though. I suppose you haven't assigned copyright for Emacs? No problem if not, the patch is small enough to go in anyway, we just have to mark it. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 00:15:05 2017 Received: (at 28637) by debbugs.gnu.org; 11 Oct 2017 04:15:05 +0000 Received: from localhost ([127.0.0.1]:32900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e28QD-0004Ex-7w for submit@debbugs.gnu.org; Wed, 11 Oct 2017 00:15:05 -0400 Received: from mail-vk0-f44.google.com ([209.85.213.44]:56186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e28QC-0004ED-0o for 28637@debbugs.gnu.org; Wed, 11 Oct 2017 00:15:04 -0400 Received: by mail-vk0-f44.google.com with SMTP id b5so282392vkf.12 for <28637@debbugs.gnu.org>; Tue, 10 Oct 2017 21:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YiDjkA+Mw+LAR3StxVSMaD2lbA1ksfJtpbmfd9p9AXE=; b=pLHROB7BKdjA8623uSrNdbuvOma6e0RFZ7Vgoi4ZMG8JDfAfZDE4f5B42UOQFbZl4k a1Xzc4/5yRbsGPS/9GsnBvPvIJVofWuPMsM/wyFdLnh6oMQjiOecr8dJsrABNK/k1Yur SUx90LpWxIrGu6A+fdhadlkUnRYKgPlUMhIPRPBIrpWggWHl1qLLyhDKlYGvJ4BQSw9M pu/Ofwpe76WUL8lEwMf9Lyp2VFkj8q3Lz/hnPGGSeOeqtygsI2t6jkZnmqg8GvnEmEuU DYLho513Z93+cFS0R1TeNJ0eNpyANLOkRgNAFShNNgplf2lZ/tjRi85RwtpJrLbsJtOU YlqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YiDjkA+Mw+LAR3StxVSMaD2lbA1ksfJtpbmfd9p9AXE=; b=qRJvf7eA0PG9BxjUAnWcR+cjpYOPa4kOc2JyHBPDZEcRATEAhG30UWidYEtY7RW1ph 7DOf6Zx4zKme96Tyc3slVUpkL5uIQ6CH9KkH6uBOTsx0V5jEH7fKf7P44eOuWdMWS2uZ p50crnq2TBP8922ffH+YokbM9VSwR+U5afQUcjx+D+zzuSV8wAkyr8bCt2WO3/ztIfi0 iCqdqlTdK2zRFMMEk7jmG6NHP+W+y+XhzUrLnpEa2bzEV55YZFWSy+PyZY9Oh/56/qwi z0oDswy2MwEadA5UyLsGvO6lkWzeqQi2c1jP8UenAhrZP/UnOX34a0UnfwLzNFBx7SbW QqKA== X-Gm-Message-State: AMCzsaVLhBWBbgg37f+SP7HJ0miD+jqbZzxNRz4A2/txGjZ0+TmFi1r2 U2xX2Dj5x6r1r1RllgLOixDKJGB9OtbBcws5tjw= X-Google-Smtp-Source: AOwi7QCoaab8oNHbrrFdvGsjnUFbBoufsttMJFnbY4BSeuVl/fbzsiIRojDXQB05Ml6JzHxiVnAh6FRswh8nFVubZ/4= X-Received: by 10.31.49.215 with SMTP id x206mr8404600vkx.67.1507695298330; Tue, 10 Oct 2017 21:14:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.0.106 with HTTP; Tue, 10 Oct 2017 21:14:57 -0700 (PDT) Received: by 10.176.0.106 with HTTP; Tue, 10 Oct 2017 21:14:57 -0700 (PDT) In-Reply-To: <871smacwln.fsf@users.sourceforge.net> References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> From: David Glasser Date: Tue, 10 Oct 2017 21:14:57 -0700 X-Google-Sender-Auth: jIu5ivX9V7zybClcVHylmESWNsE Message-ID: Subject: Re: bug#28637: [PATCH] Display commit in package description, if available To: Noam Postavsky Content-Type: multipart/alternative; boundary="001a11440992afc7d8055b3daae0" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 28637 Cc: 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --001a11440992afc7d8055b3daae0 Content-Type: text/plain; charset="UTF-8" On Oct 10, 2017 6:16 PM, "Noam Postavsky" wrote: I suppose you haven't assigned copyright for Emacs? No problem if not, the patch is small enough to go in anyway, we just have to mark it. I don't believe I have. --dave --001a11440992afc7d8055b3daae0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On O= ct 10, 2017 6:16 PM, "Noam Postavsky" <npostavs@users.sourceforge.net> wrote:
I suppose you haven't assigned copyright for Emacs?=C2=A0 No problem if= not,
the patch is small enough to go in anyway, we just have to mark it.

I don&= #39;t believe I have.=C2=A0
--dave
--001a11440992afc7d8055b3daae0-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 06:41:46 2017 Received: (at 28637) by debbugs.gnu.org; 11 Oct 2017 10:41:46 +0000 Received: from localhost ([127.0.0.1]:33074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2ESQ-0005j1-A7 for submit@debbugs.gnu.org; Wed, 11 Oct 2017 06:41:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2ESO-0005in-LZ for 28637@debbugs.gnu.org; Wed, 11 Oct 2017 06:41:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2ESG-0004OM-CK for 28637@debbugs.gnu.org; Wed, 11 Oct 2017 06:41:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2ESG-0004OH-8t; Wed, 11 Oct 2017 06:41:36 -0400 Received: from [176.228.60.248] (port=4298 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e2ESF-0007KC-5O; Wed, 11 Oct 2017 06:41:36 -0400 Date: Wed, 11 Oct 2017 13:41:18 +0300 Message-Id: <83wp42nf01.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <871smacwln.fsf@users.sourceforge.net> (message from Noam Postavsky on Tue, 10 Oct 2017 21:16:36 -0400) Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28637 Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Tue, 10 Oct 2017 21:16:36 -0400 > Cc: 28637@debbugs.gnu.org > > I think this should be okay to go to emacs-26; it's not strictly > speaking a bug fix, but it's obviously safe and this info is often > useful for package maintainers fielding bug reports, so it would be good > to have it more widely available. Eli? Are we sure no feature parses this output, and might be confused by the extra line? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 08:32:53 2017 Received: (at 28637) by debbugs.gnu.org; 11 Oct 2017 12:32:53 +0000 Received: from localhost ([127.0.0.1]:33146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2GBw-0003vK-Nd for submit@debbugs.gnu.org; Wed, 11 Oct 2017 08:32:52 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:49223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2GBu-0003v0-S2 for 28637@debbugs.gnu.org; Wed, 11 Oct 2017 08:32:51 -0400 Received: by mail-it0-f48.google.com with SMTP id y15so2748835ita.4 for <28637@debbugs.gnu.org>; Wed, 11 Oct 2017 05:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BkEKc667kUHKinBrttTEqeBEG4x9sH4v5+PbTemzNw4=; b=nPZMt4ja+hGn462ZjTPEKvTLsDMJF62y+Bp5XN0yhq0c9KuV37YuqRLwZorW5GNbEG A00js9Ycs+diWA3fdkPLHGf7gwtXdTFys8MUnG1Pv6Mg36uj/5O6WqttBucBVp83DS/B Wcp5AzQjtj/4vx0UE+ON0t2dsSzC2KuoyTp1f+cRMarbUzD9regFN6+yBfPKqNvYAlOM 54cgzzQhWoX2HdcMjuCw5dNbp+faIhrZTOQ0LjVewpbcKKUmmnbV7vvhrhqZttRN67Ia SoJkT+xPcUCWKTy0cPp4c5Ptpl3vgA28/mDD4VMMOi7jnXCzERRR20tZ2UzSI4QiZDRV nfvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=BkEKc667kUHKinBrttTEqeBEG4x9sH4v5+PbTemzNw4=; b=r+sZHWH7bO4bezO/1n+NcCJCJHRXJu/Dx0c8kstk158wva3HugES38J/bgTkxOThpy 5sPB8lM9PXAdxClU6KHTuH0PKiGBUddMkc5Sho2tL72ok9enmipzjIkrHkoLevh9IMBF Z5GnDM/ctlxU+ZR+WwlouYXYy233W8JsSD0ZWRtAAnim+bN2Uv4EjI9HdiIrN9Zt9Ybf Gq3Mg/X/Yrn4f7CfsosThu3tTKkjGTQFMpxCHkh+5546SdcQdwcGFsltkcLGnlbugUxJ wNxcbyXWpL4jJy1AWb/EMfvDQEVrtXchH8yVFAjIFL0uGy18Npbpu0xQx0NN2IkeC90I vuSg== X-Gm-Message-State: AMCzsaX14qeSEqYV23jqBheyqDt0D8bU3gCfb8J7c9HB3BWnKSRK7HtO 6wFmLb6tCZ3hh2DtFTY1zJbB9Q== X-Google-Smtp-Source: AOwi7QDBS5w4tRmxEpCOD2LBZV6+1DILr/r+7CaE43W39CBAIvIxgeOP9RwUpXQ63g4a2GKS3FNiGg== X-Received: by 10.36.192.136 with SMTP id u130mr22953833itf.143.1507725165021; Wed, 11 Oct 2017 05:32:45 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id a72sm1636946itb.34.2017.10.11.05.32.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Oct 2017 05:32:44 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> <83wp42nf01.fsf@gnu.org> Date: Wed, 11 Oct 2017 08:32:43 -0400 In-Reply-To: <83wp42nf01.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Oct 2017 13:41:18 +0300") Message-ID: <87wp41c1as.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28637 Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Tue, 10 Oct 2017 21:16:36 -0400 >> Cc: 28637@debbugs.gnu.org >> >> I think this should be okay to go to emacs-26; it's not strictly >> speaking a bug fix, but it's obviously safe and this info is often >> useful for package maintainers fielding bug reports, so it would be good >> to have it more widely available. Eli? > > Are we sure no feature parses this output, and might be confused by > the extra line? As far as I can tell, it's only used for the *Help* buffer, and nothing parses that. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 09:12:53 2017 Received: (at 28637) by debbugs.gnu.org; 11 Oct 2017 13:12:53 +0000 Received: from localhost ([127.0.0.1]:33179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2Gof-0004vp-6X for submit@debbugs.gnu.org; Wed, 11 Oct 2017 09:12:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2God-0004vY-2P for 28637@debbugs.gnu.org; Wed, 11 Oct 2017 09:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2GoT-0006Dl-E5 for 28637@debbugs.gnu.org; Wed, 11 Oct 2017 09:12:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2GoT-0006DZ-An; Wed, 11 Oct 2017 09:12:41 -0400 Received: from [176.228.60.248] (port=4429 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e2GoS-00018S-27; Wed, 11 Oct 2017 09:12:41 -0400 Date: Wed, 11 Oct 2017 16:12:25 +0300 Message-Id: <83o9pdomkm.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87wp41c1as.fsf@users.sourceforge.net> (message from Noam Postavsky on Wed, 11 Oct 2017 08:32:43 -0400) Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> <83wp42nf01.fsf@gnu.org> <87wp41c1as.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28637 Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org > Date: Wed, 11 Oct 2017 08:32:43 -0400 > > Eli Zaretskii writes: > > >> From: Noam Postavsky > >> Date: Tue, 10 Oct 2017 21:16:36 -0400 > >> Cc: 28637@debbugs.gnu.org > >> > >> I think this should be okay to go to emacs-26; it's not strictly > >> speaking a bug fix, but it's obviously safe and this info is often > >> useful for package maintainers fielding bug reports, so it would be good > >> to have it more widely available. Eli? > > > > Are we sure no feature parses this output, and might be confused by > > the extra line? > > As far as I can tell, it's only used for the *Help* buffer, and nothing > parses that. Then it could be okay for emacs-26, if its addition is deemed important enough. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 19:58:43 2017 Received: (at 28637) by debbugs.gnu.org; 23 Oct 2017 23:58:43 +0000 Received: from localhost ([127.0.0.1]:58147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6mcF-0003sF-HX for submit@debbugs.gnu.org; Mon, 23 Oct 2017 19:58:43 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:43232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6mcD-0003rx-KN for 28637@debbugs.gnu.org; Mon, 23 Oct 2017 19:58:41 -0400 Received: by mail-io0-f169.google.com with SMTP id 134so21987517ioo.0 for <28637@debbugs.gnu.org>; Mon, 23 Oct 2017 16:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Dg2oawPUdBteVMG4vfl6/hNk/vPjX3HltJwa0JApmew=; b=n1WddIRCTF82fTM4OX4Un78ZZBWCTW+o/Wd5vs0Wi86jOSJn5jKolwMp/zJyVrzS4k UO+6TpdY2Gq91+ptNISnI9aCvK4ykIQYKEZcJYzLYuSGJkbgOOleOSKe4LO/74PzcGal jnE0xdrU0ZnRk5Uilxw/rAXCxgcn/AC4jGxSP1P5MH8sBF0SEFd9emJYHKCJ3chvgHfd TN/gBQ94iaNbz2c18/n7slztgUcgUap6MZmZYT7fO95Y/uKWDuK/i1o9okirKHiq5aJa +1a/Y9BAjC9g6mLeiB5dFTsmo6FeR42m3Ftodm6YUpSVkqMnxIduLfUq4FzuyjJihKlo xQcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Dg2oawPUdBteVMG4vfl6/hNk/vPjX3HltJwa0JApmew=; b=eFJqV2bYzLi5iJj2+y4O5SDlJEjMcE90mABuCrYN+vWsdgyxSLxdRisuAjGU5HVQmr dFu6P2cj+9FVTU1pBs7Etq5AuS0Bxq8nK0Sj0GbeZ9QeZwWPojINFoeWQjGQvuUf+KNO HZYqqm5fm6VZvGWO/OSWs+SEDGvuAWSBFEDSG9A06hY2F33ZX38Te94BdJtXgmshjt9Z iKfszsEAe5AyFeBi0/7llz88U1Py3I/FNxqpS+K4YDZbpp56rNl6XXvmo8U+41BP53HZ REIXD4RyrPATq1dtgPkohqLmfiDR2QnbgFzBGq9SrxjhoLUGJxgazhUENHPEXhNUkeJU 1EXw== X-Gm-Message-State: AMCzsaX/JQFLDc6p1F0dsST3o6zd1jNYEUTSwnhgHsgDQPRKv8BCiFEO zdmdv9KMOAmZ9WRgoO7SWgCp9Q== X-Google-Smtp-Source: ABhQp+SthITCxSl0CYaXExNae1gyx2eXknLic/NgOIXByWaF9DBfRRpoRuSXc4JlqreYv0iSogUE5w== X-Received: by 10.107.83.4 with SMTP id h4mr20312788iob.145.1508803115578; Mon, 23 Oct 2017 16:58:35 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r65sm92445ith.1.2017.10.23.16.58.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Oct 2017 16:58:34 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> <83wp42nf01.fsf@gnu.org> <87wp41c1as.fsf@users.sourceforge.net> <83o9pdomkm.fsf@gnu.org> Date: Mon, 23 Oct 2017 19:58:32 -0400 In-Reply-To: <83o9pdomkm.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Oct 2017 16:12:25 +0300") Message-ID: <87fua9ct7b.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 28637 Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Eli Zaretskii writes: > Then it could be okay for emacs-26, if its addition is deemed > important enough. >From my perspective as a package maintainer, it would be very useful to get the commit hash in bug reports. Getting a timestamp in place of a version from MELPA users has been a pretty long-standing source of minor irritation. So I would like to have this in Emacs 26 to end the irritation sooner rather than later. Obviously it's not vital, but it usefulness vs risk ratio seems to me high enough to be worth it. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 10:47:05 2017 Received: (at 28637) by debbugs.gnu.org; 24 Oct 2017 14:47:05 +0000 Received: from localhost ([127.0.0.1]:60011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e70Tx-0008FJ-H0 for submit@debbugs.gnu.org; Tue, 24 Oct 2017 10:47:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e70Tv-0008Ei-IP for 28637@debbugs.gnu.org; Tue, 24 Oct 2017 10:47:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e70Tk-0006Vb-VS for 28637@debbugs.gnu.org; Tue, 24 Oct 2017 10:46:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e70Tk-0006VX-Ri; Tue, 24 Oct 2017 10:46:52 -0400 Received: from [176.228.60.248] (port=4045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e70Tk-0003nd-9K; Tue, 24 Oct 2017 10:46:52 -0400 Date: Tue, 24 Oct 2017 17:46:38 +0300 Message-Id: <833768a9ip.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87fua9ct7b.fsf@users.sourceforge.net> (message from Noam Postavsky on Mon, 23 Oct 2017 19:58:32 -0400) Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> <83wp42nf01.fsf@gnu.org> <87wp41c1as.fsf@users.sourceforge.net> <83o9pdomkm.fsf@gnu.org> <87fua9ct7b.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28637 Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org > Date: Mon, 23 Oct 2017 19:58:32 -0400 > > >From my perspective as a package maintainer, it would be very useful to > get the commit hash in bug reports. Getting a timestamp in place of a > version from MELPA users has been a pretty long-standing source of minor > irritation. So I would like to have this in Emacs 26 to end the > irritation sooner rather than later. > > Obviously it's not vital, but it usefulness vs risk ratio seems to me > high enough to be worth it. OK. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 19:26:13 2017 Received: (at 28637) by debbugs.gnu.org; 24 Oct 2017 23:26:13 +0000 Received: from localhost ([127.0.0.1]:60399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78aK-0007Ub-N8 for submit@debbugs.gnu.org; Tue, 24 Oct 2017 19:26:12 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:43592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e78aI-0007UG-3B; Tue, 24 Oct 2017 19:26:10 -0400 Received: by mail-it0-f48.google.com with SMTP id k70so9617449itk.0; Tue, 24 Oct 2017 16:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=d2btjbj2Ons1fZ0JVbmFybl+A+aGvy+J2XH6pQWZtn8=; b=U2u87AEmR+p0ToNf7gDRtDZ42fULqgPVCjvRqM229TBGJwLOHHRzqiaMmmJ8icbJhe +RH9dFSBPIA8MNe9R6xu3WE3cB9QR9CYR+hfgw7Sj4+ZKLEKBudnjaXyvU/I1n9Sko+L LizULmcWjAA/kdLuWcY4D/3mxl3SW3LPDwBgj2e43xMlcqReBqk3J4ApdvZkT2D9YW+Q npNA8qgUM9EUo3n4hvlIbEhH755Mq2R3LbE7mW+S8A12XoLStyP/j22Udl+sE7F7lauv 0UAaeaXzcoMHFsTRB2WD95dFwv8pZew7Sa5cpuLk495TvTzIPyhbr7dYirjM/sGbJnvk jz6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=d2btjbj2Ons1fZ0JVbmFybl+A+aGvy+J2XH6pQWZtn8=; b=g9AatTw8wKNCtoWvZmtnZFAaff6G2e6U2JJHHMG9XJF+EpQh/d5Xh1lytNKZGSIHfp V11ypa79vllOM6rKeEThHCzfgJPVmDzIa8GwhsL8f1X0zINaPA4IFxvQGxXChAyKYX6F AI3Iy8cl8tdRrzw3NvpxEt8rIsCX63arqn+JbBGHk9IVGspRHPozIAdHDT+QySM3aapF 8H7ztRW5CIuZ4UlRVx3BpzUbj3AeH8+EMZ0MKrF0ABw3jr88I28nU8bSZ7AVU+iXnnsV bW5Cu8pHdR/6+Vz3yxj6R4E7HkApGoraMWWTmTVKx89D7r5OaOIiAfgb02W3egkDiLzp knIg== X-Gm-Message-State: AMCzsaX7FYSBh1K0xewXEHhDibpISGZEhO+ipGJ11B59TxpRTEgUJkUq 4Iq73MQ5xJYrI3upqGEVeNnvIA== X-Google-Smtp-Source: ABhQp+QbxG1Bf26QFbDUgSnTMqtE8V9cc2wCJ17qjIccZR0jIP9uNKbVf7wY02cYcM8Bhj2suOuRiQ== X-Received: by 10.36.13.210 with SMTP id 201mr307835itx.95.1508887563994; Tue, 24 Oct 2017 16:26:03 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 10sm464863ios.17.2017.10.24.16.26.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 16:26:02 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#28637: [PATCH] Display commit in package description, if available References: <874lr6d3tp.fsf@users.sourceforge.net> <871smacwln.fsf@users.sourceforge.net> <83wp42nf01.fsf@gnu.org> <87wp41c1as.fsf@users.sourceforge.net> <83o9pdomkm.fsf@gnu.org> <87fua9ct7b.fsf@users.sourceforge.net> <833768a9ip.fsf@gnu.org> Date: Tue, 24 Oct 2017 19:26:01 -0400 In-Reply-To: <833768a9ip.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Oct 2017 17:46:38 +0300") Message-ID: <87d15ccely.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28637 Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 28637 fixed close 28637 26.1 quit Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: glasser@davidglasser.net, 28637@debbugs.gnu.org >> Date: Mon, 23 Oct 2017 19:58:32 -0400 >> >> >From my perspective as a package maintainer, it would be very useful to >> get the commit hash in bug reports. Getting a timestamp in place of a >> version from MELPA users has been a pretty long-standing source of minor >> irritation. So I would like to have this in Emacs 26 to end the >> irritation sooner rather than later. >> >> Obviously it's not vital, but it usefulness vs risk ratio seems to me >> high enough to be worth it. > > OK. Pushed to emacs-26. [1: 0c536a20fb]: 2017-10-24 19:14:30 -0400 Display commit in package description, if available (Bug#28637) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0c536a20fb4833bafea1c2a14b9ff2bac2a3ebd8 From unknown Mon Aug 18 14:21:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Nov 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator