GNU bug report logs - #28635
[PATCH] Allow configuring the disk image size of a virtual machine

Previous Next

Full log

Message #25 received at 28635-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28635-done <at> debbugs.gnu.org
Subject: Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to
 <virtual-machine>.
Date: Wed, 4 Oct 2017 07:25:36 +0100

[Message part 1 (text/plain, inline)]

On Tue, 03 Oct 2017 15:12:04 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > * gnu/system/vm.scm (<virtual-machine>): Add disk-image-size.
> >   (port-forwardings->qemu-options): Use disk-image-size from
> >   <virtual-machine>.  
> 
> As long as “make check-system TESTS=basic” passes, fine with me!

It failed at first, as I had a the memory-size and disk-image-size
fields the wrong way around in a match statement, but after I fixed
that it worked fine.

I've now pushed these changes, thanks for your review :)

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.