GNU bug report logs - #28635
[PATCH] Allow configuring the disk image size of a virtual machine

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28635: closed ([PATCH] Allow configuring the disk image size
 of a virtual machine)
Date: Wed, 04 Oct 2017 06:26:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 4 Oct 2017 07:25:36 +0100
with message-id <20171004072536.0d736c3a <at> cbaines.net>
and subject line Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to <virtual-machine>.
has caused the debbugs.gnu.org bug report #28635,
regarding [PATCH] Allow configuring the disk image size of a virtual machine
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28635: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28635
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Allow configuring the disk image size of a virtual machine
Date: Thu, 28 Sep 2017 20:54:16 +0100

[Message part 3 (text/plain, inline)]

Allow configuring the size of the virtual machine disk when using the
virtual-matchine record type.

Christopher Baines (2):
  vm: Add a minimum root size.
  vm: Add disk-image-size to <virtual-machine>.

 gnu/system/vm.scm | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28635-done <at> debbugs.gnu.org
Subject: Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to
 <virtual-machine>.
Date: Wed, 4 Oct 2017 07:25:36 +0100

[Message part 6 (text/plain, inline)]

On Tue, 03 Oct 2017 15:12:04 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > * gnu/system/vm.scm (<virtual-machine>): Add disk-image-size.
> >   (port-forwardings->qemu-options): Use disk-image-size from
> >   <virtual-machine>.  
> 
> As long as “make check-system TESTS=basic” passes, fine with me!

It failed at first, as I had a the memory-size and disk-image-size
fields the wrong way around in a match statement, but after I fixed
that it worked fine.

I've now pushed these changes, thanks for your review :)

[Message part 7 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.