From unknown Sun Aug 17 09:09:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28635 <28635@debbugs.gnu.org> To: bug#28635 <28635@debbugs.gnu.org> Subject: Status: [PATCH] Allow configuring the disk image size of a virtual machine Reply-To: bug#28635 <28635@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:09:09 +0000 retitle 28635 [PATCH] Allow configuring the disk image size of a virtual ma= chine reassign 28635 guix-patches submitter 28635 Christopher Baines severity 28635 normal tag 28635 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 15:54:38 2017 Received: (at submit) by debbugs.gnu.org; 28 Sep 2017 19:54:38 +0000 Received: from localhost ([127.0.0.1]:37129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxetJ-00041I-TU for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:54:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxetH-000414-Cc for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxetB-0008B9-KW for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:54:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxetB-0008B3-HE for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:54:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxetA-0006sG-Dp for guix-patches@gnu.org; Thu, 28 Sep 2017 15:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxet7-00089J-D9 for guix-patches@gnu.org; Thu, 28 Sep 2017 15:54:28 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:58894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxet7-00088m-7F for guix-patches@gnu.org; Thu, 28 Sep 2017 15:54:25 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 8F8FC13E5D6; Thu, 28 Sep 2017 20:54:22 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 5AAA613E5D5 for ; Thu, 28 Sep 2017 20:54:22 +0100 (BST) Date: Thu, 28 Sep 2017 20:54:16 +0100 From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] Allow configuring the disk image size of a virtual machine Message-ID: <20170928205416.647d53d7@cbaines.net> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/hrWyA_rmR6YwmBB/96iXDL/"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --Sig_/hrWyA_rmR6YwmBB/96iXDL/ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Allow configuring the size of the virtual machine disk when using the virtual-matchine record type. Christopher Baines (2): vm: Add a minimum root size. vm: Add disk-image-size to . gnu/system/vm.scm | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) --Sig_/hrWyA_rmR6YwmBB/96iXDL/ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnNU2hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XelCA/9EY3fEqnh5xkJPZf6iTrhvDXZR+oypfDz5x7YBnhlyIu2aoYujgmPsXzL F/EYB2TkJP4WO6MoxvIPH/arKoVlgt57f3QdnOQZdXCMj1octfIMRX5zVbuSLwtf SDJzdeLAYU+qs/6h/HkZpmC5hFfz2vHvyFNPOdKubKZn4rLsjgLFFnrDmTrVGBAd iYPgDcdBC14pQcRUAowTEyIZv2RVaOSDS/JTSwy/LmAuXMclPJo0Z7Wl6qULP/WE 0Ruju4spyqNmyjbp1mapCNWUuCXVBCFeyLjZ0fPeTKMoieezshLQLQ8b7w1WZTX3 PVH32U2q0baLQbQXm1j2druYHr6dG6UkIUaEcc8d24yeqnVV6dmzbmMknojbnzpk D+4yRJ1ouWeuDN8021UE7p0znPeHV92EzHgGSTH5jwHgqSFiXssy8307sHl9f+EV d7maWTWb5DV3w5TKWOBD0/v6jQSv8HIu4NGOro8KBESJ2qzzKfYKANMRsni32WLE DwbhyuAnIv6k2SauJQzirVFOkqfIa8zkCwH17S/pTXHPoyHI29jGy5NP6Gra2102 PcePEjqKXE+kN7rC2/7HsZV3AJtueK0JYCEZw4UbPvmdW35pUsEW8ADmVKZWzmxi TQ6XBht4AFlGkce2IuU4FJIag/vFFIgdfF0wv4YaI25V5x//1Mw= =99Gj -----END PGP SIGNATURE----- --Sig_/hrWyA_rmR6YwmBB/96iXDL/-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 15:57:58 2017 Received: (at 28635) by debbugs.gnu.org; 28 Sep 2017 19:57:58 +0000 Received: from localhost ([127.0.0.1]:37137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxewY-00046c-E6 for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:57:58 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44181 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxewX-00046O-1H for 28635@debbugs.gnu.org; Thu, 28 Sep 2017 15:57:57 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 6FF6613E5D7; Thu, 28 Sep 2017 20:57:55 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 3DAA013E5D5 for <28635@debbugs.gnu.org>; Thu, 28 Sep 2017 20:57:55 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b00183f1 for <28635@debbugs.gnu.org>; Thu, 28 Sep 2017 19:57:54 +0000 (UTC) From: Christopher Baines To: 28635@debbugs.gnu.org Subject: [PATCH 1/2] vm: Add a minimum root size. Date: Thu, 28 Sep 2017 20:57:53 +0100 Message-Id: <20170928195754.28688-1-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28635 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/system/vm.scm (qemu-image): When guessing the root-size, use a lower bound of 20 MiB, otherwise the root file system size is sometimes 0 MiB in size. --- gnu/system/vm.scm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 78143e4f7..d340a8563 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -304,9 +304,12 @@ the image." #:register-closures? #$register-closures? #:system-directory #$os-drv)) (root-size #$(if (eq? 'guess disk-image-size) - #~(estimated-partition-size - (map (cut string-append "/xchg/" <>) - graphs)) + #~(max + ;; Minimum 20 MiB root size + (* 20 (expt 2 20)) + (estimated-partition-size + (map (cut string-append "/xchg/" <>) + graphs))) (- disk-image-size (* 50 (expt 2 20))))) (partitions (list (partition -- 2.14.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 15:57:58 2017 Received: (at 28635) by debbugs.gnu.org; 28 Sep 2017 19:57:59 +0000 Received: from localhost ([127.0.0.1]:37139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxewY-00046f-KI for submit@debbugs.gnu.org; Thu, 28 Sep 2017 15:57:58 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44182 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxewX-00046P-0w for 28635@debbugs.gnu.org; Thu, 28 Sep 2017 15:57:57 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 81A7813E5D5; Thu, 28 Sep 2017 20:57:55 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 5D5D513E5D6 for <28635@debbugs.gnu.org>; Thu, 28 Sep 2017 20:57:55 +0100 (BST) Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 12671489 for <28635@debbugs.gnu.org>; Thu, 28 Sep 2017 19:57:54 +0000 (UTC) From: Christopher Baines To: 28635@debbugs.gnu.org Subject: [PATCH 2/2] vm: Add disk-image-size to . Date: Thu, 28 Sep 2017 20:57:54 +0100 Message-Id: <20170928195754.28688-2-mail@cbaines.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170928195754.28688-1-mail@cbaines.net> References: <20170928195754.28688-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28635 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/system/vm.scm (): Add disk-image-size. (port-forwardings->qemu-options): Use disk-image-size from . --- gnu/system/vm.scm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index d340a8563..2f31a615b 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -709,6 +709,8 @@ it is mostly useful when FULL-BOOT? is true." (default #f)) (memory-size virtual-machine-memory-size ;integer (MiB) (default 256)) + (disk-image-size virtual-machine-disk-image-size ;integer (bytes) + (default 'guess)) (port-forwardings virtual-machine-port-forwardings ;list of integer pairs (default '()))) @@ -737,12 +739,15 @@ FORWARDINGS is a list of host-port/guest-port pairs." system target) ;; XXX: SYSTEM and TARGET are ignored. (match vm - (($ os qemu graphic? memory-size ()) + (($ os qemu graphic? disk-image-size memory-size ()) (system-qemu-image/shared-store-script os #:qemu qemu #:graphic? graphic? - #:memory-size memory-size)) - (($ os qemu graphic? memory-size forwardings) + #:memory-size memory-size + #:disk-image-size + disk-image-size)) + (($ os qemu graphic? memory-size disk-image-size + forwardings) (let ((options `("-net" ,(string-append "user," @@ -751,6 +756,8 @@ FORWARDINGS is a list of host-port/guest-port pairs." #:qemu qemu #:graphic? graphic? #:memory-size memory-size + #:disk-image-size + disk-image-size #:options options))))) ;;; vm.scm ends here -- 2.14.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 29 02:48:31 2017 Received: (at 28635) by debbugs.gnu.org; 29 Sep 2017 06:48:31 +0000 Received: from localhost ([127.0.0.1]:37443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxp67-0004NH-3q for submit@debbugs.gnu.org; Fri, 29 Sep 2017 02:48:31 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:44409 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxp63-0004N3-RK; Fri, 29 Sep 2017 02:48:28 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 069BE13E5E3; Fri, 29 Sep 2017 07:48:27 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id E1E7413E5E2; Fri, 29 Sep 2017 07:48:24 +0100 (BST) Date: Fri, 29 Sep 2017 07:48:21 +0100 From: Christopher Baines To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#28198] [PATCH 1/4] vm: Add disk-image-size to . Message-ID: <20170929074821.06100e60@cbaines.net> In-Reply-To: <87y3p22ap7.fsf@gnu.org> References: <20170823101831.72c11e2f@cbaines.net> <20170823092516.6846-1-mail@cbaines.net> <87y3pzudh7.fsf@gnu.org> <20170925213648.25ef5dd1@cbaines.net> <87y3p22ap7.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/ctP2jS/=o3ddyUwsV=sjojU"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28635 Cc: 28635@debbugs.gnu.org, 28198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/ctP2jS/=o3ddyUwsV=sjojU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 26 Sep 2017 09:14:28 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hi Chris! >=20 > Christopher Baines skribis: >=20 > > On Thu, 31 Aug 2017 14:29:56 +0200 > > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > =20 > >> Hi Chris, =20 > > > > Thanks for reviewing these patches Ludo, unfortunately its taken me > > nearly a month to get around to replying. > > > > Thankfully, I've made some progress in that time. > > =20 > >> Christopher Baines skribis: > >> =20 > >> > * gnu/system/vm.scm (): Add > >> > disk-image-size. > >> > (port-forwardings->qemu-options): Use disk-image-size from > >> > . =20 > >>=20 > >> In which case is it useful? Perhaps if you want to create lots of > >> data on the root file system in the MongoDB test? > >>=20 > >> Currently builds a shared-store VM (like =E2=80=98gu= ix > >> system vm=E2=80=99) in which the root file system has a fixed size tha= t=E2=80=99s > >> usually good enough. =20 > > > > The best answer I have at the moment is that I think MongoDB > > creates a rather large file, even if it has no data to store in it. > > I'll do some more investigation to confirm this though. =20 >=20 > OK, that=E2=80=99s a good reason anyway. :-) >=20 > >> > --- a/gnu/system/vm.scm > >> > +++ b/gnu/system/vm.scm > >> > @@ -653,6 +653,8 @@ it is mostly useful when FULL-BOOT? is > >> > true." (default #f)) > >> > (memory-size virtual-machine-memory-size ;integer (MiB) > >> > (default 256)) > >> > + (disk-image-size virtual-machine-disk-image-size ;integer > >> > (bytes) > >> > + (default (* 70 (expt 2 20)))) =20 > >>=20 > >> I think we can use 'guess here as the default value (and we should > >> do the same in places where #:disk-image-size has an arbitrary > >> default.) =20 > > > > I've been looking at this in the last few days. Making 'guess the > > default value here does mean something, and I think it's a good > > idea. > > > > As far as I can tell, for this specific test, these are the 3 > > functions that are called on the way to using the actual size, and > > the defaults they have: > > > > system-qemu-image/shared-store-script default: > > (* (if full-boot? 500 70) > > (expt 2 20))) > > > > system-qemu-image/shared-store default:=20 > > (* (if full-boot? 500 30)=20 > > (expt 2 20))) > > > > qemu-image default: > > 'guess > > > > From my tests, if the default in the is set to > > 'guess, then for the mongodb test the guess seems to be 0 MiB at the > > moment, which doesn't work. I've started looking at setting a > > sensible default in qemu-image, so that the root filesystem size > > isn't 0 MiB. =20 >=20 > Indeed. Maybe we can go with your patch as-is and investigate the > problem with 'guess separately. Thoughts? That's fine with me. I've also now created a separate bug with this patch, and another to add a default value [1]. I tested it with the memcached system test, and the disk image size was the same plus the test still passed. I haven't checked the other tests yet. 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28635 --Sig_/ctP2jS/=o3ddyUwsV=sjojU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnN7LVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xd47g//RZ3W1CeY1S72/5ZVwSi1panfjnE8f3ZxPfnWWi5Xsu9BA8NW2fWvsoxG A7bpzIyK09aqOhinKgAZDsS7TdNXGQOvyfs7zmF00OKppAh+ntixyqdaa8uMitS0 aV2JSFAbg6/b+wTqMPrfH+RWPsuW4e+ADx+VGSRCCbeUyBLluN+gL+D/rI3cAUSr yfwypHDS1YF0wmX48Kcmk2SpV2JB6CLyTlLrm/hrwMlXdKPDAhTqce89zmBlF1uI RWegm5s7n9Ii+sp++BDUhUShetadoK89oSYmt1l+08FkXdAU8kMntqJwDTzLJznS +X/Q+16bm1fInt88BpxonzBI1nrdl90UUsLRWDfo/N+AMNWfTkR/P3X5R2Q1NYPG Vi9/loTvymuck+HnhyfDLoLu1f4NPVzW8iuVNNjQBgrFkQDhOaQhm2wNjJDJ+ZY+ doGekWiQu+FUF63vLohboWVSriVJsIoyUhYFoK2US7W3BemvExfZHSiSv7lpVPu7 M5tHKTA8JNqC+ISgFT4ue6HySKSW7MmrR7HuTwYiK7xx0c+RcsZUwUauqYoWZBl2 u0sJ+TyYF6RuqlMaVzPKd8CesvnTa7vW1J+MUY37syAnbHfodEf/6xQsfPYAfdHb RnyJKbbet+l5VdC84KHLufkwTwn5z6Es3R4h8RzT02ImbQy2DRM= =+o3L -----END PGP SIGNATURE----- --Sig_/ctP2jS/=o3ddyUwsV=sjojU-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 09:11:29 2017 Received: (at 28635) by debbugs.gnu.org; 3 Oct 2017 13:11:29 +0000 Received: from localhost ([127.0.0.1]:45418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMyv-0000hX-7Z for submit@debbugs.gnu.org; Tue, 03 Oct 2017 09:11:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMyu-0000hE-22 for 28635@debbugs.gnu.org; Tue, 03 Oct 2017 09:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzMyl-00066o-24 for 28635@debbugs.gnu.org; Tue, 03 Oct 2017 09:11:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzMyk-00066k-V7; Tue, 03 Oct 2017 09:11:18 -0400 Received: from [193.50.110.164] (port=37430 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzMyk-0006NO-Gw; Tue, 03 Oct 2017 09:11:18 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Christopher Baines Subject: Re: [bug#28635] [PATCH 1/2] vm: Add a minimum root size. References: <20170928205416.647d53d7@cbaines.net> <20170928195754.28688-1-mail@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 03 Oct 2017 15:11:16 +0200 In-Reply-To: <20170928195754.28688-1-mail@cbaines.net> (Christopher Baines's message of "Thu, 28 Sep 2017 20:57:53 +0100") Message-ID: <874lrg8jgr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28635 Cc: 28635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Christopher Baines skribis: > * gnu/system/vm.scm (qemu-image): When guessing the root-size, use a lower > bound of 20 MiB, otherwise the root file system size is sometimes 0 MiB= in > size. LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 09:12:16 2017 Received: (at 28635) by debbugs.gnu.org; 3 Oct 2017 13:12:16 +0000 Received: from localhost ([127.0.0.1]:45422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMzg-0000j6-Fg for submit@debbugs.gnu.org; Tue, 03 Oct 2017 09:12:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMzf-0000iu-IB for 28635@debbugs.gnu.org; Tue, 03 Oct 2017 09:12:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzMzW-0006zN-QM for 28635@debbugs.gnu.org; Tue, 03 Oct 2017 09:12:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzMzW-0006zH-NN; Tue, 03 Oct 2017 09:12:06 -0400 Received: from [193.50.110.164] (port=37450 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzMzW-0006Pn-9m; Tue, 03 Oct 2017 09:12:06 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Christopher Baines Subject: Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to . References: <20170928195754.28688-1-mail@cbaines.net> <20170928195754.28688-2-mail@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?utf-8?Q?Vend=C3=A9miaire?= an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 03 Oct 2017 15:12:04 +0200 In-Reply-To: <20170928195754.28688-2-mail@cbaines.net> (Christopher Baines's message of "Thu, 28 Sep 2017 20:57:54 +0100") Message-ID: <87zi9874uz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28635 Cc: 28635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Christopher Baines skribis: > * gnu/system/vm.scm (): Add disk-image-size. > (port-forwardings->qemu-options): Use disk-image-size from > . As long as =E2=80=9Cmake check-system TESTS=3Dbasic=E2=80=9D passes, fine w= ith me! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 02:25:46 2017 Received: (at 28635-done) by debbugs.gnu.org; 4 Oct 2017 06:25:46 +0000 Received: from localhost ([127.0.0.1]:47269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzd7q-0000AI-HA for submit@debbugs.gnu.org; Wed, 04 Oct 2017 02:25:46 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:48268 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzd7o-0000A9-LY for 28635-done@debbugs.gnu.org; Wed, 04 Oct 2017 02:25:45 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id CFBCB13E653; Wed, 4 Oct 2017 07:25:43 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id DE73313E652; Wed, 4 Oct 2017 07:25:42 +0100 (BST) Date: Wed, 4 Oct 2017 07:25:36 +0100 From: Christopher Baines To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#28635] [PATCH 2/2] vm: Add disk-image-size to . Message-ID: <20171004072536.0d736c3a@cbaines.net> In-Reply-To: <87zi9874uz.fsf@gnu.org> References: <20170928195754.28688-1-mail@cbaines.net> <20170928195754.28688-2-mail@cbaines.net> <87zi9874uz.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/0TAsRgM2_ciTcS7Sk6QCDsk"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28635-done Cc: 28635-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/0TAsRgM2_ciTcS7Sk6QCDsk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 03 Oct 2017 15:12:04 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > * gnu/system/vm.scm (): Add disk-image-size. > > (port-forwardings->qemu-options): Use disk-image-size from > > . =20 >=20 > As long as =E2=80=9Cmake check-system TESTS=3Dbasic=E2=80=9D passes, fine= with me! It failed at first, as I had a the memory-size and disk-image-size fields the wrong way around in a match statement, but after I fixed that it worked fine. I've now pushed these changes, thanks for your review :) --Sig_/0TAsRgM2_ciTcS7Sk6QCDsk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnUfuBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeKvA//a8S28VYvYuWfrIr6jK2k76kuCGvZa9mjfm6ra+NnrHAPDXlwzhxukmIN 7FGywB/SKYY3fDnO/uW6yMzGr34amkkQ5ADgBbpuiKJyN176ZGK9F2oRMI5b5HUQ NSOznJiezfwGlnJpMyrZrcJzzfwFC72+xzDHqj4OstXTgWyddFs8Ulq2cppyn7H3 D5Bna9ZCxLRIZOQtrVob0Q93pIBm+eQmYkV4UV+UCrjC5/lyb6nvJ0M9+xjHyWW8 bHHWvcpIUZY4IhSguCu3BQwOqjpItqQU01XqRIwEBHkLqT3QO6zCEaMJ2MqtgGF8 0EekIHq4Bn426+mUJO8WxLf68FsdisntsoQAMligSd4qIkpfZpCC8eHS+8LEzddZ cqDoXdc4ZoSXwUiTnRZ/7715/qZv7yjUgX6L4nboksML43QVXYjMJo3jnHNE+H2y luABbNlWl1BzT1MFUxzoe+J8G3D3XbzMqrhbvne3nilorLHPYFqn8v4vSZFHIAJP i+wVrlpk5aZv/yPjcYbPdmauWPruQ+xzEdQnKvwQY3nrs/on0BMg3pV04yNyrJWI 5KiMxnRmdxP+BMRWlEPSpHQSLossPqbYPfmtrQuvx5qO5sgbBLd5RC1S/jcyOKzF 9/vYbTAhhP3PVOapl2LxwS17SjRwNqhJNg1cjZFs4qtdAyW31uA= =g10p -----END PGP SIGNATURE----- --Sig_/0TAsRgM2_ciTcS7Sk6QCDsk-- From unknown Sun Aug 17 09:09:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 01 Nov 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator