GNU bug report logs - #28619
[PATCH] doc: Fix rottlog configuration sample code.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28619 in the body.
You can then email your comments to 28619 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: Fix rottlog configuration sample code.
Date: Wed, 27 Sep 2017 17:36:34 +0200 (CEST)

[Message part 1 (text/plain, inline)]

I believe the current example code for a basic rottlog-service does 
not work. (mcron-service) requires an argument specifying the list of 
jobs.

I think either (service mcron-service-type) or (mcron-service '()) 
would be ok.  I use the former and attached patch updates the manual 
in this way.  Is that ok?

Thomas

[0001-doc-Fix-rottlog-configuration-sample-code.patch (text/x-patch, inline)]

From 46b54b38ceea9c1e20e68be6e2d1127b41a14e72 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
Date: Wed, 27 Sep 2017 17:31:31 +0200
Subject: [PATCH] doc: Fix rottlog configuration sample code.

* doc/guix.texi (Log Rotation): Correct code for the default mcron-service.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 1356a357c..9fd99fd53 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -9959,7 +9959,7 @@ with the default settings, for commonly encountered log files.
 
 (operating-system
   ;; @dots{}
-  (services (cons* (mcron-service)
+  (services (cons* (service mcron-service-type)
                    (service rottlog-service-type)
                    %base-services)))
 @end lisp
-- 
2.14.1

Message #8 received at 28619 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: 28619 <at> debbugs.gnu.org
Subject: Re: [bug#28619] [PATCH] doc: Fix rottlog configuration sample code.
Date: Thu, 28 Sep 2017 22:10:35 +0200

Thomas Danckaert <post <at> thomasdanckaert.be> skribis:

>>From 46b54b38ceea9c1e20e68be6e2d1127b41a14e72 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
> Date: Wed, 27 Sep 2017 17:31:31 +0200
> Subject: [PATCH] doc: Fix rottlog configuration sample code.
>
> * doc/guix.texi (Log Rotation): Correct code for the default mcron-service.

Good catch!  LGTM.

Thanks,
Ludo'.

Message #13 received at 28619-done <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: 28619-done <at> debbugs.gnu.org
Subject: Re: [bug#28619] [PATCH] doc: Fix rottlog configuration sample code.
Date: Sat, 30 Sep 2017 19:26:23 +0200 (CEST)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.