GNU bug report logs - #28615
25.3; rgrep, grep-read-files confusingly completes file names

Previous Next

Full log

Message #25 received at 28615 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Allen Li <vianchielfaura <at> gmail.com>
Cc: 28615 <at> debbugs.gnu.org
Subject: Re: bug#28615: [PATCH] Clarify what grep-read-files wants
Date: Tue, 10 Oct 2017 10:52:01 +0300

> From: Allen Li <vianchielfaura <at> gmail.com>
> Date: Mon, 9 Oct 2017 23:51:47 -0700
> Cc: 28615 <at> debbugs.gnu.org
> 
> Are you saying that a user might mistake the completion on
> grep-files-aliases as completion on file name?

Something like that, yes.  In general, I don't think completing on
wildcards is useful.

> I believe that with the new prompt change, that is unlikely.

People don't always read the prompt paying attention to every word of
it, and "all" is a valid wildcard anyway.

> >> As I noted in the bug, most of the completions that would be
> >> provided by read-file-name-internal don't work
> >
> > IMO, that's okay, because wildcards cannot be meaningfully completed
> > on.
> 
> But the aliases from grep-files-aliases can be meaningfully
> completed.  I don't see why we shouldn't provide meaningful
> completion if the user defines a lot of aliases, seeing as how
> the current file name completion is useless.

I didn't think allowing it to complete on 2 non-file values is
important enough to justify the possible confusion.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.