GNU bug report logs - #28615
25.3; rgrep, grep-read-files confusingly completes file names

Previous Next

Full log

View this message in rfc822 format

From: Allen Li <vianchielfaura <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28615 <at> debbugs.gnu.org
Subject: bug#28615: [PATCH] Clarify what grep-read-files wants
Date: Mon, 9 Oct 2017 23:51:47 -0700

On Mon, Oct 9, 2017 at 10:55 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Allen Li <vianchielfaura <at> gmail.com>
>> Date: Mon, 9 Oct 2017 21:43:59 -0700
>> Cc: 28615-done <at> debbugs.gnu.org
>>
>> Why did you not change the collection function?
>
> Because there could be a file called literally like one of the
> shorthands in grep-files-aliases, or whose name includes those
> shorthands as a substring.

Not sure what you mean.  There is no use case for completing a
file name.  Are you saying that a user might mistake the completion
on grep-files-aliases as completion on file name?  I believe that
with the new prompt change, that is unlikely.

>
>> As I noted in the bug, most of the completions that would be
>> provided by read-file-name-internal don't work
>
> IMO, that's okay, because wildcards cannot be meaningfully completed
> on.

But the aliases from grep-files-aliases can be meaningfully
completed.  I don't see why we shouldn't provide meaningful
completion if the user defines a lot of aliases, seeing as how
the current file name completion is useless.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.