Subject: bug#28606: closed (Re: [bug#28606] [PATCH] gnu: Add dino.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 28 Sep 2017 10:50:02 +0000

Your bug report

#28606: [PATCH] gnu: Add dino.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
28606: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28606
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#28606] [PATCH] gnu: Add dino.
From: Ricardo Wurmus <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Thu, 28 Sep 2017 12:48:33 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Hello,
>
> Ricardo Wurmus <[email-masked]> skribis:
>
>> * gnu/packages/messaging.scm (dino): New variable.
>
> That looks alright to me!

Thanks for the review!

>> +         ("vala" ,vala)
>
> I found there’s a tendency to include Vala-generated C code (see
> ‘lxsession’ for instance.)  It might be worth checking if that’s the
> case here.

It looks like there is no generated C code in the repository.  There’s
only a handful of C files, and they look like source code.

>> +      (synopsis "Modern Jabber (XMPP) client")
>> +      (description "Dino is a Jabber (XMPP) client which aims to fit well into
>> +a modern desktop environment.")
>
> Nitpick: I don’t like “modern”!  :-)  I think it’s very subjective and
> unhelpful.  Maybe something like “Graphical Jabber client”, and
> something that says it’s well integrated with GNOME and whatnot?

Hah, as a fellow user of a decidedly “un-modern” desktop environment I
agree :)  I’ll change it to something more neutral-sounding.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Subject: [PATCH] gnu: Add dino.
From: Ricardo Wurmus <[email-masked]>
To: [email-masked]
Cc: Ricardo Wurmus <[email-masked]>
Date: Tue, 26 Sep 2017 12:14:10 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/messaging.scm (dino): New variable.
---
 gnu/packages/messaging.scm | 54 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 52ca4bef7..42820f0b9 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -533,6 +533,60 @@ transformation; audio and video conferences; file transfer; TLS, GPG and
 end-to-end encryption support; XML console.")
     (license license:gpl3)))
 
+(define-public dino
+  ;; The only release tarball is for version 0.0, but it is very old and fails
+  ;; to build.
+  (let ((commit "54a25fd926070a977138cec94908c55806e22f4a")
+        (revision "1"))
+    (package
+      (name "dino")
+      (version (string-append "0.0-" revision "." (string-take commit 9)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/dino/dino.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "1m100wzr5xqaj3r4vprxj0961833wqk0p7z94nmjsf2f0s67v5r3"))))
+      (build-system cmake-build-system)
+      (arguments
+       `(#:tests? #f ; there are no tests
+         #:parallel-build? #f ; not supported
+         #:configure-flags
+         ;; FIXME: we disable the omemo plugin because it needs
+         ;; libsignal-protocol, for which we don't have a package yet.
+         '("-DDISABLED_PLUGINS=omemo")
+         #:modules ((guix build cmake-build-system)
+                    ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
+                    (guix build utils))
+         #:imported-modules (,@%gnu-build-system-modules
+                             (guix build cmake-build-system)
+                             (guix build glib-or-gtk-build-system))
+         #:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'glib-or-gtk-wrap
+             (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
+      (inputs
+       `(("libgee" ,libgee)
+         ("libsoup" ,libsoup)
+         ("sqlite" ,sqlite)
+         ("gpgme" ,gpgme)
+         ("gtk+" ,gtk+)
+         ("glib-networking" ,glib-networking)
+         ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+      (native-inputs
+       `(("pkg-config" ,pkg-config)
+         ("glib" ,glib "bin")
+         ("vala" ,vala)
+         ("gettext" ,gettext-minimal)))
+      (home-page "https://dino.im")
+      (synopsis "Modern Jabber (XMPP) client")
+      (description "Dino is a Jabber (XMPP) client which aims to fit well into
+a modern desktop environment.")
+      (license license:gpl3+))))
+
 (define-public prosody
   (package
     (name "prosody")
-- 
2.14.1