From unknown Sat Jun 21 10:30:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28602 <28602@debbugs.gnu.org> To: bug#28602 <28602@debbugs.gnu.org> Subject: Status: Unpack fails with no error message when using a .zip source Reply-To: bug#28602 <28602@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:30:51 +0000 retitle 28602 Unpack fails with no error message when using a .zip source reassign 28602 guix submitter 28602 nee severity 28602 normal tag 28602 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 16:10:39 2017 Received: (at submit) by debbugs.gnu.org; 25 Sep 2017 20:10:39 +0000 Received: from localhost ([127.0.0.1]:58998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwZiB-00054I-68 for submit@debbugs.gnu.org; Mon, 25 Sep 2017 16:10:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwZi9-000545-EA for submit@debbugs.gnu.org; Mon, 25 Sep 2017 16:10:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwZi3-0001mf-Ah for submit@debbugs.gnu.org; Mon, 25 Sep 2017 16:10:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwZi3-0001mU-78 for submit@debbugs.gnu.org; Mon, 25 Sep 2017 16:10:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwZi2-0004ex-36 for bug-guix@gnu.org; Mon, 25 Sep 2017 16:10:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwZhy-0001k9-UG for bug-guix@gnu.org; Mon, 25 Sep 2017 16:10:30 -0400 Received: from cock.li ([185.100.85.212]:46314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwZhy-0001ha-FP for bug-guix@gnu.org; Mon, 25 Sep 2017 16:10:26 -0400 To: bug-guix@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1506370220; bh=oPmwle5wzcfr2MOTs2mSK9SKTT+4f+1dlH2/ZYTaSxk=; h=To:From:Subject:Date:From; b=gaquSYKuhNbPpxDDBg9x4wGQL4SB/v86x4A+sq80t/y1lg2BfzAgaU47LGcRMNUqQ ISvziKqqWAezeW3CIE9RqVbwzsytBm6UhP1WvfK6GF3QUXrs+ncFu93i8XiGWhjq+b kSBgzh3hNVaHknLQMWCmo1YCMeY67MfmsJJrMlkmmHpFGgE6BSed6uLl03lwzYthqd YBrRWDWD+h035aQIaW4wLMUWS20E4rkJsYgw7WaWsO9MFwzsES/4RS3H1se0yJVRvx 67m7xyDPINe0BhL+OtwysdfvbHygbsbG97VL7LQUKp2E2wY++mx2nvXw3Lk7h1VdE9 dkKfuTcT+8blA== From: nee Subject: Unpack fails with no error message when using a .zip source Message-ID: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> Date: Mon, 25 Sep 2017 22:10:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, right now unpacking .zip sources only works when unzip is added as native input. That's all right, but there is no error message, just: starting phase `unpack' phase `unpack' failed after 0.0 seconds It should say something like: starting phase `unpack' Archive with .zip suffix failed to unpack. Please add unzip as native-input to the package, e.g. (native-inputs `(("unzip" ,unzip))) phase `unpack' failed after 0.0 seconds I tested this in the cmake-build-system From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 14:17:34 2017 Received: (at submit) by debbugs.gnu.org; 4 Oct 2017 18:17:34 +0000 Received: from localhost ([127.0.0.1]:49183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzoEf-0002YY-2v for submit@debbugs.gnu.org; Wed, 04 Oct 2017 14:17:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzoEc-0002YI-UT for submit@debbugs.gnu.org; Wed, 04 Oct 2017 14:17:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzoEW-00036Y-N8 for submit@debbugs.gnu.org; Wed, 04 Oct 2017 14:17:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzoEW-00036Q-Jy for submit@debbugs.gnu.org; Wed, 04 Oct 2017 14:17:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzoEV-0002hd-5w for bug-guix@gnu.org; Wed, 04 Oct 2017 14:17:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzoEQ-00030A-8D for bug-guix@gnu.org; Wed, 04 Oct 2017 14:17:23 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:34359) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzoEQ-0002yn-1g for bug-guix@gnu.org; Wed, 04 Oct 2017 14:17:18 -0400 X-Originating-IP: 181.221.159.64 Received: from adfeno-pc1 (unknown [181.221.159.64]) (Authenticated sender: adfeno@hyperbola.info) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0F6081720BF for ; Wed, 4 Oct 2017 20:17:14 +0200 (CEST) From: Adonay Felipe Nogueira To: bug-guix@gnu.org Subject: Re: bug#28602: Unpack fails with no error message when using a .zip source References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> Date: Wed, 04 Oct 2017 15:17:13 -0300 In-Reply-To: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> (nee@cock.li's message of "Mon, 25 Sep 2017 22:10:19 +0200") Message-ID: <87wp4abwwm.fsf@hyperbola.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Does the .zip file have a a single directory on the root? If not, then we can call it a zipbomb/tarbomb. These bombs are bad because they can replace things without notice, and can be very difficult to track what was added. Last time I checked Guix expects only a single directory in the root of the file --- this might have changed, but I didn't test it since one year ago. nee writes: > Hello, > > right now unpacking .zip sources only works when unzip is added as > native input. That's all right, but there is no error message, just: > > starting phase `unpack' > phase `unpack' failed after 0.0 seconds > > It should say something like: > > starting phase `unpack' > Archive with .zip suffix failed to unpack. Please add unzip as > native-input to the package, e.g. (native-inputs `(("unzip" ,unzip))) > phase `unpack' failed after 0.0 seconds > > I tested this in the cmake-build-system --=20 - https://libreplanet.org/wiki/User:Adfeno - Palestrante e consultor sobre /software/ livre (n=C3=A3o confundir com gratis). - "WhatsApp"? Ele n=C3=A3o =C3=A9 livre. Por favor, use o GNU Ring ou o Tox. - Contato: https://libreplanet.org/wiki/User:Adfeno#vCard - Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft Office, MP3, MP4, WMA, WMV. - Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU GIMP, Inkscape SVG, JPG, LibreOffice (padr=C3=A3o ODF), OGG, OPUS, PDF (apenas sem DRM), PNG, TXT, WEBM. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 17:00:55 2017 Received: (at 28602) by debbugs.gnu.org; 9 Oct 2017 21:00:55 +0000 Received: from localhost ([127.0.0.1]:58702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1fAV-0000Ga-5S for submit@debbugs.gnu.org; Mon, 09 Oct 2017 17:00:55 -0400 Received: from cock.li ([185.100.85.212]:55884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1fAT-0000GJ-3h for 28602@debbugs.gnu.org; Mon, 09 Oct 2017 17:00:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on cock.li X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 shortcircuit=_SCTYPE_ autolearn=disabled version=3.4.1 Subject: Re: bug#28602: [PATCH] guix: gnu-build-system: warn about missing unzip input unzip DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1507582845; bh=5PweF0XiHKb66LTsnsBnZPxv+kZ/Cb1oLamgx76aE5k=; h=Subject:From:To:References:Date:In-Reply-To:From; b=ILMbgZ+qYE88WPue6yZ+Qii4hjB6nTWmF0R4VUZxvAlLbESi4nD+BA0PD/oORKm3r noxQxaLr3qm9TIHWijvovRc+/VIZzO8E/ZjBJVdwCC6Howi9FQYbGtv0+ob6B3k47q DGbz6kJ/W7C2od+J5AO3P8XL7rCLq8rZfoQQX1OJjRvAuJMhOWpd31AcKcqEYMScVM aTc2yHeMuPKqqwujx5Ilm084da7bpsKFDBpZp0UdOLm1KWXt5FS/EXaT1Wi2m+bZj9 HJ1ortoXUTml1DgTvzP05O95WRD/LimgNtMq/cABAUPeBES6rhiIOvQqCSob9IwDIU tXu2PJLdZp7Iw== From: nee To: 28602@debbugs.gnu.org References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> Message-ID: <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> Date: Mon, 9 Oct 2017 23:00:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> Content-Type: multipart/mixed; boundary="------------E2723A09A93805169AB0EC89" Content-Language: en-GB X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28602 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------E2723A09A93805169AB0EC89 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hello here is a patch to fix this bug. It changes the gnu-build-system, so the hashes of almost all packages will also change. I guess core-updates is the right branch for this. --------------E2723A09A93805169AB0EC89 Content-Type: text/x-patch; name="0001-guix-gnu-build-system-warn-about-missing-unzip-input.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-guix-gnu-build-system-warn-about-missing-unzip-input.pa"; filename*1="tch" >From 089b9741a734f0682a671df6c0c36dfefcbd407c Mon Sep 17 00:00:00 2001 From: nee Date: Mon, 9 Oct 2017 22:49:12 +0200 Subject: [PATCH] guix: gnu-build-system: warn about missing unzip input during unpack. --- guix/build/gnu-build-system.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index e37b75140..c16d15964 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -67,6 +67,21 @@ See https://reproducible-builds.org/specs/source-date-epoch/." #f dir)) +(define (unzip filepath) + "Unzip archive file. +Warn the user when unzip fails and the executable is not present." + (define exit-code (system* "unzip" filepath)) + (define program-not-found-code 32512) + (cond ((zero? exit-code) #t) + ((eqv? exit-code program-not-found-code) + (format (current-error-port) + "warning: Archive with .zip suffix failed to unpack. +Please add unzip as native-input to the package, +e.g. (native-inputs `((\"unzip\" ,unzip)))") + (newline (current-error-port)) + #f) + (else #f))) + (define* (set-paths #:key target inputs native-inputs (search-paths '()) (native-search-paths '()) #:allow-other-keys) @@ -154,7 +169,7 @@ working directory." #:keep-mtime? #t) #t) (and (if (string-suffix? ".zip" source) - (zero? (system* "unzip" source)) + (unzip source) (zero? (system* "tar" "xvf" source))) (chdir (first-subdirectory "."))))) -- 2.14.1 --------------E2723A09A93805169AB0EC89-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 17:05:09 2017 Received: (at 28602) by debbugs.gnu.org; 9 Oct 2017 21:05:09 +0000 Received: from localhost ([127.0.0.1]:58715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1fEb-0000OW-Jh for submit@debbugs.gnu.org; Mon, 09 Oct 2017 17:05:09 -0400 Received: from cock.li ([185.100.85.212]:56709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1fEa-0000OC-Cj for 28602@debbugs.gnu.org; Mon, 09 Oct 2017 17:05:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on cock.li X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 shortcircuit=_SCTYPE_ autolearn=disabled version=3.4.1 Subject: Re: bug#28602: Unpack fails with no error message when using a .zip source DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1507583102; bh=8WHIiyfo1wVBjePU3E4F+TiStD2UB/DZJgMBLz0LBtI=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=tZ+mcD4h+e4T1O8iXaiFKK6GC/f3pOC7FkQ8bBzH5xFoWNXqa521zzTptpnPZ68TX /Wt4FIeGdpwZX30zPdXRB7iKdOXzTkyyncAiW25Q5ZEnHgeMhPRyTmNzpVqJlIB3Ns 8oJ8GYjGOwzyr1Y0FVktRgZx5I78w7Mdh3UM2eZRZdf85zlRinw7Le1qU3V+AwH2or PEvoJxZvotsX3uJFeR9p7iVhntJ/9C8tvhuWqR2xssg8ULgwTZCsPh0jreJ6sIxcge DliFF6eMygcIxjBZiTq+pRDMOq1qmoZU+BLfahC3h7msSmWcKkuU7HkZ4U4NtoIQy1 Dc+hClGa+RbYA== To: Adonay Felipe Nogueira References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <87wp4abwwm.fsf@hyperbola.info> From: nee Message-ID: <1771470d-8b9a-a516-7da2-6532432955a4@cock.li> Date: Mon, 9 Oct 2017 23:05:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <87wp4abwwm.fsf@hyperbola.info> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28602 Cc: 28602@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 04.10.2017 um 20:17 schrieb Adonay Felipe Nogueira: > Does the .zip file have a a single directory on the root? > > If not, then we can call it a zipbomb/tarbomb. These bombs are bad > because they can replace things without notice, and can be very > difficult to track what was added. Last time I checked Guix expects only > a single directory in the root of the file --- this might have changed, > but I didn't test it since one year ago. Hello, this is a different problem. Tarbombs are still a problem, but unrelated to this. The gnu-build-system does not have unzip by default. If a package's source comes in a zip the package must have unzip as native-input. If it isn't the (system* "unzip" source) call in the unpack function will fail because there is no unzip executable. Happy hacking! From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 13:27:09 2017 Received: (at control) by debbugs.gnu.org; 26 Nov 2017 18:27:09 +0000 Received: from localhost ([127.0.0.1]:59590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ1e1-0008UI-BT for submit@debbugs.gnu.org; Sun, 26 Nov 2017 13:27:09 -0500 Received: from cock.li ([185.100.85.212]:45775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ1dz-0008Tn-3i for control@debbugs.gnu.org; Sun, 26 Nov 2017 13:27:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on cock.li X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 shortcircuit=_SCTYPE_ autolearn=disabled version=3.4.1 To: control@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1511720820; bh=rjRzyhhCcFu/4/VGrHyv1EqulpkFMo7ffegOr5UyFfo=; h=To:References:From:Subject:Date:In-Reply-To:From; b=CrIc6IL4pXy93Y0nUv5dUNFmpXE0ebburY+N7wLzQSwVhb620pyuEWK6siimvrYjn z/np8psSA7P2tD+4zUaIruMmThyxWculwH9GVOJI/r+0ImZnT5bewUUsftYG2Z4u+Y jWW1R0jFbPxjTIx6Ynk+x7PjhXaKrWodKbNbBrPFo901CfDjq0NyRDPpys1Qy3hCwj OmkjOEpubqoItEKi/VOTPRdVxKKvd5mxJ9JzcA/lB1qrrHqPP0uyUQHHySbPkH158i w6oi10sAB2FXdL9I2eaSnJURI5KrUQozEi3G/H0jS6rukHggSUy9Lk8k2HmEWRtYOd 5ymN+a0iyW/iA== References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> From: nee Subject: Re: bug#28602: [PATCH] guix: gnu-build-system: warn about missing unzip input unzip Message-ID: <414ddf3f-f38d-f794-1b5e-613b71e371a0@cock.li> Date: Sun, 26 Nov 2017 19:27:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 28602 + patch From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 07:58:28 2021 Received: (at 28602) by debbugs.gnu.org; 5 Jul 2021 11:58:29 +0000 Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0NF6-0005oq-Mj for submit@debbugs.gnu.org; Mon, 05 Jul 2021 07:58:28 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:44972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0NF3-0005ny-MC for 28602@debbugs.gnu.org; Mon, 05 Jul 2021 07:58:26 -0400 Received: by mail-wm1-f44.google.com with SMTP id i2-20020a05600c3542b02902058529ea07so3426075wmq.3 for <28602@debbugs.gnu.org>; Mon, 05 Jul 2021 04:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PczEcsSE6pVtzrHa57FTuJHW8BXN4lFx3iARA8KrliY=; b=pQwnlhcagozm10627r0ztBr91gbXoh2oNfqQKP8qqKwRF6XoMcdX5iwou5Xh5o7B4c phYmCqZ/rb/fB+tYBNz2gZCLge940JUXfLVe7PWEMeYwstejZ/1z7tXlnfQ+DFKuRGIC r/B4jAAVK+sJApymbmGfMjMZcZCtn/GWTm498KO5cUhJisVFbEumxBaZzaLbloVpeIW0 Lj8qUoXqAzTxREt/M0qEKGMZSjp/aabEKr/joLqfrZL/8Fx/M6H7TjAEip2ZT4l/Q93R RTGOWoXdyrXi5ZUGwRPFT0P2rwWIZ0grNEgWO4+IW8XLH/Os8JhVR4xR1MCBun3JOwQV zWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PczEcsSE6pVtzrHa57FTuJHW8BXN4lFx3iARA8KrliY=; b=WBpv4XeVRE8v7detkJvsrhyIwrrkZ6MAgdNcAvGuyMJKidYUUUuNJ9uU+ABks8CiK3 /MjMm+dFtCvdD2BtVmomGphZ5y6XjXSoO2CA60ae239rEgOoK00jJCUuJ/sF9enu/d07 P6X1dhDIQL5so5dLd+OcLlZdmBPXmsYD9FwNdcQU7oTX1WSTgMQs7c2n6g9afAG2EKLK arVGRa/Cs4y5Z1yNxHuQONHLdKVnzTUf54LhTy3e+8DwFHuNXqLff2bMqaE5MRN1uOrG MD2dxthMd9Gdq/0MV+fdX4plhEGWwUMNjcktimUjNfzcnXNfWm1AeThE05q2SVYKKLPt juKg== X-Gm-Message-State: AOAM5320leSWo5RhRvb2zuf/S7TZwVm5EGS6RBJwN9lpTpENmEj6SxKd pTKBZa5jzW5matz409Us51Upv9gCdW0= X-Google-Smtp-Source: ABdhPJyMCH+rv4kQt2A/TMS0S/ilzcb604/BByb/CcRh4u4qNWvm5hVNlpbZJZ2eJr7ZltMfsNzlmw== X-Received: by 2002:a7b:c249:: with SMTP id b9mr14761772wmj.4.1625486300057; Mon, 05 Jul 2021 04:58:20 -0700 (PDT) Received: from pfiuh02 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id x21sm17438934wmj.6.2021.07.05.04.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 04:58:19 -0700 (PDT) From: zimoun To: nee Subject: Re: bug#28602: Unpack fails with no error message when using a .zip source References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> Date: Mon, 05 Jul 2021 13:46:26 +0200 In-Reply-To: <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> (nee@cock.li's message of "Mon, 9 Oct 2017 23:00:29 +0200") Message-ID: <877di52dbh.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28602 Cc: 28602@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thanks for the patch and sorry for the delay. On Mon, 09 Oct 2017 at 23:00, nee wrote: > Hello here is a patch to fix this bug. It changes the gnu-build-system, > so the hashes of almost all packages will also change. I guess > core-updates is the right branch for this. > >>>From 089b9741a734f0682a671df6c0c36dfefcbd407c Mon Sep 17 00:00:00 2001 > From: nee > Date: Mon, 9 Oct 2017 22:49:12 +0200 > Subject: [PATCH] guix: gnu-build-system: warn about missing unzip input during > unpack. > > --- > guix/build/gnu-build-system.scm | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm > index e37b75140..c16d15964 100644 > --- a/guix/build/gnu-build-system.scm > +++ b/guix/build/gnu-build-system.scm > @@ -67,6 +67,21 @@ See https://reproducible-builds.org/specs/source-date-epoch/." > #f > dir)) > > +(define (unzip filepath) > + "Unzip archive file. > +Warn the user when unzip fails and the executable is not present." > + (define exit-code (system* "unzip" filepath)) > + (define program-not-found-code 32512) > + (cond ((zero? exit-code) #t) > + ((eqv? exit-code program-not-found-code) > + (format (current-error-port) > + "warning: Archive with .zip suffix failed to unpack. > +Please add unzip as native-input to the package, > +e.g. (native-inputs `((\"unzip\" ,unzip)))") > + (newline (current-error-port)) > + #f) > + (else #f))) Give a look at 'invoke' from (guix build utils). > (define* (set-paths #:key target inputs native-inputs > (search-paths '()) (native-search-paths '()) > #:allow-other-keys) > @@ -154,7 +169,7 @@ working directory." > #:keep-mtime? #t) > #t) > (and (if (string-suffix? ".zip" source) > - (zero? (system* "unzip" source)) > + (unzip source) > (zero? (system* "tar" "xvf" source))) > (chdir (first-subdirectory "."))))) After 9a87649c863e1ff8b073b356875eb05eecedbcf7, this part uses 'invoke'. Instead of your 'unzip', the exception raised by 'invoke' should be catched and then should trigger the hint message. WDYT? All the best, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 20:54:35 2021 Received: (at 28602) by debbugs.gnu.org; 26 Nov 2021 01:54:35 +0000 Received: from localhost ([127.0.0.1]:58351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqQRQ-0004OO-BO for submit@debbugs.gnu.org; Thu, 25 Nov 2021 20:54:35 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:33737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqQRI-0004Nl-BL for 28602@debbugs.gnu.org; Thu, 25 Nov 2021 20:54:15 -0500 Received: by mail-wr1-f54.google.com with SMTP id d24so15330639wra.0 for <28602@debbugs.gnu.org>; Thu, 25 Nov 2021 17:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zo9XTUsRgZHTZVJ8hBH/ffzPntzvtEEdz90kZMUPZIo=; b=TaNneXNdt1IeglfUnhAfG20gabQd2kIYWHFqeiqXcWJqu8uxY08fyrjrKDRO4ykp/E CWD5bY8ip9rypm7UswCo7YvOmMG8E/Ice4wMfXHpkO4q5K7YeKxWuFXYd657A39rlUnb UvYfpO33EZq8XsnweJUup/rgx7uo9v87I4urLCXjyBX/4FSq44IjeyXQPE+268izvBvf J+7lSc3O/iQH38uAS4Xb2vWMtz4o0tAzh1+KeulsL3q8xjD5h1y6wkkHcLCyzORwSHob 0cYzs0oUZTxgFWUf/sZ1UaFFS1KNtchBquXQvgHS5gHPYBWP0TZwsB32fiwcEtmDJcVk q8XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zo9XTUsRgZHTZVJ8hBH/ffzPntzvtEEdz90kZMUPZIo=; b=xkCSMWx0aDVI0Ps4RnCj8CHIaxstFD9Skds5tGUpQvTKbVFWSaIGKA5GlNHPw374ZC 1fG7JAE2wxhj5TQvHr+jZM96NkZQmM1xkgfMTwbdNSviJC8bQbGH5TXzHFdXtJEiPAXK q5Tu7ifYSyFtCPpViG2CxPH75YljB6c+h1CJy6ChVw1mBjsu9X4XRwMVzDX/+OlFDN4i viWvO1vHcG9UcAV1ECJhWYzoRf59EILpE/JtPjlBjoSy3lKDajgDejB7lhwQGJfDyvVQ OP3B4Uk06xp3+m8GoW8p/noZdYzqtPf0zkNi4KemvhUm/fE1t97XPeaQJqsgk8j67tHm eCNQ== X-Gm-Message-State: AOAM5320iaVQdpSCxgOcUvpY/Fnmaw60wnfRTGjn41AU2rTj5AAZxd/V C+yOJu/cNERB8GhAi08Rb7Z4jOHaSOA= X-Google-Smtp-Source: ABdhPJwO/xC8xAcAHmdN3GEqSZ8+9RxXwX8ARz7nMbVceylozFmv3E2EhxuQR+sPzDBfuYPc6P4LzA== X-Received: by 2002:adf:8b1e:: with SMTP id n30mr11068242wra.75.1637891646414; Thu, 25 Nov 2021 17:54:06 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id a22sm4396105wme.19.2021.11.25.17.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 17:54:06 -0800 (PST) From: zimoun To: nee Subject: bug#28602: [core-updates] Unpack fails with no error message when using a .zip source References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> <877di52dbh.fsf_-_@gmail.com> Date: Fri, 26 Nov 2021 02:49:04 +0100 In-Reply-To: <877di52dbh.fsf_-_@gmail.com> (zimoun's message of "Mon, 05 Jul 2021 13:46:26 +0200") Message-ID: <86fsrjr8j3.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28602 Cc: 28602@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, This patch [1] had been submitted in 2017 and fallen in the cracks. The code below requires improvement and I am not convinced by the feature. Therefore closing? wrote: > On Mon, 09 Oct 2017 at 23:00, nee wrote: >> Hello here is a patch to fix this bug. It changes the gnu-build-system, >> so the hashes of almost all packages will also change. I guess >> core-updates is the right branch for this. >> >>>>>From 089b9741a734f0682a671df6c0c36dfefcbd407c Mon Sep 17 00:00:00 2001 >> From: nee >> Date: Mon, 9 Oct 2017 22:49:12 +0200 >> Subject: [PATCH] guix: gnu-build-system: warn about missing unzip input during >> unpack. >> >> --- >> guix/build/gnu-build-system.scm | 17 ++++++++++++++++- >> 1 file changed, 16 insertions(+), 1 deletion(-) >> >> diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm >> index e37b75140..c16d15964 100644 >> --- a/guix/build/gnu-build-system.scm >> +++ b/guix/build/gnu-build-system.scm >> @@ -67,6 +67,21 @@ See https://reproducible-builds.org/specs/source-date-epoch/." >> #f >> dir)) >> >> +(define (unzip filepath) >> + "Unzip archive file. >> +Warn the user when unzip fails and the executable is not present." >> + (define exit-code (system* "unzip" filepath)) >> + (define program-not-found-code 32512) >> + (cond ((zero? exit-code) #t) >> + ((eqv? exit-code program-not-found-code) >> + (format (current-error-port) >> + "warning: Archive with .zip suffix failed to unpack. >> +Please add unzip as native-input to the package, >> +e.g. (native-inputs `((\"unzip\" ,unzip)))") >> + (newline (current-error-port)) >> + #f) >> + (else #f))) > > Give a look at 'invoke' from (guix build utils). > >> (define* (set-paths #:key target inputs native-inputs >> (search-paths '()) (native-search-paths '()) >> #:allow-other-keys) >> @@ -154,7 +169,7 @@ working directory." >> #:keep-mtime? #t) >> #t) >> (and (if (string-suffix? ".zip" source) >> - (zero? (system* "unzip" source)) >> + (unzip source) >> (zero? (system* "tar" "xvf" source))) >> (chdir (first-subdirectory "."))))) > > After 9a87649c863e1ff8b073b356875eb05eecedbcf7, this part uses 'invoke'. > Instead of your 'unzip', the exception raised by 'invoke' should be > catched and then should trigger the hint message. WDYT? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 04 17:57:39 2022 Received: (at 28602) by debbugs.gnu.org; 4 Jan 2022 22:57:39 +0000 Received: from localhost ([127.0.0.1]:39076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4skN-00044y-HQ for submit@debbugs.gnu.org; Tue, 04 Jan 2022 17:57:39 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:42683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4skM-00044d-1U for 28602@debbugs.gnu.org; Tue, 04 Jan 2022 17:57:38 -0500 Received: by mail-wr1-f54.google.com with SMTP id w20so70091438wra.9 for <28602@debbugs.gnu.org>; Tue, 04 Jan 2022 14:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nrkfOwRURk68ew+nO99mYn/cUIl0WszobLJFI3N0EMA=; b=jFcu8RInZbQG5IyKuqx9xiDApi3jeN9oPWnFFzhW8joQKz1qUsTT+EoFbYNI8oUJWf Ac8bAOvA35wOI2i2zYlvasEN3344DGSyvn2u9XCRaNxC+sTU+KEvnuipLje0B+nW0T6z ZHGlOrmrTPVl2/B+WQpF8gVh5ws3xeeqWXCquJeGNl1fR+Drr1zx5AeCn1H/7cI2C2cX h2I35dgrswbNdjeyEqrWsNB1Zfv/CXTD4O4n+UQwpMEcCxr01XUrTKAsjQ0KaJssg11B sxofbb04T3al6292OQe44nUMujGHMpQNeiTW7mteSuPwZU+LOOwu7aqrXSgtvusluqet 6nvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nrkfOwRURk68ew+nO99mYn/cUIl0WszobLJFI3N0EMA=; b=sjNX6Py7L/6PZxYwfhZVaKfFvECPLDuC6Qm2iVA8LE1em1RKibRWFlU4WaMpEJZngG NBpnGzh5ze8nfP2TnME3zAIbiYIAtMeH45viDKIqUjIMs2V2HsHSScg/2BFkbzUwEJBz f1ZiGQg+LsKK0nEXfrKfh24Z6GM1XxiIoDQjM8cyoJIJIeff+Et2/SUmsdKMDlfzxfAc CgLMZaYn0yXMhg2zP/HN8X/NjsL8uRFsfpWGcKHKCzRl8D/RFsRwub4KbOz6ceMzDDwq 84LbtHh0t1aJVZmElFVrCl+PgXCtG0Lup/iTfAwqe22K0jDP4EPsVijIhS9l1vgdKV1L ZozQ== X-Gm-Message-State: AOAM533GzhNROda3Psf8ClROjQa4XuM7aTiEvTIZYyXtvUFYCKiSVD9W u1J93dl223uY6Fv7mmxG3bXgnkMtGpM= X-Google-Smtp-Source: ABdhPJyC+bXxxMK9OYd84QVvH66U9wgvb5KojHLQe/dYRxMjNzf4atcjlJG+rrogi1kOBrO7nIjRHw== X-Received: by 2002:a05:6000:144c:: with SMTP id v12mr43369949wrx.266.1641337052457; Tue, 04 Jan 2022 14:57:32 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id b14sm39393041wrg.15.2022.01.04.14.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 14:57:31 -0800 (PST) From: zimoun To: nee Subject: Re: bug#28602: Unpack fails with no error message when using a .zip source References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> <877di52dbh.fsf_-_@gmail.com> <86fsrjr8j3.fsf_-_@gmail.com> Date: Tue, 04 Jan 2022 23:55:40 +0100 In-Reply-To: <86fsrjr8j3.fsf_-_@gmail.com> (zimoun's message of "Fri, 26 Nov 2021 02:49:04 +0100") Message-ID: <86zgobaz6b.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28602 Cc: 28602@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Fri, 26 Nov 2021 at 02:49, zimoun wrote: > This patch [1] had been submitted in 2017 and fallen in the cracks. The > code below requires improvement and I am not convinced by the feature. > Therefore closing? > > Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 06:41:52 2022 Received: (at 28602-done) by debbugs.gnu.org; 23 Mar 2022 10:41:52 +0000 Received: from localhost ([127.0.0.1]:42839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWyR6-0007ON-Fm for submit@debbugs.gnu.org; Wed, 23 Mar 2022 06:41:52 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:42543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWyR3-0007O2-OZ for 28602-done@debbugs.gnu.org; Wed, 23 Mar 2022 06:41:50 -0400 Received: by mail-wr1-f44.google.com with SMTP id r13so1462343wrr.9 for <28602-done@debbugs.gnu.org>; Wed, 23 Mar 2022 03:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pycx31vQPQjPExevrcNU9sN2PhJVyKc8zF7XBDNAaRQ=; b=Nbp7ruiorkeBhNJt8UrcaxpI5irm6eyBV/ADeoJSe3RqdKWinW/lJjeH9QHu1auUL0 omlRH4NzfaIOSXT7xM1pyePWDc1hbcohDEDdg5Q7KbHWHw8oAgrNUmgjgYaxclhpN1HU MuudmPNgk3JTNi3hV5vFTgsryb9xZtvfQLhcydzmxnRof4PDH37dWMaZEeH0fYTw0yX3 ZQdmnuk/a7U2JKIHWl/VhDyBJm6N7r8+6GFoFCsiKCwgBG7rE0f/4hv89lE+6+MfwfaT hqxeU8eJvs2GTlW1foLPJADvvx4IBw9CNvc+hZgPcj3SwWeZu76n1kTZUMt2YXYy+Vti onKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pycx31vQPQjPExevrcNU9sN2PhJVyKc8zF7XBDNAaRQ=; b=IQWxCv07/Gf/r2rizxtwswblDLwj2zhYZqaQP7MFT6n+1nOyzfFiBUEgIu/ccklWEm T7vuuW/B+s6MPQymB0JRRml0DKH1gRwFNCbUxq+U9G/A/udp1zh/H2eYZIPDhogbvoyJ N161gySS7bIjJakQPSP6kVWKLzNxNBWQ5LBWq63qw7wAWWUJ9lhu5RI0KmBTyzf36tBc 04QzRafchndvy7heiUiZQ5S8xqFqrqYMZmts3hRNoliaiQfdb0i/wLqHJE4wm4cafl5e Cj6fdxaJyb5/JARHpjcDVlHbO9LAoM97PZoIlph2GI5HD8EmkrBfKqBx3xFNUduVWoDB 2MVQ== X-Gm-Message-State: AOAM530b/w8YJ4XVGwfhP7Dy7ypByulY3Js1GDmeCiBZRGOEE0XyM2Mm zr7vjKfQfls1kkO0VpHrjEf2uTHLoUs9QA== X-Google-Smtp-Source: ABdhPJxabaLxx3rIVjRjdA9SSrxUwi5UjAgzNpnX5ylsRBJbbHIdlS+GgAh2eEorUFh+8gdiia8ytg== X-Received: by 2002:adf:e104:0:b0:1f1:d891:5aa6 with SMTP id t4-20020adfe104000000b001f1d8915aa6mr26969677wrz.582.1648032103701; Wed, 23 Mar 2022 03:41:43 -0700 (PDT) Received: from lili (client-eduroam632.canalip.upmc.fr. [134.157.122.122]) by smtp.gmail.com with ESMTPSA id a6-20020a05600c224600b0038cbfb9cfbcsm1726591wmm.47.2022.03.23.03.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 03:41:43 -0700 (PDT) From: zimoun To: nee Subject: Re: bug#28602: Unpack fails with no error message when using a .zip source References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> <877di52dbh.fsf_-_@gmail.com> <86fsrjr8j3.fsf_-_@gmail.com> <86zgobaz6b.fsf_-_@gmail.com> Date: Wed, 23 Mar 2022 11:37:28 +0100 In-Reply-To: <86zgobaz6b.fsf_-_@gmail.com> (zimoun's message of "Tue, 04 Jan 2022 23:55:40 +0100") Message-ID: <86tubp0xav.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28602-done Cc: 28602-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 04 Jan 2022 at 23:55, zimoun wrote: > On Fri, 26 Nov 2021 at 02:49, zimoun wrote: > >> This patch [1] had been submitted in 2017 and fallen in the cracks. The >> code below requires improvement and I am not convinced by the feature. >> Therefore closing? >> >> > If no answer before the next release [1], I will close it. Well, 11 weeks later without an answer, I am closing. Cheers, simon From unknown Sat Jun 21 10:30:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Apr 2022 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator