GNU bug report logs - #28599
26.0.50; font-lock-ensure changes the face of text buttons

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28599 in the body.
You can then email your comments to 28599 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexander Miller <alexanderm <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; font-lock-ensure changes the face of text buttons
Date: Mon, 25 Sep 2017 21:47:53 +0200

Steps to reproduce:

* emacs -q
* switch to a text-mode buffer
* Run (insert-text-button "AAAAAAAAAAA" 'face 'font-lock-constant-face)
* Run (font-lock-ensure)

The button's face will now have changed from font-lock-constant to button.
This only happens once, a second call to font-lock-ensure makes no such
changes.
Overlay buttons don't seem to be affected.

I also tested this on a self-compiled emacs 25.2.1, with the same result.

In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.19)
of 2017-09-15 built on a-laptop
Repository revision: 6e38b9253e3d67def0e16f90da574b4622d962a3
Windowing system distributor 'The X.Org Foundation

Message #8 received at 28599 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alexander Miller <alexanderm <at> web.de>
Cc: 28599 <at> debbugs.gnu.org
Subject: Re: 26.0.50; font-lock-ensure changes the face of text buttons
Date: Wed, 30 Oct 2019 19:48:18 +0100

Alexander Miller <alexanderm <at> web.de> writes:

> Steps to reproduce:
>
> * emacs -q
> * switch to a text-mode buffer
> * Run (insert-text-button "AAAAAAAAAAA" 'face 'font-lock-constant-face)
> * Run (font-lock-ensure)
>
> The button's face will now have changed from font-lock-constant to button.
> This only happens once, a second call to font-lock-ensure makes no such
> changes.
> Overlay buttons don't seem to be affected.
>
> I also tested this on a self-compiled emacs 25.2.1, with the same result.

I'm unable to reproduce this exactly -- when I try this in Emacs 27, the
face property is just cleared, and no new face is applied.  And it
happens on all calls to font-lock-ensure.

This happens because that function calls,
font-lock-default-fontify-region, which calls
font-lock-default-unfontify-region is called, and it just does

(defun font-lock-default-unfontify-region (beg end)
  "Unfontify the text between BEG and END.
This function is the default `font-lock-unfontify-region-function'."
  (remove-list-of-text-properties
   beg end (append
	    font-lock-extra-managed-props
	    (if font-lock-syntactic-keywords
		'(syntax-table face font-lock-multiline)
	      '(face font-lock-multiline)))))

So if you want to have both your own faces and use font-lock, too, you
have to use font-lock-face instead of face, according to "Precalculated
Fontification".

So there doesn't seem to be a bug here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.